193453 2019-01-15 10:03:23 -0800 Add allow directive for MTLCompilerService.xpc to PluginProcess and WebContent 2019-01-15 11:34:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1494674 0 pvollan 2019-01-15 10:03:23 -0800 It should be added to: PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb WebProcess/com.apple.WebProcess.sb.in 1494676 1 pvollan 2019-01-15 10:03:43 -0800 rdar://problem/47268166 1494677 2 359170 pvollan 2019-01-15 10:05:36 -0800 Created attachment 359170 Patch 1494679 3 359170 bfulgham 2019-01-15 10:06:59 -0800 Comment on attachment 359170 Patch Great -- thank you for adding this. It looks like you have some smart quotes, which will break things. Can you please fix? 1494680 4 359170 bfulgham 2019-01-15 10:07:26 -0800 Comment on attachment 359170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359170&action=review > Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:164 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService”)) You've got a "”" as the closing quote. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:194 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService”)) Ditto > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:613 > +(allow mach-lookup (xpc-service-name "com.apple.MTLCompilerService”)) Ditto 1494683 5 359172 pvollan 2019-01-15 10:12:24 -0800 Created attachment 359172 Patch 1494685 6 pvollan 2019-01-15 10:13:06 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 359170 [details] > Patch > > Great -- thank you for adding this. > > It looks like you have some smart quotes, which will break things. Can you > please fix? Ah, good catch! I have updated the patch. Thanks for reviewing! 1494727 7 359172 bfulgham 2019-01-15 11:05:58 -0800 Comment on attachment 359172 Patch Looks great. r=me! 1494736 8 359172 commit-queue 2019-01-15 11:34:18 -0800 Comment on attachment 359172 Patch Clearing flags on attachment: 359172 Committed r239994: <https://trac.webkit.org/changeset/239994> 1494737 9 commit-queue 2019-01-15 11:34:20 -0800 All reviewed patches have been landed. Closing bug. 359170 2019-01-15 10:05:36 -0800 2019-01-15 10:12:23 -0800 Patch bug-193453-20190115100536.patch text/plain 2571 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk5OTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTE1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYWxsb3cgZGlyZWN0aXZl IGZvciBNVExDb21waWxlclNlcnZpY2UueHBjIHRvIFBsdWdpblByb2Nlc3MgYW5kIFdlYkNvbnRl bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ1 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcyNjgxNjY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBw bGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW46CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorICAgICAgICAq IFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTktMDEtMTUgIEJy aWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVyOiB1cGRhdGUg Q3JlYXRlIFdpbmRvdyBpbXBsZW1lbnRhdGlvbiB0byBzdXBwb3J0IG5ld2VzdCBzcGVjaWZpY2F0 aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJL aXQucGx1Z2luLWNvbW1vbi5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1BsdWdp blByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5zYi5pbgkocmV2aXNp b24gMjM5OTg5KQorKysgU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUu V2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTE2MCw2ICsxNjAs OSBAQAogKQogI2VuZGlmCiAKKzs7IDxyZGFyOi8vcHJvYmxlbS80NzI2ODE2Nj4KKyhhbGxvdyBt YWNoLWxvb2t1cCAoeHBjLXNlcnZpY2UtbmFtZSAiY29tLmFwcGxlLk1UTENvbXBpbGVyU2Vydmlj ZeKAnSkpCisKIDs7IFV0aWxpdHkgZnVuY3Rpb25zCiAoZGVmaW5lIChob21lLWxpdGVyYWwgaG9t ZS1yZWxhdGl2ZS1saXRlcmFsKQogICAgIChsaXRlcmFsIChzdHJpbmctYXBwZW5kIChwYXJhbSAi SE9NRV9ESVIiKSBob21lLXJlbGF0aXZlLWxpdGVyYWwpKSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LnNiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCShyZXZpc2lvbiAyMzk5ODkpCisr KyBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudC5zYgkod29ya2luZyBjb3B5KQpAQCAtMTkwLDYgKzE5MCw5IEBACiAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuZnJvbnRib2FyZC53b3Jrc3BhY2UiKQogICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLmZyb250Ym9hcmQuc3lzdGVtYXBwc2VydmljZXMiKSkKIAor OzsgPHJkYXI6Ly9wcm9ibGVtLzQ3MjY4MTY2PgorKGFsbG93IG1hY2gtbG9va3VwICh4cGMtc2Vy dmljZS1uYW1lICJjb20uYXBwbGUuTVRMQ29tcGlsZXJTZXJ2aWNl4oCdKSkKKwogKGFsbG93LXBy ZWZlcmVuY2VzLWNvbW1vbikKIAogOzsgQ29yZU1vdGlvbgpJbmRleDogU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24g MjM5OTg5KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNz LnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC02MDksNiArNjA5LDkgQEAKICNlbmRpZgogKQogCis7 OyA8cmRhcjovL3Byb2JsZW0vNDcyNjgxNjY+CisoYWxsb3cgbWFjaC1sb29rdXAgKHhwYy1zZXJ2 aWNlLW5hbWUgImNvbS5hcHBsZS5NVExDb21waWxlclNlcnZpY2XigJ0pKQorCiAjaWYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKIChkZW55IG1hY2gtbG9va3VwICh3 aXRoIG5vLWxvZykKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5WaWV3QnJpZGdlQXV4aWxp YXJ5IikK 359172 2019-01-15 10:12:24 -0800 2019-01-15 11:34:18 -0800 Patch bug-193453-20190115101223.patch text/plain 2565 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk5OTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTE1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYWxsb3cgZGlyZWN0aXZl IGZvciBNVExDb21waWxlclNlcnZpY2UueHBjIHRvIFBsdWdpblByb2Nlc3MgYW5kIFdlYkNvbnRl bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ1 MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcyNjgxNjY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBw bGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW46CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorICAgICAgICAq IFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTktMDEtMTUgIEJy aWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViRHJpdmVyOiB1cGRhdGUg Q3JlYXRlIFdpbmRvdyBpbXBsZW1lbnRhdGlvbiB0byBzdXBwb3J0IG5ld2VzdCBzcGVjaWZpY2F0 aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJL aXQucGx1Z2luLWNvbW1vbi5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1BsdWdp blByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5zYi5pbgkocmV2aXNp b24gMjM5OTkwKQorKysgU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUu V2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTE2MCw2ICsxNjAs OSBAQAogKQogI2VuZGlmCiAKKzs7IDxyZGFyOi8vcHJvYmxlbS80NzI2ODE2Nj4KKyhhbGxvdyBt YWNoLWxvb2t1cCAoeHBjLXNlcnZpY2UtbmFtZSAiY29tLmFwcGxlLk1UTENvbXBpbGVyU2Vydmlj ZSIpKQorCiA7OyBVdGlsaXR5IGZ1bmN0aW9ucwogKGRlZmluZSAoaG9tZS1saXRlcmFsIGhvbWUt cmVsYXRpdmUtbGl0ZXJhbCkKICAgICAobGl0ZXJhbCAoc3RyaW5nLWFwcGVuZCAocGFyYW0gIkhP TUVfRElSIikgaG9tZS1yZWxhdGl2ZS1saXRlcmFsKSkpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5z Ygo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgkocmV2aXNpb24gMjM5OTkwKQorKysg U291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2Vi S2l0LldlYkNvbnRlbnQuc2IJKHdvcmtpbmcgY29weSkKQEAgLTE5MCw2ICsxOTAsOSBAQAogICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmZyb250Ym9hcmQud29ya3NwYWNlIikKICAgICAoZ2xv YmFsLW5hbWUgImNvbS5hcHBsZS5mcm9udGJvYXJkLnN5c3RlbWFwcHNlcnZpY2VzIikpCiAKKzs7 IDxyZGFyOi8vcHJvYmxlbS80NzI2ODE2Nj4KKyhhbGxvdyBtYWNoLWxvb2t1cCAoeHBjLXNlcnZp Y2UtbmFtZSAiY29tLmFwcGxlLk1UTENvbXBpbGVyU2VydmljZSIpKQorCiAoYWxsb3ctcHJlZmVy ZW5jZXMtY29tbW9uKQogCiA7OyBDb3JlTW90aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyMzk5 OTApCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2Iu aW4JKHdvcmtpbmcgY29weSkKQEAgLTYwOSw2ICs2MDksOSBAQAogI2VuZGlmCiApCiAKKzs7IDxy ZGFyOi8vcHJvYmxlbS80NzI2ODE2Nj4KKyhhbGxvdyBtYWNoLWxvb2t1cCAoeHBjLXNlcnZpY2Ut bmFtZSAiY29tLmFwcGxlLk1UTENvbXBpbGVyU2VydmljZSIpKQorCiAjaWYgX19NQUNfT1NfWF9W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKIChkZW55IG1hY2gtbG9va3VwICh3aXRoIG5v LWxvZykKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5WaWV3QnJpZGdlQXV4aWxpYXJ5IikK