193443 2019-01-15 05:04:52 -0800 clang-tidy: Fix unnecessary copy of for loop variables in ANGLE 2019-01-15 14:10:27 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/angleproject/issues/detail?id=3075 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen commit-queue dino ews-watchlist graouts kondapallykalyan webkit-bug-importer oldest_to_newest 1494602 0 ddkilzer 2019-01-15 05:04:52 -0800 Running clang-tidy on ANGLE resulted in these potential performance improvements to prevent object copies in for loops: Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1070:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto block : uniformBlocks) ^ const & Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1087:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto var : outputVaryings) ^ const & Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1100:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto var : outputVariables) ^ const & Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp:73:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto macro : mExpander->mMacrosToReenable) ^ const & Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp:195:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy] for (auto nameInSet : nameSet) ^ const & 1494604 1 359156 ddkilzer 2019-01-15 05:17:23 -0800 Created attachment 359156 Patch v1 1494605 2 ews-watchlist 2019-01-15 05:20:42 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1494797 3 359156 commit-queue 2019-01-15 13:47:57 -0800 Comment on attachment 359156 Patch v1 Clearing flags on attachment: 359156 Committed r240001: <https://trac.webkit.org/changeset/240001> 1494798 4 commit-queue 2019-01-15 13:47:59 -0800 All reviewed patches have been landed. Closing bug. 1494799 5 webkit-bug-importer 2019-01-15 13:48:38 -0800 <rdar://problem/47295060> 359156 2019-01-15 05:17:23 -0800 2019-01-15 13:47:57 -0800 Patch v1 bug-193443-20190115051722.patch text/plain 4434 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNWI4NTZlMzhlMDY4MTI2ODdlY2M4YjdmZDk5NjNiZWJhZjgwNTE1ZS4uYjFiOTBhNjgwN2Ew OTFiOTE2Njc0NDgxZTU4YzQzY2JhNzcwOGQyZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTAxLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBh cHBsZS5jb20+CisKKyAgICAgICAgY2xhbmctdGlkeTogRml4IHVubmVjZXNzYXJ5IGNvcHkgb2Yg Zm9yIGxvb3AgdmFyaWFibGVzIGluIEFOR0xFCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcv Yi8xOTM0NDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IHVud2FudGVkIGNvcHlpbmcgb2YgbG9vcCB2YXJpYWJsZXMgYnkgbWFraW5nIHRoZW0g Y29uc3QKKyAgICAgICAgcmVmZXJlbmNlcy4KKworICAgICAgICAqIHNyYy9jb21waWxlci9wcmVw cm9jZXNzb3IvTWFjcm9FeHBhbmRlci5jcHA6CisgICAgICAgIChwcDo6TWFjcm9FeHBhbmRlcjo6 U2NvcGVkTWFjcm9SZWVuYWJsZXI6On5TY29wZWRNYWNyb1JlZW5hYmxlcik6CisgICAgICAgIC0g UHJldmVudHMgY29weSBhbmQgcmVmZXJlbmNlIGNodXJuIG9mIHN0ZDo6c2hhcmVkX3B0cjxNYWNy bz4KKyAgICAgICAgICBvYmplY3RzLgorICAgICAgICAqIHNyYy9jb21waWxlci90cmFuc2xhdG9y L0NvbXBpbGVyLmNwcDoKKyAgICAgICAgKHNoOjpUQ29tcGlsZXI6OnVzZUFsbE1lbWJlcnNJblVu dXNlZFN0YW5kYXJkQW5kU2hhcmVkQmxvY2tzKToKKyAgICAgICAgLSBQcmV2ZW50cyBjb3B5IG9m IHNoOjpJbnRlcmZhY2VCbG9jayBzdHJ1Y3RzLgorICAgICAgICAoc2g6OlRDb21waWxlcjo6aW5p dGlhbGl6ZU91dHB1dFZhcmlhYmxlcyk6CisgICAgICAgIC0gUHJldmVudHMgY29weSBvZiBzaDo6 VmFyeWluZyBzdHJ1Y3RzLgorICAgICAgICAqIHNyYy9saWJBTkdMRS9Qcm9ncmFtLmNwcDoKKyAg ICAgICAgKGdsOjooYW5vbnltb3VzIG5hbWVzcGFjZSk6OkluY2x1ZGVTYW1lQXJyYXlFbGVtZW50 KToKKyAgICAgICAgLSBQcmV2ZW50cyBjb3B5IG9mIHN0ZDo6c3RyaW5nIG9iamVjdHMuCisKIDIw MTgtMTAtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBBTkdM RSBwYXJ0IG9mIFtYY29kZV0gVXBkYXRlIHNvbWUgYnVpbGQgc2V0dGluZ3MgYXMgcmVjb21tZW5k ZWQgYnkgWGNvZGUgMTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9j b21waWxlci9wcmVwcm9jZXNzb3IvTWFjcm9FeHBhbmRlci5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvY29tcGlsZXIvcHJlcHJvY2Vzc29yL01hY3JvRXhwYW5kZXIuY3BwCmluZGV4 IGQ4OGQzYTY4NTM4MmNlZDUwMzE3MjhiNzNkN2M3YjIzYTUyMmUwM2MuLjZlMmFjY2YyOWRhZGJl NDQyOTRhZmQ2NTVkZWJkMzg5ODdhZmNmYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21waWxlci9wcmVwcm9jZXNzb3IvTWFjcm9FeHBhbmRlci5jcHAKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3ByZXByb2Nlc3Nvci9NYWNyb0V4 cGFuZGVyLmNwcApAQCAtNzAsNyArNzAsNyBAQCBNYWNyb0V4cGFuZGVyOjpTY29wZWRNYWNyb1Jl ZW5hYmxlcjo6U2NvcGVkTWFjcm9SZWVuYWJsZXIoTWFjcm9FeHBhbmRlciAqZXhwYW5kZQogTWFj cm9FeHBhbmRlcjo6U2NvcGVkTWFjcm9SZWVuYWJsZXI6On5TY29wZWRNYWNyb1JlZW5hYmxlcigp CiB7CiAgICAgbUV4cGFuZGVyLT5tRGVmZXJSZWVuYWJsaW5nTWFjcm9zID0gZmFsc2U7Ci0gICAg Zm9yIChhdXRvIG1hY3JvIDogbUV4cGFuZGVyLT5tTWFjcm9zVG9SZWVuYWJsZSkKKyAgICBmb3Ig KGNvbnN0IGF1dG8mIG1hY3JvIDogbUV4cGFuZGVyLT5tTWFjcm9zVG9SZWVuYWJsZSkKICAgICB7 CiAgICAgICAgIC8vIENvcHlpbmcgdGhlIHN0cmluZyBoZXJlIGJ5IHVzaW5nIHN1YnN0ciBpcyBh IGNoZWNrIGZvciB1c2UtYWZ0ZXItZnJlZS4gSXQgZGV0ZWN0cwogICAgICAgICAvLyB1c2UtYWZ0 ZXItZnJlZSBtb3JlIHJlbGlhYmx5IHRoYW4ganVzdCB0b2dnbGluZyB0aGUgZGlzYWJsZWQgZmxh Zy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFu c2xhdG9yL0NvbXBpbGVyLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxl ci90cmFuc2xhdG9yL0NvbXBpbGVyLmNwcAppbmRleCAyZjQxMWNiNThjNzVhNDYzYWYzYzk2MWU5 ODJiNWIxZjc5Yjk3OThkLi41OTQxNDdkODY5NWFmZjc3N2VmOWY0MDg0NWVhZWUzZjAxNzExZDM1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvdHJhbnNs YXRvci9Db21waWxlci5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBp bGVyL3RyYW5zbGF0b3IvQ29tcGlsZXIuY3BwCkBAIC0xMDY3LDcgKzEwNjcsNyBAQCB2b2lkIFRD b21waWxlcjo6dXNlQWxsTWVtYmVyc0luVW51c2VkU3RhbmRhcmRBbmRTaGFyZWRCbG9ja3MoVElu dGVybUJsb2NrICpyb290KQogewogICAgIHNoOjpJbnRlcmZhY2VCbG9ja0xpc3QgbGlzdDsKIAot ICAgIGZvciAoYXV0byBibG9jayA6IHVuaWZvcm1CbG9ja3MpCisgICAgZm9yIChjb25zdCBhdXRv JiBibG9jayA6IHVuaWZvcm1CbG9ja3MpCiAgICAgewogICAgICAgICBpZiAoIWJsb2NrLnN0YXRp Y1VzZSAmJgogICAgICAgICAgICAgKGJsb2NrLmxheW91dCA9PSBzaDo6QkxPQ0tMQVlPVVRfU1RE MTQwIHx8IGJsb2NrLmxheW91dCA9PSBzaDo6QkxPQ0tMQVlPVVRfU0hBUkVEKSkKQEAgLTEwODQs NyArMTA4NCw3IEBAIHZvaWQgVENvbXBpbGVyOjppbml0aWFsaXplT3V0cHV0VmFyaWFibGVzKFRJ bnRlcm1CbG9jayAqcm9vdCkKICAgICBJbml0VmFyaWFibGVMaXN0IGxpc3Q7CiAgICAgaWYgKHNo YWRlclR5cGUgPT0gR0xfVkVSVEVYX1NIQURFUiB8fCBzaGFkZXJUeXBlID09IEdMX0dFT01FVFJZ X1NIQURFUl9PRVMpCiAgICAgewotICAgICAgICBmb3IgKGF1dG8gdmFyIDogb3V0cHV0VmFyeWlu Z3MpCisgICAgICAgIGZvciAoY29uc3QgYXV0byYgdmFyIDogb3V0cHV0VmFyeWluZ3MpCiAgICAg ICAgIHsKICAgICAgICAgICAgIGxpc3QucHVzaF9iYWNrKHZhcik7CiAgICAgICAgICAgICBpZiAo dmFyLm5hbWUgPT0gImdsX1Bvc2l0aW9uIikKQEAgLTEwOTcsNyArMTA5Nyw3IEBAIHZvaWQgVENv bXBpbGVyOjppbml0aWFsaXplT3V0cHV0VmFyaWFibGVzKFRJbnRlcm1CbG9jayAqcm9vdCkKICAg ICBlbHNlCiAgICAgewogICAgICAgICBBU1NFUlQoc2hhZGVyVHlwZSA9PSBHTF9GUkFHTUVOVF9T SEFERVIpOwotICAgICAgICBmb3IgKGF1dG8gdmFyIDogb3V0cHV0VmFyaWFibGVzKQorICAgICAg ICBmb3IgKGNvbnN0IGF1dG8mIHZhciA6IG91dHB1dFZhcmlhYmxlcykKICAgICAgICAgewogICAg ICAgICAgICAgbGlzdC5wdXNoX2JhY2sodmFyKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL1Byb2dyYW0uY3BwIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL1Byb2dyYW0uY3BwCmluZGV4IDc5NWQzMjYwNDE4 MTFhMDU0YTk0MTA5ODZlOTI3Y2UxMjA0YjE1NDAuLjljYjdmYjc2OGM4NmI5MDYyNzljYWQ3NWE5 OGY5Y2Q0ZTUxMDk0M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9Qcm9ncmFtLmNwcAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGli QU5HTEUvUHJvZ3JhbS5jcHAKQEAgLTE5Miw3ICsxOTIsNyBAQCBib29sIEluY2x1ZGVTYW1lQXJy YXlFbGVtZW50KGNvbnN0IHN0ZDo6c2V0PHN0ZDo6c3RyaW5nPiAmbmFtZVNldCwgY29uc3Qgc3Rk OjpzdAogewogICAgIHN0ZDo6dmVjdG9yPHVuc2lnbmVkIGludD4gc3Vic2NyaXB0czsKICAgICBz dGQ6OnN0cmluZyBiYXNlTmFtZSA9IFBhcnNlUmVzb3VyY2VOYW1lKG5hbWUsICZzdWJzY3JpcHRz KTsKLSAgICBmb3IgKGF1dG8gbmFtZUluU2V0IDogbmFtZVNldCkKKyAgICBmb3IgKGNvbnN0IGF1 dG8mIG5hbWVJblNldCA6IG5hbWVTZXQpCiAgICAgewogICAgICAgICBzdGQ6OnZlY3Rvcjx1bnNp Z25lZCBpbnQ+IGFycmF5SW5kaWNlczsKICAgICAgICAgc3RkOjpzdHJpbmcgYXJyYXlOYW1lID0g UGFyc2VSZXNvdXJjZU5hbWUobmFtZUluU2V0LCAmYXJyYXlJbmRpY2VzKTsK