193441 2019-01-15 03:32:45 -0800 [JSC] printf-type mishap 2019-01-16 00:08:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 csaavedra csaavedra ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1494588 0 csaavedra 2019-01-15 03:32:45 -0800 [2/1678] Building CXX object Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o ../../Source/JavaScriptCore/jsc.cpp: In function ‘int jscmain(int, char**)’: ../../Source/JavaScriptCore/jsc.cpp:2941:16: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=] printf("Memory Footprint:\n Current Footprint: %llu\n Peak Footprint: %llu\n", footprint.current, footprint.peak); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/jsc.cpp:2941:16: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=] 1494590 1 359151 csaavedra 2019-01-15 03:38:48 -0800 Created attachment 359151 Patch 1494827 2 359151 saam 2019-01-15 14:46:19 -0800 Comment on attachment 359151 Patch This doesn't seem to build. Isn't there something for size_t? 1494932 3 359151 mark.lam 2019-01-15 17:22:06 -0800 Comment on attachment 359151 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359151&action=review > Source/JavaScriptCore/jsc.cpp:2941 > - printf("Memory Footprint:\n Current Footprint: %llu\n Peak Footprint: %llu\n", footprint.current, footprint.peak); > + printf("Memory Footprint:\n Current Footprint: %lu\n Peak Footprint: %lu\n", footprint.current, footprint.peak); Saam is correct. You made this work for 32-bit builds but broke 64-bit builds. Instead, you should use size_t like so: printf("Memory Footprint:\n Current Footprint: %zu\n Peak Footprint: %zu\n", static_cast<size_t>(footprint.current), static_cast<size_t>(footprint.peak)); 1495027 4 csaavedra 2019-01-16 00:07:27 -0800 Tomas Popela already pushed a fix in https://trac.webkit.org/changeset/239981/webkit. 1495028 5 webkit-bug-importer 2019-01-16 00:08:31 -0800 <rdar://problem/47309674> 359151 2019-01-15 03:38:48 -0800 2019-01-15 14:46:19 -0800 Patch bug-193441-20190115133847.patch text/plain 1392 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 Nzc3NjkzYTIyYTI4OTc2MGFmZDI1ODU1ZmY1M2EzMGZkMjA5ZDU2Li5iNTc2ZTA5YjAyMGYwZjkz YzY0YjFjYWRiNjI4N2RiNWViODc4OTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wMS0xNSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdIHByaW50Zi10eXBlIG1pc2hhcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNDQxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAo anNjbWFpbik6IEZpeCB0aGUgcHJpbnRmKCkgZm9ybWF0IHN0cmluZworCiAyMDE5LTAxLTE1ICBD YWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBERkdCeXRlQ29kZVBh cnNlciBydWxlcyBmb3IgYml0d2lzZSBvcGVyYXRpb25zIHNob3VsZCBjb25zaWRlciB0eXBlIG9m IHRoZWlyIG9wZXJhbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCmluZGV4IGEwZDg1NGE3M2I2OTM2YmIz YTlmYmFhYTMxZGY0YjUyOTc5ZTU0ZTguLjRhZjhmODFhY2ZhZWE2YjQ4MTIzZjZkNDBlYzQ2MTY2 ZjkwYTI1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCkBAIC0yOTM4LDcgKzI5MzgsNyBAQCBpbnQg anNjbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgaWYgKG9wdGlvbnMubV9kdW1wTWVt b3J5Rm9vdHByaW50KSB7CiAgICAgICAgIE1lbW9yeUZvb3RwcmludCBmb290cHJpbnQgPSBNZW1v cnlGb290cHJpbnQ6Om5vdygpOwogCi0gICAgICAgIHByaW50ZigiTWVtb3J5IEZvb3RwcmludDpc biAgICBDdXJyZW50IEZvb3RwcmludDogJWxsdVxuICAgIFBlYWsgRm9vdHByaW50OiAlbGx1XG4i LCBmb290cHJpbnQuY3VycmVudCwgZm9vdHByaW50LnBlYWspOworICAgICAgICBwcmludGYoIk1l bW9yeSBGb290cHJpbnQ6XG4gICAgQ3VycmVudCBGb290cHJpbnQ6ICVsdVxuICAgIFBlYWsgRm9v dHByaW50OiAlbHVcbiIsIGZvb3RwcmludC5jdXJyZW50LCBmb290cHJpbnQucGVhayk7CiAgICAg fQogCiAgICAgcmV0dXJuIHJlc3VsdDsK