193422 2019-01-14 18:11:55 -0800 Add option to JSC to dump memory footprint on script completion 2019-01-15 03:39:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue csaavedra ews-watchlist keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1494441 0 msaboff 2019-01-14 18:11:55 -0800 This is similar to the work done in <https://bugs.webkit.org/show_bug.cgi?id=189768> - "Add functions to measure memory footprint to JSC", extending it to a command line option. Use of this option would dump the peak and current footprint when processing a script is completed. 1494442 1 webkit-bug-importer 2019-01-14 18:12:57 -0800 <rdar://problem/47273045> 1494445 2 359114 msaboff 2019-01-14 18:22:01 -0800 Created attachment 359114 Patch 1494447 3 359114 mark.lam 2019-01-14 18:23:22 -0800 Comment on attachment 359114 Patch r=me 1494465 4 359114 commit-queue 2019-01-14 19:01:38 -0800 Comment on attachment 359114 Patch Clearing flags on attachment: 359114 Committed r239969: <https://trac.webkit.org/changeset/239969> 1494466 5 commit-queue 2019-01-14 19:01:39 -0800 All reviewed patches have been landed. Closing bug. 1494591 6 csaavedra 2019-01-15 03:39:44 -0800 I submitted a patch in https://bugs.webkit.org/show_bug.cgi?id=193441 to fix the printf()-related warnings. 359114 2019-01-14 18:22:01 -0800 2019-01-14 19:01:38 -0800 Patch 193422.patch text/plain 2949 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM5OTY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE5LTAxLTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCBvcHRpb24gdG8gSlNDIHRvIGR1bXAgbWVtb3J5IGZvb3RwcmludCBvbiBzY3JpcHQg Y29tcGxldGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzNDIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkZWQgdGhlIC0tZm9vdHByaW50IG9wdGlvbiB0byBkdW1wIHBlYWsgYW5kIGN1cnJlbnQg bWVtb3J5IHVzYWdlLiAgVGhpcyB1c2VzIHRoZSBzYW1lCisgICAgICAgIE9TIGNhbGxzIGFkZGVk IGluIHIyMzYyMzYyLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKHByaW50VXNhZ2VT dGF0ZW1lbnQpOgorICAgICAgICAoQ29tbWFuZExpbmU6OnBhcnNlQXJndW1lbnRzKToKKyAgICAg ICAgKGpzY21haW4pOgorCiAyMDE5LTAxLTE0ICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtp QHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pTQ10gQUkgc2hvdWxkIGNoZWNrIHRoZSBnaXZl biBjb25zdGFudCdzIGFycmF5IHR5cGUgd2hlbiBmb2xkaW5nIEdldEJ5VmFsIGludG8gY29uc3Rh bnQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAyMzk5NjcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIwLDYgKzQyMCw3IEBA IHB1YmxpYzoKICAgICBTdHJpbmcgbV91bmNhdWdodEV4Y2VwdGlvbk5hbWU7CiAgICAgYm9vbCBt X3RyZWF0V2F0Y2hkb2dFeGNlcHRpb25Bc1N1Y2Nlc3MgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9h bHdheXNEdW1wVW5jYXVnaHRFeGNlcHRpb24geyBmYWxzZSB9OworICAgIGJvb2wgbV9kdW1wTWVt b3J5Rm9vdHByaW50IHsgZmFsc2UgfTsKICAgICBib29sIG1fZHVtcFNhbXBsaW5nUHJvZmlsZXJE YXRhIHsgZmFsc2UgfTsKICAgICBib29sIG1fZW5hYmxlUmVtb3RlRGVidWdnaW5nIHsgZmFsc2Ug fTsKIApAQCAtMjU3Miw2ICsyNTczLDcgQEAgc3RhdGljIE5PX1JFVFVSTiB2b2lkIHByaW50VXNh Z2VTdGF0ZW1lbgogICAgIGZwcmludGYoc3RkZXJyLCAiICAtLWV4Y2VwdGlvbj08bmFtZT4gICAg ICAgICBDaGVjayB0aGUgbGFzdCBzY3JpcHQgZXhpdHMgd2l0aCBhbiB1bmNhdWdodCBleGNlcHRp b24gd2l0aCB0aGUgc3BlY2lmaWVkIG5hbWVcbiIpOwogICAgIGZwcmludGYoc3RkZXJyLCAiICAt LXdhdGNoZG9nLWV4Y2VwdGlvbi1vayAgICBVbmNhdWdodCB3YXRjaGRvZyBleGNlcHRpb25zIGV4 aXQgd2l0aCBzdWNjZXNzXG4iKTsKICAgICBmcHJpbnRmKHN0ZGVyciwgIiAgLS1kdW1wRXhjZXB0 aW9uICAgICAgICAgICAgRHVtcCB1bmNhdWdodCBleGNlcHRpb24gdGV4dFxuIik7CisgICAgZnBy aW50ZihzdGRlcnIsICIgIC0tZm9vdHByaW50ICAgICAgICAgICAgICAgIER1bXAgbWVtb3J5IGZv b3RwcmludCBhZnRlciBkb25lIGV4ZWN1dGluZ1xuIik7CiAgICAgZnByaW50ZihzdGRlcnIsICIg IC0tb3B0aW9ucyAgICAgICAgICAgICAgICAgIER1bXBzIGFsbCBKU0MgVk0gb3B0aW9ucyBhbmQg ZXhpdHNcbiIpOwogICAgIGZwcmludGYoc3RkZXJyLCAiICAtLWR1bXBPcHRpb25zICAgICAgICAg ICAgICBEdW1wcyBhbGwgbm9uLWRlZmF1bHQgSlNDIFZNIG9wdGlvbnMgYmVmb3JlIGNvbnRpbnVp bmdcbiIpOwogICAgIGZwcmludGYoc3RkZXJyLCAiICAtLTxqc2MgVk0gb3B0aW9uPj08dmFsdWU+ ICBTZXRzIHRoZSBzcGVjaWZpZWQgSlNDIFZNIG9wdGlvblxuIik7CkBAIC0yNzIwLDYgKzI3MjIs MTEgQEAgdm9pZCBDb21tYW5kTGluZTo6cGFyc2VBcmd1bWVudHMoaW50IGFyZwogICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoIXN0cmNtcChhcmcsICItLWZv b3RwcmludCIpKSB7CisgICAgICAgICAgICBtX2R1bXBNZW1vcnlGb290cHJpbnQgPSB0cnVlOwor ICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KKwogICAgICAgICBzdGF0aWMgY29uc3Qg dW5zaWduZWQgZXhjZXB0aW9uU3RyTGVuZ3RoID0gc3RybGVuKCItLWV4Y2VwdGlvbj0iKTsKICAg ICAgICAgaWYgKCFzdHJuY21wKGFyZywgIi0tZXhjZXB0aW9uPSIsIGV4Y2VwdGlvblN0ckxlbmd0 aCkpIHsKICAgICAgICAgICAgIG1fdW5jYXVnaHRFeGNlcHRpb25OYW1lID0gU3RyaW5nKGFyZyAr IGV4Y2VwdGlvblN0ckxlbmd0aCk7CkBAIC0yOTI4LDYgKzI5MzUsMTIgQEAgaW50IGpzY21haW4o aW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogCiAgICAgcHJpbnRTdXBlclNhbXBsZXJTdGF0ZSgpOwog CisgICAgaWYgKG9wdGlvbnMubV9kdW1wTWVtb3J5Rm9vdHByaW50KSB7CisgICAgICAgIE1lbW9y eUZvb3RwcmludCBmb290cHJpbnQgPSBNZW1vcnlGb290cHJpbnQ6Om5vdygpOworCisgICAgICAg IHByaW50ZigiTWVtb3J5IEZvb3RwcmludDpcbiAgICBDdXJyZW50IEZvb3RwcmludDogJWxsdVxu ICAgIFBlYWsgRm9vdHByaW50OiAlbGx1XG4iLCBmb290cHJpbnQuY3VycmVudCwgZm9vdHByaW50 LnBlYWspOworICAgIH0KKwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK