193412 2019-01-14 15:06:45 -0800 Correctly handle rotation for local video playback 2019-01-15 13:21:10 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1494336 0 youennf 2019-01-14 15:06:45 -0800 We regressed rotation handling for local play back 1494347 1 359084 youennf 2019-01-14 15:31:43 -0800 Created attachment 359084 Patch 1494349 2 youennf 2019-01-14 15:36:54 -0800 <rdar://problem/46878040> 1494784 3 359084 commit-queue 2019-01-15 13:21:09 -0800 Comment on attachment 359084 Patch Clearing flags on attachment: 359084 Committed r240000: <https://trac.webkit.org/changeset/240000> 1494785 4 commit-queue 2019-01-15 13:21:10 -0800 All reviewed patches have been landed. Closing bug. 359084 2019-01-14 15:31:43 -0800 2019-01-15 13:21:09 -0800 Patch bug-193412-20190114153143.patch text/plain 4668 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMzOTRkNzAxZjI1MzE1 ODJiY2IyZGRjMmE2ZDA4N2Q3YjEwYjU5Ni4uNzJkNWNiNDlkY2ZmYTVkMTBhZDRiNjhmYmNmNWFi MDBiNGM3ZGY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAxLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDb3JyZWN0bHkgaGFuZGxl IHJvdGF0aW9uIGZvciBsb2NhbCB2aWRlbyBwbGF5YmFjaworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIEFWVmlkZW9DYXB0dXJlU291cmNlIHRv IGNvbXB1dGUgdGhlIHNpemUgZ2l2ZW4gdG8gc2V0dGluZ3MgYWZ0ZXIgcm90YXRpbmcgdGhlIHNh bXBsZS4KKyAgICAgICAgVGhpcyBlbnN1cmVzIGNvbXB1dGluZyB0aGUgc2l6ZSBvZiB2aWRlbyBl bGVtZW50cyBhcHByb3ByaWF0ZWx5LgorICAgICAgICBBbHNvIG1ha2VzIHN1cmUgdG8gbm90aWZ5 IG9ic2VydmVycyBvZiBzaXplIGNoYW5nZSB3aGVuZXZlciByb3RhdGlvbiBoYXBwZW5zIGFzIHNl dHRpbmdzKCkgY2FsbCB3aWxsIHByb3ZpZGUgYSBkaWZmZXJlbnQgc2l6ZS4KKyAgICAgICAgQ292 ZXJlZCBieSBtYW51YWwgdGVzdGluZyBhcyB3ZSBkbyBub3QgaGF2ZSB5ZXQgZW11bGF0aW9uIG9m IGxvY2FsIGNhcHR1cmUgd2l0aCByb3RhdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlh c3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRp bWVNZWRpYVNvdXJjZTo6c2V0SW50cmluc2ljU2l6ZSk6CisgICAgICAgICogcGxhdGZvcm0vbWVk aWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tOgorICAgICAgICAoV2ViQ29yZTo6 QVZWaWRlb0NhcHR1cmVTb3VyY2U6OnNldHRpbmdzKToKKyAgICAgICAgKFdlYkNvcmU6OkFWVmlk ZW9DYXB0dXJlU291cmNlOjpjb21wdXRlU2FtcGxlUm90YXRpb24pOgorCiAyMDE5LTAxLTA5ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXVtNYXJn aW5Db2xsYXBzaW5nXSBBZGQgc3VwcG9ydCBmb3IgcGVjdWxpYXIgY2FzZXMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU1lZGlhU291cmNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFT b3VyY2UuY3BwCmluZGV4IGU0ZTVhOTg4MGZlNGRkNjk3YzhhMjI5OWM0YjI2ZWM0ZGUxMWE4YWMu Ljk2Y2Y1ZDk5YzNiYjI1ZTI5YzJmNmJiMzk2YzhiNWI4MDI2NzkxOTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFTb3VyY2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lTWVkaWFT b3VyY2UuY3BwCkBAIC04OTAsOSArODkwLDEwIEBAIHZvaWQgUmVhbHRpbWVNZWRpYVNvdXJjZTo6 c2V0SW50cmluc2ljU2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogICAgIGlmIChtX2ludHJpbnNp Y1NpemUgPT0gc2l6ZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgYXV0byBjdXJyZW50U2l6ZSA9 IHRoaXMtPnNpemUoKTsKICAgICBtX2ludHJpbnNpY1NpemUgPSBzaXplOwogCi0gICAgaWYgKG1f aW50cmluc2ljU2l6ZSAhPSBtX3NpemUpCisgICAgaWYgKGN1cnJlbnRTaXplICE9IHRoaXMtPnNp emUoKSkKICAgICAgICAgbm90aWZ5U2V0dGluZ3NEaWRDaGFuZ2VPYnNlcnZlcnMoeyBSZWFsdGlt ZU1lZGlhU291cmNlU2V0dGluZ3M6OkZsYWc6OldpZHRoLCBSZWFsdGltZU1lZGlhU291cmNlU2V0 dGluZ3M6OkZsYWc6OkhlaWdodCB9KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1t CmluZGV4IDhhMDBmMDQ1MTdkOTczZjlkNWJjN2QzYThkM2UzNWY1MzZmZWQwNWIuLjE2YmI4MjE1 MzlmMDVjZGEyYjQ5NWQ5ODI0NGI3NjkwOWZkMWE4ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVT b3VyY2UubW0KQEAgLTI2MCw3ICsyNjAsMTEgQEAgY29uc3QgUmVhbHRpbWVNZWRpYVNvdXJjZVNl dHRpbmdzJiBBVlZpZGVvQ2FwdHVyZVNvdXJjZTo6c2V0dGluZ3MoKQogICAgICAgICBzZXR0aW5n cy5zZXRGYWNpbmdNb2RlKFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6VW5rbm93bik7CiAK ICAgICBzZXR0aW5ncy5zZXRGcmFtZVJhdGUoZnJhbWVSYXRlKCkpOwotICAgIGF1dG8mIHNpemUg PSB0aGlzLT5zaXplKCk7CisKKyAgICBhdXRvIHNpemUgPSB0aGlzLT5zaXplKCk7CisgICAgaWYg KG1fc2FtcGxlUm90YXRpb24gPT0gTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246OkxlZnQgfHwg bV9zYW1wbGVSb3RhdGlvbiA9PSBNZWRpYVNhbXBsZTo6VmlkZW9Sb3RhdGlvbjo6UmlnaHQpCisg ICAgICAgIHNpemUgPSBzaXplLnRyYW5zcG9zZWRTaXplKCk7CisgICAgCiAgICAgc2V0dGluZ3Mu c2V0V2lkdGgoc2l6ZS53aWR0aCgpKTsKICAgICBzZXR0aW5ncy5zZXRIZWlnaHQoc2l6ZS5oZWln aHQoKSk7CiAgICAgc2V0dGluZ3Muc2V0RGV2aWNlSWQoaGFzaGVkSWQoKSk7CkBAIC01MDEsMjUg KzUwNSwzMSBAQCB2b2lkIEFWVmlkZW9DYXB0dXJlU291cmNlOjpvcmllbnRhdGlvbkNoYW5nZWQo aW50IG9yaWVudGF0aW9uKQogdm9pZCBBVlZpZGVvQ2FwdHVyZVNvdXJjZTo6Y29tcHV0ZVNhbXBs ZVJvdGF0aW9uKCkKIHsKICAgICBib29sIGZyb250Q2FtZXJhID0gW2RldmljZSgpIHBvc2l0aW9u XSA9PSBBVkNhcHR1cmVEZXZpY2VQb3NpdGlvbkZyb250OworICAgIE1lZGlhU2FtcGxlOjpWaWRl b1JvdGF0aW9uIHNhbXBsZVJvdGF0aW9uOwogICAgIHN3aXRjaCAobV9zZW5zb3JPcmllbnRhdGlv biAtIG1fZGV2aWNlT3JpZW50YXRpb24pIHsKICAgICBjYXNlIDA6Ci0gICAgICAgIG1fc2FtcGxl Um90YXRpb24gPSBNZWRpYVNhbXBsZTo6VmlkZW9Sb3RhdGlvbjo6Tm9uZTsKKyAgICAgICAgc2Ft cGxlUm90YXRpb24gPSBNZWRpYVNhbXBsZTo6VmlkZW9Sb3RhdGlvbjo6Tm9uZTsKICAgICAgICAg YnJlYWs7CiAgICAgY2FzZSAxODA6CiAgICAgY2FzZSAtMTgwOgotICAgICAgICBtX3NhbXBsZVJv dGF0aW9uID0gTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246OlVwc2lkZURvd247CisgICAgICAg IHNhbXBsZVJvdGF0aW9uID0gTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246OlVwc2lkZURvd247 CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgOTA6Ci0gICAgICAgIG1fc2FtcGxlUm90YXRpb24g PSBmcm9udENhbWVyYSA/IE1lZGlhU2FtcGxlOjpWaWRlb1JvdGF0aW9uOjpMZWZ0IDogTWVkaWFT YW1wbGU6OlZpZGVvUm90YXRpb246OlJpZ2h0OworICAgICAgICBzYW1wbGVSb3RhdGlvbiA9IGZy b250Q2FtZXJhID8gTWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246OkxlZnQgOiBNZWRpYVNhbXBs ZTo6VmlkZW9Sb3RhdGlvbjo6UmlnaHQ7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgLTkwOgog ICAgIGNhc2UgLTI3MDoKLSAgICAgICAgbV9zYW1wbGVSb3RhdGlvbiA9IGZyb250Q2FtZXJhID8g TWVkaWFTYW1wbGU6OlZpZGVvUm90YXRpb246OlJpZ2h0IDogTWVkaWFTYW1wbGU6OlZpZGVvUm90 YXRpb246OkxlZnQ7CisgICAgICAgIHNhbXBsZVJvdGF0aW9uID0gZnJvbnRDYW1lcmEgPyBNZWRp YVNhbXBsZTo6VmlkZW9Sb3RhdGlvbjo6UmlnaHQgOiBNZWRpYVNhbXBsZTo6VmlkZW9Sb3RhdGlv bjo6TGVmdDsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7Ci0gICAgICAgIG1fc2FtcGxlUm90YXRpb24gPSBNZWRpYVNhbXBsZTo6Vmlk ZW9Sb3RhdGlvbjo6Tm9uZTsKKyAgICAgICAgc2FtcGxlUm90YXRpb24gPSBNZWRpYVNhbXBsZTo6 VmlkZW9Sb3RhdGlvbjo6Tm9uZTsKICAgICB9CisgICAgaWYgKHNhbXBsZVJvdGF0aW9uID09IG1f c2FtcGxlUm90YXRpb24pCisgICAgICAgIHJldHVybjsKKworICAgIG1fc2FtcGxlUm90YXRpb24g PSBzYW1wbGVSb3RhdGlvbjsKKyAgICBub3RpZnlTZXR0aW5nc0RpZENoYW5nZU9ic2VydmVycyh7 IFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6RmxhZzo6V2lkdGgsIFJlYWx0aW1lTWVkaWFT b3VyY2VTZXR0aW5nczo6RmxhZzo6SGVpZ2h0IH0pOwogfQogCiB2b2lkIEFWVmlkZW9DYXB0dXJl U291cmNlOjpwcm9jZXNzTmV3RnJhbWUoUmVmPE1lZGlhU2FtcGxlPiYmIHNhbXBsZSkK