193400 2019-01-14 09:34:53 -0800 Remove the specific handling of ephemeral sessions from CacheStorage::Engine::from 2019-01-15 14:35:50 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez cgarcia commit-queue ews-watchlist webkit-bug-importer oldest_to_newest 1494174 0 youennf 2019-01-14 09:34:53 -0800 CacheStorage::Engine::from should query the engine map with the default private session ID in case of ephemeral sessions 1494175 1 359043 youennf 2019-01-14 09:38:15 -0800 Created attachment 359043 Patch 1494449 2 359043 achristensen 2019-01-14 18:33:09 -0800 Comment on attachment 359043 Patch I think we should just remove the use of legacyPrivateSessionID here. Why are you expanding it? 1494634 3 youennf 2019-01-15 08:26:27 -0800 (In reply to Alex Christensen from comment #2) > Comment on attachment 359043 [details] > Patch > > I think we should just remove the use of legacyPrivateSessionID here. Why > are you expanding it? True, this is no longer needed. I will remove these two lines instead. 1494638 4 359161 youennf 2019-01-15 08:29:52 -0800 Created attachment 359161 Patch 1494818 5 359161 commit-queue 2019-01-15 14:34:40 -0800 Comment on attachment 359161 Patch Clearing flags on attachment: 359161 Committed r240009: <https://trac.webkit.org/changeset/240009> 1494819 6 commit-queue 2019-01-15 14:34:42 -0800 All reviewed patches have been landed. Closing bug. 1494820 7 webkit-bug-importer 2019-01-15 14:35:50 -0800 <rdar://problem/47297048> 359043 2019-01-14 09:38:15 -0800 2019-01-15 08:29:51 -0800 Patch bug-193400-20190114093814.patch text/plain 2174 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzY2VjN2M1ZWQ2NGJiMWQ1 Mjg5NDRlMzc0NDg1YWJkZDczY2NmOGIuLjNmZTYxNGVhZjljM2JkMTcwNWE0YTQ2ZDRlZTI4OTIy ZDRkNGQyYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMTEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlU3RvcmFnZTo6RW5naW5l Ojpmcm9tIHNob3VsZCBxdWVyeSB0aGUgZW5naW5lIG1hcCB3aXRoIHRoZSBkZWZhdWx0IHByaXZh dGUgc2Vzc2lvbiBJRCBpbiBjYXNlIG9mIGVwaGVtZXJhbCBzZXNzaW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNDAwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIHF1ZXJ5IHRoZSBl bmdpbmUgbWFwIHdpdGggdGhlICd1bmlxdWUnIGVwaGVtZXJhbCBzZXNzaW9uIElELgorICAgICAg ICBUaGlzIHdpbGwgcHJldmVudCB1bm5lY2Vzc2FyeSBJUEMgbWVzc2FnZXMgdG8gcXVlcnkgY2Fj aGUgc3RvcmFnZSBwYXJhbWV0ZXJzIHRvIFVJUHJvY2Vzcy4KKworICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNh Y2hlU3RvcmFnZTo6RW5naW5lOjpmcm9tKToKKyAgICAgICAgKiBXZWJLaXQueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvajoKKwogMjAxOS0wMS0xMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGEgbmV3IFNQSSB0byByZXF1ZXN0IGZvciBjYWNoZSBzdG9y YWdlIHF1b3RhIGluY3JlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZS5jcHAKaW5kZXggMzQxMjJiYjYxNDIwYTVl NDQ3YjM1NzEyZmJkZjdjNDBmYzdkZmI0Yy4uYjY4MTdhMDZiYTk5OGU0MmY5NTM1MTM1ZTk3OTcw ZGQ3OTUwMjdkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9DYWNoZVN0b3JhZ2VFbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lLmNwcApAQCAtNzUsMTQgKzc1LDE0IEBAIEVuZ2lu ZTo6fkVuZ2luZSgpCiAKIHZvaWQgRW5naW5lOjpmcm9tKE5ldHdvcmtQcm9jZXNzJiBuZXR3b3Jr UHJvY2VzcywgUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBGdW5jdGlvbjx2b2lkKEVuZ2luZSYp PiYmIGNhbGxiYWNrKQogeworICAgIGlmIChzZXNzaW9uSUQuaXNFcGhlbWVyYWwoKSkKKyAgICAg ICAgc2Vzc2lvbklEID0gUEFMOjpTZXNzaW9uSUQ6OmxlZ2FjeVByaXZhdGVTZXNzaW9uSUQoKTsK KwogICAgIGlmIChhdXRvKiBlbmdpbmUgPSBuZXR3b3JrUHJvY2Vzcy5maW5kQ2FjaGVFbmdpbmUo c2Vzc2lvbklEKSkgewogICAgICAgICBjYWxsYmFjaygqZW5naW5lKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KIAotICAgIGlmIChzZXNzaW9uSUQuaXNFcGhlbWVyYWwoKSkKLSAgICAgICAgc2Vz c2lvbklEID0gUEFMOjpTZXNzaW9uSUQ6OmxlZ2FjeVByaXZhdGVTZXNzaW9uSUQoKTsKLQogICAg IG5ldHdvcmtQcm9jZXNzLmNhY2hlU3RvcmFnZVBhcmFtZXRlcnMoc2Vzc2lvbklELCBbbmV0d29y a1Byb2Nlc3MgPSBtYWtlUmVmKG5ldHdvcmtQcm9jZXNzKSwgc2Vzc2lvbklELCBjYWxsYmFjayA9 IFdURk1vdmUoY2FsbGJhY2spXSAoYXV0byYmIHJvb3RQYXRoLCBhdXRvIHF1b3RhKSBtdXRhYmxl IHsKICAgICAgICAgY2FsbGJhY2sobmV0d29ya1Byb2Nlc3MtPmVuc3VyZUNhY2hlRW5naW5lKHNl c3Npb25JRCwgWyZdIHsKICAgICAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEVuZ2luZSB7 IHNlc3Npb25JRCwgbmV0d29ya1Byb2Nlc3MuZ2V0KCksIFN0cmluZyB7IHJvb3RQYXRoIH0sIHF1 b3RhIH0pOwo= 359161 2019-01-15 08:29:52 -0800 2019-01-15 14:34:40 -0800 Patch bug-193400-20190115082952.patch text/plain 1741 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzY2VjN2M1ZWQ2NGJiMWQ1 Mjg5NDRlMzc0NDg1YWJkZDczY2NmOGIuLjg5MDBmZGQ0NmJjOGE5Mjk4NDAxNmZkY2E0MjM4YWYy MTliOWQ0MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDEtMTUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSB0aGUgc3BlY2lmaWMg aGFuZGxpbmcgb2YgZXBoZW1lcmFsIHNlc3Npb25zIGZyb20gQ2FjaGVTdG9yYWdlOjpFbmdpbmU6 OmZyb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 MzQwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0 IGlzIG5vIGxvbmdlciBuZWVkZWQgYXMgd2UgY29ycmVjdGx5IGhhbmRsZSBlcGhlbWVyYWwgc2Vz c2lvbnMgcmVtb3ZhbC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3Rv cmFnZUVuZ2luZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6RW5naW5lOjpm cm9tKToKKwogMjAxOS0wMS0xMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIGEgbmV3IFNQSSB0byByZXF1ZXN0IGZvciBjYWNoZSBzdG9yYWdlIHF1b3Rh IGluY3JlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hl L0NhY2hlU3RvcmFnZUVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2Nh Y2hlL0NhY2hlU3RvcmFnZUVuZ2luZS5jcHAKaW5kZXggMzQxMjJiYjYxNDIwYTVlNDQ3YjM1NzEy ZmJkZjdjNDBmYzdkZmI0Yy4uMWI4NDFjZmU2NzQ4ZjAyYWExNzY4ZjQ4N2FlN2FjYjEyNjg2M2M5 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0 b3JhZ2VFbmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv Q2FjaGVTdG9yYWdlRW5naW5lLmNwcApAQCAtODAsOSArODAsNiBAQCB2b2lkIEVuZ2luZTo6ZnJv bShOZXR3b3JrUHJvY2VzcyYgbmV0d29ya1Byb2Nlc3MsIFBBTDo6U2Vzc2lvbklEIHNlc3Npb25J RCwgRnVuYwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKHNlc3Npb25JRC5pc0Vw aGVtZXJhbCgpKQotICAgICAgICBzZXNzaW9uSUQgPSBQQUw6OlNlc3Npb25JRDo6bGVnYWN5UHJp dmF0ZVNlc3Npb25JRCgpOwotCiAgICAgbmV0d29ya1Byb2Nlc3MuY2FjaGVTdG9yYWdlUGFyYW1l dGVycyhzZXNzaW9uSUQsIFtuZXR3b3JrUHJvY2VzcyA9IG1ha2VSZWYobmV0d29ya1Byb2Nlc3Mp LCBzZXNzaW9uSUQsIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldIChhdXRvJiYgcm9vdFBh dGgsIGF1dG8gcXVvdGEpIG11dGFibGUgewogICAgICAgICBjYWxsYmFjayhuZXR3b3JrUHJvY2Vz cy0+ZW5zdXJlQ2FjaGVFbmdpbmUoc2Vzc2lvbklELCBbJl0gewogICAgICAgICAgICAgcmV0dXJu IGFkb3B0UmVmKCpuZXcgRW5naW5lIHsgc2Vzc2lvbklELCBuZXR3b3JrUHJvY2Vzcy5nZXQoKSwg U3RyaW5nIHsgcm9vdFBhdGggfSwgcXVvdGEgfSk7Cg==