193384 2019-01-12 16:21:01 -0800 Web Inspector: Event breakpoints: typing uppercase "DOM" doesn't show completions for events that start with "DOM" 2019-01-14 15:23:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1494007 0 nvasilyev 2019-01-12 16:21:01 -0800 Steps: 1. Add an event breakpoint 2. Type "DOM" Expected: Completion shows events that start with "DOM", e.g. "DOMActivate", "DOMCharacterDataModified", and etc. Actual: No completion is shown. Notes: Typing lowercase "dom" shows events that start with "DOM". 1494014 1 358999 hi 2019-01-12 19:23:28 -0800 Created attachment 358999 Patch 1494275 2 358999 nvasilyev 2019-01-14 13:13:51 -0800 Comment on attachment 358999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358999&action=review > Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:109 > + if (eventName.toLowerCase().startsWith(this._domEventNameInputElement.value.toLowerCase())) This fixes the bug! I'd r+ 👍 1494333 3 358999 joepeck 2019-01-14 14:56:20 -0800 Comment on attachment 358999 Patch r=me 1494340 4 358999 commit-queue 2019-01-14 15:22:52 -0800 Comment on attachment 358999 Patch Clearing flags on attachment: 358999 Committed r239955: <https://trac.webkit.org/changeset/239955> 1494341 5 commit-queue 2019-01-14 15:22:54 -0800 All reviewed patches have been landed. Closing bug. 1494342 6 webkit-bug-importer 2019-01-14 15:23:28 -0800 <rdar://problem/47267836> 358999 2019-01-12 19:23:28 -0800 2019-01-14 15:22:52 -0800 Patch bug-193384-20190112202327.patch text/plain 1732 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVmMjg4MjQ3NDM5NWY2MjMxMjdjMDkzNDNmMWIz NzRlNjk1ZDZlNGIuLjg4NWVhMzg1Y2U1MWYyM2YzN2RjMmIwZWNlNzMyNmNiNDI0MWNkNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTEyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBF dmVudCBicmVha3BvaW50czogdHlwaW5nIHVwcGVyY2FzZSAiRE9NIiBkb2Vzbid0IHNob3cgY29t cGxldGlvbnMgZm9yIGV2ZW50cyB0aGF0IHN0YXJ0IHdpdGggIkRPTSIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzM4NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9F dmVudEJyZWFrcG9pbnRQb3BvdmVyLmpzOgorICAgICAgICAoV0kuRXZlbnRCcmVha3BvaW50UG9w b3Zlci5wcm90b3R5cGUuc2hvdyk6CisKIDIwMTktMDEtMTEgIE1hdHQgQmFrZXIgIDxtYXR0YmFr ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IGRlbGV0 aW5nIGFuIGF1ZGl0IHB1dHMgc2VsZWN0aW9uIGluIGEgc2VsZWN0ZWQgYnV0IGludmlzaWJsZSBz dGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRXZlbnRCcmVha3BvaW50UG9wb3Zlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0V2ZW50QnJlYWtwb2ludFBvcG92ZXIuanMKaW5kZXggYzM4YmEwYTlk OTBiOGM4MGU4YTc5ZDEwNDg3YmY2ZmNkNjVmMDY3MS4uM2E3NDNkNTdiYWY3Y2VjODAwZDczM2Qw OTM4YTM2OWU2MDdjNjQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRXZlbnRCcmVha3BvaW50UG9wb3Zlci5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9FdmVudEJyZWFrcG9pbnRQb3BvdmVyLmpz CkBAIC0xMDYsNyArMTA2LDcgQEAgV0kuRXZlbnRCcmVha3BvaW50UG9wb3ZlciA9IGNsYXNzIEV2 ZW50QnJlYWtwb2ludFBvcG92ZXIgZXh0ZW5kcyBXSS5Qb3BvdmVyCiAgICAgICAgICAgICAudGhl bigoZXZlbnROYW1lcykgPT4gewogICAgICAgICAgICAgICAgIHRoaXMuX2N1cnJlbnRDb21wbGV0 aW9ucyA9IFtdOwogICAgICAgICAgICAgICAgIGZvciAobGV0IGV2ZW50TmFtZSBvZiBldmVudE5h bWVzKSB7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChldmVudE5hbWUudG9Mb3dlckNhc2UoKS5z dGFydHNXaXRoKHRoaXMuX2RvbUV2ZW50TmFtZUlucHV0RWxlbWVudC52YWx1ZSkpCisgICAgICAg ICAgICAgICAgICAgIGlmIChldmVudE5hbWUudG9Mb3dlckNhc2UoKS5zdGFydHNXaXRoKHRoaXMu X2RvbUV2ZW50TmFtZUlucHV0RWxlbWVudC52YWx1ZS50b0xvd2VyQ2FzZSgpKSkKICAgICAgICAg ICAgICAgICAgICAgICAgIHRoaXMuX2N1cnJlbnRDb21wbGV0aW9ucy5wdXNoKGV2ZW50TmFtZSk7 CiAgICAgICAgICAgICAgICAgfQogCg==