193369 2019-01-11 15:11:05 -0800 Fix style CFNetworkSPI style checker warnings from r239698 2019-01-11 16:41:28 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist hi joepeck webkit-bug-importer oldest_to_newest 1493851 0 hi 2019-01-11 15:11:05 -0800 <https://webkit.org/b/191539#c36>: ERROR: Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:214: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:94: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:134: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:661: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] 1493852 1 358954 hi 2019-01-11 15:12:53 -0800 Created attachment 358954 Patch 1493857 2 358954 joepeck 2019-01-11 15:24:16 -0800 Comment on attachment 358954 Patch r=me 1493885 3 358954 commit-queue 2019-01-11 16:40:20 -0800 Comment on attachment 358954 Patch Clearing flags on attachment: 358954 Committed r239884: <https://trac.webkit.org/changeset/239884> 1493886 4 commit-queue 2019-01-11 16:40:22 -0800 All reviewed patches have been landed. Closing bug. 1493889 5 webkit-bug-importer 2019-01-11 16:41:28 -0800 <rdar://problem/47224762> 358954 2019-01-11 15:12:53 -0800 2019-01-11 16:40:20 -0800 Patch bug-193369-20190111161252.patch text/plain 5063 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjA5Y2ViZTIxN2RkZjMzZmIwNzVhNjBiMzhhYWVkOGMzNDBjNzQ2Mi4uZThlOWJjNGNm YWI5NmU4OTdiYWFiODJlZDhhNzU4Y2E2YjZlODZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx OS0wMS0xMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IHN0eWxlIENGTmV0d29ya1NQSSBzdHlsZSBjaGVja2VyIHdhcm5pbmdzIGZyb20gcjIzOTY5OAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzY5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAxOS0wMS0xMSAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KIAogICAgICAgICBFbmFibGUgREZHIG9uIEFSTS9MaW51eCBhZ2FpbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFu Z2VMb2cKaW5kZXggNWExMGQ3NDkxNTk5MDY2MTI5NGU5MjBkODdlYWI4MTAwMmIyN2VmYi4uYzlh OWQ3ZGU2MjUwYTJjMTkzNWNkMTEwNWY2OGM3NGVhZWZmMjZlZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMTEgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBw bGUuY29tPgorCisgICAgICAgIEZpeCBzdHlsZSBDRk5ldHdvcmtTUEkgc3R5bGUgY2hlY2tlciB3 YXJuaW5ncyBmcm9tIHIyMzk2OTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MzM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaDoKKwogMjAxOS0wMS0xMCAg Sm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBPdmVycmlkZSB0 aGUgc2Vzc2lvbiBjb25maWd1cmF0aW9uIGZvciBjb29raWVBY2NlcHRQb2xpY3kKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5k ZXggZDUzY2MzM2M2OTI3ZTYxYWE0ZTY5ZGFlOTBkYTgwNTEyNTdkZTkyNS4uNGU0YjhlNzdjZTIx OTFiODg2MDBkMDU4MTFkNzdjZjU4Y2UzNmQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wMS0xMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IHN0eWxlIENGTmV0d29ya1NQSSBzdHlsZSBjaGVja2VyIHdhcm5pbmdzIGZyb20gcjIzOTY5 OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzY5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoLVtXS05l dHdvcmtTZXNzaW9uRGVsZWdhdGUgVVJMU2Vzc2lvbjp0YXNrOmRpZEZpbmlzaENvbGxlY3RpbmdN ZXRyaWNzOl0pOgorCiAyMDE5LTAxLTExICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBw bGUuY29tPgogCiAgICAgICAgIEludHJvZHVjZSBJREwgZmlsZXMgZm9yIHJ1bnRpbWUtZW5hYmxl ZCBVbmRvTWFuYWdlciBhbmQgVW5kb0l0ZW0gSmF2YVNjcmlwdCBBUEkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4 IGE1NzRiMDRlYjMyZDMxODg4MjBmMDRkZGI3ZGRiYTkwMzZhM2M5NzMuLjhkZjk1MmU4YmVkMjIz MTU1OGFmNTZjNDU2YTI1MTliNTU5OTM3YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtMTQ3MSwzICsxNDcx LDcgQEAKICNpZiAoUExBVEZPUk0oTUFDKSAmJiAoX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA9PSAxMDEyMDAgfHwgKF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx NDAwICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDE0MDQpKSkgfHwgKFBM QVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAw ICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTIwMjAwKSB8fCAoUExBVEZP Uk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSA1MDAwMCAm JiBfX1dBVENIX09TX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gNTAyMDApIHx8IChQTEFURk9STShB UFBMRVRWKSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMCAmJiBfX1RW X09TX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTIwMjAwKQogI2RlZmluZSBIQVZFX0NGTkVUV09S S19PVkVSUklERV9TRVNTSU9OX0NPT0tJRV9BQ0NFUFRfUE9MSUNZIDEKICNlbmRpZgorCisjaWYg KFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1 MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMzAwMDApCisjZGVmaW5lIEhBVkVfQ0ZORVRXT1JLX05FR09USUFURURfU1NM X1BST1RPQ09MX0NJUEhFUiAxCisjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BB TC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkv Y2YvQ0ZOZXR3b3JrU1BJLmgKaW5kZXggMmNmM2RjM2U5ZWFhNGVhZjRiZmY0YjAxYTEyNjdlZTU5 YzdjNzIwNS4uNWM0ZTk4M2I0ZjRjMDg3MWNiM2ZiMDc5YWFhOGRhMzA1MzU5MGQzMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKKysrIGIv U291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKQEAgLTIxNSw3ICsy MTUsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBOU1VSTFNlc3Npb25Db21wYW5pb25Q cm94eVByZWZlcmVuY2UpIHsKIEBlbmQKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8IChQTEFURk9STShJ T1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDAp CisjaWYgSEFWRShDRk5FVFdPUktfTkVHT1RJQVRFRF9TU0xfUFJPVE9DT0xfQ0lQSEVSKQogQGlu dGVyZmFjZSBOU1VSTFNlc3Npb25UYXNrVHJhbnNhY3Rpb25NZXRyaWNzICgpCiBAcHJvcGVydHkg KGFzc2lnbikgU1NMUHJvdG9jb2wgX25lZ290aWF0ZWRUTFNQcm90b2NvbDsKIEBwcm9wZXJ0eSAo YXNzaWduKSBTU0xDaXBoZXJTdWl0ZSBfbmVnb3RpYXRlZFRMU0NpcGhlcjsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5t bSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2Nv YS5tbQppbmRleCBmODU2ZmY1NTIyYmE5YzRjMmIwZTZhNzg1YjQ2NmUzMzZkYjZmNThlLi4wZWNk ODg2ZWI0MGYwODAyYjExMmNiNzc3OTYxNTJmNTE4OTM3NDQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1t CkBAIC05Myw3ICs5Myw3IEBAIHN0YXRpYyBXZWJDb3JlOjpOZXR3b3JrTG9hZFByaW9yaXR5IHRv TmV0d29ya0xvYWRQcmlvcml0eShmbG9hdCBwcmlvcml0eSkKICAgICByZXR1cm4gV2ViQ29yZTo6 TmV0d29ya0xvYWRQcmlvcml0eTo6TWVkaXVtOwogfQogCi0jaWYgKFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE1MDApIHx8IChQTEFURk9STShJ T1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMzAwMDAp CisjaWYgSEFWRShDRk5FVFdPUktfTkVHT1RJQVRFRF9TU0xfUFJPVE9DT0xfQ0lQSEVSKQogc3Rh dGljIFN0cmluZyBzdHJpbmdGb3JTU0xQcm90b2NvbChTU0xQcm90b2NvbCBwcm90b2NvbCkKIHsK ICAgICBzd2l0Y2ggKHByb3RvY29sKSB7CkBAIC02NjAsNyArNjYwLDcgQEAgLSAodm9pZClVUkxT ZXNzaW9uOihOU1VSTFNlc3Npb24gKilzZXNzaW9uIHRhc2s6KE5TVVJMU2Vzc2lvblRhc2sgKil0 YXNrIGRpZEZpbmkKICAgICAgICAgICAgIG5ldHdvcmtMb2FkTWV0cmljcy5jb25uZWN0aW9uSWRl bnRpZmllciA9IFN0cmluZyhbbS5fY29ubmVjdGlvbklkZW50aWZpZXIgVVVJRFN0cmluZ10pOwog I2VuZGlmCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEwMTUwMCkgfHwgKFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9fSVBIT05FX09T X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEzMDAwMCkKKyNpZiBIQVZFKENGTkVUV09SS19ORUdP VElBVEVEX1NTTF9QUk9UT0NPTF9DSVBIRVIpCiAgICAgICAgICAgICBuZXR3b3JrTG9hZE1ldHJp Y3MudGxzUHJvdG9jb2wgPSBzdHJpbmdGb3JTU0xQcm90b2NvbChtLl9uZWdvdGlhdGVkVExTUHJv dG9jb2wpOwogICAgICAgICAgICAgbmV0d29ya0xvYWRNZXRyaWNzLnRsc0NpcGhlciA9IHN0cmlu Z0ZvclNTTENpcGhlcihtLl9uZWdvdGlhdGVkVExTQ2lwaGVyKTsKICNlbmRpZgo=