193362 2019-01-11 13:45:04 -0800 webkitpy: Support alternate simctl device list output 2019-01-14 13:32:51 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn lforschler ryanhaddad thorton webkit-bug-importer oldest_to_newest 1493784 0 jbedard 2019-01-11 13:45:04 -0800 There are a few different variations of simctl device list outputs, we should support them. 1493785 1 jbedard 2019-01-11 13:45:21 -0800 <rdar://problem/47122965> 1493794 2 358939 jbedard 2019-01-11 13:52:24 -0800 Created attachment 358939 Patch 1493812 3 358939 lforschler 2019-01-11 14:07:33 -0800 Comment on attachment 358939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358939&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:137 > + for devices_for_runtime in simctl_json['devices']: it seems strange to set devices_for_runtime to an empty list, then use it as an iterator here? 1493813 4 358945 jbedard 2019-01-11 14:11:08 -0800 Created attachment 358945 Patch 1493815 5 jbedard 2019-01-11 14:12:17 -0800 (In reply to Lucas Forschler from comment #3) > Comment on attachment 358939 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358939&action=review > > > Tools/Scripts/webkitpy/xcode/simulated_device.py:137 > > + for devices_for_runtime in simctl_json['devices']: > > it seems strange to set devices_for_runtime to an empty list, then use it as > an iterator here? Surprised this code worked! Just uploaded a patch to fix it. 1493835 6 358945 commit-queue 2019-01-11 14:48:21 -0800 Comment on attachment 358945 Patch Clearing flags on attachment: 358945 Committed r239878: <https://trac.webkit.org/changeset/239878> 1493836 7 commit-queue 2019-01-11 14:48:23 -0800 All reviewed patches have been landed. Closing bug. 1493837 8 webkit-bug-importer 2019-01-11 14:49:28 -0800 <rdar://problem/47221502> 1494277 9 jbedard 2019-01-14 13:20:45 -0800 Reopening to attach new patch. 1494278 10 359074 jbedard 2019-01-14 13:20:46 -0800 Created attachment 359074 Patch 1494284 11 jbedard 2019-01-14 13:32:51 -0800 Committed r239939: <https://trac.webkit.org/changeset/239939> 358939 2019-01-11 13:52:24 -0800 2019-01-11 14:11:07 -0800 Patch bug-193362-20190111135224.patch text/plain 1957 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTg3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogU3VwcG9ydCBhbHRlcm5hdGUgc2ltY3RsIGRldmljZSBs aXN0IG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzMzYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzEyMjk2NT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv eGNvZGUvc2ltdWxhdGVkX2RldmljZS5weToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFn ZXIucG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMpOgorCiAyMDE5LTAxLTExICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW51cCBwb3NzaWJsZSBX SypDb3B5L0NyZWF0ZSBsZWFrcyBpbiBXZWJLaXRUZXN0UnVubmVyCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShyZXZpc2lvbiAy Mzk4NzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2Uu cHkJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw3ICsxMzEsMTcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2 aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLkFWQUlM QUJMRV9SVU5USU1FUyA9IFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2NyZWF0ZV9ydW50aW1lcyhz aW1jdGxfanNvblsncnVudGltZXMnXSkKIAogICAgICAgICBmb3IgcnVudGltZSBpbiBTaW11bGF0 ZWREZXZpY2VNYW5hZ2VyLkFWQUlMQUJMRV9SVU5USU1FUzoKLSAgICAgICAgICAgIGZvciBkZXZp Y2VfanNvbiBpbiBzaW1jdGxfanNvblsnZGV2aWNlcyddW3J1bnRpbWUubmFtZV06CisgICAgICAg ICAgICAjIE5lZWRlZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzQ3MTIyOTY1PgorICAgICAgICAgICAg ZGV2aWNlc19mb3JfcnVudGltZSA9IFtdCisgICAgICAgICAgICBpZiBpc2luc3RhbmNlKHNpbWN0 bF9qc29uWydkZXZpY2VzJ10sIGxpc3QpOgorICAgICAgICAgICAgICAgIGZvciBkZXZpY2VzX2Zv cl9ydW50aW1lIGluIHNpbWN0bF9qc29uWydkZXZpY2VzJ106CisgICAgICAgICAgICAgICAgICAg IGlmIGRldmljZXNfZm9yX3J1bnRpbWVbJ25hbWUnXSA9PSBydW50aW1lLm5hbWU6CisgICAgICAg ICAgICAgICAgICAgICAgICBkZXZpY2VzX2Zvcl9ydW50aW1lID0gZGV2aWNlc19mb3JfcnVudGlt ZVsnZGV2aWNlcyddCisgICAgICAgICAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAg ZWxzZToKKyAgICAgICAgICAgICAgICBkZXZpY2VzX2Zvcl9ydW50aW1lID0gc2ltY3RsX2pzb25b J2RldmljZXMnXVtydW50aW1lLm5hbWVdCisKKyAgICAgICAgICAgIGZvciBkZXZpY2VfanNvbiBp biBkZXZpY2VzX2Zvcl9ydW50aW1lOgogICAgICAgICAgICAgICAgIGRldmljZSA9IFNpbXVsYXRl ZERldmljZU1hbmFnZXIuX2NyZWF0ZV9kZXZpY2Vfd2l0aF9ydW50aW1lKGhvc3QsIHJ1bnRpbWUs IGRldmljZV9qc29uKQogICAgICAgICAgICAgICAgIGlmIG5vdCBkZXZpY2U6CiAgICAgICAgICAg ICAgICAgICAgIGNvbnRpbnVlCg== 358945 2019-01-11 14:11:08 -0800 2019-01-14 13:20:44 -0800 Patch bug-193362-20190111141107.patch text/plain 1909 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTg3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogU3VwcG9ydCBhbHRlcm5hdGUgc2ltY3RsIGRldmljZSBs aXN0IG91dHB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzMzYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzEyMjk2NT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv eGNvZGUvc2ltdWxhdGVkX2RldmljZS5weToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFn ZXIucG9wdWxhdGVfYXZhaWxhYmxlX2RldmljZXMpOgorCiAyMDE5LTAxLTExICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW51cCBwb3NzaWJsZSBX SypDb3B5L0NyZWF0ZSBsZWFrcyBpbiBXZWJLaXRUZXN0UnVubmVyCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShyZXZpc2lvbiAy Mzk4NzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2Uu cHkJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw3ICsxMzEsMTcgQEAgY2xhc3MgU2ltdWxhdGVkRGV2 aWNlTWFuYWdlcihvYmplY3QpOgogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLkFWQUlM QUJMRV9SVU5USU1FUyA9IFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2NyZWF0ZV9ydW50aW1lcyhz aW1jdGxfanNvblsncnVudGltZXMnXSkKIAogICAgICAgICBmb3IgcnVudGltZSBpbiBTaW11bGF0 ZWREZXZpY2VNYW5hZ2VyLkFWQUlMQUJMRV9SVU5USU1FUzoKLSAgICAgICAgICAgIGZvciBkZXZp Y2VfanNvbiBpbiBzaW1jdGxfanNvblsnZGV2aWNlcyddW3J1bnRpbWUubmFtZV06CisgICAgICAg ICAgICAjIE5lZWRlZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzQ3MTIyOTY1PgorICAgICAgICAgICAg ZGV2aWNlcyA9IFtdCisgICAgICAgICAgICBpZiBpc2luc3RhbmNlKHNpbWN0bF9qc29uWydkZXZp Y2VzJ10sIGxpc3QpOgorICAgICAgICAgICAgICAgIGZvciBkZXZpY2VzX2Zvcl9ydW50aW1lIGlu IHNpbWN0bF9qc29uWydkZXZpY2VzJ106CisgICAgICAgICAgICAgICAgICAgIGlmIGRldmljZXNf Zm9yX3J1bnRpbWVbJ25hbWUnXSA9PSBydW50aW1lLm5hbWU6CisgICAgICAgICAgICAgICAgICAg ICAgICBkZXZpY2VzID0gZGV2aWNlc19mb3JfcnVudGltZVsnZGV2aWNlcyddCisgICAgICAgICAg ICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICBk ZXZpY2VzID0gc2ltY3RsX2pzb25bJ2RldmljZXMnXVtydW50aW1lLm5hbWVdCisKKyAgICAgICAg ICAgIGZvciBkZXZpY2VfanNvbiBpbiBkZXZpY2VzOgogICAgICAgICAgICAgICAgIGRldmljZSA9 IFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2NyZWF0ZV9kZXZpY2Vfd2l0aF9ydW50aW1lKGhvc3Qs IHJ1bnRpbWUsIGRldmljZV9qc29uKQogICAgICAgICAgICAgICAgIGlmIG5vdCBkZXZpY2U6CiAg ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCg== 359074 2019-01-14 13:20:46 -0800 2019-01-14 13:22:59 -0800 Patch bug-193362-20190114132046.patch text/plain 1480 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTkzNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTE0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogU3VwcG9ydCBhbHRlcm5hdGUgc2ltY3RsIGRldmljZSBs aXN0IG91dHB1dCAoRm9sbG93LXVwIGZpeCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MzM2MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDcxMjI5 NjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11 bGF0ZWREZXZpY2VNYW5hZ2VyLnBvcHVsYXRlX2F2YWlsYWJsZV9kZXZpY2VzKToKKwogMjAxOS0w MS0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBb aU9TXSBFeHBvc2UgU1BJIHRvIGFjY2VzcyB0aGUgY3VycmVudCBzZW50ZW5jZSBib3VuZGFyeSBh bmQgc2VsZWN0aW9uIHN0YXRlCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3Np bXVsYXRlZF9kZXZpY2UucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94 Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CShyZXZpc2lvbiAyMzk5MjkpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHdvcmtpbmcgY29weSkKQEAg LTEzOSw3ICsxMzksNyBAQCBjbGFzcyBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyKG9iamVjdCk6CiAg ICAgICAgICAgICAgICAgICAgICAgICBkZXZpY2VzID0gZGV2aWNlc19mb3JfcnVudGltZVsnZGV2 aWNlcyddCiAgICAgICAgICAgICAgICAgICAgICAgICBicmVhawogICAgICAgICAgICAgZWxzZToK LSAgICAgICAgICAgICAgICBkZXZpY2VzID0gc2ltY3RsX2pzb25bJ2RldmljZXMnXVtydW50aW1l Lm5hbWVdCisgICAgICAgICAgICAgICAgZGV2aWNlcyA9IHNpbWN0bF9qc29uWydkZXZpY2VzJ10u Z2V0KHJ1bnRpbWUubmFtZSwgTm9uZSkgb3Igc2ltY3RsX2pzb25bJ2RldmljZXMnXS5nZXQocnVu dGltZS5pZGVudGlmaWVyLCBbXSkKIAogICAgICAgICAgICAgZm9yIGRldmljZV9qc29uIGluIGRl dmljZXM6CiAgICAgICAgICAgICAgICAgZGV2aWNlID0gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5f Y3JlYXRlX2RldmljZV93aXRoX3J1bnRpbWUoaG9zdCwgcnVudGltZSwgZGV2aWNlX2pzb24pCg==