193354 2019-01-11 11:15:05 -0800 Make "Disable Web SQL" on by default 2019-01-16 09:09:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 193451 1 sihui_liu sihui_liu commit-queue ggaren tsavell webkit-bug-importer oldest_to_newest 1493712 0 sihui_liu 2019-01-11 11:15:05 -0800 Web SQL should be off now. 1493713 1 sihui_liu 2019-01-11 11:15:43 -0800 <rdar://problem/46524584> 1493718 2 358915 sihui_liu 2019-01-11 11:23:25 -0800 Created attachment 358915 Patch 1493816 3 358915 ggaren 2019-01-11 14:18:52 -0800 Comment on attachment 358915 Patch r=me 1493897 4 358915 commit-queue 2019-01-11 17:00:21 -0800 Comment on attachment 358915 Patch Clearing flags on attachment: 358915 Committed r239885: <https://trac.webkit.org/changeset/239885> 1493898 5 commit-queue 2019-01-11 17:00:23 -0800 All reviewed patches have been landed. Closing bug. 1494328 6 tsavell 2019-01-14 14:52:18 -0800 I found that the changes in https://trac.webkit.org/changeset/239885/webkit has caused 2 API failure and 1 Timeout on Mac. Log: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run-api-tests/logs/stdio Confirmed this using command: run-api-tests --no-build --debug --root debug-239885 I got these failures with a spade with 239885 but none with 239884. 1494380 7 sihui_liu 2019-01-14 16:20:47 -0800 (In reply to Truitt Savell from comment #6) > I found that the changes in https://trac.webkit.org/changeset/239885/webkit > > has caused 2 API failure and 1 Timeout on Mac. > > Log: > https://build.webkit.org/builders/ > Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/10386/steps/run- > api-tests/logs/stdio > > Confirmed this using command: > run-api-tests --no-build --debug --root debug-239885 > > I got these failures with a spade with 239885 but none with 239884. This failure should be harmless. We can either remove the WebSQL part or enable WebSQL in TestRunner. 1494393 8 ggaren 2019-01-14 16:38:04 -0800 Can we change the API tests to explicitly enable WebSQL when they run? 1494437 9 sihui_liu 2019-01-14 18:06:20 -0800 (In reply to Geoffrey Garen from comment #8) > Can we change the API tests to explicitly enable WebSQL when they run? We have (In reply to Geoffrey Garen from comment #8) > Can we change the API tests to explicitly enable WebSQL when they run? Yes, we can 1494439 10 359112 sihui_liu 2019-01-14 18:07:45 -0800 Created attachment 359112 Fix tests 1494651 11 sihui_liu 2019-01-15 08:54:18 -0800 (In reply to Sihui Liu from comment #10) > Created attachment 359112 [details] > Fix tests Patch cannot be tested after bug is closed... Fix in https://bugs.webkit.org/show_bug.cgi?id=193451 358915 2019-01-11 11:23:25 -0800 2019-01-11 17:00:21 -0800 Patch bug-193354-20190111112324.patch text/plain 1201 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUxMTk3ZWY1NGQ2NWE1MDQw ZGFiMDEwYTQ4ZmJhMzQwMjllYjMzYzQuLjA4Y2M4MDM0Zjg5NjRiNGY1MmNjODJlYjRhZDhlODdm M2VmZWRiYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEtMTEgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSAiRGlzYWJsZSBXZWIgU1FM IiBvbiBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTMzNTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ2NTI0NTg0PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYlBy ZWZlcmVuY2VzLnlhbWw6CisKIDIwMTktMDEtMDkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXBkYXRlIHNhbmRib3ggcHJvZmlsZSB0byB1c2Ug aWNvbnNlcnZpY2VzIGluc3RlYWQgb2YgbHNkaWNvbnNlcnZpY2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IDAwYThkZTgyNDg4YTE1YThkMDI5MzNjYzc2ZDJj NzBiYjk3MTZiYmMuLjFmODg3N2U5MTBmMGVjNzZlMjljYmVmY2E2MGVjNWQ2NTU2YzY0MzUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIv U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtMTM2Niw3ICsxMzY2 LDcgQEAgQ1NTVHlwZWRPTUVuYWJsZWQ6CiAKIFdlYlNRTERpc2FibGVkOgogICB0eXBlOiBib29s Ci0gIGRlZmF1bHRWYWx1ZTogZmFsc2UKKyAgZGVmYXVsdFZhbHVlOiB0cnVlCiAgIGh1bWFuUmVh ZGFibGVOYW1lOiAiRGlzYWJsZSBXZWIgU1FMIgogICBodW1hblJlYWRhYmxlRGVzY3JpcHRpb246 ICJEaXNhYmxlIFdlYiBTUUwiCiAgIHdlYmNvcmVCaW5kaW5nOiBSdW50aW1lRW5hYmxlZEZlYXR1 cmVzCg== 359112 2019-01-14 18:07:45 -0800 2019-01-15 08:50:28 -0800 Fix tests patch_fix_tests text/plain 1876 sihui_liu ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRHVwbGlj YXRlQ29tcGxldGlvbkhhbmRsZXJDYWxscy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvRHVwbGljYXRlQ29tcGxldGlvbkhhbmRsZXJDYWxscy5tbQppbmRleCBhYzcw ODJmYjg5Mi4uOTEyNjRmN2FkZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvRHVwbGljYXRlQ29tcGxldGlvbkhhbmRsZXJDYWxscy5tbQorKysgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0R1cGxpY2F0ZUNvbXBsZXRpb25I YW5kbGVyQ2FsbHMubW0KQEAgLTEyNiw2ICsxMjYsOSBAQCBAZW5kCiBURVNUKFdlYktpdCwgRHVw bGljYXRlQ29tcGxldGlvbkhhbmRsZXJDYWxscykKIHsKICAgICBhdXRvIHdlYlZpZXcgPSBhZG9w dE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgODAw LCA2MDApXSk7CisgICAgYXV0byBwcmVmZXJlbmNlcyA9IChfX2JyaWRnZSBXS1ByZWZlcmVuY2Vz UmVmKVtbd2ViVmlldyBjb25maWd1cmF0aW9uXSBwcmVmZXJlbmNlc107CisgICAgV0tQcmVmZXJl bmNlc1NldFdlYlNRTERpc2FibGVkKHByZWZlcmVuY2VzLCBmYWxzZSk7CisKICAgICBhdXRvIGRl bGVnYXRlID0gYWRvcHROUyhbW0R1cGxpY2F0ZUNvbXBsZXRpb25IYW5kbGVyQ2FsbHNEZWxlZ2F0 ZSBhbGxvY10gaW5pdF0pOwogICAgIFt3ZWJWaWV3IHNldE5hdmlnYXRpb25EZWxlZ2F0ZTpkZWxl Z2F0ZS5nZXQoKV07CiAgICAgW3dlYlZpZXcgc2V0VUlEZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQoKV07 CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYnNp dGVEYXRhU3RvcmVDdXN0b21QYXRocy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzLm1tCmluZGV4IDc2NGVkZjQ3YTMw Li4wMjBiNGYyNWZjMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9XZWJzaXRlRGF0YVN0b3JlQ3VzdG9tUGF0aHMubW0KKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0YVN0b3JlQ3VzdG9tUGF0aHMubW0K QEAgLTEyOCw2ICsxMjgsOSBAQCBzdGF0aWMgdm9pZCBydW5XZWJzaXRlRGF0YVN0b3JlQ3VzdG9t UGF0aHMoU2hvdWxkRW5hYmxlUHJvY2Vzc1ByZXdhcm1pbmcgc2hvdWxkRQogCiAgICAgUmV0YWlu UHRyPFdLV2ViVmlldz4gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRX aXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjpjb25maWd1 cmF0aW9uLmdldCgpXSk7CiAgICAgW3dlYlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRlOmhhbmRs ZXIuZ2V0KCldOworICAgIAorICAgIGF1dG8gcHJlZmVyZW5jZXMgPSAoX19icmlkZ2UgV0tQcmVm ZXJlbmNlc1JlZilbW3dlYlZpZXcgY29uZmlndXJhdGlvbl0gcHJlZmVyZW5jZXNdOworICAgIFdL UHJlZmVyZW5jZXNTZXRXZWJTUUxEaXNhYmxlZChwcmVmZXJlbmNlcywgZmFsc2UpOwogCiAgICAg TlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbW05T QnVuZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291cmNlOkAiV2Vic2l0ZURhdGFTdG9yZUN1c3Rv bVBhdGhzIiB3aXRoRXh0ZW5zaW9uOkAiaHRtbCIgc3ViZGlyZWN0b3J5OkAiVGVzdFdlYktpdEFQ SS5yZXNvdXJjZXMiXV07CiAgICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6cmVxdWVzdF07Cg==