193340 2019-01-10 14:44:59 -0800 Cleanup possible WK*Copy/Create leaks in WebKitTestRunner 2019-01-14 06:51:08 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue darin ddkilzer joepeck lforschler webkit-bug-importer oldest_to_newest 1493478 0 joepeck 2019-01-10 14:44:59 -0800 Cleanup possible WK*Copy/Create leaks in WebKitTestRunner Searching for lines with WK.*?Create / WK.*?Copy that don't use WKRetainPtr or improperly use it. 1493480 1 358838 joepeck 2019-01-10 14:46:43 -0800 Created attachment 358838 [PATCH] Proposed Fix 1493758 2 358838 ddkilzer 2019-01-11 12:54:06 -0800 Comment on attachment 358838 [PATCH] Proposed Fix r=me 1493765 3 358838 commit-queue 2019-01-11 13:04:15 -0800 Comment on attachment 358838 [PATCH] Proposed Fix Clearing flags on attachment: 358838 Committed r239871: <https://trac.webkit.org/changeset/239871> 1493766 4 commit-queue 2019-01-11 13:04:17 -0800 All reviewed patches have been landed. Closing bug. 1493770 5 webkit-bug-importer 2019-01-11 13:05:28 -0800 <rdar://problem/47217944> 1494134 6 358838 darin 2019-01-14 06:51:08 -0800 Comment on attachment 358838 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=358838&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:434 > + WKRetainPtr<WKStringRef> totalPrevalentResourcesKey(AdoptWK, WKStringCreateWithUTF8CString("TotalPrevalentResources")); > + WKRetainPtr<WKStringRef> totalPrevalentResourcesWithUserInteractionKey(AdoptWK, WKStringCreateWithUTF8CString("TotalPrevalentResourcesWithUserInteraction")); > + WKRetainPtr<WKStringRef> top3SubframeUnderTopFrameOriginsKey(AdoptWK, WKStringCreateWithUTF8CString("Top3SubframeUnderTopFrameOrigins")); Please use the adoptWK function, not the special AdoptWK constructor, in new code. We want to get rid of those special constructors some day. 358838 2019-01-10 14:46:43 -0800 2019-01-11 13:04:15 -0800 [PATCH] Proposed Fix wktr-1.patch text/plain 6041 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Nzhm ZTI1MjYxMS4uZWMwYzc1MjQyMjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxOS0wMS0xMCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIENsZWFudXAgcG9zc2libGUgV0sq Q29weS9DcmVhdGUgbGVha3MgaW4gV2ViS2l0VGVzdFJ1bm5lcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzQwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcDoKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRCdW5kbGU6 OmRpZFJlY2VpdmVNZXNzYWdlVG9QYWdlKToKKyAgICAgICAgUHVsbCB0aGUgc3RyaW5ncyBvdXQg aW50byBhIFdLUmV0YWluUHRyLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9XZWJOb3Rp ZmljYXRpb25Qcm92aWRlci5jcHA6CisgICAgICAgIChXVFI6OldlYk5vdGlmaWNhdGlvblByb3Zp ZGVyOjpjbG9zZVdlYk5vdGlmaWNhdGlvbik6CisgICAgICAgIEFkb3B0IHRoZSBjcmVhdGVkIHZh bHVlIGludG8gdGhlIFdLUmV0YWluUHRyLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9t YWMvVGVzdENvbnRyb2xsZXJNYWMubW06CisgICAgICAgIChXVFI6OmdlbmVyYXRlV2hpdGVsaXN0 KToKKyAgICAgICAgSW1tZWRpYXRlbHkgYWRvcHQgYSBjcmVhdGVkIHZhbHVlIHRvIGF2b2lkIHBv dGVudGlhbCBtaXN0YWtlcy4KKwogMjAxOS0wMS0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgogCiAgICAgICAgIExlYWsgb2YgV0tXZWJQcm9jZXNzUGx1Z0luSGl0VGVz dFJlc3VsdCAoMTYwIGJ5dGVzKSBpbiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgcnVubmlu ZyBsYXlvdXQgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0 ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKaW5kZXggMzUxZWUwNjZjYzQuLmU0MTVmOTA1 MTMwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0lu amVjdGVkQnVuZGxlLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0luamVjdGVkQnVuZGxlLmNwcApAQCAtNDI4LDExICs0MjgsMTUgQEAgdm9pZCBJbmplY3Rl ZEJ1bmRsZTo6ZGlkUmVjZWl2ZU1lc3NhZ2VUb1BhZ2UoV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIFdL U3RyaW5nUmVmIG0KIAogICAgIGlmIChXS1N0cmluZ0lzRXF1YWxUb1VURjhDU3RyaW5nKG1lc3Nh Z2VOYW1lLCAiUmVzb3VyY2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeUZpbmlzaGVkIikpIHsKICAg ICAgICAgV0tEaWN0aW9uYXJ5UmVmIG1lc3NhZ2VCb2R5RGljdGlvbmFyeSA9IHN0YXRpY19jYXN0 PFdLRGljdGlvbmFyeVJlZj4obWVzc2FnZUJvZHkpOwotICAgICAgICAKLSAgICAgICAgdW5zaWdu ZWQgdG90YWxQcmV2YWxlbnRSZXNvdXJjZXMgPSAodW5zaWduZWQpV0tVSW50NjRHZXRWYWx1ZShz dGF0aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNzYWdl Qm9keURpY3Rpb25hcnksIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJUb3RhbFByZXZh bGVudFJlc291cmNlcyIpKSkpOwotICAgICAgICB1bnNpZ25lZCB0b3RhbFByZXZhbGVudFJlc291 cmNlc1dpdGhVc2VySW50ZXJhY3Rpb24gPSAodW5zaWduZWQpV0tVSW50NjRHZXRWYWx1ZShzdGF0 aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNzYWdlQm9k eURpY3Rpb25hcnksIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJUb3RhbFByZXZhbGVu dFJlc291cmNlc1dpdGhVc2VySW50ZXJhY3Rpb24iKSkpKTsKLSAgICAgICAgdW5zaWduZWQgdG9w M1N1YmZyYW1lVW5kZXJUb3BGcmFtZU9yaWdpbnMgPSAodW5zaWduZWQpV0tVSW50NjRHZXRWYWx1 ZShzdGF0aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNz YWdlQm9keURpY3Rpb25hcnksIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJUb3AzU3Vi ZnJhbWVVbmRlclRvcEZyYW1lT3JpZ2lucyIpKSkpOwotICAgICAgICAKKworICAgICAgICBXS1Jl dGFpblB0cjxXS1N0cmluZ1JlZj4gdG90YWxQcmV2YWxlbnRSZXNvdXJjZXNLZXkoQWRvcHRXSywg V0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoIlRvdGFsUHJldmFsZW50UmVzb3VyY2VzIikp OworICAgICAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gdG90YWxQcmV2YWxlbnRSZXNvdXJj ZXNXaXRoVXNlckludGVyYWN0aW9uS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhD U3RyaW5nKCJUb3RhbFByZXZhbGVudFJlc291cmNlc1dpdGhVc2VySW50ZXJhY3Rpb24iKSk7Cisg ICAgICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB0b3AzU3ViZnJhbWVVbmRlclRvcEZyYW1l T3JpZ2luc0tleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiVG9wM1N1 YmZyYW1lVW5kZXJUb3BGcmFtZU9yaWdpbnMiKSk7CisKKyAgICAgICAgdW5zaWduZWQgdG90YWxQ cmV2YWxlbnRSZXNvdXJjZXMgPSAodW5zaWduZWQpV0tVSW50NjRHZXRWYWx1ZShzdGF0aWNfY2Fz dDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNzYWdlQm9keURpY3Rp b25hcnksIHRvdGFsUHJldmFsZW50UmVzb3VyY2VzS2V5LmdldCgpKSkpOworICAgICAgICB1bnNp Z25lZCB0b3RhbFByZXZhbGVudFJlc291cmNlc1dpdGhVc2VySW50ZXJhY3Rpb24gPSAodW5zaWdu ZWQpV0tVSW50NjRHZXRWYWx1ZShzdGF0aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5 R2V0SXRlbUZvcktleShtZXNzYWdlQm9keURpY3Rpb25hcnksIHRvdGFsUHJldmFsZW50UmVzb3Vy Y2VzV2l0aFVzZXJJbnRlcmFjdGlvbktleS5nZXQoKSkpKTsKKyAgICAgICAgdW5zaWduZWQgdG9w M1N1YmZyYW1lVW5kZXJUb3BGcmFtZU9yaWdpbnMgPSAodW5zaWduZWQpV0tVSW50NjRHZXRWYWx1 ZShzdGF0aWNfY2FzdDxXS1VJbnQ2NFJlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleShtZXNz YWdlQm9keURpY3Rpb25hcnksIHRvcDNTdWJmcmFtZVVuZGVyVG9wRnJhbWVPcmlnaW5zS2V5Lmdl dCgpKSkpOworCiAgICAgICAgIG1fdGVzdFJ1bm5lci0+c3RhdGlzdGljc0RpZFJ1blRlbGVtZXRy eUNhbGxiYWNrKHRvdGFsUHJldmFsZW50UmVzb3VyY2VzLCB0b3RhbFByZXZhbGVudFJlc291cmNl c1dpdGhVc2VySW50ZXJhY3Rpb24sIHRvcDNTdWJmcmFtZVVuZGVyVG9wRnJhbWVPcmlnaW5zKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvV2ViTm90aWZpY2F0aW9uUHJvdmlkZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9X ZWJOb3RpZmljYXRpb25Qcm92aWRlci5jcHAKaW5kZXggYjAwOWIzNmEzYWMuLmU0M2Y2NjJhN2E0 IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1dlYk5vdGlmaWNhdGlvblByb3Zp ZGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1dlYk5vdGlmaWNhdGlvblByb3Zp ZGVyLmNwcApAQCAtMTI2LDcgKzEyNiw3IEBAIHZvaWQgV2ViTm90aWZpY2F0aW9uUHJvdmlkZXI6 OmNsb3NlV2ViTm90aWZpY2F0aW9uKFdLTm90aWZpY2F0aW9uUmVmIG5vdGlmaWNhdGlvCiAKICAg ICByZW1vdmVHbG9iYWxJREZyb21JRE1hcChtX2xvY2FsVG9HbG9iYWxOb3RpZmljYXRpb25JRE1h cCwgaWQpOwogCi0gICAgV0tSZXRhaW5QdHI8V0tVSW50NjRSZWY+IHdrSUQgPSBXS1VJbnQ2NENy ZWF0ZShpZCk7CisgICAgV0tSZXRhaW5QdHI8V0tVSW50NjRSZWY+IHdrSUQoQWRvcHRXSywgV0tV SW50NjRDcmVhdGUoaWQpKTsKICAgICBXS1JldGFpblB0cjxXS011dGFibGVBcnJheVJlZj4gYXJy YXkoQWRvcHRXSywgV0tNdXRhYmxlQXJyYXlDcmVhdGUoKSk7CiAgICAgV0tBcnJheUFwcGVuZEl0 ZW0oYXJyYXkuZ2V0KCksIHdrSUQuZ2V0KCkpOwogICAgIFdLTm90aWZpY2F0aW9uTWFuYWdlclBy b3ZpZGVyRGlkQ2xvc2VOb3RpZmljYXRpb25zKG5vdGlmaWNhdGlvbk1hbmFnZXIsIGFycmF5Lmdl dCgpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1Rlc3RDb250cm9s bGVyTWFjLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVzdENvbnRyb2xsZXJNYWMu bW0KaW5kZXggZDU3NTAxMGFiOGIuLjU4M2VlZDRmMTk2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL21hYy9UZXN0Q29udHJvbGxlck1hYy5tbQorKysgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL21hYy9UZXN0Q29udHJvbGxlck1hYy5tbQpAQCAtMjkzLDIyICsyOTMsMjIgQEAg c3RhdGljIE5TU2V0ICpzeXN0ZW1IaWRkZW5Gb250RmFtaWx5U2V0KCkKIAogc3RhdGljIFdLUmV0 YWluUHRyPFdLQXJyYXlSZWY+IGdlbmVyYXRlV2hpdGVsaXN0KCkKIHsKLSAgICBXS011dGFibGVB cnJheVJlZiByZXN1bHQgPSBXS011dGFibGVBcnJheUNyZWF0ZSgpOworICAgIFdLUmV0YWluUHRy PFdLTXV0YWJsZUFycmF5UmVmPiByZXN1bHQgPSBhZG9wdFdLKFdLTXV0YWJsZUFycmF5Q3JlYXRl KCkpOwogICAgIGZvciAoTlNTdHJpbmcgKmZvbnRGYW1pbHkgaW4gYWxsb3dlZEZvbnRGYW1pbHlT ZXQoKSkgewogICAgICAgICBOU0FycmF5ICpmb250c0ZvckZhbWlseSA9IFtbTlNGb250TWFuYWdl ciBzaGFyZWRGb250TWFuYWdlcl0gYXZhaWxhYmxlTWVtYmVyc09mRm9udEZhbWlseTpmb250RmFt aWx5XTsKICAgICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGZhbWlseUluRm9udCA9IGFk b3B0V0soV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoW2ZvbnRGYW1pbHkgVVRGOFN0cmlu Z10pKTsKLSAgICAgICAgV0tBcnJheUFwcGVuZEl0ZW0ocmVzdWx0LCBmYW1pbHlJbkZvbnQuZ2V0 KCkpOworICAgICAgICBXS0FycmF5QXBwZW5kSXRlbShyZXN1bHQuZ2V0KCksIGZhbWlseUluRm9u dC5nZXQoKSk7CiAgICAgICAgIGZvciAoTlNBcnJheSAqZm9udEluZm8gaW4gZm9udHNGb3JGYW1p bHkpIHsKICAgICAgICAgICAgIC8vIEZvbnQgbmFtZSBpcyB0aGUgZmlyc3QgZW50cnkgaW4gdGhl IGFycmF5LgogICAgICAgICAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGZvbnROYW1lID0g YWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhbW2ZvbnRJbmZvIG9iamVjdEF0 SW5kZXg6MF0gVVRGOFN0cmluZ10pKTsKLSAgICAgICAgICAgIFdLQXJyYXlBcHBlbmRJdGVtKHJl c3VsdCwgZm9udE5hbWUuZ2V0KCkpOworICAgICAgICAgICAgV0tBcnJheUFwcGVuZEl0ZW0ocmVz dWx0LmdldCgpLCBmb250TmFtZS5nZXQoKSk7CiAgICAgICAgIH0KICAgICB9CiAKICAgICBmb3Ig KE5TU3RyaW5nICpoaWRkZW5Gb250RmFtaWx5IGluIHN5c3RlbUhpZGRlbkZvbnRGYW1pbHlTZXQo KSkKLSAgICAgICAgV0tBcnJheUFwcGVuZEl0ZW0ocmVzdWx0LCBhZG9wdFdLKFdLU3RyaW5nQ3Jl YXRlV2l0aFVURjhDU3RyaW5nKFtoaWRkZW5Gb250RmFtaWx5IFVURjhTdHJpbmddKSkuZ2V0KCkp OworICAgICAgICBXS0FycmF5QXBwZW5kSXRlbShyZXN1bHQuZ2V0KCksIGFkb3B0V0soV0tTdHJp bmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoW2hpZGRlbkZvbnRGYW1pbHkgVVRGOFN0cmluZ10pKS5n ZXQoKSk7CiAKLSAgICByZXR1cm4gYWRvcHRXSyhyZXN1bHQpOworICAgIHJldHVybiByZXN1bHQ7 CiB9CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtSW5pdGlhbGl6ZUNvbnRleHQoKQo=