193332 2019-01-10 12:46:18 -0800 [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t 2019-02-05 08:03:43 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193101 P2 Normal --- 1 cturner cturner bugs-noreply commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1493399 0 cturner 2019-01-10 12:46:18 -0800 [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t 1493403 1 358821 cturner 2019-01-10 12:51:45 -0800 Created attachment 358821 Patch Temporary fix for bad template deducation when ICU switched to the UChar=char16_t typedef. With this definition, the specliazation for Signed && Integral wins over the typedef for UChar 1493901 2 358821 mcatanzaro 2019-01-11 17:07:56 -0800 Comment on attachment 358821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358821&action=review > Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:88 > -#if PLATFORM(WIN) > +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59 > EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world")); > #else > EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world")); // Treated as a character. I wonder how many bugs this behavior difference is causing. This is really unfortunate. :/ I almost gave this r-, but the new version is better and the old approach will be obsoleted eventually. Can we remove the #if PLATFORM(WIN), though? Surely that is there because they were using newer ICU? 1494049 3 cturner 2019-01-13 15:08:42 -0800 (In reply to Michael Catanzaro from comment #2) > I almost gave this r-, but the new version is better and the old approach > will be obsoleted eventually. Can we remove the #if PLATFORM(WIN), though? > Surely that is there because they were using newer ICU? IIUC, Windows hits the problem for a different reason, not sure if they use ICU, but on that platform UChar=wchar_t rather than unsigned short as assumed in this test. 1494053 4 mcatanzaro 2019-01-13 15:35:50 -0800 Let's continue discussion of how to fix the footgun here in bug #193101. 1494095 5 359023 cturner 2019-01-14 02:20:56 -0800 Created attachment 359023 Patch for landing 1494100 6 359023 commit-queue 2019-01-14 02:59:12 -0800 Comment on attachment 359023 Patch for landing Clearing flags on attachment: 359023 Committed r239920: <https://trac.webkit.org/changeset/239920> 1494101 7 commit-queue 2019-01-14 02:59:13 -0800 All reviewed patches have been landed. Closing bug. 358821 2019-01-10 12:51:45 -0800 2019-01-14 02:20:52 -0800 Patch bug-193332-20190110205144.patch text/plain 2240 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5ODE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjkxYjI3NmM3ZTQ1OGI3NThlYWU3MmJhOTg3MjFhYTEw Njc3MDcxMS4uZGFkZGJhMzlkMzVmYTc4NTYzYjdhOGNiM2QzMzA5YWRlNTk2MjEwNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTAxLTEwICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV1BFXSBXb3JrYXJvdW5kIGZvciBpbmNvcnJlY3QgdGVtcGxhdGUgc3BlY2lhbGl6 YXRpb24gYmVpbmcgc2VsZWN0ZWQgd2hlbiBVQ2hhcj1jaGFyMTZfdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9TdHJpbmdDb25jYXRlbmF0ZS5jcHA6IFdoZW4gVUNoYXIgaXMKKyAgICAgICAgZGVmaW5lZCBh cyBhIGNoYXIxNl90LCB3aGljaCBjaGFuZ2VkIGluIElDVSA1OSwgdGhlCisgICAgICAgIFN0cmlu Z1R5cGVBZGFwdGVyPFVuc2lnbmVkSW50LCAuLi4+IG92ZXJsb2FkIGNhdGNoZXMgY2FzdHMgdG8K KyAgICAgICAgdW5zaWduZWQgc2hvcnQuIFRoaXMgdGVzdCBpcyByZWx5aW5nIG9uIHRoZSBiZWhh dmlvdXIgdGhhdAorICAgICAgICBVQ2hhcj11bnNpZ25lZCBzaG9ydCwgd2hpY2ggZG9lc24ndCBo b2xkIGFjcm9zcyBwbGF0Zm9ybXMgYW5kIElDVQorICAgICAgICBsaWJyYXJ5IHZlcnNpb25zLiBU aGUgZnVsbCBmaXggd291bGQgYmUgYSBzcGVjaWFsIHN5bnRheCBmb3IKKyAgICAgICAgbGl0ZXJh bCBjaGFyYWN0ZXJzIHNvIHRoYXQgdGhlc2UgYW1iaWd1aXRpZXMgZG8gbm90IGFyaXNlLiBUaGF0 CisgICAgICAgIHdvcmsgaXMgcHJvcG9zZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MzEwMS4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAy MDE5LTAxLTA5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAg ICAgICAgIFtXaW5dW01pbmlCcm93c2VyXSB3Y2hhcl90IHN0cmluZ3Mgc2hvdWxkbid0IGJlIHRy ZWF0ZWQgYXMgQlNUUgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv U3RyaW5nQ29uY2F0ZW5hdGUuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3Ry aW5nQ29uY2F0ZW5hdGUuY3BwCmluZGV4IDM4OGIzMGUzMDg2ZmMzZTFhNThiOWRjMWY5YTI0NDk0 ZTdhYWE1ZGQuLmVlNzAwNGE0ZjU5NzljOTg5MWQ0ZWRlZDk3MzQ1ZGNlMGM0MjAzM2QgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1N0cmluZ0NvbmNhdGVuYXRlLmNw cAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdDb25jYXRlbmF0ZS5j cHAKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0 ZU51bWJlcnMuaD4KICNpbmNsdWRlIDxjc3RkZGVmPgogI2luY2x1ZGUgPGNzdGRpbnQ+CisjaW5j bHVkZSA8dW5pY29kZS91dmVybnVtLmg+CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIApA QCAtODEsNyArODIsNyBAQCBURVNUKFdURiwgU3RyaW5nQ29uY2F0ZW5hdGVfVW5zaWduZWQpCiAg ICAgRVhQRUNUX0VRKCJoZWxsbyAwIHdvcmxkIiwgbWFrZVN0cmluZygiaGVsbG8gIiwgMHUgLCAi IHdvcmxkIikpOwogCiAgICAgRVhQRUNUX0VRKCJoZWxsbyA0MiB3b3JsZCIsIG1ha2VTdHJpbmco ImhlbGxvICIsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGNoYXI+KDQyKSAsICIgd29ybGQiKSk7Ci0j aWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJTikgfHwgVV9JQ1VfVkVSU0lPTl9NQUpP Ul9OVU0gPj0gNTkKICAgICBFWFBFQ1RfRVEoImhlbGxvIDQyIHdvcmxkIiwgbWFrZVN0cmluZygi aGVsbG8gIiwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgc2hvcnQ+KDQyKSAsICIgd29ybGQiKSk7CiAj ZWxzZQogICAgIEVYUEVDVF9FUSgiaGVsbG8gKiB3b3JsZCIsIG1ha2VTdHJpbmcoImhlbGxvICIs IHN0YXRpY19jYXN0PHVuc2lnbmVkIHNob3J0Pig0MikgLCAiIHdvcmxkIikpOyAvLyBUcmVhdGVk IGFzIGEgY2hhcmFjdGVyLgo= 359023 2019-01-14 02:20:56 -0800 2019-01-14 02:59:12 -0800 Patch for landing bug-193332-20190114102055.patch text/plain 2253 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTEyYmZmYTY5YTY1ZjFmNTgzNzM0Mjg5Y2M3NWQzZTM0 OTFmYTRhMy4uMjJlNTUxNmY0YjFiNWY1MjdkOWFmOTRiZTBhNDc5Yjk5NGQ0OTM3ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTAxLTE0ICBDaGFybGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV1BFXSBXb3JrYXJvdW5kIGZvciBpbmNvcnJlY3QgdGVtcGxhdGUgc3BlY2lhbGl6 YXRpb24gYmVpbmcgc2VsZWN0ZWQgd2hlbiBVQ2hhcj1jaGFyMTZfdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTWljaGFlbCBDYXRhbnphcm8uCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9TdHJpbmdDb25jYXRlbmF0ZS5jcHA6IFdoZW4gVUNoYXIgaXMKKyAgICAgICAgZGVmaW5l ZCBhcyBhIGNoYXIxNl90LCB3aGljaCBjaGFuZ2VkIGluIElDVSA1OSwgdGhlCisgICAgICAgIFN0 cmluZ1R5cGVBZGFwdGVyPFVuc2lnbmVkSW50LCAuLi4+IG92ZXJsb2FkIGNhdGNoZXMgY2FzdHMg dG8KKyAgICAgICAgdW5zaWduZWQgc2hvcnQuIFRoaXMgdGVzdCBpcyByZWx5aW5nIG9uIHRoZSBi ZWhhdmlvdXIgdGhhdAorICAgICAgICBVQ2hhcj11bnNpZ25lZCBzaG9ydCwgd2hpY2ggZG9lc24n dCBob2xkIGFjcm9zcyBwbGF0Zm9ybXMgYW5kIElDVQorICAgICAgICBsaWJyYXJ5IHZlcnNpb25z LiBUaGUgZnVsbCBmaXggd291bGQgYmUgYSBzcGVjaWFsIHN5bnRheCBmb3IKKyAgICAgICAgbGl0 ZXJhbCBjaGFyYWN0ZXJzIHNvIHRoYXQgdGhlc2UgYW1iaWd1aXRpZXMgZG8gbm90IGFyaXNlLiBU aGF0CisgICAgICAgIHdvcmsgaXMgcHJvcG9zZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MzEwMS4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgor CiAyMDE5LTAxLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLiBbR1RLXVtXUEVdIFJ1biBkaXN0Y2hlY2sgd2l0aCBndGtk b2MgYW5kIE1pbmlCcm93c2VyIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV1RGL1N0cmluZ0NvbmNhdGVuYXRlLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL1N0cmluZ0NvbmNhdGVuYXRlLmNwcAppbmRleCAzODhiMzBlMzA4NmZjM2UxYTU4 YjlkYzFmOWEyNDQ5NGU3YWFhNWRkLi5lZTcwMDRhNGY1OTc5Yzk4OTFkNGVkZWQ5NzM0NWRjZTBj NDIwMzNkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdD b25jYXRlbmF0ZS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3RyaW5n Q29uY2F0ZW5hdGUuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSA8d3RmL3RleHQvU3Ry aW5nQ29uY2F0ZW5hdGVOdW1iZXJzLmg+CiAjaW5jbHVkZSA8Y3N0ZGRlZj4KICNpbmNsdWRlIDxj c3RkaW50PgorI2luY2x1ZGUgPHVuaWNvZGUvdXZlcm51bS5oPgogCiBuYW1lc3BhY2UgVGVzdFdl YktpdEFQSSB7CiAKQEAgLTgxLDcgKzgyLDcgQEAgVEVTVChXVEYsIFN0cmluZ0NvbmNhdGVuYXRl X1Vuc2lnbmVkKQogICAgIEVYUEVDVF9FUSgiaGVsbG8gMCB3b3JsZCIsIG1ha2VTdHJpbmcoImhl bGxvICIsIDB1ICwgIiB3b3JsZCIpKTsKIAogICAgIEVYUEVDVF9FUSgiaGVsbG8gNDIgd29ybGQi LCBtYWtlU3RyaW5nKCJoZWxsbyAiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPig0MikgLCAi IHdvcmxkIikpOwotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU4pIHx8IFVfSUNV X1ZFUlNJT05fTUFKT1JfTlVNID49IDU5CiAgICAgRVhQRUNUX0VRKCJoZWxsbyA0MiB3b3JsZCIs IG1ha2VTdHJpbmcoImhlbGxvICIsIHN0YXRpY19jYXN0PHVuc2lnbmVkIHNob3J0Pig0MikgLCAi IHdvcmxkIikpOwogI2Vsc2UKICAgICBFWFBFQ1RfRVEoImhlbGxvICogd29ybGQiLCBtYWtlU3Ry aW5nKCJoZWxsbyAiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBzaG9ydD4oNDIpICwgIiB3b3JsZCIp KTsgLy8gVHJlYXRlZCBhcyBhIGNoYXJhY3Rlci4K