193324 2019-01-10 09:44:22 -0800 [macOS] Add name of IORegistry key in sandbox. 2019-01-10 10:49:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue jer.noble webkit-bug-importer oldest_to_newest 1493327 0 pvollan 2019-01-10 09:44:22 -0800 IOGVAVTCapabilities key has been changed to IOGVAHEVCDecodeCapabilities. 1493328 1 bfulgham 2019-01-10 09:47:09 -0800 We should allow both to support new WebKit on older OS. 1493330 2 358801 pvollan 2019-01-10 09:48:48 -0800 Created attachment 358801 Patch 1493335 3 358801 bfulgham 2019-01-10 10:02:21 -0800 Comment on attachment 358801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358801&action=review I don't think this is right. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") This will cause this to break if someone runs STP on an older OS.. I think this should be: (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabilities)") 1493336 4 358802 pvollan 2019-01-10 10:04:18 -0800 Created attachment 358802 Patch 1493338 5 pvollan 2019-01-10 10:05:29 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 358801 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358801&action=review > > I don't think this is right. > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251 > > + (iokit-property-regex #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)") > > This will cause this to break if someone runs STP on an older OS.. > > I think this should be: > > (iokit-property-regex > #"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapa > bilities)") Ah, right! I have updated the patch. Thanks for reviewing! 1493340 6 358802 bfulgham 2019-01-10 10:08:53 -0800 Comment on attachment 358802 Patch Looks good! 1493354 7 358802 commit-queue 2019-01-10 10:47:50 -0800 Comment on attachment 358802 Patch Clearing flags on attachment: 358802 Committed r239834: <https://trac.webkit.org/changeset/239834> 1493355 8 commit-queue 2019-01-10 10:47:51 -0800 All reviewed patches have been landed. Closing bug. 1493356 9 webkit-bug-importer 2019-01-10 10:49:29 -0800 <rdar://problem/47182898> 358801 2019-01-10 09:48:48 -0800 2019-01-10 10:04:16 -0800 Patch bug-193324-20190110094847.patch text/plain 1465 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk4MzEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAxLTEwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENoYW5nZSBuYW1l IG9mIElPUmVnaXN0cnkga2V5IGluIHNhbmRib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMzMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJT0dWQVZUQ2FwYWJpbGl0aWVzIGtleSBoYXMgYmVlbiBj aGFuZ2VkIHRvIElPR1ZBSEVWQ0RlY29kZUNhcGFiaWxpdGllcy4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTktMDEtMDkgIE1hdHQgUmFq Y2EgIDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFB1dCBwZXItZG9jdW1lbnQgYXV0b3Bs YXkgYmVoYXZpb3IgYmVoaW5kIHJ1bnRpbWUgd2Vic2l0ZSBwb2xpY2llcyBxdWlyayBpbnN0ZWFk IG9mIGEgY29tcGlsZSB0aW1lIGZsYWcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9j b20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDIzOTY4MykKKysr IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29y a2luZyBjb3B5KQpAQCAtMjQ4LDcgKzI0OCw3IEBACiAgICAgKGlva2l0LXByb3BlcnR5ICJJT0Zy YW1lYnVmZmVyT3BlbkdMSW5kZXgiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9HZW5lcmFsSW50 ZXJlc3QiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9HTEJ1bmRsZU5hbWUiKQotICAgIChpb2tp dC1wcm9wZXJ0eS1yZWdleCAjIl5JT0dWQShCR1JBRW5jfENvZGVjfEVuY29kZXJSZXN0cmljdGVk fFNjYWxlcnxWVENhcGFiaWxpdGllcykiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5J T0dWQShCR1JBRW5jfENvZGVjfEVuY29kZXJSZXN0cmljdGVkfFNjYWxlcnxIRVZDRGVjb2RlQ2Fw YWJpbGl0aWVzKSIpCiAgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklPR1ZBKC4qKShEZXxF biljb2RlJCIpCiAgICAgKGlva2l0LXByb3BlcnR5ICJJT0hpYmVybmF0ZVN0YXRlIikKICAgICAo aW9raXQtcHJvcGVydHkgIklPSTJDVHJhbnNhY3Rpb25UeXBlcyIpCg== 358802 2019-01-10 10:04:18 -0800 2019-01-10 10:47:50 -0800 Patch bug-193324-20190110100417.patch text/plain 1477 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk4MzEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAxLTEwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIEFkZCBuYW1lIG9m IElPUmVnaXN0cnkga2V5IGluIHNhbmRib3guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMzMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJT0dWQVZUQ2FwYWJpbGl0aWVzIGtleSBoYXMgYmVlbiBjaGFu Z2VkIHRvIElPR1ZBSEVWQ0RlY29kZUNhcGFiaWxpdGllcy4KKworICAgICAgICAqIFdlYlByb2Nl c3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMTktMDEtMDkgIE1hdHQgUmFqY2Eg IDxtcmFqY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFB1dCBwZXItZG9jdW1lbnQgYXV0b3BsYXkg YmVoYXZpb3IgYmVoaW5kIHJ1bnRpbWUgd2Vic2l0ZSBwb2xpY2llcyBxdWlyayBpbnN0ZWFkIG9m IGEgY29tcGlsZSB0aW1lIGZsYWcKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20u YXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9uIDIzOTY4MykKKysrIFNv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkod29ya2lu ZyBjb3B5KQpAQCAtMjQ4LDcgKzI0OCw3IEBACiAgICAgKGlva2l0LXByb3BlcnR5ICJJT0ZyYW1l YnVmZmVyT3BlbkdMSW5kZXgiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9HZW5lcmFsSW50ZXJl c3QiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiSU9HTEJ1bmRsZU5hbWUiKQotICAgIChpb2tpdC1w cm9wZXJ0eS1yZWdleCAjIl5JT0dWQShCR1JBRW5jfENvZGVjfEVuY29kZXJSZXN0cmljdGVkfFNj YWxlcnxWVENhcGFiaWxpdGllcykiKQorICAgIChpb2tpdC1wcm9wZXJ0eS1yZWdleCAjIl5JT0dW QShCR1JBRW5jfENvZGVjfEVuY29kZXJSZXN0cmljdGVkfFNjYWxlcnxWVENhcGFiaWxpdGllc3xI RVZDRGVjb2RlQ2FwYWJpbGl0aWVzKSIpCiAgICAgKGlva2l0LXByb3BlcnR5LXJlZ2V4ICMiXklP R1ZBKC4qKShEZXxFbiljb2RlJCIpCiAgICAgKGlva2l0LXByb3BlcnR5ICJJT0hpYmVybmF0ZVN0 YXRlIikKICAgICAoaW9raXQtcHJvcGVydHkgIklPSTJDVHJhbnNhY3Rpb25UeXBlcyIpCg==