193320 2019-01-10 07:26:39 -0800 [GTK] Several resourceLoadStatistics tests are failing since r239816 "Create a WebResourceLoadStatisticsStore attached to the NetworkSession" 2019-01-22 13:36:38 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez webkit-unassigned bfulgham bugs-noreply mcatanzaro pgriffis oldest_to_newest 1493288 0 magomez 2019-01-10 07:26:39 -0800 There are 14 failing. Here they are with their diffs: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-redirect-collusion-actual.txt @@ -7,7 +7,6 @@ PASS Colluding host 2 got set as prevalent resource. PASS Colluding host 3 got set as prevalent resource. PASS Colluding host 4 got set as prevalent resource. -PASS Colluding localhost got set as prevalent resource after actual sub frame redirect. PASS successfullyParsed is true TEST COMPLETE http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion-actual.txt @@ -7,7 +7,6 @@ PASS Colluding host 2 got set as prevalent resource. PASS Colluding host 3 got set as prevalent resource. PASS Colluding host 4 got set as prevalent resource. -PASS Colluding localhost got set as prevalent resource after actual navigational redirect. PASS successfullyParsed is true TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html [ Failure ] --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-actual.txt @@ -3,10 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") is true -PASS testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") is true +FAIL testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://localhost", "http://127.0.0.1") should be true. Was false. +FAIL testRunner.isStatisticsRegisteredAsRedirectingTo("http://127.0.0.1", "http://localhost") should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1493312 1 bfulgham 2019-01-10 08:49:23 -0800 My guess is that I broke it with this change: Index: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp =================================================================== --- a/trunk/Source/WebKit/UIProcess/WebPageProxy.cpp +++ b/trunk/Source/WebKit/UIProcess/WebPageProxy.cpp @@ -4452,6 +4448,9 @@ WebFrameProxy* originatingFrame = m_process->webFrame(originatingFrameInfoData.frameID); +#if ENABLE(RESOURCE_LOAD_STATISTICS) if (auto* resourceLoadStatisticsStore = websiteDataStore().resourceLoadStatistics()) resourceLoadStatisticsStore->logFrameNavigation(frame, URL(URL(), m_pageLoadState.url()), request, redirectResponse.url()); + logFrameNavigation(frame, URL(URL(), m_pageLoadState.url()), request, redirectResponse.url()); +#endif if (m_policyClient) @@ -4475,4 +4474,36 @@ m_shouldSuppressAppLinksInNextNavigationPolicyDecision = false; } I was a little confused with this code on GTK/WPE, since the feature defines for non-Apple builds seems to have it off: WebKitFeatures.cmake: WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource load statistics support" PRIVATE OFF) So, I moved the websiteDataStore().resourceLoadStatistics() access inside a macro, since that stuff shouldn't exist if the build flag is turned off. GTK (and probably others) seem to be building a weird half on/half off version of the feature. I think GTK either needs to turn the feature flag on, or disable the tests. As a quick fix, you could just remove the "#if ENABLE(RESOURCE_LOAD_STATISTICS)" I added in WebPageProxy.cpp. 1496916 2 mcatanzaro 2019-01-22 12:58:39 -0800 (In reply to Brent Fulgham from comment #1) > I was a little confused with this code on GTK/WPE, since the feature defines > for non-Apple builds seems to have it off: > > WebKitFeatures.cmake: > WEBKIT_OPTION_DEFINE(ENABLE_RESOURCE_LOAD_STATISTICS "Toggle resource load > statistics support" PRIVATE OFF) Yes, we're working on turning it on for WPE and GTK, but not there yet. > So, I moved the websiteDataStore().resourceLoadStatistics() access inside a > macro, since that stuff shouldn't exist if the build flag is turned off. GTK > (and probably others) seem to be building a weird half on/half off version > of the feature. Well we build with it OFF, as you see. If the code doesn't respect the flag, I'd say that's a bug. Seems almost all the tests passed for a long time even though it's turned OFF, which is surprising. > I think GTK either needs to turn the feature flag on, or disable the tests. > > As a quick fix, you could just remove the "#if > ENABLE(RESOURCE_LOAD_STATISTICS)" I added in WebPageProxy.cpp. I think I'm just going to skip the tests. 1496920 3 bfulgham 2019-01-22 13:00:22 -0800 (In reply to Michael Catanzaro from comment #2) > > As a quick fix, you could just remove the "#if > > ENABLE(RESOURCE_LOAD_STATISTICS)" I added in WebPageProxy.cpp. > > I think I'm just going to skip the tests. That sounds reasonable. These tests make no sense if the feature is off. 1496946 4 mcatanzaro 2019-01-22 13:36:38 -0800 Skipped in r240293.