193310 2019-01-09 20:38:09 -0800 [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position 2019-01-10 07:43:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1493210 0 zalan 2019-01-09 20:38:09 -0800 ssia 1493216 1 358779 zalan 2019-01-09 21:22:48 -0800 Created attachment 358779 Patch 1493293 2 358779 commit-queue 2019-01-10 07:42:25 -0800 Comment on attachment 358779 Patch Clearing flags on attachment: 358779 Committed r239827: <https://trac.webkit.org/changeset/239827> 1493294 3 commit-queue 2019-01-10 07:42:27 -0800 All reviewed patches have been landed. Closing bug. 1493296 4 webkit-bug-importer 2019-01-10 07:43:28 -0800 <rdar://problem/47177901> 358779 2019-01-09 21:22:48 -0800 2019-01-10 07:42:25 -0800 Patch bug-193310-20190109212237.patch text/plain 6812 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMzOTRkNzAxZjI1MzE1 ODJiY2IyZGRjMmE2ZDA4N2Q3YjEwYjU5Ni4uZjc3N2U0NTY5N2Q1M2EwZThmNjc2YjJlMGYxMzRj NDg2NTE1Mjk2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAxLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5D b2xsYXBzaW5nXSBUYWtlIGNvbGxhcHNlZCB0aHJvdWdoIHNpYmxpbmdzIGludG8gYWNjb3VudCB3 aGVuIGNvbXB1dGluZyB2ZXJ0aWNhbCBwb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIGJsb2NrIGluZmxvdyBlbGVtZW50IGhhcyBw cmV2aW91cyBzaWJsaW5ncyB3aXRoIGNvbGxhcHNlZCB0aHJvdWdoIHZlcnRpY2FsIG1hcmdpbnMs CisgICAgICAgIHRoZW4gdGhpcyBib3gncyBiZWZvcmUgbWFyZ2luIGNvdWxkIF9pbmRpcmVjdGx5 XyBjb2xsYXBzZSB3aXRoIHRoZSBwYXJlbnQuIFVzZSB0aGUgcHJldmlvdXMgc2libGluZ3MKKyAg ICAgICAgdG8gY2hlY2sgZm9yIG1hcmdpbiBjb2xsYXBzaW5nLgorCisgICAgICAgIFRlc3Q6IGZh c3QvYmxvY2svYmxvY2stb25seS9jb2xsYXBzZWQtdGhyb3VnaC1zaWJsaW5ncy5odG1sCisKKyAg ICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjphZGp1 c3RlZFZlcnRpY2FsUG9zaXRpb25BZnRlck1hcmdpbkNvbGxhcHNpbmcgY29uc3QpOgorICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3TGF5b3V0Q29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjps YXlvdXRVc2luZ0Zvcm1hdHRpbmdDb250ZXh0KToKKwogMjAxOS0wMS0wOSAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0JGQ11bTWFyZ2luQ29sbGFwc2lu Z10gQWRkIHN1cHBvcnQgZm9yIHBlY3VsaWFyIGNhc2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29u dGV4dC5jcHAKaW5kZXggYjI0ZGU5ZjY4Mzg3ZTZmODNmZDMwMjA2M2U3NmNkMDhmNjA3ZTMxMi4u ZWNkOGY4NzQzN2I0ODA0ZTllNDA3ZGJmZGRlMWIxOWJjMTZlNWQ4ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9y bWF0dGluZ0NvbnRleHQuY3BwCkBAIC00NzcsOCArNDc3LDEzIEBAIExheW91dFVuaXQgQmxvY2tG b3JtYXR0aW5nQ29udGV4dDo6YWRqdXN0ZWRWZXJ0aWNhbFBvc2l0aW9uQWZ0ZXJNYXJnaW5Db2xs YXBzaW5nCiAgICAgICAgIGN1cnJlbnRMYXlvdXRCb3ggPSAmcHJldmlvdXNJbkZsb3dTaWJsaW5n OwogICAgIH0KIAotICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrQ29udGVudEJveFRvcCA9IGxheW91 dFN0YXRlLmRpc3BsYXlCb3hGb3JMYXlvdXRCb3goKmxheW91dEJveC5jb250YWluaW5nQmxvY2so KSkuY29udGVudEJveFRvcCgpOwotICAgIGlmIChNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQmVmb3Jl Q29sbGFwc2VzV2l0aFBhcmVudE1hcmdpbkJlZm9yZShsYXlvdXRTdGF0ZSwgbGF5b3V0Qm94KSB8 fCBNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQmVmb3JlQ29sbGFwc2VzV2l0aFBhcmVudE1hcmdpbkFm dGVyKGxheW91dFN0YXRlLCBsYXlvdXRCb3gpKQorICAgIGF1dG8mIGNvbnRhaW5pbmdCbG9jayA9 ICpsYXlvdXRCb3guY29udGFpbmluZ0Jsb2NrKCk7CisgICAgYXV0byBjb250YWluaW5nQmxvY2tD b250ZW50Qm94VG9wID0gbGF5b3V0U3RhdGUuZGlzcGxheUJveEZvckxheW91dEJveChjb250YWlu aW5nQmxvY2spLmNvbnRlbnRCb3hUb3AoKTsKKyAgICAvLyBJZiB3ZSByZWFjaGVkIHRoZSBwYXJl bnQgdGhyb3VnaCBjb2xsYXBzZWQgc2libGluZyhzKSwgdGhpcyBib3ggKG1heSkgY29sbGFwc2Vz IHRoZSBiZWZvcmUgbWFyZ2luIGluZGlyZWN0bHkgd2l0aCB0aGUgcGFyZW50LiAgCisgICAgYXV0 byogY29sbGFwc2luZ0NhbmRpZGF0ZSA9IGxheW91dEJveC5wcmV2aW91c0luRmxvd1NpYmxpbmco KSA/IGNvbnRhaW5pbmdCbG9jay5maXJzdEluRmxvd0NoaWxkKCkgOiAmbGF5b3V0Qm94OworICAg IGF1dG8gbWFyZ2luQmVmb3JlQ29sbGFwc2VzV2l0aFBhcmVudCA9IE1hcmdpbkNvbGxhcHNlOjpt YXJnaW5CZWZvcmVDb2xsYXBzZXNXaXRoUGFyZW50TWFyZ2luQmVmb3JlKGxheW91dFN0YXRlLCAq Y29sbGFwc2luZ0NhbmRpZGF0ZSkgCisgICAgICAgIHx8IE1hcmdpbkNvbGxhcHNlOjptYXJnaW5C ZWZvcmVDb2xsYXBzZXNXaXRoUGFyZW50TWFyZ2luQWZ0ZXIobGF5b3V0U3RhdGUsICpjb2xsYXBz aW5nQ2FuZGlkYXRlKTsKKyAgICBpZiAobWFyZ2luQmVmb3JlQ29sbGFwc2VzV2l0aFBhcmVudCkK ICAgICAgICAgcmV0dXJuIGNvbnRhaW5pbmdCbG9ja0NvbnRlbnRCb3hUb3A7CiAKICAgICByZXR1 cm4gY29udGFpbmluZ0Jsb2NrQ29udGVudEJveFRvcCArIG1hcmdpbkJlZm9yZTsKZGlmZiAtLWdp dCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNDliZmExODc4MzYy NzkwOWExNDE5OWI2YTExODUxMzVhOTdmNTFmLi42MGI4N2RjYmYyNWRjODc1YzYzZTYyNjJmYmVk OGYzNWZhNTJhNzA0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMDkgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtCRkNdW01hcmdpbkNvbGxhcHNpbmddIFRha2Ug Y29sbGFwc2VkIHRocm91Z2ggc2libGluZ3MgaW50byBhY2NvdW50IHdoZW4gY29tcHV0aW5nIHZl cnRpY2FsIHBvc2l0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTMzMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIExheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0OgorCiAy MDE5LTAxLTA5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bQkZDXVtNYXJnaW5Db2xsYXBzaW5nXSBBZGQgc3VwcG9ydCBmb3IgcGVjdWxpYXIgY2FzZXMu CmRpZmYgLS1naXQgYS9Ub29scy9MYXlvdXRSZWxvYWRlZC9taXNjL0xGQy1wYXNzaW5nLXRlc3Rz LnR4dCBiL1Rvb2xzL0xheW91dFJlbG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0Cmlu ZGV4IDIyNWI3NDc1ZGE4M2FhNWNhYWUxOTFlYTU5MWFhNjI1MWU2OWNmNjguLmUzYzg1MTg0MTZk MzJiZGU0NDViNGQyYWI5ZWNkOTcwMTY5MDZkMmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0xheW91dFJl bG9hZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CisrKyBiL1Rvb2xzL0xheW91dFJlbG9h ZGVkL21pc2MvTEZDLXBhc3NpbmctdGVzdHMudHh0CkBAIC02Myw2ICs2Myw3IEBAIGZhc3QvYmxv Y2svYmxvY2stb25seS9tYXJnaW4tbGVmdC1yaWdodC1zaXppbmcuaHRtbAogZmFzdC9ibG9jay9i bG9jay1vbmx5L21hcmdpbi1wcm9wYWdhdGlvbi1zaW1wbGUtY29udGVudC1oZWlnaHQuaHRtbAog ZmFzdC9ibG9jay9ibG9jay1vbmx5L21hcmdpbi1zaWJsaW5nLWNvbGxhcHNlLXByb3BhZ2F0ZWQu aHRtbAogZmFzdC9ibG9jay9ibG9jay1vbmx5L21hcmdpbi1zaW1wbGUuaHRtbAorZmFzdC9ibG9j ay9ibG9jay1vbmx5L2NvbGxhcHNlZC10aHJvdWdoLXNpYmxpbmdzLmh0bWwKIGZhc3QvYmxvY2sv YmxvY2stb25seS9taW4tbWF4LWhlaWdodC1wZXJjZW50YWdlLmh0bWwKIGZhc3QvYmxvY2svYmxv Y2stb25seS9uZWdhdGl2ZS1tYXJnaW4tc2ltcGxlLmh0bWwKIGZhc3QvYmxvY2svYmxvY2stb25s eS9wYWRkaW5nLW5lc3RlZC5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2ZlYmNiNTIyMTQxNDA4ZDY4YmVjMmUwYWU4 YjQ4ZjVmMGI3YmE1Ni4uZGRlZjRjODUwNjMzNTk0ODI3NzNkZGI1YTQ4MDM3YjcyZGE2YzM2ZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTA5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXVtNYXJnaW5Db2xsYXBzaW5nXSBUYWtlIGNv bGxhcHNlZCB0aHJvdWdoIHNpYmxpbmdzIGludG8gYWNjb3VudCB3aGVuIGNvbXB1dGluZyB2ZXJ0 aWNhbCBwb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkzMzEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBmYXN0L2Jsb2NrL21hcmdpbi1jb2xsYXBzZS9jb2xsYXBzZWQtdGhyb3VnaC1zaWJs aW5ncy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvYmxvY2svbWFyZ2luLWNv bGxhcHNlL2NvbGxhcHNlZC10aHJvdWdoLXNpYmxpbmdzLmh0bWw6IEFkZGVkLgorCiAyMDE5LTAx LTA5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9zaG93LXNlbGVjdGlvbi1pbi1lbXB0eS1vdmVyZmxv dy1oaWRkZW4tZG9jdW1lbnQuaHRtbCBvZnRlbiB0aW1lcyBvdXQgaW4gaW50ZXJuYWwgYXV0b21h dGlvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9ibG9jay1vbmx5L2NvbGxh cHNlZC10aHJvdWdoLXNpYmxpbmdzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmxv Y2svYmxvY2stb25seS9jb2xsYXBzZWQtdGhyb3VnaC1zaWJsaW5ncy1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uZDEwZjg1NTZjYmQzNThjOTljNzVkMzE3ZDJlM2M1ZjRiMWM4YzE0NQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxvY2stb25seS9jb2xsYXBzZWQt dGhyb3VnaC1zaWJsaW5ncy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMiBAQAorbGF5ZXIgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCits YXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDAp IHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDcwKSBzaXplIDc4NHg1 MjIKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUgNDAweDQwMAorICAgICAg ICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwwKSBzaXplIDQwMHgwCisgICAgICAgIFJlbmRlckJs b2NrIHtESVZ9IGF0ICgwLDApIHNpemUgNDAweDAKKyAgICAgICAgUmVuZGVyQmxvY2sge0RJVn0g YXQgKDAsMCkgc2l6ZSA0MDB4MAorICAgICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwwKSBz aXplIDQwMHgwCisgICAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUgNDAweDAK KyAgICAgICAgUmVuZGVyQmxvY2sge0RJVn0gYXQgKDAsMCkgc2l6ZSAxMDB4MTAwCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLW9ubHkvY29sbGFwc2VkLXRocm91Z2gt c2libGluZ3MuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxvY2stb25seS9jb2xsYXBz ZWQtdGhyb3VnaC1zaWJsaW5ncy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk0MTE5Y2NhYzRlOWEyYjQyNmNh YmRkMmFlODBmN2VhY2Y0YzVmOTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Jsb2NrL2Jsb2NrLW9ubHkvY29sbGFwc2VkLXRocm91Z2gtc2libGluZ3MuaHRtbApAQCAtMCww ICsxLDggQEAKKzxkaXYgc3R5bGU9IndpZHRoOiA0MDBweDsgaGVpZ2h0OiA0MDBweCI+CisJPGRp diBzdHlsZT0ibWFyZ2luLXRvcDogMTBweDsgbWFyZ2luLWJvdHRvbTogNzBweCI+PC9kaXY+CisJ PGRpdiBzdHlsZT0ibWFyZ2luLXRvcDogMjBweDsgbWFyZ2luLWJvdHRvbTogNjBweCI+PC9kaXY+ CisJPGRpdiBzdHlsZT0ibWFyZ2luLXRvcDogMzBweDsgbWFyZ2luLWJvdHRvbTogNTBweCI+PC9k aXY+CisJPGRpdiBzdHlsZT0ibWFyZ2luLXRvcDogNDBweDsgbWFyZ2luLWJvdHRvbTogNDBweCI+ PC9kaXY+CisJPGRpdiBzdHlsZT0ibWFyZ2luLXRvcDogNTBweDsgbWFyZ2luLWJvdHRvbTogMzBw eCI+PC9kaXY+CisJPGRpdiBzdHlsZT0id2lkdGg6IDEwMHB4OyBoZWlnaHQ6IDEwMHB4OyBtYXJn aW4tdG9wOiAyMHB4Ij48L2Rpdj4KKzwvZGl2Pgo=