193309 2019-01-09 16:33:55 -0800 Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters 2019-01-10 10:09:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ews-watchlist graouts simon.fraser webkit-bug-importer oldest_to_newest 1493169 0 dino 2019-01-09 16:33:55 -0800 Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters 1493170 1 dino 2019-01-09 16:34:20 -0800 <rdar://problem/45279224> 1493171 2 358765 dino 2019-01-09 16:40:42 -0800 Created attachment 358765 Patch 1493246 3 358765 graouts 2019-01-10 02:31:52 -0800 Comment on attachment 358765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358765&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2157 > + if (backdropFilterRect.width() > 0 && backdropFilterRect.height() > 0) { Should `canHaveBackdropFilters` be set to true in case either the width or height is 0? Also, do we need the `> 0` check? I assume these values can't be negative. 1493318 4 358765 dino 2019-01-10 09:26:45 -0800 Comment on attachment 358765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358765&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2157 >> + if (backdropFilterRect.width() > 0 && backdropFilterRect.height() > 0) { > > Should `canHaveBackdropFilters` be set to true in case either the width or height is 0? Also, do we need the `> 0` check? I assume these values can't be negative. If either the width or height is 0, then there is no point having a backdrop layer. Regarding negative, I don't think they ever should be < 0, but it is technically possible... and one of the ways the crash could have happened. I'm hoping to get a reproduction from an originator to see what really went wrong. 1493342 5 dino 2019-01-10 10:09:29 -0800 Committed r239833: <https://trac.webkit.org/changeset/239833> 358765 2019-01-09 16:40:42 -0800 2019-01-10 02:31:52 -0800 Patch bug-193309-20190110114040.patch text/plain 3846 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVhMjBiMDIzY2MxMGM1 YjU4OWRmZDVjZjAyZjI0NmFmYTI4OGJhZC4uMjQyMTZlZGRlMTY3ZmRhZGQzNTg0NWZkYzhiMTFk YTdiZjE0MGNhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTAxLTA5ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTYWZhcmkgQ3Jhc2hpbmcgaW4g VmVyc2lvbiAxMi4wLjEgKDE0NjA2LjIuMTA0LjEuMSkgV2ViQ29yZTo6R3JhcGhpY3NMYXllckNB Ojp1cGRhdGVCYWNrZHJvcEZpbHRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MzMwOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDUyNzkyMjQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBzcGVj dWxhdGl2ZSBmaXggZm9yIGEgQ2hlY2tlZEFyaXRobWV0aWMgY3Jhc2ggdHJpZ2dlcmVkIGluIHVw ZGF0ZUJhY2tkcm9wRmlsdGVycy4KKworICAgICAgICBUaGUgY3Jhc2ggbG9nIGluZGljYXRlcyB3 ZSBjcmFzaCBpbiBhIENoZWNrZWQ8PiBjbGFzcyB0aGF0IGlzIG5vdCByZWNvcmRpbmcKKyAgICAg ICAgb3ZlcmZsb3cgaS5lLiBpdCBpcyBjcmFzaGluZyBkdWUgdG8gYW4gb3ZlcmZsb3cuIFRoZSBv bmx5IHBsYWNlIGluIHRoaXMgZnVuY3Rpb24KKyAgICAgICAgd2hlcmUgdGhhdCBjb3VsZCBoYXBw ZW4gaXMgd2hlbiB3ZSBjb252ZXJ0IHRoZSBGbG9hdFJlY3QgZm9yIHRoZSBiYWNrZHJvcAorICAg ICAgICByZWdpb24gaW50byBhIENoZWNrZWQ8dW5zaWduZWQ+IGZvciB3aWR0aCBhbmQgaGVpZ2h0 LiBUaGlzIHN1Z2dlc3RzIHRoYXQgZWl0aGVyCisgICAgICAgIHRoZSB3aWR0aCBvciBoZWlnaHQg YXJlIG5lZ2F0aXZlLCBvciB0aGUgZmxvYXQgdmFsdWVzIGFyZSB0b28gbGFyZ2UgZm9yIGludGVn ZXJzLAorICAgICAgICBvciB0aGUgcHJvZHVjdCBvZiB0aGUgdHdvIG92ZXJmbG93cy4KKworICAg ICAgICBBdm9pZCB0aGlzIGJ5IHVzaW5nIFJlY29yZE92ZXJmbG93LCBidXQgYWxzbyBjaGFuZ2lu ZyB0aGUgY29kZSBhIGxpdHRsZSB0bworICAgICAgICBiYWlsIGlmIHRoZSByZWN0YW5nbGUgaXMg aW5jb3JyZWN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXll ckNBLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDQTo6dXBkYXRlQmFja2Ry b3BGaWx0ZXJzKToKKwogMjAxOS0wMS0wOSAgSnVzdGluIEZhbiAgPGp1c3Rpbl9mYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXZWJHUFVdIEZpeCB2ZXJ0ZXgtYnVmZmVyLXRyaWFuZ2xlLXN0cmlw IHRlc3QgYW5kIHNtYWxsIHVwZGF0ZSB0byBHUFVSZW5kZXJQaXBlbGluZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAK aW5kZXggNjUwZWI2YzhlNTRhYjcyMjVlYTg5NDBjMWQ4MjEzYmVjZGIwZmQ5NS4uZTU3NGY5Nzg1 MDk1NjBjYTAzYTY3ZjgyN2U5YzNhMTgyMjlkMWViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCkBAIC0yMTQ3 LDE4ICsyMTQ3LDIyIEBAIHZvaWQgR3JhcGhpY3NMYXllckNBOjp1cGRhdGVGaWx0ZXJzKCkKIAog dm9pZCBHcmFwaGljc0xheWVyQ0E6OnVwZGF0ZUJhY2tkcm9wRmlsdGVycyhDb21taXRTdGF0ZSYg Y29tbWl0U3RhdGUpCiB7CisgICAgdXNpbmcgQ2hlY2tlZFVuc2lnbmVkID0gQ2hlY2tlZDx1bnNp Z25lZCwgUmVjb3JkT3ZlcmZsb3c+OworCiAgICAgYm9vbCBjYW5IYXZlQmFja2Ryb3BGaWx0ZXJz ID0gbmVlZHNCYWNrZHJvcCgpOwogCiAgICAgaWYgKGNhbkhhdmVCYWNrZHJvcEZpbHRlcnMpIHsK LSAgICAgICAgQ2hlY2tlZDx1bnNpZ25lZCwgUmVjb3JkT3ZlcmZsb3c+IGJhY2tkcm9wRmlsdGVy QXJlYSA9IENoZWNrZWQ8dW5zaWduZWQ+KHN0YXRpY19jYXN0PGludD4obV9iYWNrZHJvcEZpbHRl cnNSZWN0LnJlY3QoKS53aWR0aCgpKSkgKiBDaGVja2VkPHVuc2lnbmVkPihzdGF0aWNfY2FzdDxp bnQ+KG1fYmFja2Ryb3BGaWx0ZXJzUmVjdC5yZWN0KCkuaGVpZ2h0KCkpKTsKLSAgICAgICAgaWYg KGJhY2tkcm9wRmlsdGVyQXJlYS5oYXNPdmVyZmxvd2VkKCkpCi0gICAgICAgICAgICBjYW5IYXZl QmFja2Ryb3BGaWx0ZXJzID0gZmFsc2U7Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAgQ2hl Y2tlZDx1bnNpZ25lZCwgUmVjb3JkT3ZlcmZsb3c+IG5ld1RvdGFsQmFja2Ryb3BGaWx0ZXJBcmVh ID0gQ2hlY2tlZDx1bnNpZ25lZCwgUmVjb3JkT3ZlcmZsb3c+KGNvbW1pdFN0YXRlLnRvdGFsQmFj a2Ryb3BGaWx0ZXJBcmVhKSArIGJhY2tkcm9wRmlsdGVyQXJlYTsKLSAgICAgICAgICAgIGlmIChu ZXdUb3RhbEJhY2tkcm9wRmlsdGVyQXJlYS5oYXNPdmVyZmxvd2VkKCkgfHwgbmV3VG90YWxCYWNr ZHJvcEZpbHRlckFyZWEudW5zYWZlR2V0KCkgPiBjTWF4VG90YWxCYWNrZHJvcEZpbHRlckFyZWEp Ci0gICAgICAgICAgICAgICAgY2FuSGF2ZUJhY2tkcm9wRmlsdGVycyA9IGZhbHNlOwotICAgICAg ICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGNvbW1pdFN0YXRlLnRvdGFsQmFja2Ryb3BGaWx0 ZXJBcmVhID0gbmV3VG90YWxCYWNrZHJvcEZpbHRlckFyZWEudW5zYWZlR2V0KCk7CisgICAgICAg IGNhbkhhdmVCYWNrZHJvcEZpbHRlcnMgPSBmYWxzZTsKKyAgICAgICAgSW50UmVjdCBiYWNrZHJv cEZpbHRlclJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KG1fYmFja2Ryb3BGaWx0ZXJzUmVjdC5yZWN0 KCkpOworICAgICAgICBpZiAoYmFja2Ryb3BGaWx0ZXJSZWN0LndpZHRoKCkgPiAwICYmIGJhY2tk cm9wRmlsdGVyUmVjdC5oZWlnaHQoKSA+IDApIHsKKyAgICAgICAgICAgIENoZWNrZWRVbnNpZ25l ZCBiYWNrZHJvcEZpbHRlckFyZWEgPSBDaGVja2VkVW5zaWduZWQoYmFja2Ryb3BGaWx0ZXJSZWN0 LndpZHRoKCkpICogQ2hlY2tlZFVuc2lnbmVkKGJhY2tkcm9wRmlsdGVyUmVjdC5oZWlnaHQoKSk7 CisgICAgICAgICAgICBpZiAoIWJhY2tkcm9wRmlsdGVyQXJlYS5oYXNPdmVyZmxvd2VkKCkpIHsK KyAgICAgICAgICAgICAgICBDaGVja2VkVW5zaWduZWQgbmV3VG90YWxCYWNrZHJvcEZpbHRlckFy ZWEgPSBDaGVja2VkVW5zaWduZWQoY29tbWl0U3RhdGUudG90YWxCYWNrZHJvcEZpbHRlckFyZWEp ICsgYmFja2Ryb3BGaWx0ZXJBcmVhOworICAgICAgICAgICAgICAgIGlmICghbmV3VG90YWxCYWNr ZHJvcEZpbHRlckFyZWEuaGFzT3ZlcmZsb3dlZCgpICYmIG5ld1RvdGFsQmFja2Ryb3BGaWx0ZXJB cmVhLnVuc2FmZUdldCgpIDw9IGNNYXhUb3RhbEJhY2tkcm9wRmlsdGVyQXJlYSkgeworICAgICAg ICAgICAgICAgICAgICBjb21taXRTdGF0ZS50b3RhbEJhY2tkcm9wRmlsdGVyQXJlYSA9IG5ld1Rv dGFsQmFja2Ryb3BGaWx0ZXJBcmVhLnVuc2FmZUdldCgpOworICAgICAgICAgICAgICAgICAgICBj YW5IYXZlQmFja2Ryb3BGaWx0ZXJzID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICB9CiAK