193307 2019-01-09 16:10:57 -0800 REGRESSION(239737) iOS quicklook tests should not dereference null 2019-01-09 16:22:47 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen bfulgham webkit-bug-importer oldest_to_newest 1493149 0 achristensen 2019-01-09 16:10:57 -0800 REGRESSION(239737) iOS quicklook tests should not dereference null 1493150 1 358759 achristensen 2019-01-09 16:11:53 -0800 Created attachment 358759 Patch 1493155 2 358759 bfulgham 2019-01-09 16:18:37 -0800 Comment on attachment 358759 Patch Looks like some null checks. Yup. r=me 1493156 3 achristensen 2019-01-09 16:19:40 -0800 http://trac.webkit.org/r239791 1493158 4 webkit-bug-importer 2019-01-09 16:22:47 -0800 <rdar://problem/47163207> 358759 2019-01-09 16:11:53 -0800 2019-01-09 16:18:37 -0800 Patch bug-193307-20190109161153.patch text/plain 7198 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzOTc5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTAxLTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TigyMzk3MzcpIGlPUyBxdWlja2xvb2sgdGVzdHMgc2hvdWxkIG5vdCBkZXJlZmVyZW5jZSBudWxs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMzMDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcXVp Y2tsb29rIHRlc3RzIHJlbHkgb24gUmVzb3VyY2VIYW5kbGUgb24gaU9TIGZvciBzb21lIHJlYXNv bi4KKyAgICAgICAgVGhpcyBpcyBhIHByb2JsZW0gd2UnbGwgZml4IGxhdGVyLCBidXQgZm9yIG5v dyBrZWVwIHRoZW0gd29ya2luZyBieSBub3QgY3Jhc2hpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlSGFuZGxlOjpjcmVhdGVOU1VSTENvbm5lY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VIYW5kbGU6OnN0YXJ0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxl Ojp3aWxsU2VuZFJlcXVlc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnRy eUhhbmRsZVBhc3N3b3JkQmFzZWRBdXRoZW50aWNhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpS ZXNvdXJjZUhhbmRsZTo6cmVjZWl2ZWRDcmVkZW50aWFsKToKKwogMjAxOS0wMS0wOSAgWmFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtEYXRhbGlzdF0gQ3Jhc2ggd2hl biBpbnB1dCB3aXRoIGRhdGFsaXN0IGlzIGR5bmFtaWNhbGx5IGFkZGVkLgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5k bGVNYWMubW0JKHJldmlzaW9uIDIzOTc4OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTcsMTIg KzE1NywxNCBAQCB2b2lkIFJlc291cmNlSGFuZGxlOjpjcmVhdGVOU1VSTENvbm5lY3RpCiAgICAg ICAgIGlmIChkLT5tX3VzZXIuaXNFbXB0eSgpICYmIGQtPm1fcGFzcy5pc0VtcHR5KCkpIHsKICAg ICAgICAgICAgIC8vIDxyZGFyOi8vcHJvYmxlbS83MTc0MDUwPiAtIEZvciBVUkxzIHRoYXQgbWF0 Y2ggdGhlIHBhdGhzIG9mIHRob3NlIHByZXZpb3VzbHkgY2hhbGxlbmdlZCBmb3IgSFRUUCBCYXNp YyBhdXRoZW50aWNhdGlvbiwgCiAgICAgICAgICAgICAvLyB0cnkgYW5kIHJldXNlIHRoZSBjcmVk ZW50aWFsIHByZWVtcHRpdmVseSwgYXMgYWxsb3dlZCBieSBSRkMgMjYxNy4KLSAgICAgICAgICAg IGQtPm1faW5pdGlhbENyZWRlbnRpYWwgPSBkLT5tX2NvbnRleHQtPnN0b3JhZ2VTZXNzaW9uKCkt PmNyZWRlbnRpYWxTdG9yYWdlKCkuZ2V0KGZpcnN0UmVxdWVzdCgpLmNhY2hlUGFydGl0aW9uKCks IGZpcnN0UmVxdWVzdCgpLnVybCgpKTsKKyAgICAgICAgICAgIGlmIChhdXRvKiBuZXR3b3JrU3Rv cmFnZVNlc3Npb24gPSBkLT5tX2NvbnRleHQtPnN0b3JhZ2VTZXNzaW9uKCkpCisgICAgICAgICAg ICAgICAgZC0+bV9pbml0aWFsQ3JlZGVudGlhbCA9IG5ldHdvcmtTdG9yYWdlU2Vzc2lvbi0+Y3Jl ZGVudGlhbFN0b3JhZ2UoKS5nZXQoZmlyc3RSZXF1ZXN0KCkuY2FjaGVQYXJ0aXRpb24oKSwgZmly c3RSZXF1ZXN0KCkudXJsKCkpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgLy8gSWYg dGhlcmUgaXMgYWxyZWFkeSBhIHByb3RlY3Rpb24gc3BhY2Uga25vd24gZm9yIHRoZSBVUkwsIHVw ZGF0ZSBzdG9yZWQgY3JlZGVudGlhbHMgYmVmb3JlIHNlbmRpbmcgYSByZXF1ZXN0LgogICAgICAg ICAgICAgLy8gVGhpcyBtYWtlcyBpdCBwb3NzaWJsZSB0byBpbXBsZW1lbnQgbG9nb3V0IGJ5IHNl bmRpbmcgYW4gWE1MSHR0cFJlcXVlc3Qgd2l0aCBrbm93biBpbmNvcnJlY3QgY3JlZGVudGlhbHMs IGFuZCBhYm9ydGluZyBpdCBpbW1lZGlhdGVseQogICAgICAgICAgICAgLy8gKHNvIHRoYXQgYW4g YXV0aGVudGljYXRpb24gZGlhbG9nIGRvZXNuJ3QgcG9wIHVwKS4KLSAgICAgICAgICAgIGQtPm1f Y29udGV4dC0+c3RvcmFnZVNlc3Npb24oKS0+Y3JlZGVudGlhbFN0b3JhZ2UoKS5zZXQoZmlyc3RS ZXF1ZXN0KCkuY2FjaGVQYXJ0aXRpb24oKSwgQ3JlZGVudGlhbChkLT5tX3VzZXIsIGQtPm1fcGFz cywgQ3JlZGVudGlhbFBlcnNpc3RlbmNlTm9uZSksIGZpcnN0UmVxdWVzdCgpLnVybCgpKTsKKyAg ICAgICAgICAgIGlmIChhdXRvKiBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBkLT5tX2NvbnRleHQt PnN0b3JhZ2VTZXNzaW9uKCkpCisgICAgICAgICAgICAgICAgbmV0d29ya1N0b3JhZ2VTZXNzaW9u LT5jcmVkZW50aWFsU3RvcmFnZSgpLnNldChmaXJzdFJlcXVlc3QoKS5jYWNoZVBhcnRpdGlvbigp LCBDcmVkZW50aWFsKGQtPm1fdXNlciwgZC0+bV9wYXNzLCBDcmVkZW50aWFsUGVyc2lzdGVuY2VO b25lKSwgZmlyc3RSZXF1ZXN0KCkudXJsKCkpOwogICAgICAgICB9CiAgICAgfQogICAgICAgICAK QEAgLTI0MCw3ICsyNDIsOCBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydCgpCiAgICAgaWYg KCFkLT5tX2NvbnRleHQtPmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAg ZC0+bV9zdG9yYWdlU2Vzc2lvbiA9IGQtPm1fY29udGV4dC0+c3RvcmFnZVNlc3Npb24oKS0+cGxh dGZvcm1TZXNzaW9uKCk7CisgICAgaWYgKGF1dG8qIG5ldHdvcmtTdG9yYWdlU2Vzc2lvbiA9IGQt Pm1fY29udGV4dC0+c3RvcmFnZVNlc3Npb24oKSkKKyAgICAgICAgZC0+bV9zdG9yYWdlU2Vzc2lv biA9IG5ldHdvcmtTdG9yYWdlU2Vzc2lvbi0+cGxhdGZvcm1TZXNzaW9uKCk7CiAKICAgICAvLyBG SVhNRTogRG8gbm90IHVzZSB0aGUgc3luYyB2ZXJzaW9uIG9mIHNob3VsZFVzZUNyZWRlbnRpYWxT dG9yYWdlIHdoZW4gdGhlIGNsaWVudCByZXR1cm5zIHRydWUgZnJvbSB1c2VzQXN5bmNDYWxsYmFj a3MuCiAgICAgYm9vbCBzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSA9ICFjbGllbnQoKSB8fCBj bGllbnQoKS0+c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UodGhpcyk7CkBAIC00NDksNyArNDUy LDkgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6d2lsbFNlbmRSZXF1ZXN0KFJlcwogICAgICAgICAv LyBPbmx5IGNvbnNpZGVyIGFwcGx5aW5nIGF1dGhlbnRpY2F0aW9uIGNyZWRlbnRpYWxzIGlmIHRo aXMgaXMgYWN0dWFsbHkgYSByZWRpcmVjdCBhbmQgdGhlIHJlZGlyZWN0CiAgICAgICAgIC8vIFVS TCBkaWRuJ3QgaW5jbHVkZSBjcmVkZW50aWFscyBvZiBpdHMgb3duLgogICAgICAgICBpZiAoZC0+ bV91c2VyLmlzRW1wdHkoKSAmJiBkLT5tX3Bhc3MuaXNFbXB0eSgpICYmICFyZWRpcmVjdFJlc3Bv bnNlLmlzTnVsbCgpKSB7Ci0gICAgICAgICAgICBDcmVkZW50aWFsIGNyZWRlbnRpYWwgPSBkLT5t X2NvbnRleHQtPnN0b3JhZ2VTZXNzaW9uKCktPmNyZWRlbnRpYWxTdG9yYWdlKCkuZ2V0KHJlcXVl c3QuY2FjaGVQYXJ0aXRpb24oKSwgcmVxdWVzdC51cmwoKSk7CisgICAgICAgICAgICBDcmVkZW50 aWFsIGNyZWRlbnRpYWw7CisgICAgICAgICAgICBpZiAoYXV0byogbmV0d29ya1N0b3JhZ2VTZXNz aW9uID0gZC0+bV9jb250ZXh0LT5zdG9yYWdlU2Vzc2lvbigpKQorICAgICAgICAgICAgICAgIGNy ZWRlbnRpYWwgPSBuZXR3b3JrU3RvcmFnZVNlc3Npb24tPmNyZWRlbnRpYWxTdG9yYWdlKCkuZ2V0 KHJlcXVlc3QuY2FjaGVQYXJ0aXRpb24oKSwgcmVxdWVzdC51cmwoKSk7CiAgICAgICAgICAgICBp ZiAoIWNyZWRlbnRpYWwuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgZC0+bV9pbml0aWFs Q3JlZGVudGlhbCA9IGNyZWRlbnRpYWw7CiAgICAgICAgICAgICAgICAgCkBAIC01NDAsMTYgKzU0 NSwyMCBAQCBib29sIFJlc291cmNlSGFuZGxlOjp0cnlIYW5kbGVQYXNzd29yZEJhCiAgICAgICAg ICAgICAvLyBUaGUgc3RvcmVkIGNyZWRlbnRpYWwgd2Fzbid0IGFjY2VwdGVkLCBzdG9wIHVzaW5n IGl0LgogICAgICAgICAgICAgLy8gVGhlcmUgaXMgYSByYWNlIGNvbmRpdGlvbiBoZXJlLCBzaW5j ZSBhIGRpZmZlcmVudCBjcmVkZW50aWFsIG1pZ2h0IGhhdmUgYWxyZWFkeSBiZWVuIHN0b3JlZCBi eSBhbm90aGVyIFJlc291cmNlSGFuZGxlLAogICAgICAgICAgICAgLy8gYnV0IHRoZSBvYnNlcnZh YmxlIGVmZmVjdCBzaG91bGQgYmUgdmVyeSBtaW5vciwgaWYgYW55LgotICAgICAgICAgICAgZC0+ bV9jb250ZXh0LT5zdG9yYWdlU2Vzc2lvbigpLT5jcmVkZW50aWFsU3RvcmFnZSgpLnJlbW92ZShk LT5tX3BhcnRpdGlvbiwgY2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpKTsKKyAgICAgICAgICAg IGlmIChhdXRvKiBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBkLT5tX2NvbnRleHQtPnN0b3JhZ2VT ZXNzaW9uKCkpCisgICAgICAgICAgICAgICAgbmV0d29ya1N0b3JhZ2VTZXNzaW9uLT5jcmVkZW50 aWFsU3RvcmFnZSgpLnJlbW92ZShkLT5tX3BhcnRpdGlvbiwgY2hhbGxlbmdlLnByb3RlY3Rpb25T cGFjZSgpKTsKICAgICAgICAgfQogCiAgICAgICAgIGlmICghY2hhbGxlbmdlLnByZXZpb3VzRmFp bHVyZUNvdW50KCkpIHsKLSAgICAgICAgICAgIENyZWRlbnRpYWwgY3JlZGVudGlhbCA9IGQtPm1f Y29udGV4dC0+c3RvcmFnZVNlc3Npb24oKS0+Y3JlZGVudGlhbFN0b3JhZ2UoKS5nZXQoZC0+bV9w YXJ0aXRpb24sIGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSk7CisgICAgICAgICAgICBDcmVk ZW50aWFsIGNyZWRlbnRpYWw7CisgICAgICAgICAgICBpZiAoYXV0byogbmV0d29ya1N0b3JhZ2VT ZXNzaW9uID0gZC0+bV9jb250ZXh0LT5zdG9yYWdlU2Vzc2lvbigpKQorICAgICAgICAgICAgICAg IGNyZWRlbnRpYWwgPSBuZXR3b3JrU3RvcmFnZVNlc3Npb24tPmNyZWRlbnRpYWxTdG9yYWdlKCku Z2V0KGQtPm1fcGFydGl0aW9uLCBjaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkpOwogICAgICAg ICAgICAgaWYgKCFjcmVkZW50aWFsLmlzRW1wdHkoKSAmJiBjcmVkZW50aWFsICE9IGQtPm1faW5p dGlhbENyZWRlbnRpYWwpIHsKICAgICAgICAgICAgICAgICBBU1NFUlQoY3JlZGVudGlhbC5wZXJz aXN0ZW5jZSgpID09IENyZWRlbnRpYWxQZXJzaXN0ZW5jZU5vbmUpOwogICAgICAgICAgICAgICAg IGlmIChjaGFsbGVuZ2UuZmFpbHVyZVJlc3BvbnNlKCkuaHR0cFN0YXR1c0NvZGUoKSA9PSA0MDEp IHsKICAgICAgICAgICAgICAgICAgICAgLy8gU3RvcmUgdGhlIGNyZWRlbnRpYWwgYmFjaywgcG9z c2libHkgYWRkaW5nIGl0IGFzIGEgZGVmYXVsdCBmb3IgdGhpcyBkaXJlY3RvcnkuCi0gICAgICAg ICAgICAgICAgICAgIGQtPm1fY29udGV4dC0+c3RvcmFnZVNlc3Npb24oKS0+Y3JlZGVudGlhbFN0 b3JhZ2UoKS5zZXQoZC0+bV9wYXJ0aXRpb24sIGNyZWRlbnRpYWwsIGNoYWxsZW5nZS5wcm90ZWN0 aW9uU3BhY2UoKSwgY2hhbGxlbmdlLmZhaWx1cmVSZXNwb25zZSgpLnVybCgpKTsKKyAgICAgICAg ICAgICAgICAgICAgaWYgKGF1dG8qIG5ldHdvcmtTdG9yYWdlU2Vzc2lvbiA9IGQtPm1fY29udGV4 dC0+c3RvcmFnZVNlc3Npb24oKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIG5ldHdvcmtTdG9y YWdlU2Vzc2lvbi0+Y3JlZGVudGlhbFN0b3JhZ2UoKS5zZXQoZC0+bV9wYXJ0aXRpb24sIGNyZWRl bnRpYWwsIGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSwgY2hhbGxlbmdlLmZhaWx1cmVSZXNw b25zZSgpLnVybCgpKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgW2NoYWxs ZW5nZS5zZW5kZXIoKSB1c2VDcmVkZW50aWFsOmNyZWRlbnRpYWwubnNDcmVkZW50aWFsKCkgZm9y QXV0aGVudGljYXRpb25DaGFsbGVuZ2U6bWFjKGNoYWxsZW5nZSldOwogICAgICAgICAgICAgICAg IHJldHVybiB0cnVlOwpAQCAtNTkxLDcgKzYwMCw4IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OnJl Y2VpdmVkQ3JlZGVudGlhbCgKICAgICAgICAgVVJMIHVybFRvU3RvcmU7CiAgICAgICAgIGlmIChj aGFsbGVuZ2UuZmFpbHVyZVJlc3BvbnNlKCkuaHR0cFN0YXR1c0NvZGUoKSA9PSA0MDEpCiAgICAg ICAgICAgICB1cmxUb1N0b3JlID0gY2hhbGxlbmdlLmZhaWx1cmVSZXNwb25zZSgpLnVybCgpOwot ICAgICAgICBkLT5tX2NvbnRleHQtPnN0b3JhZ2VTZXNzaW9uKCktPmNyZWRlbnRpYWxTdG9yYWdl KCkuc2V0KGQtPm1fcGFydGl0aW9uLCB3ZWJDcmVkZW50aWFsLCBQcm90ZWN0aW9uU3BhY2UoW2Qt Pm1fY3VycmVudE1hY0NoYWxsZW5nZSBwcm90ZWN0aW9uU3BhY2VdKSwgdXJsVG9TdG9yZSk7Cisg ICAgICAgIGlmIChhdXRvKiBuZXR3b3JrU3RvcmFnZVNlc3Npb24gPSBkLT5tX2NvbnRleHQtPnN0 b3JhZ2VTZXNzaW9uKCkpCisgICAgICAgICAgICBuZXR3b3JrU3RvcmFnZVNlc3Npb24tPmNyZWRl bnRpYWxTdG9yYWdlKCkuc2V0KGQtPm1fcGFydGl0aW9uLCB3ZWJDcmVkZW50aWFsLCBQcm90ZWN0 aW9uU3BhY2UoW2QtPm1fY3VycmVudE1hY0NoYWxsZW5nZSBwcm90ZWN0aW9uU3BhY2VdKSwgdXJs VG9TdG9yZSk7CiAgICAgICAgIFtbZC0+bV9jdXJyZW50TWFjQ2hhbGxlbmdlIHNlbmRlcl0gdXNl Q3JlZGVudGlhbDp3ZWJDcmVkZW50aWFsLm5zQ3JlZGVudGlhbCgpIGZvckF1dGhlbnRpY2F0aW9u Q2hhbGxlbmdlOmQtPm1fY3VycmVudE1hY0NoYWxsZW5nZV07CiAgICAgfSBlbHNlCiAgICAgICAg IFtbZC0+bV9jdXJyZW50TWFjQ2hhbGxlbmdlIHNlbmRlcl0gdXNlQ3JlZGVudGlhbDpjcmVkZW50 aWFsLm5zQ3JlZGVudGlhbCgpIGZvckF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOmQtPm1fY3VycmVu dE1hY0NoYWxsZW5nZV07Cg==