193284 2019-01-09 09:20:10 -0800 Web Inspector: Protocol Logging: log messages as objects if inspector^2 is open 2019-01-09 11:39:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1492970 0 hi 2019-01-09 09:20:10 -0800 I find that having to sift through the mountain of text that arises from protocol logging inside inspector^2 is a torturous task, so I think it's reasonable to say that if we have a way to display a nicer UI, we should. If inspector^2 is closed, stringify all messages. If inspector^2 is open, keep them as JSON objects so they appear all nice and pretty inside inspector^2. 1492971 1 358710 hi 2019-01-09 09:23:21 -0800 Created attachment 358710 Patch 1493003 2 358710 joepeck 2019-01-09 11:09:47 -0800 Comment on attachment 358710 Patch r=me 1493010 3 358710 commit-queue 2019-01-09 11:38:52 -0800 Comment on attachment 358710 Patch Clearing flags on attachment: 358710 Committed r239779: <https://trac.webkit.org/changeset/239779> 1493011 4 commit-queue 2019-01-09 11:38:54 -0800 All reviewed patches have been landed. Closing bug. 1493012 5 webkit-bug-importer 2019-01-09 11:39:28 -0800 <rdar://problem/47153013> 358710 2019-01-09 09:23:21 -0800 2019-01-09 11:38:52 -0800 Patch bug-193284-20190109102320.patch text/plain 4770 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxN2E1NmI0Nzc1NDk4ZjYxNWVlMmZmMGJlZjVkMmY1MzMyMzI3ZDA4Li42 NjNmNWY3NWY0MDBlZWI3Mzc1NTEyOWUxZTllMGEyMjM5MDNlOTZlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTktMDEtMDkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3RvY29sIExvZ2dpbmc6IGxvZyBtZXNzYWdl cyBhcyBvYmplY3RzIGlmIGluc3BlY3Rvcl4yIGlzIG9wZW4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzI4NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ld2UgdGVzdHMsIGFzIHRoaXMgaXMgc2lt cGx5IGV4cG9zZXMgYSB2YWx1ZS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuaWRsOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3Qu aDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Okluc3BlY3RvckZyb250ZW5kSG9zdDo6aXNCZWluZ0luc3BlY3RlZCk6IEFk ZGVkLgorCiAyMDE5LTAxLTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAg ICAgICBCbG9iIHJlZmVyZW5jZXMgZm9yIFN5c3RlbSBQcmV2aWV3cyBkb24ndCBnZXQgYSBjb3Jy ZWN0IGZpbGUgZXh0ZW5zaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4NGYwOTAxNmYy Y2ZjYjQwNGMxOGM3YTkwZjE2OGEyMTAwY2VlMDBlLi42Y2E2Njg0ZmYxNTM5OGVmOTA3YzQyZDI2 Y2IzYzMyNzQ0MjM0NGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxOS0wMS0wOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAg ICAgV2ViIEluc3BlY3RvcjogUHJvdG9jb2wgTG9nZ2luZzogbG9nIG1lc3NhZ2VzIGFzIG9iamVj dHMgaWYgaW5zcGVjdG9yXjIgaXMgb3BlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMjg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSWYgaW5zcGVjdG9yXjIgaXMgY2xvc2VkLCBzdHJpbmdpZnkgYWxs IG1lc3NhZ2VzLgorICAgICAgICBJZiBpbnNwZWN0b3JeMiBpcyBvcGVuLCBsb2cgZWFjaCBtZXNz YWdlIEpTT04gb2JqZWN0IHdpdGhvdXQgbW9kaWZ5aW5nIGl0LgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Qcm90b2NvbC9Mb2dnaW5nUHJvdG9jb2xUcmFjZXIuanM6CisgICAgICAgIChXSS5M b2dnaW5nUHJvdG9jb2xUcmFjZXIucHJvdG90eXBlLl9wcm9jZXNzRW50cnkpOgorCiAyMDE5LTAx LTA4ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFN0eWxlczogVW5kbyByZXZlcnRzIGFsbCBjaGFuZ2VzIGF0IG9uY2UKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAK aW5kZXggYzA4MGE1NmM2ODYxZjNlMzk4OTc5YTdiMTIzZDU2MmI4YjkwZjQ2YS4uMTViOGRjMDgw OWEwZjZmZDY0OWQxNWUyYThiZTYwNWI4YmI5NGNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKQEAgLTQ0NSw2ICs0NDUsMTUg QEAgdm9pZCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6Omluc3BlY3RJbnNwZWN0b3IoKQogICAgICAg ICBtX2Zyb250ZW5kUGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLnNob3coKTsKIH0KIAorYm9v bCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmlzQmVpbmdJbnNwZWN0ZWQoKQoreworICAgIGlmICgh bV9mcm9udGVuZFBhZ2UpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIEluc3BlY3RvckNv bnRyb2xsZXImIGluc3BlY3RvckNvbnRyb2xsZXIgPSBtX2Zyb250ZW5kUGFnZS0+aW5zcGVjdG9y Q29udHJvbGxlcigpOworICAgIHJldHVybiBpbnNwZWN0b3JDb250cm9sbGVyLmhhc0xvY2FsRnJv bnRlbmQoKSB8fCBpbnNwZWN0b3JDb250cm9sbGVyLmhhc1JlbW90ZUZyb250ZW5kKCk7Cit9CisK IGJvb2wgSW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpzdXBwb3J0c1Nob3dDZXJ0aWZpY2F0ZSgpIGNv bnN0CiB7CiAjaWYgUExBVEZPUk0oQ09DT0EpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmgKaW5kZXggOWMwNDQyNWUwM2U4YjgxMzNjOTE5NGYx ZWVjN2I5NGJlZGYwMGJjNi4uNTI0MmNjNjg5NDYzYmRkZGJlODg0NmY2MGVlN2FlNjEzYmNhY2Mx MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5k SG9zdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhv c3QuaApAQCAtMTA5LDYgKzEwOSw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgYmVlcCgpOwogICAg IHZvaWQgaW5zcGVjdEluc3BlY3RvcigpOworICAgIGJvb2wgaXNCZWluZ0luc3BlY3RlZCgpOwog CiBwcml2YXRlOgogI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAppbmRleCAxNjMyNzRiYzhi YWMwZTA4NmUzYmEyMmYyZTExM2Q0OTQ4NzMyYzM2Li5jN2NiZjlkMTEwYTIwNWE0Nzk2OWYzNDFk MTY4MzFjNWY1ZTQ5MjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmlkbApAQCAtODEsNiArODEsNyBAQAogCiAgICAgdm9pZCBiZWVw KCk7CiAgICAgdm9pZCBpbnNwZWN0SW5zcGVjdG9yKCk7CisgICAgYm9vbGVhbiBpc0JlaW5nSW5z cGVjdGVkKCk7CiB9OwogCiBkaWN0aW9uYXJ5IENvbnRleHRNZW51SXRlbSB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9Mb2dnaW5nUHJv dG9jb2xUcmFjZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9Mb2dnaW5nUHJvdG9jb2xUcmFjZXIuanMKaW5kZXggOGQ0MzkwZGEyOTI5ZTYyZGY2NWE3 NzY3YThmZmU3MGYwZjZiNmNmMS4uNTAwOWEzMGI1MTIwMTA4OGM3ZjMxYThlNjY2MzUyZmI2MWFk MzRhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJv dG9jb2wvTG9nZ2luZ1Byb3RvY29sVHJhY2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0xvZ2dpbmdQcm90b2NvbFRyYWNlci5qcwpAQCAtMTE5 LDcgKzExOSwxMyBAQCBXSS5Mb2dnaW5nUHJvdG9jb2xUcmFjZXIgPSBjbGFzcyBMb2dnaW5nUHJv dG9jb2xUcmFjZXIgZXh0ZW5kcyBXSS5Qcm90b2NvbFRyYWNlcgogICAgICAgICAgICAgbGV0IHRh cmdldElkID0gY29ubmVjdGlvbiAmJiBjb25uZWN0aW9uLnRhcmdldCA/IGNvbm5lY3Rpb24udGFy Z2V0LmlkZW50aWZpZXIgOiAidW5rbm93biI7CiAgICAgICAgICAgICBpZiAodGhpcy5fZmlsdGVy TXVsdGlwbGV4aW5nQmFja2VuZCAmJiB0YXJnZXRJZCA9PT0gIm11bHRpIikKICAgICAgICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgICAgICB0aGlzLl9sb2dUb0NvbnNvbGUoYCR7ZW50cnkudHlw ZX0gKCR7dGFyZ2V0SWR9KTogJHtKU09OLnN0cmluZ2lmeShlbnRyeS5tZXNzYWdlKX1gKTsKKwor ICAgICAgICAgICAgbGV0IHByZWZpeCA9IGAke2VudHJ5LnR5cGV9ICgke3RhcmdldElkfSlgOwor ICAgICAgICAgICAgaWYgKCF3aW5kb3cuSW5zcGVjdG9yVGVzdCAmJiBJbnNwZWN0b3JGcm9udGVu ZEhvc3QuaXNCZWluZ0luc3BlY3RlZCgpKQorICAgICAgICAgICAgICAgIHRoaXMuX2xvZ1RvQ29u c29sZShwcmVmaXgsIGVudHJ5Lm1lc3NhZ2UpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIHRoaXMuX2xvZ1RvQ29uc29sZShgJHtwcmVmaXh9OiAke0pTT04uc3RyaW5naWZ5KGVu dHJ5Lm1lc3NhZ2UpfWApOworCiAgICAgICAgICAgICBpZiAoZW50cnkuZXhjZXB0aW9uKSB7CiAg ICAgICAgICAgICAgICAgdGhpcy5fbG9nVG9Db25zb2xlKGVudHJ5LmV4Y2VwdGlvbik7CiAgICAg ICAgICAgICAgICAgaWYgKGVudHJ5LmV4Y2VwdGlvbi5zdGFjaykK