193280 2019-01-09 07:00:14 -0800 [ews-build] Parse and display number of style failures 2019-01-09 14:00:35 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1492933 0 aakash_jain 2019-01-09 07:00:14 -0800 Style-EWS should parse the output of check-webkit-style, count the number of failures and include this information in overall build status. 1492935 1 358701 aakash_jain 2019-01-09 07:03:48 -0800 Created attachment 358701 Proposed patch 1492936 2 aakash_jain 2019-01-09 07:05:02 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/5/builds/1140 1492938 3 ews-watchlist 2019-01-09 07:06:58 -0800 Attachment 358701 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:237: [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:237: [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1493071 4 358701 commit-queue 2019-01-09 13:59:13 -0800 Comment on attachment 358701 Proposed patch Clearing flags on attachment: 358701 Committed r239783: <https://trac.webkit.org/changeset/239783> 1493072 5 commit-queue 2019-01-09 13:59:14 -0800 All reviewed patches have been landed. Closing bug. 1493075 6 webkit-bug-importer 2019-01-09 14:00:35 -0800 <rdar://problem/47157914> 358701 2019-01-09 07:03:48 -0800 2019-01-09 13:59:13 -0800 Proposed patch ews-build-style-count.patch text/plain 2898 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTc2OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBQYXJzZSBhbmQgZGlzcGxheSBudW1iZXIgb2Ygc3R5 bGUgZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MzI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ2hl Y2tTdHlsZSk6IFVzZSBUZXN0V2l0aEZhaWx1cmVDb3VudCBhcyBiYXNlIGNsYXNzLgorICAgICAg ICAoQ2hlY2tTdHlsZS5jb3VudEZhaWx1cmVzKTogQ291bnQgdGhlIG51bWJlciBvZiBzdHlsZSBm YWlsdXJlcy4KKwogMjAxOS0wMS0wOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgW1dQRV0gQVBJIHRlc3RzIGNhbid0IHJ1biBpbiBmbGF0cGFrIGVu dmlyb25tZW50CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5CShyZXZpc2lvbiAyMzk3MjMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTM2MywxNCArMzYzLDYgQEAgY2xhc3MgVW5B cHBseVBhdGNoSWZSZXF1aXJlZChDaGVja091dFNvdQogICAgICAgICByZXR1cm4gbm90IHNlbGYu ZG9TdGVwSWYoc3RlcCkKIAogCi1jbGFzcyBDaGVja1N0eWxlKHNoZWxsLlNoZWxsQ29tbWFuZCk6 Ci0gICAgbmFtZSA9ICdjaGVjay13ZWJraXQtc3R5bGUnCi0gICAgZGVzY3JpcHRpb24gPSBbJ2No ZWNrLXdlYmtpdC1zdHlsZSBydW5uaW5nJ10KLSAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ2NoZWNr LXdlYmtpdC1zdHlsZSddCi0gICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCi0gICAgY29tbWFuZCA9 IFsnVG9vbHMvU2NyaXB0cy9jaGVjay13ZWJraXQtc3R5bGUnXQotCi0KIGNsYXNzIFRlc3RXaXRo RmFpbHVyZUNvdW50KHNoZWxsLlRlc3QpOgogICAgIGZhaWxlZFRlc3RzRm9ybWF0U3RyaW5nID0g IiVkIHRlc3QlcyBmYWlsZWQiCiAgICAgZmFpbGVkVGVzdENvdW50ID0gMApAQCAtNDA5LDYgKzQw MSwyMyBAQCBjbGFzcyBUZXN0V2l0aEZhaWx1cmVDb3VudChzaGVsbC5UZXN0KToKICAgICAgICAg cmV0dXJuIHt1J3N0ZXAnOiBzdGF0dXN9CiAKIAorY2xhc3MgQ2hlY2tTdHlsZShUZXN0V2l0aEZh aWx1cmVDb3VudCk6CisgICAgbmFtZSA9ICdjaGVjay13ZWJraXQtc3R5bGUnCisgICAgZGVzY3Jp cHRpb24gPSBbJ2NoZWNrLXdlYmtpdC1zdHlsZSBydW5uaW5nJ10KKyAgICBkZXNjcmlwdGlvbkRv bmUgPSBbJ2NoZWNrLXdlYmtpdC1zdHlsZSddCisgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCisg ICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAnJWQgc3R5bGUgZXJyb3IlcycKKyAgICBjb21t YW5kID0gWydUb29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHlsZSddCisKKyAgICBkZWYgY291 bnRGYWlsdXJlcyhzZWxmLCBjbWQpOgorICAgICAgICBsb2dfdGV4dCA9IHNlbGYubG9nX29ic2Vy dmVyLmdldFN0ZG91dCgpICsgc2VsZi5sb2dfb2JzZXJ2ZXIuZ2V0U3RkZXJyKCkKKworICAgICAg ICBtYXRjaCA9IHJlLnNlYXJjaChyJ1RvdGFsIGVycm9ycyBmb3VuZDogKD9QPGVycm9ycz5cZCsp IGluICg/UDxmaWxlcz5cZCspIGZpbGVzJywgbG9nX3RleHQpCisgICAgICAgIGlmIG5vdCBtYXRj aDoKKyAgICAgICAgICAgIHJldHVybiAwCisgICAgICAgIHJldHVybiBpbnQobWF0Y2guZ3JvdXAo J2Vycm9ycycpKQorCisKIGNsYXNzIFJ1bkJpbmRpbmdzVGVzdHMoc2hlbGwuU2hlbGxDb21tYW5k KToKICAgICBuYW1lID0gJ2JpbmRpbmdzLXRlc3RzJwogICAgIGRlc2NyaXB0aW9uID0gWydiaW5k aW5ncy10ZXN0cyBydW5uaW5nJ10KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIzOTcyMykKKysrIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2lu ZyBjb3B5KQpAQCAtMjM0LDcgKzIzNCw3IEBAIEVSUk9SOiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQv VmVyaWZpY2F0aW8KIFRvdGFsIGVycm9ycyBmb3VuZDogOCBpbiA0OCBmaWxlcycnJykKICAgICAg ICAgICAgICsgMiwKICAgICAgICAgKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0 PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nY2hlY2std2Via2l0LXN0eWxlIChmYWlsdXJlKScpCisg ICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5nPSc4 IHN0eWxlIGVycm9ycyAoZmFpbHVyZSknKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkK IAogICAgIGRlZiB0ZXN0X2ZhaWx1cmVzX25vX3N0eWxlX2lzc3VlcyhzZWxmKToK