193271 2019-01-08 20:26:54 -0800 [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR 2019-01-09 18:09:29 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead lforschler pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1492851 0 fujii 2019-01-08 20:26:54 -0800 [Win][WebKitLegacy] wchar_t strings shouldn't be treated as BSTR BSTR | Microsoft Docs https://docs.microsoft.com/en-us/previous-versions/windows/desktop/automat/bstr > A BSTR is a composite data type that consists of a length prefix, a data string, and a terminator. > The following code is incorrect: > > BSTR MyBstr = L"I am a happy BSTR"; 1492853 1 fujii 2019-01-08 20:31:12 -0800 clang-cl reports the following warnings: > ..\..\Tools\MiniBrowser\win\MiniBrowserWebHost.cpp(170,38): warning: ISO C++11 does not allow conversion from string literal to 'BSTR' (aka 'wchar_t *') [-Wwritable-strings] > HRESULT hr = doc->getElementById(L"webkit logo", &element.GetInterfacePtr()); > ^ > ..\..\Tools\MiniBrowser\win\MiniBrowserWebHost.cpp(178,70): warning: ISO C++11 does not allow conversion from string literal to 'LPWSTR' (aka 'wchar_t *') [-Wwritable-strings] > hr = target->addEventListener(L"click", new SimpleEventListener (L"webkit logo click"), FALSE); > ^ > ..\..\Tools\MiniBrowser\win\MiniBrowserWebHost.cpp(178,35): warning: ISO C++11 does not allow conversion from string literal to 'BSTR' (aka 'wchar_t *') [-Wwritable-strings] > hr = target->addEventListener(L"click", new SimpleEventListener (L"webkit logo click"), FALSE); > ^ 1492856 2 358665 fujii 2019-01-08 20:45:33 -0800 Created attachment 358665 Patch 1492859 3 358668 fujii 2019-01-08 20:54:57 -0800 Created attachment 358668 Patch 1492860 4 358668 bfulgham 2019-01-08 20:59:20 -0800 Comment on attachment 358668 Patch r=me 1493188 5 358668 fujii 2019-01-09 18:06:07 -0800 Comment on attachment 358668 Patch Clearing flags on attachment: 358668 Committed r239812: <https://trac.webkit.org/changeset/239812> 1493189 6 fujii 2019-01-09 18:06:09 -0800 All reviewed patches have been landed. Closing bug. 1493190 7 webkit-bug-importer 2019-01-09 18:09:29 -0800 <rdar://problem/47166229> 358665 2019-01-08 20:45:33 -0800 2019-01-08 20:54:21 -0800 Patch bug-193271-20190109134532.patch text/plain 2098 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjIxMzI5ZmVhNmQyYzJhZjNlMWIwZDQyY2NiOGUyMmEy NGFkYmMyMy4uYTQ1MTkzZTBlNDkyZjYzMmZjMjM4Y2JjM2UxNzI1NmVlOWQ5NmU4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAxLTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW01pbmlCcm93c2VyXSB3Y2hhcl90IHN0cmluZ3Mgc2hvdWxkbid0 IGJlIHRyZWF0ZWQgYXMgQlNUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzMjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQlNUUiBpcyBhIHNwZWNpYWwgZGF0YSBzdHJ1Y3R1cmUgY3JlYXRlZCBieSBT eXNBbGxvY1N0cmluZywgbm90IGEKKyAgICAgICAgd2NoYXJfdCBudWxsLXRlcm1pbmF0ZWQgc3Ry aW5nLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHA6 CisgICAgICAgIChNaW5pQnJvd3NlcldlYkhvc3Q6OmRpZEZpbmlzaExvYWRGb3JGcmFtZSk6IFVz ZSBfYnN0cl90IHRvIGNyZWF0ZQorICAgICAgICBCU1RSIGZyb20gd2lkZSBzdHJpbmcgbGl0ZXJh bHMuCisKIDIwMTktMDEtMDggIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAg ICAgIEJsb2IgcmVmZXJlbmNlcyBmb3IgU3lzdGVtIFByZXZpZXdzIGRvbid0IGdldCBhIGNvcnJl Y3QgZmlsZSBleHRlbnNpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9NaW5p QnJvd3NlcldlYkhvc3QuY3BwIGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2Vi SG9zdC5jcHAKaW5kZXggN2ZlNzMyNDY3NDVlZjlmYzNjNzRhN2Q2NDUwNTNmMmFkOTQxZjdlYi4u YTYwNGI4Y2UxMmY5YTc5MWQ4ZWZhNjA5ZWU3YTQ4YzZiYTNkMmUyNiAxMDA2NDQKLS0tIGEvVG9v bHMvTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHAKKysrIGIvVG9vbHMvTWlu aUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHAKQEAgLTE2Nyw3ICsxNjcsOCBAQCBI UkVTVUxUIE1pbmlCcm93c2VyV2ViSG9zdDo6ZGlkRmluaXNoTG9hZEZvckZyYW1lKF9Jbl9vcHRf IElXZWJWaWV3KiB3ZWJWaWV3LCBfSQogICAgICAgICBtX2NsaWVudC0+c2hvd0xhc3RWaXNpdGVk U2l0ZXMoKndlYlZpZXcpOwogCiAgICAgLy8gVGhlIGZvbGxvd2luZyBpcyBmb3IgdGhlIHRlc3Qg cGFnZToKLSAgICBIUkVTVUxUIGhyID0gZG9jLT5nZXRFbGVtZW50QnlJZChMIndlYmtpdCBsb2dv IiwgJmVsZW1lbnQuR2V0SW50ZXJmYWNlUHRyKCkpOworICAgIHN0YXRpYyBfYnN0cl90IGlkID0g TCJ3ZWJraXQgbG9nbyI7CisgICAgSFJFU1VMVCBociA9IGRvYy0+Z2V0RWxlbWVudEJ5SWQoaWQs ICZlbGVtZW50LkdldEludGVyZmFjZVB0cigpKTsKICAgICBpZiAoIVNVQ0NFRURFRChocikpCiAg ICAgICAgIHJldHVybiBocjsKIApAQCAtMTc1LDcgKzE3Niw5IEBAIEhSRVNVTFQgTWluaUJyb3dz ZXJXZWJIb3N0OjpkaWRGaW5pc2hMb2FkRm9yRnJhbWUoX0luX29wdF8gSVdlYlZpZXcqIHdlYlZp ZXcsIF9JCiAgICAgaWYgKCFTVUNDRUVERUQoaHIpKQogICAgICAgICByZXR1cm4gaHI7CiAKLSAg ICBociA9IHRhcmdldC0+YWRkRXZlbnRMaXN0ZW5lcihMImNsaWNrIiwgbmV3IFNpbXBsZUV2ZW50 TGlzdGVuZXIgKEwid2Via2l0IGxvZ28gY2xpY2siKSwgRkFMU0UpOworICAgIHN0YXRpYyBfYnN0 cl90IGV2ZW50TmFtZSA9IEwiY2xpY2siOworICAgIHN0YXRpYyBfYnN0cl90IGV2ZW50VHlwZSA9 IEwid2Via2l0IGxvZ28gY2xpY2siOworICAgIGhyID0gdGFyZ2V0LT5hZGRFdmVudExpc3RlbmVy KGV2ZW50TmFtZSwgbmV3IFNpbXBsZUV2ZW50TGlzdGVuZXIoZXZlbnRUeXBlKSwgRkFMU0UpOwog ICAgIGlmICghU1VDQ0VFREVEKGhyKSkKICAgICAgICAgcmV0dXJuIGhyOwogCg== 358668 2019-01-08 20:54:57 -0800 2019-01-09 18:06:07 -0800 Patch bug-193271-20190109135456.patch text/plain 2851 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjIxMzI5ZmVhNmQyYzJhZjNlMWIwZDQyY2NiOGUyMmEy NGFkYmMyMy4uNTQ2NzI1MzAzN2QxOWQzMzZlNjIzZGE2ZmY0MzdhNGJhNDBiNTFiMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTAxLTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW01pbmlCcm93c2VyXSB3Y2hhcl90IHN0cmluZ3Mgc2hvdWxkbid0 IGJlIHRyZWF0ZWQgYXMgQlNUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTkzMjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQlNUUiBpcyBhIHNwZWNpYWwgZGF0YSBzdHJ1Y3R1cmUgY3JlYXRlZCBieSBT eXNBbGxvY1N0cmluZywgbm90IGEKKyAgICAgICAgd2NoYXJfdCBudWxsLXRlcm1pbmF0ZWQgc3Ry aW5nLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL1Rlc3RSdW5uZXJXaW4uY3BwOgor ICAgICAgICAoVGVzdFJ1bm5lcjo6c2V0RGF0YWJhc2VRdW90YSk6IFVzZSBMIiIgaW5zdGVhZCBv ZiAiIiBmb3IgX2JzdHJfdC4KKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vTWluaUJyb3dzZXJX ZWJIb3N0LmNwcDoKKyAgICAgICAgKE1pbmlCcm93c2VyV2ViSG9zdDo6ZGlkRmluaXNoTG9hZEZv ckZyYW1lKTogVXNlIF9ic3RyX3QgdG8gY3JlYXRlCisgICAgICAgIEJTVFIgZnJvbSB3aWRlIHN0 cmluZyBsaXRlcmFscy4KKwogMjAxOS0wMS0wOCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5j b20+CiAKICAgICAgICAgQmxvYiByZWZlcmVuY2VzIGZvciBTeXN0ZW0gUHJldmlld3MgZG9uJ3Qg Z2V0IGEgY29ycmVjdCBmaWxlIGV4dGVuc2lvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvd2luL1Rlc3RSdW5uZXJXaW4uY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL1Rl c3RSdW5uZXJXaW4uY3BwCmluZGV4IGJlYTU5MzE0MTZlZGFiNTRkZDM3YzNmOGZhNjVmOTk4MjU0 N2RiNWQuLjEwNzI1MzI3MTRiNzFmNDAwNWY4Y2YwYzAxNDI1MDI0NTRkZjJlNGYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9UZXN0UnVubmVyV2luLmNwcAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS93aW4vVGVzdFJ1bm5lcldpbi5jcHAKQEAgLTQ0OCw3ICs0NDgsNyBA QCB2b2lkIFRlc3RSdW5uZXI6OnNldERhdGFiYXNlUXVvdGEodW5zaWduZWQgbG9uZyBsb25nIHF1 b3RhKQogICAgIGlmIChGQUlMRUQodG1wRGF0YWJhc2VNYW5hZ2VyLT5zaGFyZWRXZWJEYXRhYmFz ZU1hbmFnZXIoJmRhdGFiYXNlTWFuYWdlcikpKQogICAgICAgICByZXR1cm47CiAKLSAgICBkYXRh YmFzZU1hbmFnZXItPnNldFF1b3RhKF9ic3RyX3QoImZpbGU6Ly8vIiksIHF1b3RhKTsKKyAgICBk YXRhYmFzZU1hbmFnZXItPnNldFF1b3RhKF9ic3RyX3QoTCJmaWxlOi8vLyIpLCBxdW90YSk7CiB9 CiAKIHZvaWQgVGVzdFJ1bm5lcjo6Z29CYWNrKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93 c2VyL3dpbi9NaW5pQnJvd3NlcldlYkhvc3QuY3BwIGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL01p bmlCcm93c2VyV2ViSG9zdC5jcHAKaW5kZXggN2ZlNzMyNDY3NDVlZjlmYzNjNzRhN2Q2NDUwNTNm MmFkOTQxZjdlYi4uYTYwNGI4Y2UxMmY5YTc5MWQ4ZWZhNjA5ZWU3YTQ4YzZiYTNkMmUyNiAxMDA2 NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHAKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL01pbmlCcm93c2VyV2ViSG9zdC5jcHAKQEAgLTE2Nyw3 ICsxNjcsOCBAQCBIUkVTVUxUIE1pbmlCcm93c2VyV2ViSG9zdDo6ZGlkRmluaXNoTG9hZEZvckZy YW1lKF9Jbl9vcHRfIElXZWJWaWV3KiB3ZWJWaWV3LCBfSQogICAgICAgICBtX2NsaWVudC0+c2hv d0xhc3RWaXNpdGVkU2l0ZXMoKndlYlZpZXcpOwogCiAgICAgLy8gVGhlIGZvbGxvd2luZyBpcyBm b3IgdGhlIHRlc3QgcGFnZToKLSAgICBIUkVTVUxUIGhyID0gZG9jLT5nZXRFbGVtZW50QnlJZChM IndlYmtpdCBsb2dvIiwgJmVsZW1lbnQuR2V0SW50ZXJmYWNlUHRyKCkpOworICAgIHN0YXRpYyBf YnN0cl90IGlkID0gTCJ3ZWJraXQgbG9nbyI7CisgICAgSFJFU1VMVCBociA9IGRvYy0+Z2V0RWxl bWVudEJ5SWQoaWQsICZlbGVtZW50LkdldEludGVyZmFjZVB0cigpKTsKICAgICBpZiAoIVNVQ0NF RURFRChocikpCiAgICAgICAgIHJldHVybiBocjsKIApAQCAtMTc1LDcgKzE3Niw5IEBAIEhSRVNV TFQgTWluaUJyb3dzZXJXZWJIb3N0OjpkaWRGaW5pc2hMb2FkRm9yRnJhbWUoX0luX29wdF8gSVdl YlZpZXcqIHdlYlZpZXcsIF9JCiAgICAgaWYgKCFTVUNDRUVERUQoaHIpKQogICAgICAgICByZXR1 cm4gaHI7CiAKLSAgICBociA9IHRhcmdldC0+YWRkRXZlbnRMaXN0ZW5lcihMImNsaWNrIiwgbmV3 IFNpbXBsZUV2ZW50TGlzdGVuZXIgKEwid2Via2l0IGxvZ28gY2xpY2siKSwgRkFMU0UpOworICAg IHN0YXRpYyBfYnN0cl90IGV2ZW50TmFtZSA9IEwiY2xpY2siOworICAgIHN0YXRpYyBfYnN0cl90 IGV2ZW50VHlwZSA9IEwid2Via2l0IGxvZ28gY2xpY2siOworICAgIGhyID0gdGFyZ2V0LT5hZGRF dmVudExpc3RlbmVyKGV2ZW50TmFtZSwgbmV3IFNpbXBsZUV2ZW50TGlzdGVuZXIoZXZlbnRUeXBl KSwgRkFMU0UpOwogICAgIGlmICghU1VDQ0VFREVEKGhyKSkKICAgICAgICAgcmV0dXJuIGhyOwog Cg==