193256 2019-01-08 14:36:11 -0800 Tweak wording for build/version_check style checker error 2019-01-09 15:33:05 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue ews-watchlist glenn lforschler simon.fraser thorton webkit-bug-importer oldest_to_newest 1492765 0 ap 2019-01-08 14:36:11 -0800 Cover more potential solutions. 1492768 1 358640 ap 2019-01-08 14:48:31 -0800 Created attachment 358640 proposed patch 1493141 2 358640 commit-queue 2019-01-09 15:30:24 -0800 Comment on attachment 358640 proposed patch Clearing flags on attachment: 358640 Committed r239789: <https://trac.webkit.org/changeset/239789> 1493142 3 commit-queue 2019-01-09 15:30:25 -0800 All reviewed patches have been landed. Closing bug. 1493143 4 webkit-bug-importer 2019-01-09 15:33:05 -0800 <rdar://problem/47161453> 358640 2019-01-08 14:48:31 -0800 2019-01-09 15:30:24 -0800 proposed patch OrInternal.txt text/plain 5850 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTc0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTAxLTA4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFR3ZWFrIHdvcmRpbmcgZm9yIGJ1aWxkL3ZlcnNpb25fY2hlY2sgc3R5bGUg Y2hlY2tlciBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkzMjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAg KGNoZWNrX29zX3ZlcnNpb25fY2hlY2tzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50 ZXN0X29zX3ZlcnNpb25fY2hlY2tzKToKKwogMjAxOS0wMS0wOCAgWmhpZmVpIEZhbmcgIDx6aGlm ZWlfZmFuZ0BhcHBsZS5jb20+CiAgIAogICAgICAgICBMYXlvdXQgdGVzdCB3aWxsIGdlbmVyYXRl IGEgcGVyZiBtZXRyaWMgZmlsZSB0byByZXN1bHRzIGRpci4KSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CShyZXZpc2lvbiAyMzk3MjYpCisrKyBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkod29ya2luZyBjb3B5 KQpAQCAtMTEyOCw3ICsxMTI4LDcgQEAgZGVmIGNoZWNrX29zX3ZlcnNpb25fY2hlY2tzKGZpbGVu YW1lLCBjbAogICAgICAgICByZXR1cm4KIAogICAgIGlmIF9SRV9QQVRURVJOX1hDT0RFX1ZFUlNJ T05fTUFDUk8ubWF0Y2gobGluZSk6Ci0gICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQv dmVyc2lvbl9jaGVjaycsIDUsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVz ZSBhIG5hbWVkIG1hY3JvIGluIHd0Zi9QbGF0Zm9ybS5oIG9yIHd0Zi9GZWF0dXJlRGVmaW5lcy5o LicpCisgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnYnVpbGQvdmVyc2lvbl9jaGVjaycsIDUs ICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3JvIGlu IHd0Zi9QbGF0Zm9ybS5oLCB3dGYvRmVhdHVyZURlZmluZXMuaCwgb3IgYW4gYXBwcm9wcmlhdGUg aW50ZXJuYWwgZmlsZS4nKQogCiBjbGFzcyBfQ2xhc3NJbmZvKG9iamVjdCk6CiAgICAgIiIiU3Rv cmVzIGluZm9ybWF0aW9uIGFib3V0IGEgY2xhc3MuIiIiCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQkocmV2aXNp b24gMjM5NzI2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTU1NzMsMTQgKzU1NzMsMTQgQEAgY2xhc3Mg V2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCdXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxLjIuMyksIGlvcyhXS19NQUNfVEJBKSknLCAn V0tfTUFDX1RCQSBpcyBuZWl0aGVyIGEgdmVyc2lvbiBudW1iZXIgbm9yIFdLX0lPU19UQkEgIFti dWlsZC93a19hcGlfYXZhaWxhYmxlXSBbNV0nKQogCiAgICAgZGVmIHRlc3Rfb3NfdmVyc2lvbl9j aGVja3Moc2VsZik6Ci0gICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNpZiBQTEFURk9STShJT1Nf RkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDExMDAwMCcsICdN aXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3JvIGluIHd0 Zi9QbGF0Zm9ybS5oIG9yIHd0Zi9GZWF0dXJlRGVmaW5lcy5oLiAgW2J1aWxkL3ZlcnNpb25fY2hl Y2tdIFs1XScpCi0gICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNpZiBQTEFURk9STShNQUMpICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDEzMDAnLCAnTWlzcGxhY2VkIE9T IHZlcnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0u aCBvciB3dGYvRmVhdHVyZURlZmluZXMuaC4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nKQor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19J UEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMTAwMDAnLCAnTWlzcGxhY2VkIE9TIHZl cnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0uaCwg d3RmL0ZlYXR1cmVEZWZpbmVzLmgsIG9yIGFuIGFwcHJvcHJpYXRlIGludGVybmFsIGZpbGUuICBb YnVpbGQvdmVyc2lvbl9jaGVja10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2lm IFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IDEwMTMw MCcsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVjay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3Jv IGluIHd0Zi9QbGF0Zm9ybS5oLCB3dGYvRmVhdHVyZURlZmluZXMuaCwgb3IgYW4gYXBwcm9wcmlh dGUgaW50ZXJuYWwgZmlsZS4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nKQogICAgICAgICBz ZWxmLmFzc2VydF9saW50KCcjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEIDwgMTAxMzAwJywgJycsICdTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oJykK ICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2lmIFBMQVRGT1JNKE1BQykgJiYgX19JUEhPTkVf T1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMjAwMDAnLCAnJywgJ1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCcjaWYgUExBVEZPUk0oTUFDKSAm JiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+IDEyMDQwMCcsICdJbmNvcnJlY3Qg T1MgdmVyc2lvbiBjaGVjay4gVkVSU0lPTl9NSU5fUkVRVUlSRUQgdmFsdWVzIG5ldmVyIGluY2x1 ZGUgYSBtaW5vciB2ZXJzaW9uLiBZb3UgbWF5IGJlIGxvb2tpbmcgZm9yIGEgY29tYmluYXRpb24g b2YgVkVSU0lPTl9NSU5fUkVRVUlSRUQgZm9yIHRhcmdldCBPUyB2ZXJzaW9uIGNoZWNrIGFuZCBW RVJTSU9OX01BWF9BTExPV0VEIGZvciBTREsgY2hlY2suICBbYnVpbGQvdmVyc2lvbl9jaGVja10g WzVdJywgJ1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgnKQotICAgICAgICBzZWxmLmFzc2VydF9s aW50KCcjaWYgIVRBUkdFVF9PU19TSU1VTEFUT1IgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9S RVFVSVJFRCA8IDUwMDAwJywgJ01pc3BsYWNlZCBPUyB2ZXJzaW9uIGNoZWNrLiBQbGVhc2UgdXNl IGEgbmFtZWQgbWFjcm8gaW4gd3RmL1BsYXRmb3JtLmggb3Igd3RmL0ZlYXR1cmVEZWZpbmVzLmgu ICBbYnVpbGQvdmVyc2lvbl9jaGVja10gWzVdJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn I2lmIChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFV SVJFRCA8IDExMDAwMCkgfHwgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA8IDEwMTMwNCknLCBbJ0luY29ycmVjdCBPUyB2ZXJzaW9uIGNoZWNrLiBWRVJT SU9OX01JTl9SRVFVSVJFRCB2YWx1ZXMgbmV2ZXIgaW5jbHVkZSBhIG1pbm9yIHZlcnNpb24uIFlv dSBtYXkgYmUgbG9va2luZyBmb3IgYSBjb21iaW5hdGlvbiBvZiBWRVJTSU9OX01JTl9SRVFVSVJF RCBmb3IgdGFyZ2V0IE9TIHZlcnNpb24gY2hlY2sgYW5kIFZFUlNJT05fTUFYX0FMTE9XRUQgZm9y IFNESyBjaGVjay4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nLCAnTWlzcGxhY2VkIE9TIHZl cnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0uaCBv ciB3dGYvRmVhdHVyZURlZmluZXMuaC4gIFtidWlsZC92ZXJzaW9uX2NoZWNrXSBbNV0nXSkKLSAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2RlZmluZSBGT08gKChQTEFURk9STShNQUMpICYmIF9f TUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDEzMDIgJiYgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDApKScsICdNaXNwbGFjZWQgT1MgdmVyc2lvbiBjaGVj ay4gUGxlYXNlIHVzZSBhIG5hbWVkIG1hY3JvIGluIHd0Zi9QbGF0Zm9ybS5oIG9yIHd0Zi9GZWF0 dXJlRGVmaW5lcy5oLiAgW2J1aWxkL3ZlcnNpb25fY2hlY2tdIFs1XScpCisgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoJyNpZiAhVEFSR0VUX09TX1NJTVVMQVRPUiAmJiBfX1dBVENIX09TX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIDwgNTAwMDAnLCAnTWlzcGxhY2VkIE9TIHZlcnNpb24gY2hlY2suIFBs ZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0uaCwgd3RmL0ZlYXR1cmVEZWZp bmVzLmgsIG9yIGFuIGFwcHJvcHJpYXRlIGludGVybmFsIGZpbGUuICBbYnVpbGQvdmVyc2lvbl9j aGVja10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnI2lmIChQTEFURk9STShJT1Nf RkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDExMDAwMCkgfHwg KFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTMw NCknLCBbJ0luY29ycmVjdCBPUyB2ZXJzaW9uIGNoZWNrLiBWRVJTSU9OX01JTl9SRVFVSVJFRCB2 YWx1ZXMgbmV2ZXIgaW5jbHVkZSBhIG1pbm9yIHZlcnNpb24uIFlvdSBtYXkgYmUgbG9va2luZyBm b3IgYSBjb21iaW5hdGlvbiBvZiBWRVJTSU9OX01JTl9SRVFVSVJFRCBmb3IgdGFyZ2V0IE9TIHZl cnNpb24gY2hlY2sgYW5kIFZFUlNJT05fTUFYX0FMTE9XRUQgZm9yIFNESyBjaGVjay4gIFtidWls ZC92ZXJzaW9uX2NoZWNrXSBbNV0nLCAnTWlzcGxhY2VkIE9TIHZlcnNpb24gY2hlY2suIFBsZWFz ZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0uaCwgd3RmL0ZlYXR1cmVEZWZpbmVz LmgsIG9yIGFuIGFwcHJvcHJpYXRlIGludGVybmFsIGZpbGUuICBbYnVpbGQvdmVyc2lvbl9jaGVj a10gWzVdJ10pCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyNkZWZpbmUgRk9PICgoUExBVEZP Uk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTAxMzAyICYmIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAwKSknLCAnTWlzcGxhY2VkIE9T IHZlcnNpb24gY2hlY2suIFBsZWFzZSB1c2UgYSBuYW1lZCBtYWNybyBpbiB3dGYvUGxhdGZvcm0u aCwgd3RmL0ZlYXR1cmVEZWZpbmVzLmgsIG9yIGFuIGFwcHJvcHJpYXRlIGludGVybmFsIGZpbGUu ICBbYnVpbGQvdmVyc2lvbl9jaGVja10gWzVdJykKIAogICAgIGRlZiB0ZXN0X290aGVyKHNlbGYp OgogICAgICAgICAjIEZJWE1FOiBJbXBsZW1lbnQgdGhpcy4K