193238 2019-01-08 08:25:12 -0800 [iOS] editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html often times out in internal automation 2019-01-09 07:25:28 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1492603 0 wenson_hsieh 2019-01-08 08:25:12 -0800 The layout test editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html occasionally times out in internal automation. 1492777 1 wenson_hsieh 2019-01-08 15:15:25 -0800 I can reproduce this timeout locally once every 100-or-so runs (using --repeat-each). 1492794 2 wenson_hsieh 2019-01-08 16:07:24 -0800 From logging captured during one of these failures, it looks like we're sending the right information (i.e. caret rect) to the UI process and then telling our text interaction assistant to re-layout its subviews, but for some reason the caret view doesn't appear in the view hierarchy after all this. 1492861 3 wenson_hsieh 2019-01-08 20:59:51 -0800 ...as it turns out, I did *not* intend for runTest() to be invoked twice in this layout test 🤦🏻‍♂️ addEventListener("load", runTest); jsTestIsAsync = true; … async function runTest() { … } </script> </head> <body> … <iframe id="frame" srcdoc="<textarea id='editor'></textarea>" onload="runTest()"> Removing the redundant onload="runTest()" from the iframe element fixes the flakiness for me locally. 1492862 4 358669 wenson_hsieh 2019-01-08 21:04:26 -0800 Created attachment 358669 Patch 1492932 5 358669 wenson_hsieh 2019-01-09 06:58:35 -0800 Comment on attachment 358669 Patch Thanks for the review! 1492941 6 358669 commit-queue 2019-01-09 07:24:44 -0800 Comment on attachment 358669 Patch Clearing flags on attachment: 358669 Committed r239771: <https://trac.webkit.org/changeset/239771> 1492942 7 commit-queue 2019-01-09 07:24:45 -0800 All reviewed patches have been landed. Closing bug. 1492944 8 webkit-bug-importer 2019-01-09 07:25:28 -0800 <rdar://problem/47146052> 358669 2019-01-08 21:04:26 -0800 2019-01-09 07:24:44 -0800 Patch bug-193238-20190108210425.patch text/plain 1943 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjEzMTY5NTlhYjdkYTNjODk1YWFh YTc3YmYyMTEyNzY1MDcyYWU2NC4uOTU1MzU4YWMyMDViMDRmMmJhMDNmNDU1NmE0ZGUxYWNlYjUy MTVhYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAxLTA4ICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGVkaXRpbmcvc2VsZWN0aW9u L2lvcy9zaG93LXNlbGVjdGlvbi1pbi1lbXB0eS1vdmVyZmxvdy1oaWRkZW4tZG9jdW1lbnQuaHRt bCBvZnRlbiB0aW1lcyBvdXQgaW4gaW50ZXJuYWwgYXV0b21hdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMjM4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgZmxha3kgbGF5b3V0IHRlc3Qg dGhhdCBjdXJyZW50bHkgYXR0ZW1wdHMgdG8gcnVuIHRoZSBtYWluIGxvZ2ljIG9mIHRoZSB0ZXN0 IHR3aWNlIChvbmNlIGFmdGVyIHRoZSBjaGlsZAorICAgICAgICBmcmFtZSBmaW5pc2hlcyBsb2Fk aW5nLCBhbmQgYW5vdGhlciB0aW1lIGFmdGVyIHRoZSBtYWluIGRvY3VtZW50IGZpbmlzaGVzIGxv YWRpbmcpLiBUaGlzIGxlYWRzIHRvIGEgcmFjZQorICAgICAgICBjb25kaXRpb24gaW4gdGhlIHRl c3Qgd2hlcmUgdGhlIGluY29ycmVjdCB0ZXh0IGZpZWxkIGlzIGZvY3VzZWQsIGNhdXNpbmcgdGhl IGNhcmV0IHJlY3QgdG8gZGV2aWF0ZSBmcm9tIHRoZQorICAgICAgICBleHBlY3RlZCB2YWx1ZS4K KworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9zaG93LXNlbGVjdGlvbi1pbi1lbXB0 eS1vdmVyZmxvdy1oaWRkZW4tZG9jdW1lbnQuaHRtbDoKKwogMjAxOS0wMS0wOCAgSmlld2VuIFRh biAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJBdXRoTl0gU3VwcG9ydCBV MkYgSElEIEF1dGhlbnRpY2F0b3JzIG9uIG1hY09TCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9l ZGl0aW5nL3NlbGVjdGlvbi9pb3Mvc2hvdy1zZWxlY3Rpb24taW4tZW1wdHktb3ZlcmZsb3ctaGlk ZGVuLWRvY3VtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9pb3Mvc2hv dy1zZWxlY3Rpb24taW4tZW1wdHktb3ZlcmZsb3ctaGlkZGVuLWRvY3VtZW50Lmh0bWwKaW5kZXgg NDdlMDQ1MzYwNzgzYzdjNjA1ODA5MjAwOTE2NjRiMGViODE1Y2M2ZC4uODZjMGVkYzc3NjkxZTM4 NDNmMjRiMWI5YzAzYjg2YzllZTMxNWMzYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZWRpdGlu Zy9zZWxlY3Rpb24vaW9zL3Nob3ctc2VsZWN0aW9uLWluLWVtcHR5LW92ZXJmbG93LWhpZGRlbi1k b2N1bWVudC5odG1sCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2lvcy9zaG93 LXNlbGVjdGlvbi1pbi1lbXB0eS1vdmVyZmxvdy1oaWRkZW4tZG9jdW1lbnQuaHRtbApAQCAtODgs NyArODgsNyBAQCBhc3luYyBmdW5jdGlvbiBydW5UZXN0KCkgewogPC9idXR0b24+CiA8ZGl2IGlk PSJjb250YWluZXIiPgogICAgIDx0ZXh0YXJlYSBpZD0iZWRpdG9yIj48L3RleHRhcmVhPgotICAg IDxpZnJhbWUgaWQ9ImZyYW1lIiBzcmNkb2M9Ijx0ZXh0YXJlYSBpZD0nZWRpdG9yJz48L3RleHRh cmVhPiIgb25sb2FkPSJydW5UZXN0KCkiPjwvaWZyYW1lPgorICAgIDxpZnJhbWUgaWQ9ImZyYW1l IiBzcmNkb2M9Ijx0ZXh0YXJlYSBpZD0nZWRpdG9yJz48L3RleHRhcmVhPiI+PC9pZnJhbWU+CiA8 L2Rpdj4KIDxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rpdj4KIDxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2Pgo=