193235 2019-01-08 07:15:39 -0800 [ews-build] use patch_id instead of ewspatchid 2019-01-09 13:59:32 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue lforschler webkit-bug-importer oldest_to_newest 1492588 0 aakash_jain 2019-01-08 07:15:39 -0800 Since patch_id generated by bugzilla is unique, we decided to use the same patch_id as a unique identifier for patch in EWS, instead of generating our own id (ewspatchid). We should replace ewspatchid with patch_id. 1492591 1 358587 aakash_jain 2019-01-08 07:20:19 -0800 Created attachment 358587 Proposed patch 1493069 2 358587 commit-queue 2019-01-09 13:57:01 -0800 Comment on attachment 358587 Proposed patch Clearing flags on attachment: 358587 Committed r239782: <https://trac.webkit.org/changeset/239782> 1493070 3 commit-queue 2019-01-09 13:57:03 -0800 All reviewed patches have been landed. Closing bug. 1493074 4 webkit-bug-importer 2019-01-09 13:59:32 -0800 <rdar://problem/47157858> 358587 2019-01-08 07:20:19 -0800 2019-01-09 13:57:01 -0800 Proposed patch ews-build-ewspatchid.patch text/plain 6083 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTcyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB1c2UgcGF0Y2hfaWQgaW5zdGVhZCBvZiBld3NwYXRj aGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMy MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6IFJlcGxhY2VkIGV3c3BhdGNo aWQgd2l0aCBwYXRjaF9pZC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHk6IERpdHRvLgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weTogRGl0dG8uCisKIDIwMTktMDEtMDcgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBMZWFrIG9mIFNjcm9sbENvbXBsZXRpb25DYWxs YmFja0RhdGEgKDE2IGJ5dGVzKSBpbiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgcnVubmlu ZyBXZWJLaXQgbGF5b3V0IHRlc3RzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHJldmlzaW9uIDIzOTcyMykKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTc5 LDcgKzc5LDcgQEAgY2xhc3MgQnVpbGRGYWN0b3J5KEZhY3RvcnkpOgogCiAgICAgZGVmIHByb3Bl cnRpZXNUb1Bhc3NUb1RyaWdnZXJzKHNlbGYpOgogICAgICAgICByZXR1cm4gewotICAgICAgICAg ICAgImV3c3BhdGNoaWQiOiBQcm9wZXJ0eSgiZXdzcGF0Y2hpZCIpLAorICAgICAgICAgICAgInBh dGNoX2lkIjogUHJvcGVydHkoInBhdGNoX2lkIiksCiAgICAgICAgICAgICAiY29uZmlndXJhdGlv biI6IFByb3BlcnR5KCJjb25maWd1cmF0aW9uIiksCiAgICAgICAgICAgICAicGxhdGZvcm0iOiBQ cm9wZXJ0eSgicGxhdGZvcm0iKSwKICAgICAgICAgICAgICJmdWxsUGxhdGZvcm0iOiBQcm9wZXJ0 eSgiZnVsbFBsYXRmb3JtIiksCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyMzk3MjMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTYyNyw3ICs2MjcsNyBAQCBj bGFzcyBBcmNoaXZlQnVpbHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tCiBjbGFzcyBVcGxvYWRCdWls dFByb2R1Y3QodHJhbnNmZXIuRmlsZVVwbG9hZCk6CiAgICAgbmFtZSA9ICd1cGxvYWQtYnVpbHQt cHJvZHVjdCcKICAgICB3b3JrZXJzcmMgPSBXaXRoUHJvcGVydGllcygnV2ViS2l0QnVpbGQvJShj b25maWd1cmF0aW9uKXMuemlwJykKLSAgICBtYXN0ZXJkZXN0ID0gV2l0aFByb3BlcnRpZXMoJ3B1 YmxpY19odG1sL2FyY2hpdmVzLyUoZnVsbFBsYXRmb3JtKXMtJShhcmNoaXRlY3R1cmUpcy0lKGNv bmZpZ3VyYXRpb24pcy8lKGV3c3BhdGNoaWQpcy56aXAnKQorICAgIG1hc3RlcmRlc3QgPSBXaXRo UHJvcGVydGllcygncHVibGljX2h0bWwvYXJjaGl2ZXMvJShmdWxsUGxhdGZvcm0pcy0lKGFyY2hp dGVjdHVyZSlzLSUoY29uZmlndXJhdGlvbilzLyUocGF0Y2hfaWQpcy56aXAnKQogICAgIGhhbHRP bkZhaWx1cmUgPSBUcnVlCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgKiprd2FyZ3MpOgpAQCAt NjQxLDcgKzY0MSw3IEBAIGNsYXNzIFVwbG9hZEJ1aWx0UHJvZHVjdCh0cmFuc2Zlci5GaWxlVXAK IGNsYXNzIERvd25sb2FkQnVpbHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgY29t bWFuZCA9IFsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2Rvd25sb2FkLWJ1aWx0 LXByb2R1Y3QnLAogICAgICAgICBXaXRoUHJvcGVydGllcygnLS1wbGF0Zm9ybT0lKHBsYXRmb3Jt KXMnKSwgV2l0aFByb3BlcnRpZXMoJy0tJShjb25maWd1cmF0aW9uKXMnKSwKLSAgICAgICAgV2l0 aFByb3BlcnRpZXMoRVdTX1VSTCArICdhcmNoaXZlcy8lKGZ1bGxQbGF0Zm9ybSlzLSUoYXJjaGl0 ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMvJShld3NwYXRjaGlkKXMuemlwJyldCisgICAgICAg IFdpdGhQcm9wZXJ0aWVzKEVXU19VUkwgKyAnYXJjaGl2ZXMvJShmdWxsUGxhdGZvcm0pcy0lKGFy Y2hpdGVjdHVyZSlzLSUoY29uZmlndXJhdGlvbilzLyUocGF0Y2hfaWQpcy56aXAnKV0KICAgICBu YW1lID0gJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnCiAgICAgZGVzY3JpcHRpb24gPSBbJ2Rvd25s b2FkaW5nIGJ1aWx0IHByb2R1Y3QnXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsnZG93bmxvYWRl ZCBidWlsdCBwcm9kdWN0J10KQEAgLTY5NCw3ICs2OTQsNyBAQCBjbGFzcyBBcmNoaXZlVGVzdFJl c3VsdHMoc2hlbGwuU2hlbGxDb21tCiBjbGFzcyBVcGxvYWRUZXN0UmVzdWx0cyh0cmFuc2Zlci5G aWxlVXBsb2FkKToKICAgICBuYW1lID0gJ3VwbG9hZC10ZXN0LXJlc3VsdHMnCiAgICAgd29ya2Vy c3JjID0gJ2xheW91dC10ZXN0LXJlc3VsdHMuemlwJwotICAgIG1hc3RlcmRlc3QgPSBJbnRlcnBv bGF0ZSgncHVibGljX2h0bWwvcmVzdWx0cy8lKHByb3A6YnVpbGRlcm5hbWUpcy9yJShwcm9wOmV3 c3BhdGNoaWQpcy0lKHByb3A6YnVpbGRudW1iZXIpcy56aXAnKQorICAgIG1hc3RlcmRlc3QgPSBJ bnRlcnBvbGF0ZSgncHVibGljX2h0bWwvcmVzdWx0cy8lKHByb3A6YnVpbGRlcm5hbWUpcy9yJShw cm9wOnBhdGNoX2lkKXMtJShwcm9wOmJ1aWxkbnVtYmVyKXMuemlwJykKICAgICBoYWx0T25GYWls dXJlID0gVHJ1ZQogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsICoqa3dhcmdzKToKQEAgLTcwNyw4 ICs3MDcsOCBAQCBjbGFzcyBVcGxvYWRUZXN0UmVzdWx0cyh0cmFuc2Zlci5GaWxlVXBsCiAKIGNs YXNzIEV4dHJhY3RUZXN0UmVzdWx0cyhtYXN0ZXIuTWFzdGVyU2hlbGxDb21tYW5kKToKICAgICBu YW1lID0gJ2V4dHJhY3QtdGVzdC1yZXN1bHRzJwotICAgIHppcEZpbGUgPSBJbnRlcnBvbGF0ZSgn cHVibGljX2h0bWwvcmVzdWx0cy8lKHByb3A6YnVpbGRlcm5hbWUpcy9yJShwcm9wOmV3c3BhdGNo aWQpcy0lKHByb3A6YnVpbGRudW1iZXIpcy56aXAnKQotICAgIHJlc3VsdERpcmVjdG9yeSA9IElu dGVycG9sYXRlKCdwdWJsaWNfaHRtbC9yZXN1bHRzLyUocHJvcDpidWlsZGVybmFtZSlzL3IlKHBy b3A6ZXdzcGF0Y2hpZClzLSUocHJvcDpidWlsZG51bWJlcilzJykKKyAgICB6aXBGaWxlID0gSW50 ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1lKXMvciUocHJv cDpwYXRjaF9pZClzLSUocHJvcDpidWlsZG51bWJlcilzLnppcCcpCisgICAgcmVzdWx0RGlyZWN0 b3J5ID0gSW50ZXJwb2xhdGUoJ3B1YmxpY19odG1sL3Jlc3VsdHMvJShwcm9wOmJ1aWxkZXJuYW1l KXMvciUocHJvcDpwYXRjaF9pZClzLSUocHJvcDpidWlsZG51bWJlcilzJykKIAogICAgIGRlc2Ny aXB0aW9uRG9uZSA9IFsndXBsb2FkZWQgcmVzdWx0cyddCiAgICAgY29tbWFuZCA9IFsndW56aXAn LCB6aXBGaWxlLCAnLWQnLCByZXN1bHREaXJlY3RvcnldCkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAy Mzk3MjMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRl c3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTg3Miw3ICs4NzIsNyBAQCBjbGFzcyBUZXN0VXBsb2Fk QnVpbHRQcm9kdWN0KEJ1aWxkU3RlcE1pCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Z1bGxQ bGF0Zm9ybScsICdtYWMtc2llcnJhJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmln dXJhdGlvbicsICdyZWxlYXNlJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYXJjaGl0ZWN0 dXJlJywgJ3g4Nl82NCcpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2V3c3BhdGNoaWQnLCAn MTIzNCcpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEyMzQnKQogICAg ICAgICBzZWxmLmV4cGVjdEhpZGRlbihGYWxzZSkKICAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVD b21tYW5kcygKICAgICAgICAgICAgIEV4cGVjdCgndXBsb2FkRmlsZScsIGRpY3QoCkBAIC0xMTgw LDcgKzExODAsNyBAQCBjbGFzcyBUZXN0VXBsb2FkVGVzdFJlc3VsdHMoQnVpbGRTdGVwTWl4CiAg ICAgICAgIHNlbGYuc2V0dXBTdGVwKFVwbG9hZFRlc3RSZXN1bHRzKCkpCiAgICAgICAgIHNlbGYu c2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nLCAncmVsZWFzZScpCiAgICAgICAgIHNlbGYuc2V0 UHJvcGVydHkoJ2FyY2hpdGVjdHVyZScsICd4ODZfNjQnKQotICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdld3NwYXRjaGlkJywgJzEyMzQnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdwYXRj aF9pZCcsICcxMjM0JykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAn bWFjT1MtU2llcnJhLVJlbGVhc2UtV0syLVRlc3RzLUVXUycpCiAgICAgICAgIHNlbGYuc2V0UHJv cGVydHkoJ2J1aWxkbnVtYmVyJywgJzEyJykKICAgICAgICAgc2VsZi5leHBlY3RIaWRkZW4oRmFs c2UpCkBAIC0xMjEwLDcgKzEyMTAsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1 aWxkU3RlcE1pCiAgICAgZGVmIHRlc3Rfc3VjY2VzcyhzZWxmKToKICAgICAgICAgc2VsZi5zZXR1 cFN0ZXAoRXh0cmFjdFRlc3RSZXN1bHRzKCkpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2Nv bmZpZ3VyYXRpb24nLCAncmVsZWFzZScpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2V3c3Bh dGNoaWQnLCAnMTIzNCcpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEy MzQnKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdtYWNPUy1TaWVy cmEtUmVsZWFzZS1XSzItVGVzdHMtRVdTJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVp bGRudW1iZXInLCAnMTInKQogICAgICAgICBzZWxmLmV4cGVjdExvY2FsQ29tbWFuZHMoCkBAIC0x MjI4LDcgKzEyMjgsNyBAQCBjbGFzcyBUZXN0RXh0cmFjdFRlc3RSZXN1bHRzKEJ1aWxkU3RlcE1p CiAgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKICAgICAgICAgc2VsZi5zZXR1cFN0ZXAoRXh0 cmFjdFRlc3RSZXN1bHRzKCkpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRp b24nLCAnZGVidWcnKQotICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdld3NwYXRjaGlkJywgJzEy MzQnKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdwYXRjaF9pZCcsICcxMjM0JykKICAgICAg ICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnbWFjT1MtU2llcnJhLVJlbGVhc2Ut V0syLVRlc3RzLUVXUycpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkbnVtYmVyJywg JzEyJykKICAgICAgICAgc2VsZi5leHBlY3RMb2NhbENvbW1hbmRzKAo=