193234 2019-01-08 07:10:58 -0800 [ews-build] unapply-patch step should not update source 2019-01-17 05:55:27 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1492586 0 aakash_jain 2019-01-08 07:10:58 -0800 Currently unapply-patch step uses buildbot git methods with alwaysUseLatest=True. This cleans the working directory, but also updates the repository. We should not pull down new source changes. 1492587 1 358586 aakash_jain 2019-01-08 07:12:54 -0800 Created attachment 358586 Proposed patch 1492589 2 ews-watchlist 2019-01-08 07:16:10 -0800 Attachment 358586 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:108: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1492593 3 358588 aakash_jain 2019-01-08 07:25:14 -0800 Created attachment 358588 Proposed patch 1492931 4 aakash_jain 2019-01-09 06:30:02 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/25/builds/984 1493053 5 358588 lforschler 2019-01-09 13:19:45 -0800 Comment on attachment 358588 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=358588&action=review r=me with typo fix. > Tools/BuildSlaveSupport/ews-build/steps.py:111 > + description = ['clean-workring-directory running'] typo: working 1495444 6 aakash_jain 2019-01-17 05:54:05 -0800 Committed r240107: <https://trac.webkit.org/changeset/240107> 1495445 7 webkit-bug-importer 2019-01-17 05:55:27 -0800 <rdar://problem/47349291> 358586 2019-01-08 07:12:54 -0800 2019-01-08 07:25:14 -0800 Proposed patch ews-build-clean-webkit.patch text/plain 1831 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTcyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB1bmFwcGx5LXBhdGNoIHN0ZXAgc2hvdWxkIG5vdCB1 cGRhdGUgc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTMyMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENs ZWFuV29ya2luZ0RpcmVjdG9yeSk6IFVzZSBjbGVhbi13ZWJraXQgc2NyaXB0IHRvIGNsZWFuIHRo ZSB3b3JraW5nIGRpcmVjdG9yeS4KKyAgICAgICAgKFVuQXBwbHlQYXRjaElmUmVxdWlyZWQpOiBV c2UgQ2xlYW5Xb3JraW5nRGlyZWN0b3J5IGFzIGJhc2UgY2xhc3MuCisKIDIwMTktMDEtMDcgIERh dmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBMZWFrIG9mIFNjcm9s bENvbXBsZXRpb25DYWxsYmFja0RhdGEgKDE2IGJ5dGVzKSBpbiBjb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQgcnVubmluZyBXZWJLaXQgbGF5b3V0IHRlc3RzCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyMzk3MjMpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTEwNSw2ICsxMDUsMTQgQEAgY2xhc3MgQ2hlY2tPdXRTb3VyY2UoZ2l0LkdpdCk6CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9ncmVzcz1UcnVlLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKiprd2FyZ3Mp CiAKK2NsYXNzIENsZWFuV29ya2luZ0RpcmVjdG9yeShzaGVsbC5TaGVsbENvbW1hbmQpOgorICAg IG5hbWUgPSAnY2xlYW4td29ya2luZy1kaXJlY3RvcnknCisgICAgZGVzY3JpcHRpb24gPSBbJ2Ns ZWFuLXdvcmtyaW5nLWRpcmVjdG9yeSBydW5uaW5nJ10KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBb J2NsZWFuLXdvcmtpbmctZGlyZWN0b3J5J10KKyAgICBmbHVua09uRmFpbHVyZSA9IFRydWUKKyAg ICBoYWx0T25GYWlsdXJlID0gVHJ1ZQorICAgIGNvbW1hbmQgPSBbJ1Rvb2xzL1NjcmlwdHMvY2xl YW4td2Via2l0J10KKwogCiBjbGFzcyBBcHBseVBhdGNoKHNoZWxsLlNoZWxsQ29tbWFuZCwgQ29t cG9zaXRlU3RlcE1peGluKToKICAgICBuYW1lID0gJ2FwcGx5LXBhdGNoJwpAQCAtMzUzLDcgKzM2 MSw3IEBAIGNsYXNzIFZhbGlkYXRlUGF0Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCkKICAgICAgICAg cmV0dXJuIE5vbmUKIAogCi1jbGFzcyBVbkFwcGx5UGF0Y2hJZlJlcXVpcmVkKENoZWNrT3V0U291 cmNlKToKK2NsYXNzIFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoQ2xlYW5Xb3JraW5nRGlyZWN0b3J5 KToKICAgICBuYW1lID0gJ3VuYXBwbHktcGF0Y2gnCiAKICAgICBkZWYgZG9TdGVwSWYoc2VsZiwg c3RlcCk6Cg== 358588 2019-01-08 07:25:14 -0800 2019-01-17 05:54:21 -0800 Proposed patch ews-build-clean-webkit-v2.patch text/plain 1807 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTcyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB1bmFwcGx5LXBhdGNoIHN0ZXAgc2hvdWxkIG5vdCB1 cGRhdGUgc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTMyMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENs ZWFuV29ya2luZ0RpcmVjdG9yeSk6IFVzZSBjbGVhbi13ZWJraXQgc2NyaXB0IHRvIGNsZWFuIHRo ZSB3b3JraW5nIGRpcmVjdG9yeS4KKyAgICAgICAgKFVuQXBwbHlQYXRjaElmUmVxdWlyZWQpOiBV c2UgQ2xlYW5Xb3JraW5nRGlyZWN0b3J5IGFzIGJhc2UgY2xhc3MuCisKIDIwMTktMDEtMDcgIERh dmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBMZWFrIG9mIFNjcm9s bENvbXBsZXRpb25DYWxsYmFja0RhdGEgKDE2IGJ5dGVzKSBpbiBjb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQgcnVubmluZyBXZWJLaXQgbGF5b3V0IHRlc3RzCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyMzk3MjMpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTEwNiw2ICsxMDYsMTUgQEAgY2xhc3MgQ2hlY2tPdXRTb3VyY2UoZ2l0LkdpdCk6CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqKmt3YXJncykKIAogCitj bGFzcyBDbGVhbldvcmtpbmdEaXJlY3Rvcnkoc2hlbGwuU2hlbGxDb21tYW5kKToKKyAgICBuYW1l ID0gJ2NsZWFuLXdvcmtpbmctZGlyZWN0b3J5JworICAgIGRlc2NyaXB0aW9uID0gWydjbGVhbi13 b3JrcmluZy1kaXJlY3RvcnkgcnVubmluZyddCisgICAgZGVzY3JpcHRpb25Eb25lID0gWydjbGVh bi13b3JraW5nLWRpcmVjdG9yeSddCisgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCisgICAgaGFs dE9uRmFpbHVyZSA9IFRydWUKKyAgICBjb21tYW5kID0gWydUb29scy9TY3JpcHRzL2NsZWFuLXdl YmtpdCddCisKKwogY2xhc3MgQXBwbHlQYXRjaChzaGVsbC5TaGVsbENvbW1hbmQsIENvbXBvc2l0 ZVN0ZXBNaXhpbik6CiAgICAgbmFtZSA9ICdhcHBseS1wYXRjaCcKICAgICBkZXNjcmlwdGlvbiA9 IFsnYXBwbHlpbmctcGF0Y2gnXQpAQCAtMzUzLDcgKzM2Miw3IEBAIGNsYXNzIFZhbGlkYXRlUGF0 Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCkKICAgICAgICAgcmV0dXJuIE5vbmUKIAogCi1jbGFzcyBV bkFwcGx5UGF0Y2hJZlJlcXVpcmVkKENoZWNrT3V0U291cmNlKToKK2NsYXNzIFVuQXBwbHlQYXRj aElmUmVxdWlyZWQoQ2xlYW5Xb3JraW5nRGlyZWN0b3J5KToKICAgICBuYW1lID0gJ3VuYXBwbHkt cGF0Y2gnCiAKICAgICBkZWYgZG9TdGVwSWYoc2VsZiwgc3RlcCk6Cg==