193224 2019-01-07 16:44:48 -0800 [PSON] REGRESSION (r239182): Blank view when navigating back and forth between google.com and stack overflow 2019-01-08 10:00:00 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 192668 1 cdumez cdumez achristensen beidson dbates ews-watchlist ggaren japhet koivisto webkit-bug-importer youennf oldest_to_newest 1492493 0 cdumez 2019-01-07 16:44:48 -0800 Reproduction steps: 1. Load google.com in a tab 2. Paste and load “https://stackoverflow.com/questions/32639263/changed-load-method-order-in-xcode-7/33851001#33851001” in the URL bar in the same tab 3. Press “Back” button in Safari to go back to Google.com 4. Press “Forward” button in Safari to go back to stackoverflow.com -> Notice that the view is blank instead of showing stackoverflow.com. 1492494 1 cdumez 2019-01-07 16:45:02 -0800 <rdar://problem/47097726> 1492495 2 358557 cdumez 2019-01-07 16:50:01 -0800 Created attachment 358557 Patch 1492496 3 ews-watchlist 2019-01-07 16:52:25 -0800 Attachment 358557 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:688: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:690: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1492634 4 358557 cdumez 2019-01-08 09:59:58 -0800 Comment on attachment 358557 Patch Clearing flags on attachment: 358557 Committed r239726: <https://trac.webkit.org/changeset/239726> 1492635 5 cdumez 2019-01-08 10:00:00 -0800 All reviewed patches have been landed. Closing bug. 358557 2019-01-07 16:50:01 -0800 2019-01-08 09:59:58 -0800 Patch bug-193224-20190107165000.patch text/plain 6051 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk4NzU2ZmRmYTZiZjRj Njc1NmU3ZWJiNmViYjcyZjM3YWY0ZmZkMi4uMzdjZTM2M2Y5YTFhM2M1MDVlM2Y5ZDk3NzMyNmJj ZmFmZDVkN2FlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAxLTA3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihQU09OLXIy MzkxODIpOiBCbGFuayB2aWV3IHdoZW4gbmF2aWdhdGluZyBiYWNrIGFuZCBmb3J0aCBiZXR3ZWVu IGdvb2dsZS5jb20gYW5kIHN0YWNrIG92ZXJmbG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMyMjQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3 MDk3NzI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNpbmNlIHIyMzkxODIsIHBhZ2VzIGdldCBzdXNwZW5kZWQgaW4tcGxhY2Ugd2hlbiB3ZSBzdXNw ZW5kIHRoZSBvbGQgcHJvY2VzcyBhZnRlciBhIHByb2Nlc3Mtc3dhcCBvbiBuYXZpZ2F0aW9uLgor ICAgICAgICBXaGVuIHdlIHJldHVybiB0byBhIHN1c3BlbmRlZCBwYWdlLCB3ZSBsb2FkIHRoZSBj dXJyZW50IGhpc3RvcnkgaXRlbSBhZ2FpbiBhbmQgaXQgbm9ybWFsbHkgcHJvcGVybHkgcmVzdG9y ZXMKKyAgICAgICAgdGhlIHBhZ2UgZnJvbSBQYWdlQ2FjaGUsIGV2ZW4gdGhvdWdoIHdlIGxvYWQg dGhlIHNhbWUgaGlzdG9yeSBpdGVtIGFuZCB0aGUgY3VycmVudCBvbmUgYW5kIGV2ZW4gdGhvdWdo IHRoZQorICAgICAgICBwYWdlIGlzIHN1c3BlbmRlZCBpbi1wbGFjZSAoaS5lLiB3ZSBkaWQgbm90 IG5hdmlnYXRlIGF3YXksIHdoaWNoIGlzIHRoZSB1c3VhbCBjYXNlIGZvciBwYWdlIGNhY2hlKS4K KworICAgICAgICBUaGUgaXNzdWUgaXMgdGhhdCBpZiB0aGUgcGFnZSBVUkwgY29udGFpbnMgYSBm cmFnbWVudCwgRnJhbWVMb2FkZXI6OnNob3VsZFBlcmZvcm1GcmFnbWVudE5hdmlnYXRpb24oKSB3 b3VsZAorICAgICAgICByZXR1cm4gdHJ1ZSBiZWNhdXNlIGJvdGggdGhlIHNvdXJjZSBhbmQgZGVz dGluYXRpb24gVVJMcyAod2hpY2ggYXJlIHRoZSBzYW1lKSBjb250YWlucyBhIGZyYWdtZW50LiBU byBhZGRyZXNzCisgICAgICAgIHRoZSBpc3N1ZSwgdXBkYXRlIEZyYW1lTG9hZGVyOjpzaG91bGRQ ZXJmb3JtRnJhZ21lbnROYXZpZ2F0aW9uKCkgdG8gcmV0dXJuIGZhbHNlIGlmIHRoZSBjdXJyZW50 IHBhZ2UgaXMKKyAgICAgICAgc3VzcGVuZGVkLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpzaG91bGRQZXJmb3JtRnJh Z21lbnROYXZpZ2F0aW9uKToKKwogMjAxOS0wMS0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFByZXZlbnQgY3Jvc3Mtc2l0ZSB0b3AtbGV2ZWwgbmF2aWdhdGlv bnMgZnJvbSB0aGlyZC1wYXJ0eSBpZnJhbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAppbmRleCA1MWJiOTQ4OGU1OWM3ZGYzYjYzM2EwMjA1OWRiMTJmOTFjMzIwOGYxLi40YzI2 YTY5ODFiNDY0ZGE1OTE2ZjA1ZWI3MzU5NjY5MTU3ZWU5ZmZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAKQEAgLTMxMzQsNiArMzEzNCw3IEBAIGJvb2wgRnJhbWVMb2FkZXI6 OnNob3VsZFBlcmZvcm1GcmFnbWVudE5hdmlnYXRpb24oYm9vbCBpc0Zvcm1TdWJtaXNzaW9uLCBj b25zdCBTCiAgICAgcmV0dXJuICghaXNGb3JtU3VibWlzc2lvbiB8fCBlcXVhbExldHRlcnNJZ25v cmluZ0FTQ0lJQ2FzZShodHRwTWV0aG9kLCAiZ2V0IikpCiAgICAgICAgICYmICFpc1JlbG9hZChs b2FkVHlwZSkKICAgICAgICAgJiYgbG9hZFR5cGUgIT0gRnJhbWVMb2FkVHlwZTo6U2FtZQorICAg ICAgICAmJiBtX2ZyYW1lLmRvY3VtZW50KCktPnBhZ2VDYWNoZVN0YXRlKCkgIT0gRG9jdW1lbnQ6 OkluUGFnZUNhY2hlCiAgICAgICAgICYmICFzaG91bGRSZWxvYWQobV9mcmFtZS5kb2N1bWVudCgp LT51cmwoKSwgdXJsKQogICAgICAgICAvLyBXZSBkb24ndCB3YW50IHRvIGp1c3Qgc2Nyb2xsIGlm IGEgbGluayBmcm9tIHdpdGhpbiBhCiAgICAgICAgIC8vIGZyYW1lc2V0IGlzIHRyeWluZyB0byBy ZWxvYWQgdGhlIGZyYW1lc2V0IGludG8gX3RvcC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkNWZiMGEzMWI2OTk0YjQ0Zjc2ZDY5ODIwNTQxYmFi ZjQ5NGNiNzM5Li5iMjkzM2QxMjQ4NWZlNjVkOGRlYzhjMzhhNjI2MTVmZTVkMWY1NjdmIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTktMDEtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAg ICAgICBSZWdyZXNzaW9uKFBTT04tcjIzOTE4Mik6IEJsYW5rIHZpZXcgd2hlbiBuYXZpZ2F0aW5n IGJhY2sgYW5kIGZvcnRoIGJldHdlZW4gZ29vZ2xlLmNvbSBhbmQgc3RhY2sgb3ZlcmZsb3cKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzIyNAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDcwOTc3MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEFQSSB0ZXN0IGNvdmVyYWdlLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlv bi5tbToKKwogMjAxOS0wMS0wNyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBBIE1lZGlhVGltZSB0aW1lc2NhbGUgbXVzdCBuZXZlciBiZSB6ZXJvCmRp ZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NT d2FwT25OYXZpZ2F0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQppbmRleCA5NjEzM2E5ODc3Nzk5MDE4YTViNTk0 MTA2NDFhMWZkMjY4NTIwZmVmLi5hOTU0NTQ2NDA1YTU4YmE4MWUwNjVmMWQzMTg2NDg1YTQ3YTdl NmJkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1By b2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KQEAgLTY4NSw2ICs2ODUsNjMg QEAgVEVTVChQcm9jZXNzU3dhcCwgQmFjaykKICAgICAgICAgRVhQRUNUX0VRKDV1LCBzZWVuUElE cy5zaXplKCkpOwogfQogCitzdGF0aWMgY29uc3QgY2hhciogcGFnZVdpdGhGcmFnbWVudFRlc3RC eXRlcyA9IFIiUFNPTlJFU09VUkNFKAorPGRpdiBpZD0iZm9vIj5URVNUPC9kaXY+CispUFNPTlJF U09VUkNFIjsKKworVEVTVChQcm9jZXNzU3dhcCwgSGlzdG9yeU5hdmlnYXRpb25Ub0ZyYWdtZW50 VVJMKQoreworICAgIGF1dG8gcHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uID0gYWRvcHROUyhbW19X S1Byb2Nlc3NQb29sQ29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0pOworICAgIHByb2Nlc3NQb29s Q29uZmlndXJhdGlvbi5nZXQoKS5wcm9jZXNzU3dhcHNPbk5hdmlnYXRpb24gPSBZRVM7CisgICAg YXV0byBwcm9jZXNzUG9vbCA9IGFkb3B0TlMoW1tXS1Byb2Nlc3NQb29sIGFsbG9jXSBfaW5pdFdp dGhDb25maWd1cmF0aW9uOnByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5nZXQoKV0pOworCisgICAg YXV0byB3ZWJWaWV3Q29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0 aW9uIGFsbG9jXSBpbml0XSk7CisgICAgW3dlYlZpZXdDb25maWd1cmF0aW9uIHNldFByb2Nlc3NQ b29sOnByb2Nlc3NQb29sLmdldCgpXTsKKyAgICBhdXRvIGhhbmRsZXIgPSBhZG9wdE5TKFtbUFNP TlNjaGVtZSBhbGxvY10gaW5pdF0pOworICAgIFtoYW5kbGVyIGFkZE1hcHBpbmdGcm9tVVJMU3Ry aW5nOkAicHNvbjovL3d3dy5hcHBsZS5jb20vbWFpbi5odG1sI2ZvbyIgdG9EYXRhOnBhZ2VXaXRo RnJhZ21lbnRUZXN0Qnl0ZXNdOworICAgIFt3ZWJWaWV3Q29uZmlndXJhdGlvbiBzZXRVUkxTY2hl bWVIYW5kbGVyOmhhbmRsZXIuZ2V0KCkgZm9yVVJMU2NoZW1lOkAiUFNPTiJdOworCisgICAgYXV0 byB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01h a2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOndlYlZpZXdDb25maWd1cmF0aW9u LmdldCgpXSk7CisgICAgYXV0byBkZWxlZ2F0ZSA9IGFkb3B0TlMoW1tQU09OTmF2aWdhdGlvbkRl bGVnYXRlIGFsbG9jXSBpbml0XSk7CisgICAgW3dlYlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRl OmRlbGVnYXRlLmdldCgpXTsKKworICAgIE5TVVJMUmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJl cXVlc3QgcmVxdWVzdFdpdGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJwc29uOi8vd3d3Lndl YmtpdC5vcmcvbWFpbi5odG1sIl1dOworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3Rd OworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKyAgICBkb25lID0gZmFs c2U7CisKKyAgICBhdXRvIHdlYmtpdFBJRCA9IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmll cl07CisKKyAgICByZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwg VVJMV2l0aFN0cmluZzpAInBzb246Ly93d3cuYXBwbGUuY29tL21haW4uaHRtbCNmb28iXV07Cisg ICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6cmVxdWVzdF07CisKKyAgICBUZXN0V2ViS2l0QVBJOjpV dGlsOjpydW4oJmRvbmUpOworICAgIGRvbmUgPSBmYWxzZTsKKworICAgIGF1dG8gYXBwbGVQSUQg PSBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJdOworCisgICAgW3dlYlZpZXcgZ29CYWNr XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOworICAgIGRvbmUgPSBmYWxz ZTsKKworICAgIEVYUEVDVF9FUSh3ZWJraXRQSUQsIFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRp Zmllcl0pOworCisgICAgW3dlYlZpZXcgZ29Gb3J3YXJkXTsKKyAgICBUZXN0V2ViS2l0QVBJOjpV dGlsOjpydW4oJmRvbmUpOworICAgIGRvbmUgPSBmYWxzZTsKKworICAgIEVYUEVDVF9FUShhcHBs ZVBJRCwgW3dlYlZpZXcgX3dlYlByb2Nlc3NJZGVudGlmaWVyXSk7CisKKyAgICBib29sIGZpbmlz aGVkUnVubmluZ1NjcmlwdCA9IGZhbHNlOworICAgIFt3ZWJWaWV3IGV2YWx1YXRlSmF2YVNjcmlw dDpAImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmb28nKS5pbm5lclRleHQiIGNvbXBsZXRpb25I YW5kbGVyOiBbJl0gKGlkIHJlc3VsdCwgTlNFcnJvciAqZXJyb3IpIHsKKyAgICAgICAgTlNTdHJp bmcgKmlubmVyVGV4dCA9IChOU1N0cmluZyAqKXJlc3VsdDsKKyAgICAgICAgRVhQRUNUX1dLX1NU UkVRKEAiVEVTVCIsIGlubmVyVGV4dCk7CisgICAgICAgIGZpbmlzaGVkUnVubmluZ1NjcmlwdCA9 IHRydWU7CisgICAgfV07CisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZmaW5pc2hlZFJ1 bm5pbmdTY3JpcHQpOworfQorCiBURVNUKFByb2Nlc3NTd2FwLCBTdXNwZW5kZWRQYWdlRGllc0Fm dGVyQmFja0ZvcndhcmRMaXN0SXRlbUlzR29uZSkKIHsKICAgICBhdXRvIHByb2Nlc3NQb29sQ29u ZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tfV0tQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24gYWxsb2Nd IGluaXRdKTsK