193221 2019-01-07 15:39:39 -0800 LLInt put_by_id uses the wrong load instruction for loading flags from the metadata 2019-01-08 14:48:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1492454 0 tzagallo 2019-01-07 15:39:39 -0800 ... 1492455 1 358546 tzagallo 2019-01-07 15:41:14 -0800 Created attachment 358546 Patch 1492459 2 358546 mark.lam 2019-01-07 15:49:49 -0800 Comment on attachment 358546 Patch r=me 1492527 3 358546 keith_miller 2019-01-07 19:23:21 -0800 Comment on attachment 358546 Patch Can we get a JSC test? 1492638 4 358607 tzagallo 2019-01-08 10:07:44 -0800 Created attachment 358607 Patch 1492650 5 358607 commit-queue 2019-01-08 10:29:51 -0800 Comment on attachment 358607 Patch Clearing flags on attachment: 358607 Committed r239731: <https://trac.webkit.org/changeset/239731> 1492651 6 commit-queue 2019-01-08 10:29:53 -0800 All reviewed patches have been landed. Closing bug. 1492652 7 webkit-bug-importer 2019-01-08 10:30:32 -0800 <rdar://problem/47119372> 1492769 8 saam 2019-01-08 14:48:34 -0800 Maybe we should implement a systematic way to prevent such errors as this. Like, what if we had code that compiled: static_assert(sizeof(field) == N) or static_assert(sizeof(field) >= N) Where N is the load size for each static load of `field` in the LLInt. I think the former would probably pass compilation. But if not, we could do the latter. If that doesn't work, we should make anyone explicitly doing a larger load add some kind of syntax for "trust me, I know what I'm doing by emitting a larger load". 358546 2019-01-07 15:41:14 -0800 2019-01-08 10:07:39 -0800 Patch bug-193221-20190108004106.patch text/plain 1563 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MDYzYzZkNTYzZTZjNzMzNmNkYzI1MmRiZDM3NmZiNTY4NDljYmU5Li42Y2UyNTE3Y2NjNDc5ODEz OGI5MTI1MWU4NjAwNzZiMzgyZDIzZjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0wNyAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBMTEludCBwdXRfYnlfaWQgdXNlcyB0aGUgd3JvbmcgbG9hZCBpbnN0cnVj dGlvbiBmb3IgbG9hZGluZyBmbGFncyBmcm9tIHRoZSBtZXRhZGF0YQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMjIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZsYWdzIGFyZSBvbmx5IDQgYnl0 ZXMsIGJ1dCB3ZXJlIGxvYWRlZCB3aXRoIGxvYWRwLiBJdCB1c2VkIHRvIHdvcmssCisgICAgICAg IHNpbmNlIHRoZSBmbGFncyB3ZXJlIGZvbGxvd2VkIGJ5IGEgNC1ieXRlIHBhZGRpbmcsIGJ1dCBp dCBicm9rZSBhZnRlciB0aGUKKyAgICAgICAgc3RydWN0IHdhcyBjb21wYWN0ZWQgaW4gcjIzOTYy Ni4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206CisKIDIwMTkt MDEtMDcgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGV4dGVuZCBYSFIgYnJlYWtwb2ludHMgdG8gd29yayB3aXRoIGZldGNoCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0 LmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQu YXNtCmluZGV4IDJlN2VkOWVjYjZjNGQ2Mjc2MjU2NWY0MGMyMGY0Y2VhMDgzNjAwZjcuLmVlZDJh MGZiMjIzMWRiNTY1YzRiYmZlMTFkNGMwNmM0NTFkNDdmYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCkBAIC0xMzQx LDcgKzEzNDEsNyBAQCBsbGludE9wV2l0aE1ldGFkYXRhKG9wX3B1dF9ieV9pZCwgT3BQdXRCeUlk LCBtYWNybyAoc2l6ZSwgZ2V0LCBkaXNwYXRjaCwgbWV0YWRhdAogICAgIGdldCh2YWx1ZSwgdDEp CiAgICAgbG9hZENvbnN0YW50T3JWYXJpYWJsZShzaXplLCB0MSwgdDMpCiAKLSAgICBsb2FkcCBP cFB1dEJ5SWQ6Ok1ldGFkYXRhOjpmbGFnc1t0NV0sIHQxCisgICAgbG9hZGkgT3BQdXRCeUlkOjpN ZXRhZGF0YTo6ZmxhZ3NbdDVdLCB0MQogCiAgICAgIyBBdCB0aGlzIHBvaW50LCB3ZSBoYXZlOgog ICAgICMgdDAgLT4gb2JqZWN0IGJhc2UK 358607 2019-01-08 10:07:44 -0800 2019-01-08 10:29:51 -0800 Patch bug-193221-20190108190736.patch text/plain 2861 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MDYzYzZkNTYzZTZjNzMzNmNkYzI1MmRiZDM3NmZiNTY4NDljYmU5Li5hMjBiMGIxMjE1ZmI1NGVj NzZlOTVmMTUxZjE3YTVjMzI5MDY5MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wMS0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBMTEludCBwdXRfYnlfaWQgdXNlcyB0aGUgd3JvbmcgbG9hZCBpbnN0cnVj dGlvbiBmb3IgbG9hZGluZyBmbGFncyBmcm9tIHRoZSBtZXRhZGF0YQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMjIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgVGhlIGZsYWdzIGFyZSBvbmx5IDQgYnl0ZXMsIGJ1 dCB3ZXJlIGxvYWRlZCB3aXRoIGxvYWRwLiBJdCB1c2VkIHRvIHdvcmssCisgICAgICAgIHNpbmNl IHRoZSBmbGFncyB3ZXJlIGZvbGxvd2VkIGJ5IGEgNC1ieXRlIHBhZGRpbmcsIGJ1dCBpdCBicm9r ZSBhZnRlciB0aGUKKyAgICAgICAgc3RydWN0IHdhcyBjb21wYWN0ZWQgaW4gcjIzOTYyNi4KKwor ICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206CisKIDIwMTktMDEtMDcg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGV4dGVuZCBYSFIgYnJlYWtwb2ludHMgdG8gd29yayB3aXRoIGZldGNoCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbSBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCmlu ZGV4IDJlN2VkOWVjYjZjNGQ2Mjc2MjU2NWY0MGMyMGY0Y2VhMDgzNjAwZjcuLmVlZDJhMGZiMjIz MWRiNTY1YzRiYmZlMTFkNGMwNmM0NTFkNDdmYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCkBAIC0xMzQxLDcgKzEz NDEsNyBAQCBsbGludE9wV2l0aE1ldGFkYXRhKG9wX3B1dF9ieV9pZCwgT3BQdXRCeUlkLCBtYWNy byAoc2l6ZSwgZ2V0LCBkaXNwYXRjaCwgbWV0YWRhdAogICAgIGdldCh2YWx1ZSwgdDEpCiAgICAg bG9hZENvbnN0YW50T3JWYXJpYWJsZShzaXplLCB0MSwgdDMpCiAKLSAgICBsb2FkcCBPcFB1dEJ5 SWQ6Ok1ldGFkYXRhOjpmbGFnc1t0NV0sIHQxCisgICAgbG9hZGkgT3BQdXRCeUlkOjpNZXRhZGF0 YTo6ZmxhZ3NbdDVdLCB0MQogCiAgICAgIyBBdCB0aGlzIHBvaW50LCB3ZSBoYXZlOgogICAgICMg dDAgLT4gb2JqZWN0IGJhc2UKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggMTJjMWI3ODE0ZmQxMjk4MmQxYjUxZGUxNjhmZTgyNDc4NWFjYzI5 ZS4uNDYyMDUzOGVmYTE5NzhmMWZjY2EzMzE5OGZmZTZlMzE3MWI1NmQ3NiAxMDA2NDQKLS0tIGEv SlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxOS0wMS0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KKworICAg ICAgICBMTEludCBwdXRfYnlfaWQgdXNlcyB0aGUgd3JvbmcgbG9hZCBpbnN0cnVjdGlvbiBmb3Ig bG9hZGluZyBmbGFncyBmcm9tIHRoZSBtZXRhZGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFy ayBMYW0uCisKKyAgICAgICAgKiBzdHJlc3MvcHV0LWJ5LWlkLWZsYWdzLmpzOiBBZGRlZC4KKyAg ICAgICAgKGYpOgorICAgICAgICAoZyk6CisgICAgICAgIChudW1iZXJPZkRGR0NvbXBpbGVzKToK KwogMjAxOS0wMS0wNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBCYXNlbGluZSB2ZXJzaW9uIG9mIGdldF9ieV9pZCBtYXkgY29ycnVwdCBtZXRhZGF0YQpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvcHV0LWJ5LWlkLWZsYWdzLmpzIGIvSlNUZXN0cy9z dHJlc3MvcHV0LWJ5LWlkLWZsYWdzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2N2ZlMTZmNTdkMTM3NDRmYTAx MTgxZTNmZWY5MjliODI0MzMyOTUKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9w dXQtYnktaWQtZmxhZ3MuanMKQEAgLTAsMCArMSwyMyBAQAorZnVuY3Rpb24gZih4LCB5KSB7Cisg ICAgeC55ID0geTsKK307CisKK2Z1bmN0aW9uIGcoeCkgeworICAgIHJldHVybiB4LnkgKyA0MjsK K30KK25vSW5saW5lKGYpOworbm9JbmxpbmUoZyk7CisKK3ZhciB4ID0ge307Cit2YXIgeSA9IHt9 OworZih4LCA0Mik7CitmKHksIHt9KTsKKword2hpbGUgKCFudW1iZXJPZkRGR0NvbXBpbGVzKGcp KSB7CisgICAgb3B0aW1pemVOZXh0SW52b2NhdGlvbihnKTsKKyAgICBpZiAodHlwZW9mIGcoeCkg IT09ICdudW1iZXInKQorICAgICAgICB0aHJvdyAnZmFpbGVkIHdhcm1pbmcgdXAnOworfQorCitp ZiAodHlwZW9mIGcoeSkgIT09ICdzdHJpbmcnKQorICAgIHRocm93ICdmYWlsZWQgYWZ0ZXIgY29t cGlsYXRpb24nOwo=