193212 2019-01-07 14:03:19 -0800 Remove use of NetworkProcess::singleton in NetworkLoad/NetworkDataTask code 2019-01-07 14:31:42 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen aestes webkit-bug-importer oldest_to_newest 1492392 0 achristensen 2019-01-07 14:03:19 -0800 Remove use of NetworkProcess::singleton in NetworkLoad/NetworkDataTask code 1492393 1 358529 achristensen 2019-01-07 14:03:27 -0800 Created attachment 358529 Patch 1492410 2 achristensen 2019-01-07 14:30:17 -0800 http://trac.webkit.org/r239700 1492414 3 webkit-bug-importer 2019-01-07 14:31:42 -0800 <rdar://problem/47096678> 358529 2019-01-07 14:03:27 -0800 2019-01-07 14:26:27 -0800 Patch bug-193212-20190107140327.patch text/plain 7634 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk2OTUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAxLTA3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVzZSBv ZiBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uIGluIE5ldHdvcmtMb2FkL05ldHdvcmtEYXRhVGFz ayBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTMyMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE5ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFza0Jsb2IuY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrRGF0YVRhc2tCbG9iOjpOZXR3b3JrRGF0YVRhc2tCbG9iKToKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya0RhdGFUYXNrQmxvYjo6ZG93bmxvYWQpOgorICAgICAgICAoV2ViS2l0OjpO ZXR3b3JrRGF0YVRhc2tCbG9iOjp3cml0ZURvd25sb2FkKToKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya0RhdGFUYXNrQmxvYjo6ZGlkRmFpbERvd25sb2FkKToKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya0RhdGFUYXNrQmxvYjo6ZGlkRmluaXNoRG93bmxvYWQpOgorICAgICAgICAqIE5ldHdvcmtQ cm9jZXNzL05ldHdvcmtEYXRhVGFza0Jsb2IuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrTG9hZC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpOZXR3b3JrTG9h ZCk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpjb252ZXJ0VGFza1RvRG93bmxvYWQp OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6ZGlkUmVjZWl2ZUNoYWxsZW5nZSk6Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtMb2FkOjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmg6CisKIDIwMTktMDEtMDcgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRGVhY3RpdmF0ZSBhdWRp byBzZXNzaW9uIHdoZW5ldmVyIHBvc3NpYmxlCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL05ldHdvcmtEYXRhVGFza0Jsb2IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrQmxvYi5jcHAJKHJldmlzaW9uIDIzOTY3 MCkKKysrIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrQmxvYi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDYgKzY5LDcgQEAgTmV0d29ya0RhdGFUYXNrQmxvYjo6 TmV0d29ya0RhdGFUYXNrQmxvYgogICAgIDogTmV0d29ya0RhdGFUYXNrKHNlc3Npb24sIGNsaWVu dCwgcmVxdWVzdCwgU3RvcmVkQ3JlZGVudGlhbHNQb2xpY3k6OkRvTm90VXNlLCBmYWxzZSwgZmFs c2UpCiAgICAgLCBtX3N0cmVhbShzdGQ6Om1ha2VfdW5pcXVlPEFzeW5jRmlsZVN0cmVhbT4oKnRo aXMpKQogICAgICwgbV9maWxlUmVmZXJlbmNlcyhmaWxlUmVmZXJlbmNlcykKKyAgICAsIG1fbmV0 d29ya1Byb2Nlc3Moc2Vzc2lvbi5uZXR3b3JrUHJvY2VzcygpKQogewogICAgIGZvciAoYXV0byYg ZmlsZVJlZmVyZW5jZSA6IG1fZmlsZVJlZmVyZW5jZXMpCiAgICAgICAgIGZpbGVSZWZlcmVuY2Ut PnByZXBhcmVGb3JGaWxlQWNjZXNzKCk7CkBAIC00NjUsNyArNDY2LDcgQEAgdm9pZCBOZXR3b3Jr RGF0YVRhc2tCbG9iOjpkb3dubG9hZCgpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBh dXRvJiBkb3dubG9hZE1hbmFnZXIgPSBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuZG93bmxv YWRNYW5hZ2VyKCk7CisgICAgYXV0byYgZG93bmxvYWRNYW5hZ2VyID0gbV9uZXR3b3JrUHJvY2Vz cy0+ZG93bmxvYWRNYW5hZ2VyKCk7CiAgICAgYXV0byBkb3dubG9hZCA9IHN0ZDo6bWFrZV91bmlx dWU8RG93bmxvYWQ+KGRvd25sb2FkTWFuYWdlciwgbV9wZW5kaW5nRG93bmxvYWRJRCwgKnRoaXMs IG1fc2Vzc2lvbi0+c2Vzc2lvbklEKCksIHN1Z2dlc3RlZEZpbGVuYW1lKCkpOwogICAgIGF1dG8q IGRvd25sb2FkUHRyID0gZG93bmxvYWQuZ2V0KCk7CiAgICAgZG93bmxvYWRNYW5hZ2VyLmRhdGFU YXNrQmVjYW1lRG93bmxvYWRUYXNrKG1fcGVuZGluZ0Rvd25sb2FkSUQsIFdURk1vdmUoZG93bmxv YWQpKTsKQEAgLTQ4Nyw3ICs0ODgsNyBAQCBib29sIE5ldHdvcmtEYXRhVGFza0Jsb2I6OndyaXRl RG93bmxvYWQoCiAgICAgfQogCiAgICAgQVNTRVJUKGJ5dGVzV3JpdHRlbiA9PSBieXRlc1JlYWQp OwotICAgIGF1dG8qIGRvd25sb2FkID0gTmV0d29ya1Byb2Nlc3M6OnNpbmdsZXRvbigpLmRvd25s b2FkTWFuYWdlcigpLmRvd25sb2FkKG1fcGVuZGluZ0Rvd25sb2FkSUQpOworICAgIGF1dG8qIGRv d25sb2FkID0gbV9uZXR3b3JrUHJvY2Vzcy0+ZG93bmxvYWRNYW5hZ2VyKCkuZG93bmxvYWQobV9w ZW5kaW5nRG93bmxvYWRJRCk7CiAgICAgQVNTRVJUKGRvd25sb2FkKTsKICAgICBkb3dubG9hZC0+ ZGlkUmVjZWl2ZURhdGEoYnl0ZXNXcml0dGVuKTsKICAgICByZXR1cm4gdHJ1ZTsKQEAgLTUxNyw3 ICs1MTgsNyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza0Jsb2I6OmRpZEZhaWxEb3dubG9hCiAgICAg aWYgKG1fY2xpZW50KQogICAgICAgICBtX2NsaWVudC0+ZGlkQ29tcGxldGVXaXRoRXJyb3IoZXJy b3IpOwogICAgIGVsc2UgewotICAgICAgICBhdXRvKiBkb3dubG9hZCA9IE5ldHdvcmtQcm9jZXNz OjpzaW5nbGV0b24oKS5kb3dubG9hZE1hbmFnZXIoKS5kb3dubG9hZChtX3BlbmRpbmdEb3dubG9h ZElEKTsKKyAgICAgICAgYXV0byogZG93bmxvYWQgPSBtX25ldHdvcmtQcm9jZXNzLT5kb3dubG9h ZE1hbmFnZXIoKS5kb3dubG9hZChtX3BlbmRpbmdEb3dubG9hZElEKTsKICAgICAgICAgQVNTRVJU KGRvd25sb2FkKTsKICAgICAgICAgZG93bmxvYWQtPmRpZEZhaWwoZXJyb3IsIElQQzo6RGF0YVJl ZmVyZW5jZSgpKTsKICAgICB9CkBAIC01MzcsNyArNTM4LDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRh c2tCbG9iOjpkaWRGaW5pc2hEb3dubAogICAgIH0KIAogICAgIGNsZWFyU3RyZWFtKCk7Ci0gICAg YXV0byogZG93bmxvYWQgPSBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuZG93bmxvYWRNYW5h Z2VyKCkuZG93bmxvYWQobV9wZW5kaW5nRG93bmxvYWRJRCk7CisgICAgYXV0byogZG93bmxvYWQg PSBtX25ldHdvcmtQcm9jZXNzLT5kb3dubG9hZE1hbmFnZXIoKS5kb3dubG9hZChtX3BlbmRpbmdE b3dubG9hZElEKTsKICAgICBBU1NFUlQoZG93bmxvYWQpOwogICAgIGRvd25sb2FkLT5kaWRGaW5p c2goKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFU YXNrQmxvYi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0 d29ya0RhdGFUYXNrQmxvYi5oCShyZXZpc2lvbiAyMzk2NzApCisrKyBTb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFza0Jsb2IuaAkod29ya2luZyBjb3B5KQpAQCAtNDQs NiArNDQsOCBAQCBjbGFzcyBCbG9iRGF0YUl0ZW07CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCitj bGFzcyBOZXR3b3JrUHJvY2VzczsKKwogY2xhc3MgTmV0d29ya0RhdGFUYXNrQmxvYiBmaW5hbCA6 IHB1YmxpYyBOZXR3b3JrRGF0YVRhc2ssIHB1YmxpYyBXZWJDb3JlOjpGaWxlU3RyZWFtQ2xpZW50 IHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPE5ldHdvcmtEYXRhVGFzaz4gY3JlYXRlKE5ldHdv cmtTZXNzaW9uJiBzZXNzaW9uLCBOZXR3b3JrRGF0YVRhc2tDbGllbnQmIGNsaWVudCwgY29uc3Qg V2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBXZWJDb3JlOjpDb250ZW50U25pZmZp bmdQb2xpY3kgc2hvdWxkQ29udGVudFNuaWZmLCBjb25zdCBWZWN0b3I8UmVmUHRyPFdlYkNvcmU6 OkJsb2JEYXRhRmlsZVJlZmVyZW5jZT4+JiBmaWxlUmVmZXJlbmNlcykKQEAgLTExNSw2ICsxMTcs NyBAQCBwcml2YXRlOgogCiAgICAgVmVjdG9yPFJlZlB0cjxXZWJDb3JlOjpCbG9iRGF0YUZpbGVS ZWZlcmVuY2U+PiBtX2ZpbGVSZWZlcmVuY2VzOwogICAgIFJlZlB0cjxTYW5kYm94RXh0ZW5zaW9u PiBtX3NhbmRib3hFeHRlbnNpb247CisgICAgUmVmPE5ldHdvcmtQcm9jZXNzPiBtX25ldHdvcmtQ cm9jZXNzOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAkocmV2aXNpb24gMjM5NjcwKQorKysg U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTUyLDYgKzUyLDcgQEAgc3RydWN0IE5ldHdvcmtMb2FkOjpUaHJvdHRsZSB7CiAKIE5l dHdvcmtMb2FkOjpOZXR3b3JrTG9hZChOZXR3b3JrTG9hZENsaWVudCYgY2xpZW50LCBOZXR3b3Jr TG9hZFBhcmFtZXRlcnMmJiBwYXJhbWV0ZXJzLCBOZXR3b3JrU2Vzc2lvbiYgbmV0d29ya1Nlc3Np b24pCiAgICAgOiBtX2NsaWVudChjbGllbnQpCisgICAgLCBtX25ldHdvcmtQcm9jZXNzKG5ldHdv cmtTZXNzaW9uLm5ldHdvcmtQcm9jZXNzKCkpCiAgICAgLCBtX3BhcmFtZXRlcnMoV1RGTW92ZShw YXJhbWV0ZXJzKSkKICAgICAsIG1fbG9hZFRocm90dGxlTGF0ZW5jeShuZXR3b3JrU2Vzc2lvbi5s b2FkVGhyb3R0bGVMYXRlbmN5KCkpCiAgICAgLCBtX2N1cnJlbnRSZXF1ZXN0KG1fcGFyYW1ldGVy cy5yZXF1ZXN0KQpAQCAtMTMzLDcgKzEzNCw3IEBAIHZvaWQgTmV0d29ya0xvYWQ6OmNvbnZlcnRU YXNrVG9Eb3dubG9hZCgKICAgICBtX2N1cnJlbnRSZXF1ZXN0ID0gdXBkYXRlZFJlcXVlc3Q7CiAg ICAgbV90YXNrLT5zZXRQZW5kaW5nRG93bmxvYWQocGVuZGluZ0Rvd25sb2FkKTsKICAgICAKLSAg ICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCkuZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9u KCptX3Rhc2suZ2V0KCksIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCByZXNwb25zZSk7Cisg ICAgbV9uZXR3b3JrUHJvY2Vzcy0+ZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKCptX3Rhc2su Z2V0KCksIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCByZXNwb25zZSk7CiB9CiAKIHZvaWQg TmV0d29ya0xvYWQ6OnNldFBlbmRpbmdEb3dubG9hZElEKERvd25sb2FkSUQgZG93bmxvYWRJRCkK QEAgLTE4OCw5ICsxODksOSBAQCB2b2lkIE5ldHdvcmtMb2FkOjpkaWRSZWNlaXZlQ2hhbGxlbmdl KEF1CiAgICAgfQogICAgIAogICAgIGlmIChhdXRvKiBwZW5kaW5nRG93bmxvYWQgPSBtX3Rhc2st PnBlbmRpbmdEb3dubG9hZCgpKQotICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9uKCku YXV0aGVudGljYXRpb25NYW5hZ2VyKCkuZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdl KCpwZW5kaW5nRG93bmxvYWQsIGNoYWxsZW5nZSwgV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikp OworICAgICAgICBtX25ldHdvcmtQcm9jZXNzLT5hdXRoZW50aWNhdGlvbk1hbmFnZXIoKS5kaWRS ZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKnBlbmRpbmdEb3dubG9hZCwgY2hhbGxlbmdl LCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgZWxzZQotICAgICAgICBOZXR3b3Jr UHJvY2Vzczo6c2luZ2xldG9uKCkuYXV0aGVudGljYXRpb25NYW5hZ2VyKCkuZGlkUmVjZWl2ZUF1 dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fcGFyYW1ldGVycy53ZWJQYWdlSUQsIG1fcGFyYW1ldGVy cy53ZWJGcmFtZUlELCBjaGFsbGVuZ2UsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAg ICAgICAgbV9uZXR3b3JrUHJvY2Vzcy0+YXV0aGVudGljYXRpb25NYW5hZ2VyKCkuZGlkUmVjZWl2 ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG1fcGFyYW1ldGVycy53ZWJQYWdlSUQsIG1fcGFyYW1l dGVycy53ZWJGcmFtZUlELCBjaGFsbGVuZ2UsIFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsK IH0KIAogdm9pZCBOZXR3b3JrTG9hZDo6ZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlUmVzcG9u c2UmJiByZXNwb25zZSwgUmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciYmIGNvbXBsZXRpb25IYW5k bGVyKQpAQCAtMTk5LDcgKzIwMCw3IEBAIHZvaWQgTmV0d29ya0xvYWQ6OmRpZFJlY2VpdmVSZXNw b25zZShSZXMKICAgICBBU1NFUlQoIW1fdGhyb3R0bGUpOwogCiAgICAgaWYgKG1fdGFzayAmJiBt X3Rhc2stPmlzRG93bmxvYWQoKSkgewotICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9u KCkuZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKCptX3Rhc2suZ2V0KCksIFdURk1vdmUoY29t cGxldGlvbkhhbmRsZXIpLCByZXNwb25zZSk7CisgICAgICAgIG1fbmV0d29ya1Byb2Nlc3MtPmZp bmRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbigqbV90YXNrLmdldCgpLCBXVEZNb3ZlKGNvbXBsZXRp b25IYW5kbGVyKSwgcmVzcG9uc2UpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkluZGV4OiBT b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9hZC5oCShyZXZpc2lvbiAyMzk2 NzApCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmgJKHdvcmtp bmcgY29weSkKQEAgLTM1LDYgKzM1LDggQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK2NsYXNz IE5ldHdvcmtQcm9jZXNzOworCiBjbGFzcyBOZXR3b3JrTG9hZCBmaW5hbCA6IHByaXZhdGUgTmV0 d29ya0RhdGFUYXNrQ2xpZW50IHsKICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1Ymxp YzoKQEAgLTc5LDYgKzgxLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHRocm90dGxlRGVsYXlDb21w bGV0ZWQoKTsKIAogICAgIHN0ZDo6cmVmZXJlbmNlX3dyYXBwZXI8TmV0d29ya0xvYWRDbGllbnQ+ IG1fY2xpZW50OworICAgIFJlZjxOZXR3b3JrUHJvY2Vzcz4gbV9uZXR3b3JrUHJvY2VzczsKICAg ICBjb25zdCBOZXR3b3JrTG9hZFBhcmFtZXRlcnMgbV9wYXJhbWV0ZXJzOwogICAgIENvbXBsZXRp b25IYW5kbGVyPHZvaWQoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiYpPiBtX3JlZGlyZWN0Q29t cGxldGlvbkhhbmRsZXI7CiAgICAgUmVmUHRyPE5ldHdvcmtEYXRhVGFzaz4gbV90YXNrOwo=