193174 2019-01-06 01:50:32 -0800 [WPE][GTK] Building with ENABLE_VIDEO=OFF fails trying to use Document MediaPlayback functions. 2019-02-05 08:03:51 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psaavedra psaavedra achristensen bugs-noreply commit-queue eric.carlson ggaren jer.noble mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1492130 0 psaavedra 2019-01-06 01:50:32 -0800 Error building wpewebkit with `-DENABLE_VIDEO=OFF`: ``` In file included from DerivedSources/WebCore/unified-sources/UnifiedSource294.cpp:3: /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::stopAllMediaPlayback()': /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1723:23: error: 'class WebCore::Document' has no member named 'stopAllMediaPlayback' document->stopAllMediaPlayback(); ^~~~~~~~~~~~~~~~~~~~ /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::suspendAllMediaPlayback()': /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1735:23: error: 'class WebCore::Document' has no member named 'suspendAllMediaPlayback' document->suspendAllMediaPlayback(); ^~~~~~~~~~~~~~~~~~~~~~~ /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp: In member function 'void WebCore::Page::resumeAllMediaPlayback()': /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+01f1bceaa5-r0/git/Source/WebCore/page/Page.cpp:1750:23: error: 'class WebCore::Document' has no member named 'resumeAllMediaPlayback' document->resumeAllMediaPlayback(); ``` L1723 in Source/WebCore/page/Page.cpp: ``` void Page::stopAllMediaPlayback() { for (Frame* frame = &mainFrame(); frame; frame = frame->tree().traverseNext()) { if (auto* document = frame->document()) document->stopAllMediaPlayback(); <<<<<<<<< } } ``` But those functions are only enabled with VIDEO flag ON, L1706 in Source/WebCore/dom/Document.cpp: ``` #if ENABLE(VIDEO) void Page::stopAllMediaPlayback() void Page::suspendAllMediaPlayback() void Page::resumeAllMediaPlayback() #endif ``` 1492131 1 358457 psaavedra 2019-01-06 01:54:18 -0800 Created attachment 358457 patch 1492132 2 psaavedra 2019-01-06 01:58:52 -0800 Related to changes implemented in: commit 9e27b18c493250dd2117ada4efa758fcc58a0f14 Author: jer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Fri Jan 4 22:23:15 2019 +0000 [WebKitLegacy] Media playback pauses on scroll https://bugs.webkit.org/show_bug.cgi?id=192829 Reviewed by Eric Carlson. 1492137 3 358457 commit-queue 2019-01-06 09:15:38 -0800 Comment on attachment 358457 patch Clearing flags on attachment: 358457 Committed r239663: <https://trac.webkit.org/changeset/239663> 1492138 4 commit-queue 2019-01-06 09:15:39 -0800 All reviewed patches have been landed. Closing bug. 358457 2019-01-06 01:54:18 -0800 2019-01-06 09:15:38 -0800 patch bug-193174-20190106105417.patch text/plain 2063 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA2NjI0M2UzZWE1ZTc2 NGMxNDM0ZmIzMzU5MzAyM2I1MGE4ZWNhZS4uZWNmZjQ2MGQyY2U1ZTk5ZGI1NDhmYjYxMGUxZTBj ZTNkZDhjZjIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTA2ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10g QnVpbGRpbmcgd2l0aCBFTkFCTEVfVklERU89T0ZGIGZhaWxzIHRyeWluZyB0byB1c2UgRG9jdW1l bnQgTWVkaWFQbGF5YmFjayBmdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ YWdlOjpzdG9wQWxsTWVkaWFQbGF5YmFjayk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpzdXNw ZW5kQWxsTWVkaWFQbGF5YmFjayk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpyZXN1bWVBbGxN ZWRpYVBsYXliYWNrKToKKwogMjAxOS0wMS0wNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIExlYWsgb2YgdHdvIENDUlNBQ3J5cHRvclJlZiAoNC4wIEtieXRl cy8xIHBhZ2UgZWFjaCkgaW4gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IHJ1bm5pbmcgV2Vi S2l0IGxheW91dCB0ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggZGRmMzkxMjc5NTM0YjkwYzE1 Nzc4YmFkMmJjZTg0OWU3NTg1MTM5Mi4uZTgxY2IyMzhlMTdmZTE1ZTE0MDk4NDMxNTBhZTYzOWVl OTZkNWI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xNzE4LDE0ICsxNzE4LDE3IEBAIHZvaWQg UGFnZTo6c3RvcE1lZGlhQ2FwdHVyZSgpCiAKIHZvaWQgUGFnZTo6c3RvcEFsbE1lZGlhUGxheWJh Y2soKQogeworI2lmIEVOQUJMRShWSURFTykKICAgICBmb3IgKEZyYW1lKiBmcmFtZSA9ICZtYWlu RnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS50cmF2ZXJzZU5leHQoKSkgewog ICAgICAgICBpZiAoYXV0byogZG9jdW1lbnQgPSBmcmFtZS0+ZG9jdW1lbnQoKSkKICAgICAgICAg ICAgIGRvY3VtZW50LT5zdG9wQWxsTWVkaWFQbGF5YmFjaygpOwogICAgIH0KKyNlbmRpZgogfQog CiB2b2lkIFBhZ2U6OnN1c3BlbmRBbGxNZWRpYVBsYXliYWNrKCkKIHsKKyNpZiBFTkFCTEUoVklE RU8pCiAgICAgQVNTRVJUKCFtX21lZGlhUGxheWJhY2tJc1N1c3BlbmRlZCk7CiAgICAgaWYgKG1f bWVkaWFQbGF5YmFja0lzU3VzcGVuZGVkKQogICAgICAgICByZXR1cm47CkBAIC0xNzM2LDEwICsx NzM5LDEyIEBAIHZvaWQgUGFnZTo6c3VzcGVuZEFsbE1lZGlhUGxheWJhY2soKQogICAgIH0KIAog ICAgIG1fbWVkaWFQbGF5YmFja0lzU3VzcGVuZGVkID0gdHJ1ZTsKKyNlbmRpZgogfQogCiB2b2lk IFBhZ2U6OnJlc3VtZUFsbE1lZGlhUGxheWJhY2soKQogeworI2lmIEVOQUJMRShWSURFTykKICAg ICBBU1NFUlQobV9tZWRpYVBsYXliYWNrSXNTdXNwZW5kZWQpOwogICAgIGlmICghbV9tZWRpYVBs YXliYWNrSXNTdXNwZW5kZWQpCiAgICAgICAgIHJldHVybjsKQEAgLTE3NDksNiArMTc1NCw3IEBA IHZvaWQgUGFnZTo6cmVzdW1lQWxsTWVkaWFQbGF5YmFjaygpCiAgICAgICAgIGlmIChhdXRvKiBk b2N1bWVudCA9IGZyYW1lLT5kb2N1bWVudCgpKQogICAgICAgICAgICAgZG9jdW1lbnQtPnJlc3Vt ZUFsbE1lZGlhUGxheWJhY2soKTsKICAgICB9CisjZW5kaWYKIH0KIAogI2lmIEVOQUJMRShNRURJ QV9TRVNTSU9OKQo=