193163 2019-01-04 16:46:09 -0800 Web Inspector: Always buffer some console messages without requiring developerExtrasEnabled be enabled at log time 2019-01-14 12:53:49 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED WONTFIX InRadar P2 Normal --- 1 joepeck webkit-unassigned ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam mattbaker mkwst msaboff saam webkit-bug-importer oldest_to_newest 1491972 0 joepeck 2019-01-04 16:46:09 -0800 Always buffer some console messages without requiring developerExtrasEnabled be enabled at log time 1491973 1 joepeck 2019-01-04 16:49:08 -0800 <rdar://problem/36593635> 1491975 2 358397 joepeck 2019-01-04 16:53:09 -0800 Created attachment 358397 [PATCH] Proposed Fix I'd like to measure any performance impact from this. 1491978 3 358397 mattbaker 2019-01-04 16:58:38 -0800 Comment on attachment 358397 [PATCH] Proposed Fix r=me 1494263 4 358397 joepeck 2019-01-14 12:53:41 -0800 Comment on attachment 358397 [PATCH] Proposed Fix Obsoleting this patch. It caused a performance regression on benchmarks so I think I'll take a different approach. 358397 2019-01-04 16:53:09 -0800 2019-01-14 12:53:41 -0800 [PATCH] Proposed Fix devextras-1.patch text/plain 3825 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVlYWU0MThmZDQ3Li4wYTU3MDM0MjA0NiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDEtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBbHdheXMgYnVmZmVyIHNvbWUgY29uc29sZSBtZXNzYWdlcyB3aXRob3V0IHJlcXVpcmluZyBk ZXZlbG9wZXJFeHRyYXNFbmFibGVkIGJlIGVuYWJsZWQgYXQgbG9nIHRpbWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzE2MworICAgICAgICA8cmRh cjovL3Byb2JsZW0vMzY1OTM2MzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5j cHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6YWRkTWVzc2Fn ZVRvQ29uc29sZSk6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6 YWRkQ29uc29sZU1lc3NhZ2UpOgorICAgICAgICBBbGxvdyBjb25zb2xlIG1lc3NhZ2VzIHRvIGJl IGJ1ZmZlcmVkIHdpdGhvdXQgdGhlIGRldmVsb3BlciBleHRyYXMgc2V0dGluZy4KKyAgICAgICAg UmVkdWNlIHRoZSBidWZmZXIgc2l6ZSBvbiB3YXRjaE9TIHRvIGxpbWl0IGFueSBwb3RlbnRpYWwg bWVtb3J5IGltcGFjdC4KKwogMjAxOS0wMS0wMyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBERkcgSW50ZWdlclJhbmdlT3B0aW1pemF0aW9uIHBoYXNlIGV4 Y2VlZGluZyBsb29wIGxpbWl0IHNob3VsZG4ndCBBU1NFUlQKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDb25zb2xl QWdlbnQuY3BwCmluZGV4IDRjZmVkN2M1NWY0Li5kZWUwZGQzYzYxNCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ29uc29sZUFnZW50 LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0 b3JDb25zb2xlQWdlbnQuY3BwCkBAIC0zOSw3ICszOSwxMiBAQAogCiBuYW1lc3BhY2UgSW5zcGVj dG9yIHsKIAorI2lmIFBMQVRGT1JNKFdBVENIT1MpCitzdGF0aWMgY29uc3QgdW5zaWduZWQgbWF4 aW11bUNvbnNvbGVNZXNzYWdlcyA9IDI1OworI2Vsc2UKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBt YXhpbXVtQ29uc29sZU1lc3NhZ2VzID0gMTAwOworI2VuZGlmCisKIHN0YXRpYyBjb25zdCBpbnQg ZXhwaXJlQ29uc29sZU1lc3NhZ2VzU3RlcCA9IDEwOwogCiBJbnNwZWN0b3JDb25zb2xlQWdlbnQ6 Okluc3BlY3RvckNvbnNvbGVBZ2VudChBZ2VudENvbnRleHQmIGNvbnRleHQsIEluc3BlY3Rvckhl YXBBZ2VudCogaGVhcEFnZW50KQpAQCAtMTIwLDkgKzEyNSw2IEBAIHZvaWQgSW5zcGVjdG9yQ29u c29sZUFnZW50OjpyZXNldCgpCiAKIHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50OjphZGRNZXNz YWdlVG9Db25zb2xlKHN0ZDo6dW5pcXVlX3B0cjxDb25zb2xlTWVzc2FnZT4gbWVzc2FnZSkKIHsK LSAgICBpZiAoIW1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLmluc3BlY3RvckVudmlyb25tZW50KCku ZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpKQotICAgICAgICByZXR1cm47Ci0KICAgICBpZiAobWVz c2FnZS0+dHlwZSgpID09IE1lc3NhZ2VUeXBlOjpDbGVhcikgewogICAgICAgICBFcnJvclN0cmlu ZyB1bnVzZWQ7CiAgICAgICAgIGNsZWFyTWVzc2FnZXModW51c2VkKTsKQEAgLTIxNiw3ICsyMTgs NiBAQCBzdGF0aWMgYm9vbCBpc0dyb3VwTWVzc2FnZShNZXNzYWdlVHlwZSB0eXBlKQogCiB2b2lk IEluc3BlY3RvckNvbnNvbGVBZ2VudDo6YWRkQ29uc29sZU1lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRy PENvbnNvbGVNZXNzYWdlPiBjb25zb2xlTWVzc2FnZSkKIHsKLSAgICBBU1NFUlQobV9pbmplY3Rl ZFNjcmlwdE1hbmFnZXIuaW5zcGVjdG9yRW52aXJvbm1lbnQoKS5kZXZlbG9wZXJFeHRyYXNFbmFi bGVkKCkpOwogICAgIEFTU0VSVF9BUkcoY29uc29sZU1lc3NhZ2UsIGNvbnNvbGVNZXNzYWdlKTsK IAogICAgIENvbnNvbGVNZXNzYWdlKiBwcmV2aW91c01lc3NhZ2UgPSBtX2NvbnNvbGVNZXNzYWdl cy5pc0VtcHR5KCkgPyBudWxscHRyIDogbV9jb25zb2xlTWVzc2FnZXMubGFzdCgpLmdldCgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9XZWJDb25zb2xlQWdl bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9XZWJDb25zb2xlQWdlbnQu Y3BwCmluZGV4IGQzZDQzYjZmNmZlLi41MzdmZjQ4ODAyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2FnZW50cy9XZWJDb25zb2xlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvV2ViQ29uc29sZUFnZW50LmNwcApAQCAtMTQ0LDkgKzE0 NCw2IEBAIHZvaWQgV2ViQ29uc29sZUFnZW50OjpmcmFtZVdpbmRvd0Rpc2NhcmRlZChET01XaW5k b3cqIHdpbmRvdykKIAogdm9pZCBXZWJDb25zb2xlQWdlbnQ6OmRpZFJlY2VpdmVSZXNwb25zZSh1 bnNpZ25lZCBsb25nIHJlcXVlc3RJZGVudGlmaWVyLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBy ZXNwb25zZSkKIHsKLSAgICBpZiAoIW1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLmluc3BlY3RvckVu dmlyb25tZW50KCkuZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpKQotICAgICAgICByZXR1cm47Ci0K ICAgICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA+PSA0MDApIHsKICAgICAgICAgU3Ry aW5nIG1lc3NhZ2UgPSAiRmFpbGVkIHRvIGxvYWQgcmVzb3VyY2U6IHRoZSBzZXJ2ZXIgcmVzcG9u ZGVkIHdpdGggYSBzdGF0dXMgb2YgIiArIFN0cmluZzo6bnVtYmVyKHJlc3BvbnNlLmh0dHBTdGF0 dXNDb2RlKCkpICsgIiAoIiArIHJlc3BvbnNlLmh0dHBTdGF0dXNUZXh0KCkgKyAnKSc7CiAgICAg ICAgIGFkZE1lc3NhZ2VUb0NvbnNvbGUoc3RkOjptYWtlX3VuaXF1ZTxDb25zb2xlTWVzc2FnZT4o TWVzc2FnZVNvdXJjZTo6TmV0d29yaywgTWVzc2FnZVR5cGU6OkxvZywgTWVzc2FnZUxldmVsOjpF cnJvciwgbWVzc2FnZSwgcmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIDAsIDAsIG51bGxwdHIsIHJl cXVlc3RJZGVudGlmaWVyKSk7CkBAIC0xNTUsOSArMTUyLDYgQEAgdm9pZCBXZWJDb25zb2xlQWdl bnQ6OmRpZFJlY2VpdmVSZXNwb25zZSh1bnNpZ25lZCBsb25nIHJlcXVlc3RJZGVudGlmaWVyLCBj b25zdAogCiB2b2lkIFdlYkNvbnNvbGVBZ2VudDo6ZGlkRmFpbExvYWRpbmcodW5zaWduZWQgbG9u ZyByZXF1ZXN0SWRlbnRpZmllciwgY29uc3QgUmVzb3VyY2VFcnJvciYgZXJyb3IpCiB7Ci0gICAg aWYgKCFtX2luamVjdGVkU2NyaXB0TWFuYWdlci5pbnNwZWN0b3JFbnZpcm9ubWVudCgpLmRldmVs b3BlckV4dHJhc0VuYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgLy8gUmVwb3J0IGZh aWx1cmVzIG9ubHkuCiAgICAgaWYgKGVycm9yLmlzQ2FuY2VsbGF0aW9uKCkpCiAgICAgICAgIHJl dHVybjsK