193160 2019-01-04 14:15:20 -0800 Web Inspector: Use save sheet instead of dialog where possible 2019-01-04 16:34:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1491892 0 joepeck 2019-01-04 14:15:20 -0800 Use save sheet instead of dialog where possible Steps to Reproduce: 1. Inspect this page 2. Show Network Tab 3. Reload the page 4. Dock inspector 5. Click "Export" in the toolbar => Shows Save Dialog, expected Sheet to drop down from Toolbar Notes: - We use a sheet for a windowed inspector but didn't for docked. 1491893 1 joepeck 2019-01-04 14:15:41 -0800 <rdar://problem/37399759> 1491895 2 358366 joepeck 2019-01-04 14:16:24 -0800 Created attachment 358366 [PATCH] Proposed Fix 1491924 3 358366 hi 2019-01-04 15:21:13 -0800 Comment on attachment 358366 [PATCH] Proposed Fix rs=me, nice fix :) 1491965 4 358366 commit-queue 2019-01-04 16:34:06 -0800 Comment on attachment 358366 [PATCH] Proposed Fix Clearing flags on attachment: 358366 Committed r239647: <https://trac.webkit.org/changeset/239647> 1491966 5 commit-queue 2019-01-04 16:34:08 -0800 All reviewed patches have been landed. Closing bug. 358366 2019-01-04 14:16:24 -0800 2019-01-04 16:34:06 -0800 [PATCH] Proposed Fix save-sheet-1.patch text/plain 3918 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTQ4MzViYTQyYjYuLjRlOTY4OTlhNDZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE5LTAxLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNlIHNhdmUgc2hlZXQgaW5zdGVhZCBvZiBkaWFs b2cgd2hlcmUgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MzE2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzczOTk3NTk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1JlbW90ZVdlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1v dGVXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1TYXZlKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0 b3JQcm94eTo6cGxhdGZvcm1TYXZlKToKKwogMjAxOS0wMS0wMyAgQnJlbnQgRnVsZ2hhbSAgPGJm dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbG9naWMgaGFuZGxpbmcgRE5UIGhl YWRlciBkdXJpbmcgcmVkaXJlY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9tYWMvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9tYWMvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggYWU5ZjI1YmNmYTYu LmNhZWUyNmJkYzIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvUmVt b3RlV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv bWFjL1JlbW90ZVdlYkluc3BlY3RvclByb3h5TWFjLm1tCkBAIC0xODAsOCArMTgwLDkgQEAgdm9p ZCBSZW1vdGVXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1TYXZlKGNvbnN0IFN0cmluZyYgc3Vn Z2VzdGVkVVJMLCBjb25zdCBTdHIKICAgICAgICAgc2F2ZVRvVVJMKHBhbmVsLlVSTCk7CiAgICAg fTsKIAotICAgIGlmIChtX3dpbmRvdykKLSAgICAgICAgW3BhbmVsIGJlZ2luU2hlZXRNb2RhbEZv cldpbmRvdzptX3dpbmRvdy5nZXQoKSBjb21wbGV0aW9uSGFuZGxlcjpjb21wbGV0aW9uSGFuZGxl cl07CisgICAgTlNXaW5kb3cgKndpbmRvdyA9IG1fd2luZG93ID8gbV93aW5kb3cuZ2V0KCkgOiBb TlNBcHAga2V5V2luZG93XTsKKyAgICBpZiAod2luZG93KQorICAgICAgICBbcGFuZWwgYmVnaW5T aGVldE1vZGFsRm9yV2luZG93OndpbmRvdyBjb21wbGV0aW9uSGFuZGxlcjpjb21wbGV0aW9uSGFu ZGxlcl07CiAgICAgZWxzZQogICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihbcGFuZWwgcnVuTW9k YWxdKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJbnNw ZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0 b3JQcm94eU1hYy5tbQppbmRleCAxMjEwMDY3ZmYwZC4uODZlZjk0NTNiNTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAg LTQ5NCw4ICs0OTQsOSBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybVNhdmUoY29u c3QgU3RyaW5nJiBzdWdnZXN0ZWRVUkwsIGNvbnN0IFN0cmluZyYgYwogICAgICAgICBzYXZlVG9V UkwocGFuZWwuVVJMKTsKICAgICB9OwogCi0gICAgaWYgKG1faW5zcGVjdG9yV2luZG93KQotICAg ICAgICBbcGFuZWwgYmVnaW5TaGVldE1vZGFsRm9yV2luZG93Om1faW5zcGVjdG9yV2luZG93Lmdl dCgpIGNvbXBsZXRpb25IYW5kbGVyOmNvbXBsZXRpb25IYW5kbGVyXTsKKyAgICBOU1dpbmRvdyAq d2luZG93ID0gbV9pbnNwZWN0b3JXaW5kb3cgPyBtX2luc3BlY3RvcldpbmRvdy5nZXQoKSA6IFtO U0FwcCBrZXlXaW5kb3ddOworICAgIGlmICh3aW5kb3cpCisgICAgICAgIFtwYW5lbCBiZWdpblNo ZWV0TW9kYWxGb3JXaW5kb3c6d2luZG93IGNvbXBsZXRpb25IYW5kbGVyOmNvbXBsZXRpb25IYW5k bGVyXTsKICAgICBlbHNlCiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFtwYW5lbCBydW5Nb2Rh bF0pOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCmluZGV4IDEzNzJkYWYxMWFkLi5kMDRh MWMzMjgzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDE5LTAxLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAg ICAgV2ViIEluc3BlY3RvcjogVXNlIHNhdmUgc2hlZXQgaW5zdGVhZCBvZiBkaWFsb2cgd2hlcmUg cG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MzE2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzczOTk3NTk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJ bnNwZWN0b3JDbGllbnQubW06CisgICAgICAgIChXZWJJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6 c2F2ZSk6CisKIDIwMTktMDEtMDIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHVzaW5nIHRoZSBjdXJyZW50IHRleHQgc2Vs ZWN0aW9uIGFzIHRoZSBmaW5kIHN0cmluZyBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQpp bmRleCBkYzZjM2I4NDFkYy4uMjg5NTFhNDhjN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRM ZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0K QEAgLTM3NCw4ICszNzQsOSBAQCB2b2lkIFdlYkluc3BlY3RvckZyb250ZW5kQ2xpZW50OjpzYXZl KGNvbnN0IFN0cmluZyYgc3VnZ2VzdGVkVVJMLCBjb25zdCBTdHJpbmcmCiAgICAgfTsKIAogICAg IE5TV2luZG93ICpmcm9udGVuZFdpbmRvdyA9IFtbbV9mcm9udGVuZFdpbmRvd0NvbnRyb2xsZXIg ZnJvbnRlbmRXZWJWaWV3XSB3aW5kb3ddOwotICAgIGlmIChmcm9udGVuZFdpbmRvdykKLSAgICAg ICAgW3BhbmVsIGJlZ2luU2hlZXRNb2RhbEZvcldpbmRvdzpmcm9udGVuZFdpbmRvdyBjb21wbGV0 aW9uSGFuZGxlcjpjb21wbGV0aW9uSGFuZGxlcl07CisgICAgTlNXaW5kb3cgKndpbmRvdyA9IGZy b250ZW5kV2luZG93ID8gZnJvbnRlbmRXaW5kb3cgOiBbTlNBcHAga2V5V2luZG93XTsKKyAgICBp ZiAod2luZG93KQorICAgICAgICBbcGFuZWwgYmVnaW5TaGVldE1vZGFsRm9yV2luZG93OndpbmRv dyBjb21wbGV0aW9uSGFuZGxlcjpjb21wbGV0aW9uSGFuZGxlcl07CiAgICAgZWxzZQogICAgICAg ICBjb21wbGV0aW9uSGFuZGxlcihbcGFuZWwgcnVuTW9kYWxdKTsKIH0K