193148 2019-01-04 11:04:09 -0800 Web Inspector: Add a Setting Toggle for Source Maps 2019-01-04 13:28:53 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck simon.fraser webkit-bug-importer zalan oldest_to_newest 1491745 0 joepeck 2019-01-04 11:04:09 -0800 Add a Setting Toggle for Source Maps 1491749 1 358338 joepeck 2019-01-04 11:06:38 -0800 Created attachment 358338 [PATCH] Proposed Fix 1491768 2 358338 hi 2019-01-04 11:43:12 -0800 Comment on attachment 358338 [PATCH] Proposed Fix r=me, should we add a `console.assert(WI.settings.sourceMapsEnabled.value)` inside `WI.SourceMap` somewhere, for sanity's sake? Do we want to do anything for the case where the user disables source maps after having already downloaded and shown them (e.g. in Resources)? 1491782 3 simon.fraser 2019-01-04 12:01:20 -0800 If I'm a naive user debugging JS stuff on a web site, how do I know that I need to enable or disable source maps? 1491787 4 joepeck 2019-01-04 12:07:09 -0800 (In reply to Devin Rousso from comment #2) > Comment on attachment 358338 [details] > [PATCH] Proposed Fix > > r=me, should we add a `console.assert(WI.settings.sourceMapsEnabled.value)` > inside `WI.SourceMap` somewhere, for sanity's sake? Do we want to do > anything for the case where the user disables source maps after having > already downloaded and shown them (e.g. in Resources)? We should eventually do something where when the user toggles source maps it goes and hides / shows source maps stuff, but for now a reload is sufficient. (In reply to Simon Fraser (smfr) from comment #3) > If I'm a naive user debugging JS stuff on a web site, how do I know that I > need to enable or disable source maps? JavaScript developers should be familiar with the concept of source maps. If they are debugging their own content they should know, if they are debugging random content then its just something unfamiliar they would have to come across. The Web Inspector UI indicates SourceMaps uniquely in a few ways, which may help them recognize it is different. 1491819 5 joepeck 2019-01-04 13:01:11 -0800 > (In reply to Simon Fraser (smfr) from comment #3) > > If I'm a naive user debugging JS stuff on a web site, how do I know that I > > need to enable or disable source maps? > > JavaScript developers should be familiar with the concept of source maps. If > they are debugging their own content they should know, if they are debugging > random content then its just something unfamiliar they would have to come > across. The Web Inspector UI indicates SourceMaps uniquely in a few ways, > which may help them recognize it is different. In other words, learning about Source Maps is not much different than learning about some JS / CSS features you aren't familiar with. 1491848 6 358338 commit-queue 2019-01-04 13:27:41 -0800 Comment on attachment 358338 [PATCH] Proposed Fix Clearing flags on attachment: 358338 Committed r239635: <https://trac.webkit.org/changeset/239635> 1491849 7 commit-queue 2019-01-04 13:27:43 -0800 All reviewed patches have been landed. Closing bug. 1491850 8 webkit-bug-importer 2019-01-04 13:28:53 -0800 <rdar://problem/47055858> 358338 2019-01-04 11:06:38 -0800 2019-01-04 13:27:41 -0800 [PATCH] Proposed Fix source-maps-1.patch text/plain 4690 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQxMDljOGRkMjMzLi45ZDI0MmQxNjliNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDEtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZGQgYSBTZXR0aW5nIFRvZ2dsZSBmb3IgU291cmNlIE1hcHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzE0OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVy cy9OZXR3b3JrTWFuYWdlci5qczoKKyAgICAgICAgKFdJLk5ldHdvcmtNYW5hZ2VyLnByb3RvdHlw ZS5kb3dubG9hZFNvdXJjZU1hcCk6CisgICAgICAgIERvbid0IGRvd25sb2FkIHNvdXJjZSBtYXBz IGlmIHRoZSBzZXR0aW5nIGlzIGRpc2FibGVkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9C YXNlL1NldHRpbmcuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1Rh YkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuU2V0dGluZ3NUYWJDb250ZW50Vmlldy5wcm90 b3R5cGUuX2NyZWF0ZUdlbmVyYWxTZXR0aW5nc1ZpZXcpOgorICAgICAgICBTZXR0aW5ncyB0b2dn bGUgZm9yIHNvdXJjZSBtYXBzLiBFbmFibGVkIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBMb2Nh bGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisKIDIwMTktMDEtMDQgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBJbmNsdWRlIGBnbG9iYWxUaGlzYCBpbiBkZWZhdWx0IEphdmFTY3JpcHQgY29tcGxldGlv bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxw cm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0 aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGFhNzhlZWIwNWZiLi4wNzIx YzA5NTg5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMv ZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv TG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC0zNjIsNiArMzYy LDcgQEAgbG9jYWxpemVkU3RyaW5nc1siRW5hYmxlIFByb2dyYW0iXSA9ICJFbmFibGUgUHJvZ3Jh bSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFbmFibGUgYWxsIGJyZWFrcG9pbnRzICglcykiXSA9ICJF bmFibGUgYWxsIGJyZWFrcG9pbnRzICglcykiOwogbG9jYWxpemVkU3RyaW5nc1siRW5hYmxlIGJy ZWFrcG9pbnRzIl0gPSAiRW5hYmxlIGJyZWFrcG9pbnRzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkVu YWJsZSBwYWludCBmbGFzaGluZyJdID0gIkVuYWJsZSBwYWludCBmbGFzaGluZyI7Citsb2NhbGl6 ZWRTdHJpbmdzWyJFbmFibGUgc291cmNlIG1hcHMiXSA9ICJFbmFibGUgc291cmNlIG1hcHMiOwog bG9jYWxpemVkU3RyaW5nc1siRW5hYmxlZCJdID0gIkVuYWJsZWQiOwogbG9jYWxpemVkU3RyaW5n c1siRW5jb2RlZCJdID0gIkVuY29kZWQiOwogbG9jYWxpemVkU3RyaW5nc1siRW5jb2RpbmciXSA9 ICJFbmNvZGluZyI7CkBAIC04NzMsNiArODc0LDcgQEAgbG9jYWxpemVkU3RyaW5nc1siU29ja2V0 cyJdID0gIlNvY2tldHMiOwogbG9jYWxpemVkU3RyaW5nc1siU29ydCBBc2NlbmRpbmciXSA9ICJT b3J0IEFzY2VuZGluZyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTb3J0IERlc2NlbmRpbmciXSA9ICJT b3J0IERlc2NlbmRpbmciOwogbG9jYWxpemVkU3RyaW5nc1siU291cmNlIl0gPSAiU291cmNlIjsK K2xvY2FsaXplZFN0cmluZ3NbIlNvdXJjZSBtYXBzOiJdID0gIlNvdXJjZSBtYXBzOiI7CiBsb2Nh bGl6ZWRTdHJpbmdzWyJTb3VyY2VzIl0gPSAiU291cmNlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJT cGFjZSJdID0gIlNwYWNlIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNwYWNlcyJdID0gIlNwYWNlcyI7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1Nl dHRpbmcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRp bmcuanMKaW5kZXggZDA1MDhhMzMxNzAuLjBmNmRiMTcxZTJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCkBAIC0xMTQsNiAr MTE0LDcgQEAgV0kuc2V0dGluZ3MgPSB7CiAgICAgaW5kZW50V2l0aFRhYnM6IG5ldyBXSS5TZXR0 aW5nKCJpbmRlbnQtd2l0aC10YWJzIiwgZmFsc2UpLAogICAgIHJlc291cmNlQ2FjaGluZ0Rpc2Fi bGVkOiBuZXcgV0kuU2V0dGluZygiZGlzYWJsZS1yZXNvdXJjZS1jYWNoaW5nIiwgZmFsc2UpLAog ICAgIHNlbGVjdGVkTmV0d29ya0RldGFpbENvbnRlbnRWaWV3SWRlbnRpZmllcjogbmV3IFdJLlNl dHRpbmcoIm5ldHdvcmstZGV0YWlsLWNvbnRlbnQtdmlldy1pZGVudGlmaWVyIiwgInByZXZpZXci KSwKKyAgICBzb3VyY2VNYXBzRW5hYmxlZDogbmV3IFdJLlNldHRpbmcoInNvdXJjZS1tYXBzLWVu YWJsZWQiLCB0cnVlKSwKICAgICBzaG93QWxsUmVxdWVzdHNCcmVha3BvaW50OiBuZXcgV0kuU2V0 dGluZygic2hvdy1hbGwtcmVxdWVzdHMtYnJlYWtwb2ludCIsIHRydWUpLAogICAgIHNob3dBc3Nl cnRpb25GYWlsdXJlc0JyZWFrcG9pbnQ6IG5ldyBXSS5TZXR0aW5nKCJzaG93LWFzc2VydGlvbi1m YWlsdXJlcy1icmVha3BvaW50IiwgdHJ1ZSksCiAgICAgc2hvd0NhbnZhc1BhdGg6IG5ldyBXSS5T ZXR0aW5nKCJzaG93LWNhbnZhcy1wYXRoIiwgZmFsc2UpLApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvTmV0d29ya01hbmFnZXIuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9OZXR3b3Jr TWFuYWdlci5qcwppbmRleCAwMzQ0ZTU1NDVkZi4uNDQ0Y2Q5MGJhZDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL05ldHdvcmtNYW5h Z2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL05ldHdvcmtNYW5hZ2VyLmpzCkBAIC0xMDgsNiArMTA4LDkgQEAgV0kuTmV0d29ya01hbmFn ZXIgPSBjbGFzcyBOZXR3b3JrTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgZG93bmxv YWRTb3VyY2VNYXAoc291cmNlTWFwVVJMLCBiYXNlVVJMLCBvcmlnaW5hbFNvdXJjZUNvZGUpCiAg ICAgeworICAgICAgICBpZiAoIVdJLnNldHRpbmdzLnNvdXJjZU1hcHNFbmFibGVkLnZhbHVlKQor ICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIC8vIFRoZSBiYXNlVVJMIGNvdWxkIGhhdmUg Y29tZSBmcm9tIGEgIi8vIyBzb3VyY2VVUkwiLiBBdHRlbXB0IHRvIGdldCBhCiAgICAgICAgIC8v IHJlYXNvbmFibGUgYWJzb2x1dGUgVVJMIGZvciB0aGUgYmFzZSBieSB1c2luZyB0aGUgbWFpbiBy ZXNvdXJjZSdzIFVSTC4KICAgICAgICAgaWYgKFdJLm5ldHdvcmtNYW5hZ2VyLm1haW5GcmFtZSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Nl dHRpbmdzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCmluZGV4IDYwNTExZGUzYjJkLi5k MTIzZGMwMGI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC0y MDcsNiArMjA3LDcgQEAgV0kuU2V0dGluZ3NUYWJDb250ZW50VmlldyA9IGNsYXNzIFNldHRpbmdz VGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5UYWJDb250ZW50VmkKICAgICAgICAgZ2VuZXJhbFNl dHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKIAogICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3 LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkRlYnVnZ2VyOiIpLCBXSS5zZXR0aW5ncy5zaG93U2Nv cGVDaGFpbk9uUGF1c2UsIFdJLlVJU3RyaW5nKCJTaG93IFNjb3BlIENoYWluIG9uIHBhdXNlIikp OworICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIlNv dXJjZSBtYXBzOiIpLCBXSS5zZXR0aW5ncy5zb3VyY2VNYXBzRW5hYmxlZCwgV0kuVUlTdHJpbmco IkVuYWJsZSBzb3VyY2UgbWFwcyIpKTsKIAogICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFk ZFNlcGFyYXRvcigpOwogCg==