193147 2019-01-04 11:00:01 -0800 Web Inspector: Include `globalThis` in default JavaScript completions 2019-01-04 12:30:36 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck keith_miller mark.lam webkit-bug-importer oldest_to_newest 1491736 0 joepeck 2019-01-04 11:00:01 -0800 Include `globalThis` in default JavaScript completions 1491737 1 358336 joepeck 2019-01-04 11:00:44 -0800 Created attachment 358336 [PATCH] Proposed Fix 1491773 2 358336 hi 2019-01-04 11:49:59 -0800 Comment on attachment 358336 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=358336&action=review r=me Is `globalThis` something we'd also want to always show in the Scope chain when paused? > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:661 > "return", "static", "super", "switch", "this", "throw", "true", "try", Should we be including `"globalThis"` in `allKeywords` as well? Ditto (727) (I can't comment on it because it's outside of this diff's range) > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:664 > + var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined", "globalThis"]; `"globalThis"` should be placed before `"Infinity"` if we want to keep it alphabetized. NIT: considering how small this patch is, I wouldn't be against a bit of refactoring (e.g. `.keySet()` to `new Set()`) 1491784 3 358336 joepeck 2019-01-04 12:04:04 -0800 Comment on attachment 358336 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=358336&action=review >> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:661 >> "return", "static", "super", "switch", "this", "throw", "true", "try", > > Should we be including `"globalThis"` in `allKeywords` as well? > > Ditto (727) (I can't comment on it because it's outside of this diff's range) `globalThis` is not a keyword. >> Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:664 >> + var valueKeywords = ["false", "Infinity", "NaN", "null", "this", "true", "undefined", "globalThis"]; > > `"globalThis"` should be placed before `"Infinity"` if we want to keep it alphabetized. > > NIT: considering how small this patch is, I wouldn't be against a bit of refactoring (e.g. `.keySet()` to `new Set()`) Good idea but I'll keep the code as is for now to avoid breaking something inadvertently. 1491804 4 358336 commit-queue 2019-01-04 12:29:34 -0800 Comment on attachment 358336 [PATCH] Proposed Fix Clearing flags on attachment: 358336 Committed r239630: <https://trac.webkit.org/changeset/239630> 1491805 5 commit-queue 2019-01-04 12:29:36 -0800 All reviewed patches have been landed. Closing bug. 1491806 6 webkit-bug-importer 2019-01-04 12:30:36 -0800 <rdar://problem/47054614> 358336 2019-01-04 11:00:44 -0800 2019-01-04 12:29:34 -0800 [PATCH] Proposed Fix globalthis-1.patch text/plain 1710 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFlYTk2OGZmZWI0Li40MTA5YzhkZDIzMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDEtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbmNsdWRlIGBnbG9iYWxUaGlzYCBpbiBkZWZhdWx0IEphdmFTY3JpcHQgY29tcGxldGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzE0Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanM6Cisg ICAgICAgIEFkZCBgZ2xvYmFsVGhpc2Agd2hpY2ggaXMgYSBuZXcgZ2xvYmFsIHZhbHVlLgorCiAy MDE5LTAxLTAyICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFN0eWxlczogc2VsZWN0aW9uIGxvc3Qgd2hlbiBpbnNwZWN0b3Ig aXMgYmx1cnJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckNvbXBs ZXRpb25Db250cm9sbGVyLmpzCmluZGV4IDYyZGM5YTgxODA5Li43Nzc0ZjFjYmE3NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29k ZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxl ci5qcwpAQCAtNjYxLDcgKzY2MSw3IEBAIFdJLkNvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxl ciA9IGNsYXNzIENvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlciBleHRlbmRzCiAgICAgICAg ICAgICAicmV0dXJuIiwgInN0YXRpYyIsICJzdXBlciIsICJzd2l0Y2giLCAidGhpcyIsICJ0aHJv dyIsICJ0cnVlIiwgInRyeSIsCiAgICAgICAgICAgICAidHlwZW9mIiwgInVuZGVmaW5lZCIsICJ2 YXIiLCAidm9pZCIsICJ3aGlsZSIsICJ3aXRoIiwgInlpZWxkIgogICAgICAgICBdOwotICAgICAg ICB2YXIgdmFsdWVLZXl3b3JkcyA9IFsiZmFsc2UiLCAiSW5maW5pdHkiLCAiTmFOIiwgIm51bGwi LCAidGhpcyIsICJ0cnVlIiwgInVuZGVmaW5lZCJdOworICAgICAgICB2YXIgdmFsdWVLZXl3b3Jk cyA9IFsiZmFsc2UiLCAiSW5maW5pdHkiLCAiTmFOIiwgIm51bGwiLCAidGhpcyIsICJ0cnVlIiwg InVuZGVmaW5lZCIsICJnbG9iYWxUaGlzIl07CiAKICAgICAgICAgdmFyIGFsbG93ZWRLZXl3b3Jk c0luc2lkZUJsb2NrcyA9IGFsbEtleXdvcmRzLmtleVNldCgpOwogICAgICAgICB2YXIgYWxsb3dl ZEtleXdvcmRzV2hlbkRlY2xhcmluZ1ZhcmlhYmxlID0gdmFsdWVLZXl3b3Jkcy5rZXlTZXQoKTsK