193139 2019-01-04 06:34:32 -0800 WebDriver: element click command should handle user prompts 2019-01-04 08:28:29 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1491622 0 cgarcia 2019-01-04 06:34:32 -0800 Tests are currently timing out because of this. 1491626 1 358315 cgarcia 2019-01-04 06:36:23 -0800 Created attachment 358315 Patch 1491627 2 ews-watchlist 2019-01-04 06:37:36 -0800 Attachment 358315 did not pass style-queue: ERROR: Source/WebDriver/Session.cpp:1551: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1491643 3 cgarcia 2019-01-04 08:27:31 -0800 Committed r239610: <https://trac.webkit.org/changeset/239610> 1491644 4 webkit-bug-importer 2019-01-04 08:28:29 -0800 <rdar://problem/47048640> 358315 2019-01-04 06:36:23 -0800 2019-01-04 07:23:47 -0800 Patch wd-click-prompts.diff text/plain 5306 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNzY3ZWVmYTQxNTguLmY4MTIzZGEzOWU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGVsZW1lbnQgY2xpY2sgY29t bWFuZCBzaG91bGQgaGFuZGxlIHVzZXIgcHJvbXB0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkRyaXZl cjo6U2Vzc2lvbjo6ZWxlbWVudENsaWNrKTogSGFuZGxlIHVzZXIgcHJvbXB0cy4KKwogMjAxOS0w MS0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dMSUJdIFdlYkRyaXZlcjogYnJvd3NlciBjbG9zZSBub3QgY29ycmVjdGx5IGRldGVjdGVk IG9uIHNlc3Npb24gY2xvc2UgaW4gc29tZSBjYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRy aXZlci9TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAKaW5kZXggOWEy Y2I1MmJmZTMuLjA3MTA3MGYwOTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViRHJpdmVyL1Nlc3Np b24uY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvU2Vzc2lvbi5jcHAKQEAgLTE1MjAsNDEgKzE1 MjAsNDcgQEAgdm9pZCBTZXNzaW9uOjplbGVtZW50Q2xpY2soY29uc3QgU3RyaW5nJiBlbGVtZW50 SUQsIEZ1bmN0aW9uPHZvaWQgKENvbW1hbmRSZXN1bHQKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIE9wdGlvblNldDxFbGVtZW50TGF5b3V0T3B0aW9uPiBvcHRpb25zID0geyBFbGVtZW50 TGF5b3V0T3B0aW9uOjpTY3JvbGxJbnRvVmlld0lmTmVlZGVkLCBFbGVtZW50TGF5b3V0T3B0aW9u OjpVc2VWaWV3cG9ydENvb3JkaW5hdGVzIH07Ci0gICAgY29tcHV0ZUVsZW1lbnRMYXlvdXQoZWxl bWVudElELCBvcHRpb25zLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBl bGVtZW50SUQsIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcild KE9wdGlvbmFsPFJlY3Q+JiYgcmVjdCwgT3B0aW9uYWw8UG9pbnQ+JiYgaW5WaWV3Q2VudGVyLCBi b29sIGlzT2JzY3VyZWQsIFJlZlB0cjxKU09OOjpPYmplY3Q+JiYgZXJyb3IpIG11dGFibGUgewot ICAgICAgICBpZiAoIXJlY3QgfHwgZXJyb3IpIHsKLSAgICAgICAgICAgIGNvbXBsZXRpb25IYW5k bGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoV1RGTW92ZShlcnJvcikpKTsKLSAgICAgICAgICAgIHJl dHVybjsKLSAgICAgICAgfQotICAgICAgICBpZiAoaXNPYnNjdXJlZCkgewotICAgICAgICAgICAg Y29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJv ckNvZGU6OkVsZW1lbnRDbGlja0ludGVyY2VwdGVkKSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0g ICAgICAgIH0KLSAgICAgICAgaWYgKCFpblZpZXdDZW50ZXIpIHsKLSAgICAgICAgICAgIGNvbXBs ZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2Rl OjpFbGVtZW50Tm90SW50ZXJhY3RhYmxlKSk7CisgICAgaGFuZGxlVXNlclByb21wdHMoW3RoaXMs IGVsZW1lbnRJRCwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVy KV0oQ29tbWFuZFJlc3VsdCYmIHJlc3VsdCkgbXV0YWJsZSB7CisgICAgICAgIGlmIChyZXN1bHQu aXNFcnJvcigpKSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKHJlc3Vs dCkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0KLSAgICAgICAgZ2V0RWxlbWVu dFRhZ05hbWUoZWxlbWVudElELCBbdGhpcywgZWxlbWVudElELCBpblZpZXdDZW50ZXIgPSBXVEZN b3ZlKGluVmlld0NlbnRlciksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcildKENvbW1hbmRSZXN1bHQmJiByZXN1bHQpIG11dGFibGUgewotICAgICAgICAgICAg Ym9vbCBpc09wdGlvbkVsZW1lbnQgPSBmYWxzZTsKLSAgICAgICAgICAgIGlmICghcmVzdWx0Lmlz RXJyb3IoKSkgewotICAgICAgICAgICAgICAgIFN0cmluZyB0YWdOYW1lOwotICAgICAgICAgICAg ICAgIGlmIChyZXN1bHQucmVzdWx0KCktPmFzU3RyaW5nKHRhZ05hbWUpKQotICAgICAgICAgICAg ICAgICAgICBpc09wdGlvbkVsZW1lbnQgPSB0YWdOYW1lID09ICJvcHRpb24iOworICAgICAgICBP cHRpb25TZXQ8RWxlbWVudExheW91dE9wdGlvbj4gb3B0aW9ucyA9IHsgRWxlbWVudExheW91dE9w dGlvbjo6U2Nyb2xsSW50b1ZpZXdJZk5lZWRlZCwgRWxlbWVudExheW91dE9wdGlvbjo6VXNlVmll d3BvcnRDb29yZGluYXRlcyB9OworICAgICAgICBjb21wdXRlRWxlbWVudExheW91dChlbGVtZW50 SUQsIG9wdGlvbnMsIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGVsZW1l bnRJRCwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oT3B0 aW9uYWw8UmVjdD4mJiByZWN0LCBPcHRpb25hbDxQb2ludD4mJiBpblZpZXdDZW50ZXIsIGJvb2wg aXNPYnNjdXJlZCwgUmVmUHRyPEpTT046Ok9iamVjdD4mJiBlcnJvcikgbXV0YWJsZSB7CisgICAg ICAgICAgICBpZiAoIXJlY3QgfHwgZXJyb3IpIHsKKyAgICAgICAgICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKFdURk1vdmUoZXJyb3IpKSk7CisgICAgICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKGlzT2JzY3VyZWQp IHsKKyAgICAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWls KENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6RWxlbWVudENsaWNrSW50ZXJjZXB0ZWQpKTsKKyAg ICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAgICAgICBpZiAoIWlu Vmlld0NlbnRlcikgeworICAgICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRS ZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpFbGVtZW50Tm90SW50ZXJhY3Rh YmxlKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogCi0gICAgICAg ICAgICBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiBjb250aW51ZUFmdGVyQ2xpY2tG dW5jdGlvbiA9IFt0aGlzLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhh bmRsZXIpXShDb21tYW5kUmVzdWx0JiYgcmVzdWx0KSBtdXRhYmxlIHsKLSAgICAgICAgICAgICAg ICBpZiAocmVzdWx0LmlzRXJyb3IoKSkgewotICAgICAgICAgICAgICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihXVEZNb3ZlKHJlc3VsdCkpOwotICAgICAgICAgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgICAgICBnZXRFbGVtZW50VGFnTmFtZShlbGVtZW50SUQsIFt0aGlzLCBlbGVtZW50SUQs IGluVmlld0NlbnRlciA9IFdURk1vdmUoaW5WaWV3Q2VudGVyKSwgY29tcGxldGlvbkhhbmRsZXIg PSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oQ29tbWFuZFJlc3VsdCYmIHJlc3VsdCkgbXV0 YWJsZSB7CisgICAgICAgICAgICAgICAgYm9vbCBpc09wdGlvbkVsZW1lbnQgPSBmYWxzZTsKKyAg ICAgICAgICAgICAgICBpZiAoIXJlc3VsdC5pc0Vycm9yKCkpIHsKKyAgICAgICAgICAgICAgICAg ICAgU3RyaW5nIHRhZ05hbWU7CisgICAgICAgICAgICAgICAgICAgIGlmIChyZXN1bHQucmVzdWx0 KCktPmFzU3RyaW5nKHRhZ05hbWUpKQorICAgICAgICAgICAgICAgICAgICAgICAgaXNPcHRpb25F bGVtZW50ID0gdGFnTmFtZSA9PSAib3B0aW9uIjsKICAgICAgICAgICAgICAgICB9CiAKLSAgICAg ICAgICAgICAgICB3YWl0Rm9yTmF2aWdhdGlvblRvQ29tcGxldGUoV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcikpOwotICAgICAgICAgICAgfTsKLSAgICAgICAgICAgIGlmIChpc09wdGlvbkVsZW1l bnQpCi0gICAgICAgICAgICAgICAgc2VsZWN0T3B0aW9uRWxlbWVudChlbGVtZW50SUQsIFdURk1v dmUoY29udGludWVBZnRlckNsaWNrRnVuY3Rpb24pKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAg ICAgICAgICAgICBwZXJmb3JtTW91c2VJbnRlcmFjdGlvbihpblZpZXdDZW50ZXIudmFsdWUoKS54 LCBpblZpZXdDZW50ZXIudmFsdWUoKS55LCBNb3VzZUJ1dHRvbjo6TGVmdCwgTW91c2VJbnRlcmFj dGlvbjo6U2luZ2xlQ2xpY2ssIFdURk1vdmUoY29udGludWVBZnRlckNsaWNrRnVuY3Rpb24pKTsK KyAgICAgICAgICAgICAgICBGdW5jdGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiBjb250aW51 ZUFmdGVyQ2xpY2tGdW5jdGlvbiA9IFt0aGlzLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpXShDb21tYW5kUmVzdWx0JiYgcmVzdWx0KSBtdXRhYmxlIHsKKyAg ICAgICAgICAgICAgICAgICAgaWYgKHJlc3VsdC5pc0Vycm9yKCkpIHsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURk1vdmUocmVzdWx0KSk7CisgICAgICAgICAg ICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgICAgIH0KKworICAgICAgICAg ICAgICAgICAgICB3YWl0Rm9yTmF2aWdhdGlvblRvQ29tcGxldGUoV1RGTW92ZShjb21wbGV0aW9u SGFuZGxlcikpOworICAgICAgICAgICAgICAgIH07CisgICAgICAgICAgICAgICAgaWYgKGlzT3B0 aW9uRWxlbWVudCkKKyAgICAgICAgICAgICAgICAgICAgc2VsZWN0T3B0aW9uRWxlbWVudChlbGVt ZW50SUQsIFdURk1vdmUoY29udGludWVBZnRlckNsaWNrRnVuY3Rpb24pKTsKKyAgICAgICAgICAg ICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIHBlcmZvcm1Nb3VzZUludGVyYWN0aW9uKGlu Vmlld0NlbnRlci52YWx1ZSgpLngsIGluVmlld0NlbnRlci52YWx1ZSgpLnksIE1vdXNlQnV0dG9u OjpMZWZ0LCBNb3VzZUludGVyYWN0aW9uOjpTaW5nbGVDbGljaywgV1RGTW92ZShjb250aW51ZUFm dGVyQ2xpY2tGdW5jdGlvbikpOworICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwogICAgIH0p OwogfQo=