193136 2019-01-04 03:57:33 -0800 [GTK] install-dependencies should install python3-setuptools, libunistring-dev, bison, flex 2019-01-05 17:21:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 obrufau obrufau agomez clopez commit-queue ews-watchlist lforschler ltilve mcatanzaro rego webkit-bug-importer oldest_to_newest 1491613 0 obrufau 2019-01-04 03:57:33 -0800 I tried to compile WebKitGTK+ in a new PC with Ubuntu 18.04 but Tools/Scripts/update-webkitgtk-libs failed because python3-setuptools, libunistring-dev, bison and flex were not installed. They should have been installed by Tools/gtk/install-dependencies. 1491614 1 obrufau 2019-01-04 04:41:00 -0800 Bison and Flex dependencies were removed in bug 193033 1491731 2 obrufau 2019-01-04 10:45:32 -0800 More precisely, - python3-setuptools is needed for meson: python3 setup.py build --build-base WebKitBuild/DependenciesGTK/Build/meson-0.48.1 Traceback (most recent call last): File "setup.py", line 26, in <module> from setuptools import setup ModuleNotFoundError: No module named 'setuptools' Failed to build GTK+ port dependencies with jhbuild - libunistring-dev is needed for libpsl: WebKitBuild/DependenciesGTK/Source/libpsl-0.20.2/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-static --disable-gtk-doc checking for LIBIDN2... yes checking for library containing u8_tolower... no configure: error: You requested libidn2|libidn but libunistring is not installed. Failed to build GTK+ port dependencies with jhbuild - bison is needed for gstreamer: WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc checking for bison... no configure: error: Could not find bison Failed to build GTK+ port dependencies with jhbuild - flex is also needed for gstreamer: WebKitBuild/DependenciesGTK/Source/gstreamer-1.14.4/configure --prefix WebKitBuild/DependenciesGTK/Root --disable-Werror --disable-gtk-doc --disable-introspection --disable-examples --disable-tests --disable-static --disable-gtk-doc checking for flex... no configure: error: Could not find flex Failed to build GTK+ port dependencies with jhbuild 1491732 3 358335 obrufau 2019-01-04 10:46:42 -0800 Created attachment 358335 Patch 1491735 4 obrufau 2019-01-04 10:54:27 -0800 Not sure if I should also add the packages for brew, pacman and dnf. 1492079 5 mcatanzaro 2019-01-05 09:34:12 -0800 You need to add them for Arch and Fedora, yes. You can ignore brew because (a) it's very different from Linux and probably requires specialized expertise to enable, and (b) WebKitGTK+ hasn't been buildable on Mac in a couple years AFAIK. 1492080 6 358439 obrufau 2019-01-05 09:52:52 -0800 Created attachment 358439 Patch 1492105 7 358439 commit-queue 2019-01-05 17:19:11 -0800 Comment on attachment 358439 Patch Clearing flags on attachment: 358439 Committed r239660: <https://trac.webkit.org/changeset/239660> 1492106 8 commit-queue 2019-01-05 17:19:12 -0800 All reviewed patches have been landed. Closing bug. 1492107 9 webkit-bug-importer 2019-01-05 17:21:30 -0800 <rdar://problem/47068948> 358335 2019-01-04 10:46:42 -0800 2019-01-05 09:52:48 -0800 Patch bug-193136-20190104194641.patch text/plain 1783 obrufau U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDhkNjQyYTczMWRlMGNiNWRlZmMwZTk2MWRhMjQ1MWQw NDQyYTllNy4uM2JhOTZmZWZjMDBmN2M2NjI1OTc1OWQ2NTg3ZWQ3ZDVjZDU4OWVhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAxLTA0ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gQWRkIHB5dGhvbjMtc2V0dXB0b29scywgbGlidW5pc3RyaW5nLWRldiwgYmlz b24gYW5kIGZsZXggZGVwZW5kZW5jaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTMxMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKyAgICAgICAgQWRk IHB5dGhvbjMtc2V0dXB0b29scywgbGlidW5pc3RyaW5nLWRldiwgYmlzb24gYW5kIGZsZXggdG8g aW5zdGFsbC1kZXBlbmRlbmNpZXMsCisgICAgICAgIHRoZXkgYXJlIG5lZWRlZCBieSB1cGRhdGUt d2Via2l0Z3RrLWxpYnMuCisKIDIwMTktMDEtMDMgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNs aW5nQHNvbnkuY29tPgogCiAgICAgICAgIHRlc3QyNjItcnVubmVyIG1pc2JlaGF2ZXMgd2hlbiB0 ZXN0IGZpbGUgWUFNTCBoYXMgYSB0cmFpbGluZyBzcGFjZQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr L2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmlu ZGV4IGQ0ZDc5ZTU3ZTBjNDI2ZjNkYzM1NWEyNmMyZmFkYjZmZjExMWJlMzguLjVjOGQwZjRmMDVi MzY5NTE2NTRmZTkyN2M0ZGVjNDRjMzRhMTU5NTAgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0 YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAg LTE3Myw2ICsxNzMsOCBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAK ICAgICAjIFRoZXNlIGFyZSBkZXBlbmRlbmNpZXMgbmVjZXNzYXJ5IGZvciBidWlsZGluZyB0aGUg amhidWlsZC4KICAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKKyAgICAgICAgYmlzb24gXAorICAg ICAgICBmbGV4IFwKICAgICAgICAgZ2l0IFwKICAgICAgICAgZ29iamVjdC1pbnRyb3NwZWN0aW9u IFwKICAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXYgXApAQCAtMTk4LDYgKzIw MCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgbGli cHNsLWRldiBcCiAgICAgICAgIGxpYnNzbC1kZXYgXAogICAgICAgICBsaWJ0aWZmNS1kZXYgXAor ICAgICAgICBsaWJ1bmlzdHJpbmctZGV2IFwKICAgICAgICAgbGlidjRsLWRldiBcCiAgICAgICAg IGxpYnhjYi1jb21wb3NpdGUwLWRldiBcCiAgICAgICAgIGxpYnhjYi14Zml4ZXMwLWRldiBcCkBA IC0yMDksNiArMjEyLDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewog ICAgICAgICBsaWJ1ZGV2LWRldiBcCiAgICAgICAgIGxpYnhtbC1saWJ4bWwtcGVybCBcCiAgICAg ICAgIHB5dGhvbi1kZXYgXAorICAgICAgICBweXRob24zLXNldHVwdG9vbHMgXAogICAgICAgICBy YWdlbCBcCiAgICAgICAgIHgxMXByb3RvLWJpZ3JlcXMtZGV2IFwKICAgICAgICAgeDExcHJvdG8t Y29tcG9zaXRlLWRldiBcCg== 358439 2019-01-05 09:52:52 -0800 2019-01-05 17:19:11 -0800 Patch bug-193136-20190105185251.patch text/plain 3334 obrufau U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDhkNjQyYTczMWRlMGNiNWRlZmMwZTk2MWRhMjQ1MWQw NDQyYTllNy4uM2JhOTZmZWZjMDBmN2M2NjI1OTc1OWQ2NTg3ZWQ3ZDVjZDU4OWVhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAxLTA0ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gQWRkIHB5dGhvbjMtc2V0dXB0b29scywgbGlidW5pc3RyaW5nLWRldiwgYmlz b24gYW5kIGZsZXggZGVwZW5kZW5jaWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTMxMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKyAgICAgICAgQWRk IHB5dGhvbjMtc2V0dXB0b29scywgbGlidW5pc3RyaW5nLWRldiwgYmlzb24gYW5kIGZsZXggdG8g aW5zdGFsbC1kZXBlbmRlbmNpZXMsCisgICAgICAgIHRoZXkgYXJlIG5lZWRlZCBieSB1cGRhdGUt d2Via2l0Z3RrLWxpYnMuCisKIDIwMTktMDEtMDMgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNs aW5nQHNvbnkuY29tPgogCiAgICAgICAgIHRlc3QyNjItcnVubmVyIG1pc2JlaGF2ZXMgd2hlbiB0 ZXN0IGZpbGUgWUFNTCBoYXMgYSB0cmFpbGluZyBzcGFjZQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr L2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmlu ZGV4IGQ0ZDc5ZTU3ZTBjNDI2ZjNkYzM1NWEyNmMyZmFkYjZmZjExMWJlMzguLjU5YThmNzM1Y2M3 NGQ5Zjc1OWE3ZTQ3YjM4NDRkZTZhMzU1ZGFjMjAgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0 YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAg LTE3Myw2ICsxNzMsOCBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAK ICAgICAjIFRoZXNlIGFyZSBkZXBlbmRlbmNpZXMgbmVjZXNzYXJ5IGZvciBidWlsZGluZyB0aGUg amhidWlsZC4KICAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKKyAgICAgICAgYmlzb24gXAorICAg ICAgICBmbGV4IFwKICAgICAgICAgZ2l0IFwKICAgICAgICAgZ29iamVjdC1pbnRyb3NwZWN0aW9u IFwKICAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXYgXApAQCAtMTk4LDYgKzIw MCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgbGli cHNsLWRldiBcCiAgICAgICAgIGxpYnNzbC1kZXYgXAogICAgICAgICBsaWJ0aWZmNS1kZXYgXAor ICAgICAgICBsaWJ1bmlzdHJpbmctZGV2IFwKICAgICAgICAgbGlidjRsLWRldiBcCiAgICAgICAg IGxpYnhjYi1jb21wb3NpdGUwLWRldiBcCiAgICAgICAgIGxpYnhjYi14Zml4ZXMwLWRldiBcCkBA IC0yMDksNiArMjEyLDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewog ICAgICAgICBsaWJ1ZGV2LWRldiBcCiAgICAgICAgIGxpYnhtbC1saWJ4bWwtcGVybCBcCiAgICAg ICAgIHB5dGhvbi1kZXYgXAorICAgICAgICBweXRob24zLXNldHVwdG9vbHMgXAogICAgICAgICBy YWdlbCBcCiAgICAgICAgIHgxMXByb3RvLWJpZ3JlcXMtZGV2IFwKICAgICAgICAgeDExcHJvdG8t Y29tcG9zaXRlLWRldiBcCkBAIC0zMzQsNyArMzM4LDkgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVu ZGVuY2llc1dpdGhQYWNtYW4gewogICAgICMgVGhlc2UgYXJlIGRlcGVuZGVuY2llcyBuZWNlc3Nh cnkgZm9yIGJ1aWxkaW5nIHRoZSBqaGJ1aWxkLgogICAgICMgTm90ZTogQ291bGQgbm90IGZpbmQg bGliZWdsLW1lc2EKICAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKKyAgICAgICAgYmlzb24gXAog ICAgICAgICBleHBhdCBcCisgICAgICAgIGZsZXggXAogICAgICAgICBnaXQgXAogICAgICAgICBn bnV0bHMgXAogICAgICAgICBnb2JqZWN0LWludHJvc3BlY3Rpb24gXApAQCAtMzUyLDYgKzM1OCw3 IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoUGFjbWFuIHsKICAgICAgICAgbGli cHJveHkgXAogICAgICAgICBsaWJwc2wgXAogICAgICAgICBsaWJ0aWZmIFwKKyAgICAgICAgbGli dW5pc3RyaW5nLWRldiBcCiAgICAgICAgIGxpYnhmaXhlcyBcCiAgICAgICAgIGxpYnhmb250MiBc CiAgICAgICAgIGxpYnhjYiBcCkBAIC0zNjIsNiArMzY5LDcgQEAgZnVuY3Rpb24gaW5zdGFsbERl cGVuZGVuY2llc1dpdGhQYWNtYW4gewogICAgICAgICBwZXJsLXhtbC1saWJ4bWxcCiAgICAgICAg IHB5dGhvbjIgXAogICAgICAgICBweXRob24yLWx4bWwgXAorICAgICAgICBweXRob24zLXNldHVw dG9vbHMgXAogICAgICAgICByYWdlbCBcCiAgICAgICAgIGJpZ3JlcXNwcm90byBcCiAgICAgICAg IGNvbXBvc2l0ZXByb3RvIFwKQEAgLTQ5Nyw5ICs1MDUsMTEgQEAgZnVuY3Rpb24gaW5zdGFsbERl cGVuZGVuY2llc1dpdGhEbmYgewogCiAgICAgIyBUaGVzZSBhcmUgZGVwZW5kZW5jaWVzIG5lY2Vz c2FyeSBmb3IgYnVpbGRpbmcgdGhlIGpoYnVpbGQuCiAgICAgcGFja2FnZXM9IiRwYWNrYWdlcyBc CisgICAgICAgIGJpc29uIFwKICAgICAgICAgY3Vwcy1kZXZlbCBcCiAgICAgICAgIGRvY2Jvb2st dXRpbHMgXAogICAgICAgICBleHBhdC1kZXZlbCBcCisgICAgICAgIGZsZXggXAogICAgICAgICBn aXQgXAogICAgICAgICBnbnV0bHMtZGV2ZWwgXAogICAgICAgICBnb2JqZWN0LWludHJvc3BlY3Rp b24gXApAQCAtNTE4LDYgKzUyOCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRo RG5mIHsKICAgICAgICAgbGlicHJveHktZGV2ZWwgXAogICAgICAgICBsaWJwc2wtZGV2ZWwgXAog ICAgICAgICBsaWJ0aWZmLWRldmVsIFwKKyAgICAgICAgbGlidW5pc3RyaW5nLWRldiBcCiAgICAg ICAgIGxpYnhjYi1kZXZlbCBcCiAgICAgICAgIGxpYnhrYmZpbGUtZGV2ZWwgXAogICAgICAgICBs aWJ4a2Jjb21tb24teDExLWRldmVsIFwKQEAgLTUyNSw2ICs1MzYsNyBAQCBmdW5jdGlvbiBpbnN0 YWxsRGVwZW5kZW5jaWVzV2l0aERuZiB7CiAgICAgICAgIG10ZGV2LWRldmVsIFwKICAgICAgICAg b3JjLWRldmVsIFwKICAgICAgICAgcGVybC1YTUwtTGliWE1MIFwKKyAgICAgICAgcHl0aG9uMy1z ZXR1cHRvb2xzIFwKICAgICAgICAgcmFnZWwgXAogICAgICAgICBzeXN0ZW1kLWRldmVsIFwKICAg ICAgICAgeG9yZy14MTEtZm9udC11dGlscyBcCg==