193122 2019-01-03 12:54:28 -0800 Leak of WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback (48 bytes) in com.apple.WebKit.WebContent running WebKit layout tests 2019-01-03 16:22:33 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer cdumez commit-queue eric.carlson mcatanzaro webkit-bug-importer youennf oldest_to_newest 1491496 0 ddkilzer 2019-01-03 12:54:28 -0800 Leak of WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback (48 bytes) in com.apple.WebKit.WebContent running WebKit layout tests. $ ./Tools/Scripts/run-webkit-tests --no-build --debug --batch-size=1000 --child-processes=1 --verbose --leaks --no-retry --no-show-results imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html NOTE: Requires changes to run-webkit-tests to support --leaks with WebKit2. STACK OF 1 INSTANCE OF 'ROOT LEAK: <WebCore>': [thread 0x109a495c0]: 34 libdyld.dylib 0x7fff6611008d start + 1 33 com.apple.WebKit.WebContent 0x1099547bb invocation function for block in WebKit::XPCServiceEventHandler(NSObject<OS_xpc_object>*) + 0 XPCServiceMain.mm:46 32 com.apple.WebKit.WebContent 0x109954636 WebKit::XPCServiceMain(int, char const**) + 547 XPCServiceMain.mm:0 31 libxpc.dylib 0x7fff663469e5 _xpc_copy_xpcservice_dictionary + 0 30 libxpc.dylib 0x7fff66346ee6 _xpc_objc_main + 555 29 com.apple.Foundation 0x7fff3b21b28f -[NSRunLoop(NSRunLoop) run] + 76 28 com.apple.Foundation 0x7fff3b21b3ba -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 280 27 com.apple.CoreFoundation 0x7fff38e96be6 CFRunLoopRunSpecific + 467 26 com.apple.CoreFoundation 0x7fff38e976c4 __CFRunLoopRun + 2187 25 com.apple.CoreFoundation 0x7fff38eb611d __CFRunLoopDoTimers + 333 24 com.apple.CoreFoundation 0x7fff38eb65e8 __CFRunLoopDoTimer + 871 23 com.apple.CoreFoundation 0x7fff38eb6a35 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 22 com.apple.WebCore 0x632663cef WebCore::timerFired(__CFRunLoopTimer*, void*) + 31 MainThreadSharedTimerCF.cpp:75 21 com.apple.WebCore 0x6326426f9 WebCore::ThreadTimers::sharedTimerFiredInternal() + 185 ThreadTimers.cpp:120 20 com.apple.WebCore 0x632557a71 WebCore::PostMessageTimer::fired() + 97 DOMWindow.cpp:178 19 com.apple.WebCore 0x632550622 WebCore::DOMWindow::postMessageTimerFired(WebCore::PostMessageTimer&) + 210 Ref.h:59 18 com.apple.WebCore 0x63218c888 WebCore::EventTarget::dispatchEvent(WebCore::Event&) + 136 EventTarget.cpp:201 17 com.apple.WebCore 0x63218ab93 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) + 515 Vector.h:674 16 com.apple.WebCore 0x63218cbe8 WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul>, WebCore::EventTarget::EventInvokePhase) + 824 InspectorInstrumentation.h:279 15 com.apple.WebCore 0x631f18170 WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) + 1024 JSEventListener.cpp:175 14 com.apple.WebCore 0x631f00414 WebCore::JSExecState::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) + 100 JSExecState.h:74 13 com.apple.JavaScriptCore 0x6361779fb JSC::profiledCall(JSC::ExecState*, JSC::ProfilingReason, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&) + 187 CallData.cpp:41 12 com.apple.JavaScriptCore 0x635f30f25 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 469 JITCodeInlines.h:39 11 com.apple.JavaScriptCore 0x635958919 vmEntryToJavaScript + 200 LowLevelInterpreter64.asm:295 10 com.apple.JavaScriptCore 0x635967a61 llint_entry + 61326 LowLevelInterpreter.asm:899 9 com.apple.JavaScriptCore 0x635967a61 llint_entry + 61326 LowLevelInterpreter.asm:899 8 com.apple.JavaScriptCore 0x635967a61 llint_entry + 61326 LowLevelInterpreter.asm:899 7 0x42f928e01177 0x42f928e01000 + 375 6 com.apple.WebCore 0x631a5ddd2 WebCore::jsRTCPeerConnectionConstructorFunctionGenerateCertificate(JSC::ExecState*) + 178 Ref.h:59 5 com.apple.WebCore 0x631e160a9 WebCore::RTCPeerConnection::generateCertificate(JSC::ExecState&, WTF::Variant<JSC::Strong<JSC::JSObject>, WTF::String>&&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::RTCCertificate> >&&) + 969 Expected.h:352 4 com.apple.WebCore 0x631e0cc84 WebCore::PeerConnectionBackend::generateCertificate(WebCore::Document&, WebCore::PeerConnectionBackend::CertificateInformation const&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::RTCCertificate> >&&) + 68 Ref.h:59 3 com.apple.WebCore 0x631e1bb67 WebCore::LibWebRTCCertificateGenerator::generateCertificate(WTF::Ref<WebCore::SecurityOrigin, WTF::DumbPtrTraits<WebCore::SecurityOrigin> >&&, WebCore::LibWebRTCProvider&, WebCore::PeerConnectionBackend::CertificateInformation const&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::RTCCertificate> >&&) + 39 ThreadSafeRefCounted.h:37 2 com.apple.JavaScriptCore 0x635719ea9 WTF::fastMalloc(unsigned long) + 9 FastMalloc.cpp:188 1 libsystem_malloc.dylib 0x7fff662bd783 malloc + 24 0 libsystem_malloc.dylib 0x7fff662bd82b malloc_zone_malloc + 139 ==== 1 (48 bytes) ROOT LEAK: <WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback 0x7fafc77195a0> [48] 1491497 1 ddkilzer 2019-01-03 12:54:39 -0800 <rdar://problem/47022987> 1491503 2 358273 ddkilzer 2019-01-03 13:00:40 -0800 Created attachment 358273 Patch v1 1491540 3 358273 commit-queue 2019-01-03 16:22:31 -0800 Comment on attachment 358273 Patch v1 Clearing flags on attachment: 358273 Committed r239602: <https://trac.webkit.org/changeset/239602> 1491541 4 commit-queue 2019-01-03 16:22:33 -0800 All reviewed patches have been landed. Closing bug. 358273 2019-01-03 13:00:40 -0800 2019-01-03 16:22:31 -0800 Patch v1 bug-193122-20190103130039.patch text/plain 2775 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJhNDJlYTI0YWUxYmEx NjBkZTBkM2VhOThiOWI0MmJkMWY5ZDE2OC4uMGJhNDAyMTZiM2MyZTcyZGYyNWM0MzIwNWM1OWIz YTE2YjQ4MjI2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAxLTAzICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTGVhayBvZiBXZWJDb3Jl OjpMaWJXZWJSVENDZXJ0aWZpY2F0ZUdlbmVyYXRvcjo6UlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JD YWxsYmFjayAoNDggYnl0ZXMpIGluIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBydW5uaW5n IFdlYktpdCBsYXlvdXQgdGVzdHMKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE5MzEy Mj4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3MDIyOTg3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDQ2VydGlmaWNhdGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGliV2ViUlRDQ2VydGlmaWNhdGVHZW5lcmF0b3I6OlJUQ0NlcnRpZmljYXRlR2VuZXJhdG9y Q2FsbGJhY2s6OkFkZFJlZiBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENDZXJ0 aWZpY2F0ZUdlbmVyYXRvcjo6UlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JDYWxsYmFjazo6UmVsZWFz ZSBjb25zdCk6CisgICAgICAgIC0gUmVtb3ZlIGBmaW5hbGAga2V5d29yZCBzbyB0aGF0CisgICAg ICAgICAgYG5ldyBydGM6OlJlZkNvdW50ZWRPYmplY3Q8UlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JD YWxsYmFjaz4oKWAKKyAgICAgICAgICBjYW4gYmUgY2FsbGVkLgorICAgICAgICAoV2ViQ29yZTo6 TGliV2ViUlRDQ2VydGlmaWNhdGVHZW5lcmF0b3I6OmdlbmVyYXRlQ2VydGlmaWNhdGUpOgorICAg ICAgICAtIFRvIGZpeCB0aGUgbGVhayBjYWxsCisgICAgICAgICAgYG5ldyBydGM6OlJlZkNvdW50 ZWRPYmplY3Q8UlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JDYWxsYmFjaz4oKWAKKyAgICAgICAgICB0 byBjcmVhdGUgdGhlIG9iamVjdC4KKwogMjAxOC0xMi0yMyAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIExlYWsgb2YgQ01TYW1wbGVCdWZmZXIgKDc1MiBieXRl cykgaW4gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IHJ1bm5pbmcgV2ViS2l0IGxheW91dCB0 ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDQ2VydGlmaWNhdGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQ2VydGlmaWNhdGVHZW5lcmF0 b3IuY3BwCmluZGV4IDhhMDg4YmUzZTNjY2UxNTFmZjFlYzU0NTQ5NzZmYjE3ZWRhZDg0NzQuLjk2 ODdmNDU5NjljMGE1ODEwYzE3ZDMyNzBjZmRiMGEwYjU3OTI2ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ0NlcnRpZmlj YXRlR2VuZXJhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L2xpYndlYnJ0Yy9MaWJXZWJSVENDZXJ0aWZpY2F0ZUdlbmVyYXRvci5jcHAKQEAgLTUzLDggKzUz LDggQEAgcHVibGljOgogICAgIHsKICAgICB9CiAKLSAgICB2b2lkIEFkZFJlZigpIGNvbnN0IGZp bmFsIHsgcmVmKCk7IH0KLSAgICBydGM6OlJlZkNvdW50UmVsZWFzZVN0YXR1cyBSZWxlYXNlKCkg Y29uc3QgZmluYWwKKyAgICB2b2lkIEFkZFJlZigpIGNvbnN0IHsgcmVmKCk7IH0KKyAgICBydGM6 OlJlZkNvdW50UmVsZWFzZVN0YXR1cyBSZWxlYXNlKCkgY29uc3QKICAgICB7CiAgICAgICAgIGF1 dG8gcmVzdWx0ID0gcmVmQ291bnQoKSAtIDE7CiAgICAgICAgIGRlcmVmKCk7CkBAIC0xMDYsNyAr MTA2LDcgQEAgc3RhdGljIGlubGluZSBydGM6OktleVBhcmFtcyBrZXlQYXJhbXNGcm9tQ2VydGlm aWNhdGVUeXBlKGNvbnN0IFBlZXJDb25uZWN0aW9uQmEKIAogdm9pZCBnZW5lcmF0ZUNlcnRpZmlj YXRlKFJlZjxTZWN1cml0eU9yaWdpbj4mJiBvcmlnaW4sIExpYldlYlJUQ1Byb3ZpZGVyJiBwcm92 aWRlciwgY29uc3QgUGVlckNvbm5lY3Rpb25CYWNrZW5kOjpDZXJ0aWZpY2F0ZUluZm9ybWF0aW9u JiBpbmZvLCBET01Qcm9taXNlRGVmZXJyZWQ8SURMSW50ZXJmYWNlPFJUQ0NlcnRpZmljYXRlPj4m JiBwcm9taXNlKQogewotICAgIHJ0Yzo6c2NvcGVkX3JlZnB0cjxSVENDZXJ0aWZpY2F0ZUdlbmVy YXRvckNhbGxiYWNrPiBjYWxsYmFjayhuZXcgUlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JDYWxsYmFj ayhXVEZNb3ZlKG9yaWdpbiksIFdURk1vdmUocHJvbWlzZSkpKTsKKyAgICBydGM6OnNjb3BlZF9y ZWZwdHI8UlRDQ2VydGlmaWNhdGVHZW5lcmF0b3JDYWxsYmFjaz4gY2FsbGJhY2sobmV3IHJ0Yzo6 UmVmQ291bnRlZE9iamVjdDxSVENDZXJ0aWZpY2F0ZUdlbmVyYXRvckNhbGxiYWNrPihXVEZNb3Zl KG9yaWdpbiksIFdURk1vdmUocHJvbWlzZSkpKTsKIAogICAgIGFic2w6Om9wdGlvbmFsPHVpbnQ2 NF90PiBleHBpcmVzTXM7CiAgICAgaWYgKGluZm8uZXhwaXJlcykK