193113 2019-01-03 10:49:17 -0800 Crash under WebPageProxy::continueNavigationInNewProcess() 2019-01-04 14:10:27 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren webkit-bug-importer oldest_to_newest 1491463 0 cdumez 2019-01-03 10:49:17 -0800 Crash under WebPageProxy::continueNavigationInNewProcess(): Thread[0] EXC_BREAKPOINT (SIGTRAP) (0x0000000000000001, 0x000000019939e500) [ 0] 0x000000019939e500 WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6>::call() [inlined] std::optional<WebCore::FrameLoadType>::operator*() && at Optional.h:531:5 0x000000019939e4f0: ldraa x9, [x8, #0x8]! 0x000000019939e4f4: movk x8, #0xa345, lsl #48 0x000000019939e4f8: blraa x9, x8 0x000000019939e4fc: b 0x1e2134 ; <+300> at Function.h:101 -> 0x000000019939e500: brk #0x1 0x000000019939e504: adrp x1, 671 0x000000019939e508: add x1, x1, #0x238 ; =0x238 0x000000019939e50c: adrp x2, 671 0x000000019939e510: add x2, x2, #0x990 ; =0x990 [ 0] 0x000000019939e500 WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6>::call() [inlined] WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6::operator()() + 948 at WebPageProxy.cpp:2692 2688 } 2689 return &item != targetItem; 2690 }); 2691 m_process->send(Messages::WebPage::UpdateBackForwardListForReattach(WTFMove(itemStates)), m_pageID); -> 2692 m_process->send(Messages::WebPage::GoToBackForwardItem(navigation->navigationID(), item->itemID(), *navigation->backForwardFrameLoadType(), ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies)), m_pageID); 2693 m_process->responsivenessTimer().start(); 2694 2695 return; 2696 } [ 0] 0x000000019939e14c WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6>::call() + 324 at Function.h:101 [ 1] 0x000000019939e0d3 WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6>::call() [inlined] WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6::operator()() + 167 at WebPageProxy.cpp:2691:24 2687 return false; 2688 } 2689 return &item != targetItem; 2690 }); -> 2691 m_process->send(Messages::WebPage::UpdateBackForwardListForReattach(WTFMove(itemStates)), m_pageID); 2692 m_process->send(Messages::WebPage::GoToBackForwardItem(navigation->navigationID(), item->itemID(), *navigation->backForwardFrameLoadType(), ShouldTreatAsContinuingLoad::Yes, WTFMove(websitePolicies)), m_pageID); 2693 m_process->responsivenessTimer().start(); 2694 2695 return; [ 1] 0x000000019939e02c WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&)::$_6>::call() + 36 at Function.h:101 [ 2] 0x000000019937f443 WebKit`WebKit::WebPageProxy::swapToWebProcess(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, API::Navigation&, std::optional<unsigned long long>, WTF::CompletionHandler<void ()>&&)::$_1::operator()() [inlined] WTF::Function<void ()>::operator()() const + 19 at Function.h:56:35 [ 2] 0x000000019937f430 WebKit`WebKit::WebPageProxy::swapToWebProcess(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, API::Navigation&, std::optional<unsigned long long>, WTF::CompletionHandler<void ()>&&)::$_1::operator()() [inlined] WTF::CompletionHandler<void ()>::operator()() + 8 at CompletionHandler.h:59 [ 2] 0x000000019937f428 WebKit`WebKit::WebPageProxy::swapToWebProcess(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, API::Navigation&, std::optional<unsigned long long>, WTF::CompletionHandler<void ()>&&)::$_1::operator()() + 348 at WebPageProxy.cpp:801 [ 3] 0x000000019937f1ef WebKit`WebKit::WebPageProxy::swapToWebProcess(WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, API::Navigation&, std::optional<unsigned long long>, WTF::CompletionHandler<void ()>&&) + 443 at WebPageProxy.cpp:807:9 [ 4] 0x000000019938684b WebKit`WebKit::WebPageProxy::continueNavigationInNewProcess(API::Navigation&, WTF::Ref<WebKit::WebProcessProxy, WTF::DumbPtrTraits<WebKit::WebProcessProxy> >&&, std::optional<WebKit::WebsitePoliciesData>&&) + 439 at WebPageProxy.cpp:2677:5 [ 5] 0x0000000199386307 WebKit`WebKit::WebPageProxy::receivedNavigationPolicyDecision(WebCore::PolicyAction, API::Navigation*, WebKit::ProcessSwapRequestedByClient, WebKit::WebFrameProxy&, API::WebsitePolicies*, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&) + 1011 at WebPageProxy.cpp:2632:9 [ 6] 0x000000019939fa57 WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_2>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_2::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)::'lambda'(WebCore::PolicyAction)::operator()(WebCore::PolicyAction) + 31 at WebPageProxy.cpp:4280:13 [ 6] 0x000000019939fa38 WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_2>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_2::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 284 at WebPageProxy.cpp:4306 [ 6] 0x000000019939f91c WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebPageProxy::decidePolicyForNavigationAction(WebKit::WebFrameProxy&, WebCore::SecurityOriginData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, unsigned long long, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::DumbPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_2>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 60 at Function.h:101 [ 7] 0x0000000199374dc7 WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebFrameProxy::setUpPolicyListenerProxy(WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>&&, WebKit::ShouldExpectSafeBrowsingResult)::$_0>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) const + 19 at Function.h:56:35 [ 7] 0x0000000199374db4 WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebFrameProxy::setUpPolicyListenerProxy(WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>&&, WebKit::ShouldExpectSafeBrowsingResult)::$_0>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 8 at CompletionHandler.h:59 [ 7] 0x0000000199374dac WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebFrameProxy::setUpPolicyListenerProxy(WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>&&, WebKit::ShouldExpectSafeBrowsingResult)::$_0>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WebKit::WebFrameProxy::setUpPolicyListenerProxy(WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>&&, WebKit::ShouldExpectSafeBrowsingResult)::$_0::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) at WebFrameProxy.cpp:185 [ 7] 0x0000000199374dac WebKit`WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::CallableWrapper<WebKit::WebFrameProxy::setUpPolicyListenerProxy(WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>&&, WebKit::ShouldExpectSafeBrowsingResult)::$_0>::call(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 20 at Function.h:101 [ 8] 0x000000019936b3f7 WebKit`WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults(WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WTF::Function<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) const + 23 at Function.h:56:35 [ 8] 0x000000019936b3e0 WebKit`WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults(WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) [inlined] WTF::CompletionHandler<void (WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&)>::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 4 at CompletionHandler.h:59 [ 8] 0x000000019936b3dc WebKit`WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults(WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::DumbPtrTraits<WebKit::SafeBrowsingWarning> >&&) + 44 at WebFramePolicyListenerProxy.cpp:53 [ 9] 0x000000019936895b WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::beginSafeBrowsingCheck(WTF::URL const&, WebKit::WebFramePolicyListenerProxy&)::$_1::operator()(SSBLookupResult*, NSError*)::'lambda'()>::call() [inlined] WebKit::WebPageProxy::beginSafeBrowsingCheck(WTF::URL const&, WebKit::WebFramePolicyListenerProxy&)::$_1::operator()(SSBLookupResult*, NSError*)::'lambda'()::operator()() const + 255 at WebPageProxyCocoa.mm:94:23 [ 9] 0x000000019936885c WebKit`WTF::Function<void ()>::CallableWrapper<WebKit::WebPageProxy::beginSafeBrowsingCheck(WTF::URL const&, WebKit::WebFramePolicyListenerProxy&)::$_1::operator()(SSBLookupResult*, NSError*)::'lambda'()>::call() + 152 at Function.h:101 [ 10] 0x0000000190aca843 JavaScriptCore`WTF::RunLoop::performWork() [inlined] WTF::Function<void ()>::operator()() const + 19 at Function.h:56:35 [ 10] 0x0000000190aca830 JavaScriptCore`WTF::RunLoop::performWork() + 336 at RunLoop.cpp:123 [ 11] 0x0000000190acaabf JavaScriptCore`WTF::RunLoop::performWork(void*) + 39 at RunLoopCF.cpp:38:37 [ 12] 0x0000000188eae857 CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 27 at CFRunLoop.c:1980:9 [ 13] 0x0000000188eae7d3 CoreFoundation`__CFRunLoopDoSource0 + 91 at CFRunLoop.c:2015:13 [ 14] 0x0000000188eae08f CoreFoundation`__CFRunLoopDoSources0 + 179 at CFRunLoop.c:2051:29 [ 15] 0x0000000188ea8d5f CoreFoundation`__CFRunLoopRun + 991 at CFRunLoop.c:2922:41 [ 16] 0x0000000188ea865f CoreFoundation`CFRunLoopRunSpecific + 451 at CFRunLoop.c:3247:18 [ 17] 0x000000018b0e4dc7 GraphicsServices`GSEventRunModal + 107 at GSEvent.c:2245:9 [ 18] 0x00000001b7050c1b UIKitCore`UIApplicationMain + 215 at UIApplication.m:4353:5 [ 19] 0x000000010427ea8f MobileSafari`main + 1503 [ 20] 0x00000001889651fb libdyld.dylib`start + 3 1491464 1 cdumez 2019-01-03 10:49:39 -0800 <rdar://problem/46938686> 1491467 2 358262 cdumez 2019-01-03 11:03:16 -0800 Created attachment 358262 Patch 1491881 3 358262 cdumez 2019-01-04 14:10:26 -0800 Comment on attachment 358262 Patch Clearing flags on attachment: 358262 Committed r239638: <https://trac.webkit.org/changeset/239638> 1491882 4 cdumez 2019-01-04 14:10:27 -0800 All reviewed patches have been landed. Closing bug. 358262 2019-01-03 11:03:16 -0800 2019-01-04 14:10:26 -0800 Patch bug-193113-20190103110315.patch text/plain 5242 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQzNzdhODQ5ZDk2ZGI2OWMx MDZkMTNjZTZmMjgzZTk2OWU1NzY5YjAuLjAzYzNkZWEzODU1NjdiZTVmZTVhZGRiMzYzZDQ1M2Qw MTI4YmU2M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDEgQEAKKzIwMTktMDEtMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJQYWdlUHJv eHk6OmNvbnRpbnVlTmF2aWdhdGlvbkluTmV3UHJvY2VzcygpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMxMTMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQ2OTM4Njg2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBjcmFzaCB3YXMgaGFwcGVuaW5nIGluIGNvbnRpbnVlTmF2aWdhdGlvbkluTmV3 UHJvY2VzcygpIHdoZW4gZGVyZWZlcmVuY2luZworICAgICAgICB0aGUgT3B0aW9uYWw8PiB2YWx1 ZSByZXR1cm5lZCBieSBBUEk6Ok5hdmlnYXRpb246OmJhY2tGb3J3YXJkRnJhbWVMb2FkVHlwZSgp LCBhZnRlciB2ZXJpZnlpbmcKKyAgICAgICAgdGhhdCBBUEk6Ok5hdmlnYXRpb246OnRhcmdldEl0 ZW0oKSBpcyBub3QgbnVsbC4KKworICAgICAgICBXaGVuIGNvbnN0cnVjdGluZyBhbiBBUEk6Ok5h dmlnYXRpb24gb2JqZWN0IHdpdGggYSB0YXJnZXRJdGVtLCB5b3UgSEFWRSB0byBwYXNzCisgICAg ICAgIGluIGEgYmFja0ZvcndhcmRGcmFtZUxvYWRUeXBlIGFzIHdlbGwgc28gdGhpcyBub3JtYWxs eSBpcyBub3QgcG9zc2libGUuIEhvd2V2ZXIsCisgICAgICAgIGl0IGNhbiBoYXBwZW4gYmVjYXVz ZSBBUEk6Ok5hdmlnYXRpb246OnNldFRhcmdldEl0ZW0oKSBjYW4gZ2V0IGNhbGxlZCBsYXRlciBv biBhbmQKKyAgICAgICAgc2V0IGEgdGFyZ2V0IGl0ZW0gb24gYSBOYXZpZ2F0aW9uIG9iamVjdCB3 aGljaCBwb3RlbnRpYWxseSBkb2VzIG5vdCBoYXZlIGEKKyAgICAgICAgYmFja0ZvcndhcmRGcmFt ZUxvYWRUeXBlLiBUaGlzIHNldHRlciB3YXMgb25seSBjYWxsZWQgaW4gb25lIHBsYWNlIGluCisg ICAgICAgIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oKSB0byB1cGRhdGUgYW4gZXhp c3RpbmcgTmF2aWdhdGlvbiBvYmplY3QgdXNpbmcKKyAgICAgICAgdGhlIHRhcmdldEl0ZW0gcHJv dmlkZWQgYnkgYSBOYXZpZ2F0aW9uQWN0aW9uLiBUaGlzIGxvZ2ljIHdhcyBhZGRlZCB3aXRoIFBT T04KKyAgICAgICAgc3VwcG9ydC4KKworICAgICAgICBCZWNhdXNlIEkgd2FzIHVuYWJsZSB0byB3 cml0ZSBhIHRlc3QgY2FzZSByZXByb2R1Y2luZyB0aGlzIGFuZCBiZWNhdXNlIEkgZG8gbm90IGtu b3cKKyAgICAgICAgaG93IGl0IGNhbiBoYXBwZW4gaW4gcHJhY3RpY2UgdGhhdCB3ZSdkIGhhdmUg YSBOYXZpZ2F0aW9uQWN0aW9uIHdpdGggYSB0YXJnZXRJdGVtCisgICAgICAgIGV2ZW4gdGhvdWdo IHRoZSBOYXZpZ2F0aW9uIG9iamVjdCBpdHNlbGYgaXMgbm90IGZvciBhIGJhY2svZm9yd2FyZCBu YXZpZ2F0aW9uLCBJIGhhdmUKKyAgICAgICAgY2hvc2VuIHRvIGRyb3AgdGhlIHVuc2FmZSBBUEk6 Ok5hdmlnYXRpb246OnNldFRhcmdldEl0ZW0oKSBzZXR0ZXIgYW5kIHRoZSBjYWxsIHNpdGUuCisg ICAgICAgIFdoZW4gdGhlIGNhbGwgc2l0ZSB3YXMgYWRkZWQsIHdpdGggUHJvY2Vzc1N3YXAuTmF2 aWdhdGVUb0RhdGFVUkxUaGVuQmFjayBBUEkgdGVzdCwKKyAgICAgICAgdGhlIGludGVudGlvbiB3 YXMgdG8gY3JlYXRlIGEgYmFjay9mb3J3YXJkIG5hdmlnYXRpb24gb2JqZWN0IGluc3RlYWQgb2Yg YSBzdGFuZGFyZCBsb2FkCisgICAgICAgIG5hdmlnYXRpb24gb25lIGlmIHRoZXJlIGlzIGN1cnJl bnRseSBubyBleGlzdGluZyBOYXZpZ2F0aW9uIG9iamVjdCBpbiB0aGUgVUlQcm9jZXNzLgorICAg ICAgICBUaGlzIGNhbiBoYXBwZW4gd2hlbiB0aGUgYmFjay9mb3J3YXJkIG5hdmlnYXRpb24gaXMg dHJpZ2dlcmVkIGJ5IHRoZSBXZWJQcm9jZXNzIHZpYQorICAgICAgICBKUyAoZS5nLiBoaXN0b3J5 LmJhY2soKSkgYW5kIHRoaXMgaXMgd2hhdCB0aGUgQVBJIHRlc3QgY292ZXJzLiBUaGUgcGFydCBv ZiB0aGUgbG9naWMKKyAgICAgICAgdGhhdCB1cGRhdGVzIGFuIGV4aXN0aW5nIE5hdmlnYXRpb24g b2JqZWN0IHdpdGggYSB0YXJnZXRJdGVtIGNvbWluZyBmcm9tIHRoZQorICAgICAgICBOYXZpZ2F0 aW9uQWN0aW9uIGlzIHVudGVzdGVkIGFuZCBJIGhhdmUgbm8gZXZpZGVuY2UgaXQgZG9lcyBhbnl0 aGluZyB1c2VmdWwuIEhvd2V2ZXIsCisgICAgICAgIHdlIERPIGhhdmUgZXZpZGVuY2UgdGhhdCBp dCBjYW4gY2F1c2UgY3Jhc2hlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJTmF2aWdh dGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pOgor CiAyMDE5LTAxLTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg Q3Jhc2ggdW5kZXIgV2ViUHJvY2Vzc1Bvb2w6OmFkZFN1c3BlbmRlZFBhZ2UoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU5hdmlnYXRpb24uaCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElOYXZpZ2F0aW9uLmgKaW5kZXggODQxZDVhYzU0NDA1NWVl OTg2YzE4OTk2MWU2YjEzOWVkZWQxNTk3Mi4uYjE1MDMwZDRlNzEzMzFiOGFhOGMzMGEyNTM5OGI2 YmU0ZWZjNjMyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSU5h dmlnYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJTmF2aWdhdGlv bi5oCkBAIC05Nyw3ICs5Nyw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgY3VycmVudFJlcXVlc3RJ c1JlZGlyZWN0KCkgY29uc3QgeyByZXR1cm4gbV9sYXN0TmF2aWdhdGlvbkFjdGlvbi5pc1JlZGly ZWN0OyB9CiAKLSAgICB2b2lkIHNldFRhcmdldEl0ZW0oV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExp c3RJdGVtJiBpdGVtKSB7IG1fdGFyZ2V0SXRlbSA9ICZpdGVtOyB9CiAgICAgV2ViS2l0OjpXZWJC YWNrRm9yd2FyZExpc3RJdGVtKiB0YXJnZXRJdGVtKCkgY29uc3QgeyByZXR1cm4gbV90YXJnZXRJ dGVtLmdldCgpOyB9CiAgICAgV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3RJdGVtKiBmcm9tSXRl bSgpIGNvbnN0IHsgcmV0dXJuIG1fZnJvbUl0ZW0uZ2V0KCk7IH0KICAgICBPcHRpb25hbDxXZWJD b3JlOjpGcmFtZUxvYWRUeXBlPiBiYWNrRm9yd2FyZEZyYW1lTG9hZFR5cGUoKSBjb25zdCB7IHJl dHVybiBtX2JhY2tGb3J3YXJkRnJhbWVMb2FkVHlwZTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggOWRiNzA3MTBkOTkwMTAwYzVjYjA1OGJmZGU5MmJjNzdl YTUxYjExZC4uNDY3YTgwNmIzMTNkN2NkYTMyNjU5ZGE3MDNlNjBkZWQzZDFiYjdmNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC00Mzc5LDE4ICs0Mzc5LDE1 IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdl YkZyYW1lUHJveHkmIGZyYW1lLCBXZWJDb3JlCiAgICAgICAgIGZyYW1lU2VjdXJpdHlPcmlnaW4g PSBuYXZpZ2F0aW9uLT5kZXN0aW5hdGlvbkZyYW1lU2VjdXJpdHlPcmlnaW4oKTsKICAgICB9CiAK LSAgICBpZiAoYXV0byB0YXJnZXRCYWNrRm9yd2FyZEl0ZW1JZGVudGlmaWVyID0gbmF2aWdhdGlv bkFjdGlvbkRhdGEudGFyZ2V0QmFja0ZvcndhcmRJdGVtSWRlbnRpZmllcikgewotICAgICAgICBp ZiAoYXV0byogaXRlbSA9IG1fYmFja0ZvcndhcmRMaXN0LT5pdGVtRm9ySUQoKm5hdmlnYXRpb25B Y3Rpb25EYXRhLnRhcmdldEJhY2tGb3J3YXJkSXRlbUlkZW50aWZpZXIpKSB7Ci0gICAgICAgICAg ICBpZiAoIW5hdmlnYXRpb24pCisgICAgaWYgKCFuYXZpZ2F0aW9uKSB7CisgICAgICAgIGlmIChh dXRvIHRhcmdldEJhY2tGb3J3YXJkSXRlbUlkZW50aWZpZXIgPSBuYXZpZ2F0aW9uQWN0aW9uRGF0 YS50YXJnZXRCYWNrRm9yd2FyZEl0ZW1JZGVudGlmaWVyKSB7CisgICAgICAgICAgICBpZiAoYXV0 byogaXRlbSA9IG1fYmFja0ZvcndhcmRMaXN0LT5pdGVtRm9ySUQoKnRhcmdldEJhY2tGb3J3YXJk SXRlbUlkZW50aWZpZXIpKQogICAgICAgICAgICAgICAgIG5hdmlnYXRpb24gPSBtX25hdmlnYXRp b25TdGF0ZS0+Y3JlYXRlQmFja0ZvcndhcmROYXZpZ2F0aW9uKCppdGVtLCBtX2JhY2tGb3J3YXJk TGlzdC0+Y3VycmVudEl0ZW0oKSwgRnJhbWVMb2FkVHlwZTo6SW5kZXhlZEJhY2tGb3J3YXJkKTsK LSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBuYXZpZ2F0aW9uLT5zZXRUYXJnZXRJ dGVtKCppdGVtKTsKICAgICAgICAgfQorICAgICAgICBpZiAoIW5hdmlnYXRpb24pCisgICAgICAg ICAgICBuYXZpZ2F0aW9uID0gbV9uYXZpZ2F0aW9uU3RhdGUtPmNyZWF0ZUxvYWRSZXF1ZXN0TmF2 aWdhdGlvbihSZXNvdXJjZVJlcXVlc3QocmVxdWVzdCksIG1fYmFja0ZvcndhcmRMaXN0LT5jdXJy ZW50SXRlbSgpKTsKICAgICB9CiAKLSAgICBpZiAoIW5hdmlnYXRpb24pCi0gICAgICAgIG5hdmln YXRpb24gPSBtX25hdmlnYXRpb25TdGF0ZS0+Y3JlYXRlTG9hZFJlcXVlc3ROYXZpZ2F0aW9uKFJl c291cmNlUmVxdWVzdChyZXF1ZXN0KSwgbV9iYWNrRm9yd2FyZExpc3QtPmN1cnJlbnRJdGVtKCkp OwotCiAgICAgdWludDY0X3QgbmV3TmF2aWdhdGlvbklEID0gbmF2aWdhdGlvbi0+bmF2aWdhdGlv bklEKCk7CiAgICAgbmF2aWdhdGlvbi0+c2V0Q3VycmVudFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0 KHJlcXVlc3QpLCBtX3Byb2Nlc3MtPmNvcmVQcm9jZXNzSWRlbnRpZmllcigpKTsKICAgICBuYXZp Z2F0aW9uLT5zZXRMYXN0TmF2aWdhdGlvbkFjdGlvbihuYXZpZ2F0aW9uQWN0aW9uRGF0YSk7Cg==