193102 2019-01-03 03:06:38 -0800 [ews-build] Check patch relevance before applying the patch 2019-01-04 10:03:41 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1491393 0 aakash_jain 2019-01-03 03:06:38 -0800 We should run the CheckPatchRelevance step before applying the patch. CheckPatchRelevance is very quick, usually less than a second, While applying the patch seems to take about half a minute (since it involve cleaning up any previous change, updating to ToT and then applying the patch). For queues like WebKitPy-Tests where very little percentage of patches are actually relevant, it is a waste of time to apply the patch and then discover that the patch doesn't needs to be processed in the first place. Therefore checking the patch relevance should be one of the very first step. 1491394 1 358248 aakash_jain 2019-01-03 03:12:16 -0800 Created attachment 358248 Proposed patch 1491398 2 ews-watchlist 2019-01-03 03:15:06 -0800 Attachment 358248 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:37: [Factory.__init__] Undefined variable 'CheckPatchRelevance' [pylint/E0602] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1491692 3 358248 commit-queue 2019-01-04 10:00:10 -0800 Comment on attachment 358248 Proposed patch Clearing flags on attachment: 358248 Committed r239616: <https://trac.webkit.org/changeset/239616> 1491693 4 commit-queue 2019-01-04 10:00:11 -0800 All reviewed patches have been landed. Closing bug. 1491699 5 webkit-bug-importer 2019-01-04 10:03:41 -0800 <rdar://problem/47050389> 358248 2019-01-03 03:12:16 -0800 2019-01-04 10:00:10 -0800 Proposed patch ews-build-checkPatchRelevance-earlier.patch text/plain 3159 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzOTU4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTAxLTAzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBDaGVjayBwYXRjaCByZWxldmFuY2UgYmVmb3JlIGFw cGx5aW5nIHRoZSBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkzMTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5OgorICAg ICAgICAoRmFjdG9yeS5fX2luaXRfXyk6IE1vdmVkIENoZWNrUGF0Y2hSZWxldmFuY2Ugc3RlcCB0 byBiYXNlIGNsYXNzLgorCiAyMDE5LTAxLTAyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSG9tb2dyYXBoIHdpdGggTEFUSU4gU01BTEwgTEVU VEVSIFIgV0lUSCBGSVNISE9PSwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL2ZhY3Rvcmllcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyMzk1ODgpCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw5 ICszMCwxMSBAQCBQcm9wZXJ0eSA9IHByb3BlcnRpZXMuUHJvcGVydHkKIAogCiBjbGFzcyBGYWN0 b3J5KGZhY3RvcnkuQnVpbGRGYWN0b3J5KToKLSAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZv cm0sIGNvbmZpZ3VyYXRpb249Tm9uZSwgYXJjaGl0ZWN0dXJlcz1Ob25lLCBidWlsZE9ubHk9VHJ1 ZSwgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCAqKmt3YXJncyk6CisgICAgZGVmIF9faW5pdF9f KHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwg YnVpbGRPbmx5PVRydWUsIGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgY2hlY2tSZWxldmFuY2U9 RmFsc2UsICoqa3dhcmdzKToKICAgICAgICAgZmFjdG9yeS5CdWlsZEZhY3RvcnkuX19pbml0X18o c2VsZikKICAgICAgICAgc2VsZi5hZGRTdGVwKENvbmZpZ3VyZUJ1aWxkKHBsYXRmb3JtLCBjb25m aWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBidWlsZE9ubHksIGFkZGl0aW9uYWxBcmd1bWVudHMp KQorICAgICAgICBpZiBjaGVja1JlbGV2YW5jZToKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChD aGVja1BhdGNoUmVsZXZhbmNlKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChDaGVja091dFNvdXJj ZSgpKQogCiAKQEAgLTQ0LDggKzQ2LDcgQEAgY2xhc3MgU3R5bGVGYWN0b3J5KEZhY3RvcnkpOgog CiBjbGFzcyBCaW5kaW5nc0ZhY3RvcnkoRmFjdG9yeSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYs IHBsYXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwgYWRkaXRp b25hbEFyZ3VtZW50cz1Ob25lLCAqKmt3YXJncyk6Ci0gICAgICAgIEZhY3RvcnkuX19pbml0X18o c2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRp dGlvbmFsQXJndW1lbnRzKQotICAgICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tQYXRjaFJlbGV2YW5j ZSgpKQorICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0 aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgY2hlY2tSZWxl dmFuY2U9VHJ1ZSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkJpbmRpbmdzVGVzdHMoKSkKIAog CkBAIC01Nyw4ICs1OCw3IEBAIGNsYXNzIFdlYktpdFBlcmxGYWN0b3J5KEZhY3RvcnkpOgogCiBj bGFzcyBXZWJLaXRQeUZhY3RvcnkoRmFjdG9yeSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBs YXRmb3JtLCBjb25maWd1cmF0aW9uPU5vbmUsIGFyY2hpdGVjdHVyZXM9Tm9uZSwgYWRkaXRpb25h bEFyZ3VtZW50cz1Ob25lLCAqKmt3YXJncyk6Ci0gICAgICAgIEZhY3RvcnkuX19pbml0X18oc2Vs ZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlv bmFsQXJndW1lbnRzKQotICAgICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tQYXRjaFJlbGV2YW5jZSgp KQorICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9u LCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgY2hlY2tSZWxldmFu Y2U9VHJ1ZSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bldlYktpdFB5VGVzdHMoKSkKIAogCkBA IC0xMDQsOCArMTA0LDcgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAKIGNsYXNzIEpT Q1Rlc3RzRmFjdG9yeShGYWN0b3J5KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0s IGNvbmZpZ3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPU5vbmUsIGFkZGl0aW9uYWxB cmd1bWVudHM9Tm9uZSwgKiprd2FyZ3MpOgotICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYs IHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25h bEFyZ3VtZW50cykKLSAgICAgICAgc2VsZi5hZGRTdGVwKENoZWNrUGF0Y2hSZWxldmFuY2UoKSkK KyAgICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwg YXJjaGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudHMsIGNoZWNrUmVsZXZhbmNl PVRydWUpCiAgICAgICAgIHNlbGYuYWRkU3RlcChDb21waWxlSlNDT25seSgpKQogICAgICAgICBz ZWxmLmFkZFN0ZXAoVW5BcHBseVBhdGNoSWZSZXF1aXJlZCgpKQogICAgICAgICBzZWxmLmFkZFN0 ZXAoQ29tcGlsZUpTQ09ubHlUb1QoKSkK