193090 2019-01-02 14:52:38 -0800 IndexedDB: When deleting databases, some open databases might be missed 2019-01-14 16:20:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson commit-queue ews-watchlist jsbell webkit-bug-importer oldest_to_newest 1491269 0 sihui_liu 2019-01-02 14:52:38 -0800 Currently we only close databases which have open database connections before deleting file. 1491273 1 358210 sihui_liu 2019-01-02 14:58:59 -0800 Created attachment 358210 patch 1493688 2 358210 beidson 2019-01-11 09:22:05 -0800 Comment on attachment 358210 patch View in context: https://bugs.webkit.org/attachment.cgi?id=358210&action=review > Source/WebCore/ChangeLog:3 > + IndexedDB: files should be deleted after databases being opened are closed This was also unclear to me. Maybe "When deleting databases, some open databases might be missed" > Source/WebCore/ChangeLog:8 > + We should close all open databases instead of databases from open database connections, because database thread "We should close all databases with an open backing store instead of looking at which ones have an open database connection. This is because a database might be in the process of getting a backing store before its connection has been created" 1494350 3 359085 sihui_liu 2019-01-14 15:40:47 -0800 Created attachment 359085 Patch for landing 1494376 4 359085 commit-queue 2019-01-14 16:19:23 -0800 Comment on attachment 359085 Patch for landing Clearing flags on attachment: 359085 Committed r239960: <https://trac.webkit.org/changeset/239960> 1494377 5 commit-queue 2019-01-14 16:19:24 -0800 All reviewed patches have been landed. Closing bug. 1494379 6 webkit-bug-importer 2019-01-14 16:20:35 -0800 <rdar://problem/47269748> 358210 2019-01-02 14:58:59 -0800 2019-01-14 15:40:45 -0800 patch patch text/plain 2427 sihui_liu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwODFkNmQ3MDYyZS4uODdlM2JjY2M2MzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMS0wMiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4K KworICAgICAgICBJbmRleGVkREI6IGZpbGVzIHNob3VsZCBiZSBkZWxldGVkIGFmdGVyIGRhdGFi YXNlcyBiZWluZyBvcGVuZWQgYXJlIGNsb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIGNsb3NlIGFsbCBvcGVuIGRhdGFiYXNlcyBp bnN0ZWFkIG9mIGRhdGFiYXNlcyBmcm9tIG9wZW4gZGF0YWJhc2UgY29ubmVjdGlvbnMsIGJlY2F1 c2UgZGF0YWJhc2UgdGhyZWFkIAorICAgICAgICB3aWxsIHN0YXJ0IGFjY2Vzc2luZyBkYXRhYmFz ZSBmaWxlIGJlZm9yZSB0aGVyZSBpcyBhIGNvbm5lY3Rpb24uCisKKyAgICAgICAgKiBNb2R1bGVz L2luZGV4ZWRkYi9zZXJ2ZXIvSURCU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNl cnZlcjo6SURCU2VydmVyOjpjbG9zZUFuZERlbGV0ZURhdGFiYXNlc01vZGlmaWVkU2luY2UpOgor ICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpJREJTZXJ2ZXI6OmNsb3NlQW5kRGVsZXRlRGF0 YWJhc2VzRm9yT3JpZ2lucyk6CisKIDIwMTktMDEtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIExheWVyU2Nyb2xsQ29vcmRpbmF0aW9u Um9sZSB0byBTY3JvbGxDb29yZGluYXRpb25Sb2xlIGFuZCBtYWtlIGFuIGVudW0gY2xhc3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJ2 ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcnZl ci5jcHAKaW5kZXggY2IxN2JhMWQ1NzkuLjVkOTM2YzhiZWJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvSURCU2VydmVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvSURCU2VydmVyLmNwcApAQCAtNTA5 LDggKzUwOSw4IEBAIHZvaWQgSURCU2VydmVyOjpjbG9zZUFuZERlbGV0ZURhdGFiYXNlc01vZGlm aWVkU2luY2UoV2FsbFRpbWUgbW9kaWZpY2F0aW9uVGltZSwKICAgICB9CiAKICAgICBIYXNoU2V0 PFVuaXF1ZUlEQkRhdGFiYXNlKj4gb3BlbkRhdGFiYXNlczsKLSAgICBmb3IgKGF1dG8qIGNvbm5l Y3Rpb24gOiBtX2RhdGFiYXNlQ29ubmVjdGlvbnMudmFsdWVzKCkpCi0gICAgICAgIG9wZW5EYXRh YmFzZXMuYWRkKGNvbm5lY3Rpb24tPmRhdGFiYXNlKCkpOworICAgIGZvciAoYXV0byYgZGF0YWJh c2UgOiBtX3VuaXF1ZUlEQkRhdGFiYXNlTWFwLnZhbHVlcygpKQorICAgICAgICBvcGVuRGF0YWJh c2VzLmFkZChkYXRhYmFzZS5nZXQoKSk7CiAKICAgICBmb3IgKGF1dG8mIGRhdGFiYXNlIDogb3Bl bkRhdGFiYXNlcykKICAgICAgICAgZGF0YWJhc2UtPmltbWVkaWF0ZUNsb3NlRm9yVXNlckRlbGV0 ZSgpOwpAQCAtNTI1LDE0ICs1MjUsMTEgQEAgdm9pZCBJREJTZXJ2ZXI6OmNsb3NlQW5kRGVsZXRl RGF0YWJhc2VzRm9yT3JpZ2lucyhjb25zdCBWZWN0b3I8U2VjdXJpdHlPcmlnaW5EYXQKICAgICBB U1NFUlRfVU5VU0VEKGFkZFJlc3VsdCwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOwogCiAgICAgSGFz aFNldDxVbmlxdWVJREJEYXRhYmFzZSo+IG9wZW5EYXRhYmFzZXM7Ci0gICAgZm9yIChhdXRvKiBj b25uZWN0aW9uIDogbV9kYXRhYmFzZUNvbm5lY3Rpb25zLnZhbHVlcygpKSB7Ci0gICAgICAgIGF1 dG8gZGF0YWJhc2UgPSBjb25uZWN0aW9uLT5kYXRhYmFzZSgpOwotICAgICAgICBBU1NFUlQoZGF0 YWJhc2UpOwotCisgICAgZm9yIChhdXRvJiBkYXRhYmFzZSA6IG1fdW5pcXVlSURCRGF0YWJhc2VN YXAudmFsdWVzKCkpIHsKICAgICAgICAgY29uc3QgYXV0byYgaWRlbnRpZmllciA9IGRhdGFiYXNl LT5pZGVudGlmaWVyKCk7CiAgICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDogb3JpZ2lucykgewog ICAgICAgICAgICAgaWYgKGlkZW50aWZpZXIuaXNSZWxhdGVkVG9PcmlnaW4ob3JpZ2luKSkgewot ICAgICAgICAgICAgICAgIG9wZW5EYXRhYmFzZXMuYWRkKGRhdGFiYXNlKTsKKyAgICAgICAgICAg ICAgICBvcGVuRGF0YWJhc2VzLmFkZChkYXRhYmFzZS5nZXQoKSk7CiAgICAgICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K 359085 2019-01-14 15:40:47 -0800 2019-01-14 16:19:23 -0800 Patch for landing bug-193090-20190114154046.patch text/plain 2609 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5Nzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMzOTRkNzAxZjI1MzE1 ODJiY2IyZGRjMmE2ZDA4N2Q3YjEwYjU5Ni4uOTZjYjk0MzlkMGUwMzUxYjhlNjRmNTA0ZDE2OWM4 NGFlMzBhZTBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTE0ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEluZGV4ZWREQjogV2hlbiBk ZWxldGluZyBkYXRhYmFzZXMsIHNvbWUgb3BlbiBkYXRhYmFzZXMgbWlnaHQgYmUgbWlzc2VkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMwOTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCisKKyAgICAgICAgV2Ugc2hvdWxkIGNs b3NlIGFsbCBkYXRhYmFzZXMgd2l0aCBhbiBvcGVuIGJhY2tpbmcgc3RvcmUgaW5zdGVhZCBvZiBs b29raW5nIGF0IHdoaWNoIG9uZXMgaGF2ZSBhbiBvcGVuIGRhdGFiYXNlCisgICAgICAgIGNvbm5l Y3Rpb24uIFRoaXMgaXMgYmVjYXVzZSBhIGRhdGFiYXNlIG1pZ2h0IGJlIGluIHRoZSBwcm9jZXNz IG9mIGdldHRpbmcgYSBiYWNraW5nIHN0b3JlIGJlZm9yZSBpdHMgY29ubmVjdGlvbgorICAgICAg ICBoYXMgYmVlbiBjcmVhdGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvc2VydmVy L0lEQlNlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJTZXJ2ZXI6OklEQlNlcnZlcjo6 Y2xvc2VBbmREZWxldGVEYXRhYmFzZXNNb2RpZmllZFNpbmNlKToKKyAgICAgICAgKFdlYkNvcmU6 OklEQlNlcnZlcjo6SURCU2VydmVyOjpjbG9zZUFuZERlbGV0ZURhdGFiYXNlc0Zvck9yaWdpbnMp OgorCiAyMDE5LTAxLTA5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0xGQ11bQkZDXVtNYXJnaW5Db2xsYXBzaW5nXSBBZGQgc3VwcG9ydCBmb3IgcGVjdWxpYXIg Y2FzZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2 ZXIvSURCU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZl ci9JREJTZXJ2ZXIuY3BwCmluZGV4IGNiMTdiYTFkNTc5YjZkMjU5OWZmNGM1YmNlZmRmZTJmYWVm NGJlYTAuLjVkOTM2YzhiZWJiYWQ4YTZjNTJkZmU0Mzg0N2Y0YTczNGU1MzQ0NGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJ2ZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJ2ZXIu Y3BwCkBAIC01MDksOCArNTA5LDggQEAgdm9pZCBJREJTZXJ2ZXI6OmNsb3NlQW5kRGVsZXRlRGF0 YWJhc2VzTW9kaWZpZWRTaW5jZShXYWxsVGltZSBtb2RpZmljYXRpb25UaW1lLAogICAgIH0KIAog ICAgIEhhc2hTZXQ8VW5pcXVlSURCRGF0YWJhc2UqPiBvcGVuRGF0YWJhc2VzOwotICAgIGZvciAo YXV0byogY29ubmVjdGlvbiA6IG1fZGF0YWJhc2VDb25uZWN0aW9ucy52YWx1ZXMoKSkKLSAgICAg ICAgb3BlbkRhdGFiYXNlcy5hZGQoY29ubmVjdGlvbi0+ZGF0YWJhc2UoKSk7CisgICAgZm9yIChh dXRvJiBkYXRhYmFzZSA6IG1fdW5pcXVlSURCRGF0YWJhc2VNYXAudmFsdWVzKCkpCisgICAgICAg IG9wZW5EYXRhYmFzZXMuYWRkKGRhdGFiYXNlLmdldCgpKTsKIAogICAgIGZvciAoYXV0byYgZGF0 YWJhc2UgOiBvcGVuRGF0YWJhc2VzKQogICAgICAgICBkYXRhYmFzZS0+aW1tZWRpYXRlQ2xvc2VG b3JVc2VyRGVsZXRlKCk7CkBAIC01MjUsMTQgKzUyNSwxMSBAQCB2b2lkIElEQlNlcnZlcjo6Y2xv c2VBbmREZWxldGVEYXRhYmFzZXNGb3JPcmlnaW5zKGNvbnN0IFZlY3RvcjxTZWN1cml0eU9yaWdp bkRhdAogICAgIEFTU0VSVF9VTlVTRUQoYWRkUmVzdWx0LCBhZGRSZXN1bHQuaXNOZXdFbnRyeSk7 CiAKICAgICBIYXNoU2V0PFVuaXF1ZUlEQkRhdGFiYXNlKj4gb3BlbkRhdGFiYXNlczsKLSAgICBm b3IgKGF1dG8qIGNvbm5lY3Rpb24gOiBtX2RhdGFiYXNlQ29ubmVjdGlvbnMudmFsdWVzKCkpIHsK LSAgICAgICAgYXV0byBkYXRhYmFzZSA9IGNvbm5lY3Rpb24tPmRhdGFiYXNlKCk7Ci0gICAgICAg IEFTU0VSVChkYXRhYmFzZSk7Ci0KKyAgICBmb3IgKGF1dG8mIGRhdGFiYXNlIDogbV91bmlxdWVJ REJEYXRhYmFzZU1hcC52YWx1ZXMoKSkgewogICAgICAgICBjb25zdCBhdXRvJiBpZGVudGlmaWVy ID0gZGF0YWJhc2UtPmlkZW50aWZpZXIoKTsKICAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBv cmlnaW5zKSB7CiAgICAgICAgICAgICBpZiAoaWRlbnRpZmllci5pc1JlbGF0ZWRUb09yaWdpbihv cmlnaW4pKSB7Ci0gICAgICAgICAgICAgICAgb3BlbkRhdGFiYXNlcy5hZGQoZGF0YWJhc2UpOwor ICAgICAgICAgICAgICAgIG9wZW5EYXRhYmFzZXMuYWRkKGRhdGFiYXNlLmdldCgpKTsKICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQo=