193069 2019-01-01 17:46:55 -0800 [WPE][GTK] Add new WPE and JSC API directories to API watchlist 2019-01-07 12:29:15 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux NEW P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia mcatanzaro oldest_to_newest 1491121 0 mcatanzaro 2019-01-01 17:46:55 -0800 Add new WPE and JSC API directories to API watchlist 1491122 1 358178 mcatanzaro 2019-01-01 17:47:56 -0800 Created attachment 358178 Patch 1491385 2 358178 cgarcia 2019-01-02 23:40:21 -0800 Comment on attachment 358178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358178&action=review > Tools/Scripts/webkitpy/common/config/watchlist:72 > "GtkWebKit2PublicAPI": { I would change this name too. GLibPublicAPI for example, or GTKWPEPublicAPI. But Gtk and WebKit2 are no longer true. > Tools/Scripts/webkitpy/common/config/watchlist:443 > + "GtkWebKit2PublicAPI": [ "Thanks for the patch. If this patch contains new GTK or WPE API " JSC is not GTK nor WPE API. > Tools/Scripts/webkitpy/common/config/watchlist:445 > "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ], This URL looks weird too now. We should probably rename it and update it to reflect WPE and JSC if we really want to use the same guidelines. 358178 2019-01-01 17:47:56 -0800 2019-01-07 12:29:15 -0800 Patch bug-193069-20190101194755.patch text/plain 2665 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGRjZWUxZTUyNzAwZmFlMGE3MzdjNTAwOGQ1YTg1ZjBm MWE4ZjA2MC4uZDlhYzZlNzJlNGI3NGVlMTExZWUzNmQ5YWUxNGYwYzYxZjIxNWQzZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE5LTAxLTAxICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXVtHVEtdIEFkZCBuZXcgV1BFIGFuZCBKU0MgQVBJIGRpcmVjdG9y aWVzIHRvIEFQSSB3YXRjaGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5MzA2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdDoK KwogMjAxOC0xMi0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgV2ViRHJpdmVyOiB3YXJuIGFib3V0IG5vbiBleGlzdGluZyB0ZXN0cyB3aGVu IHBhcnNpbmcgZXhwZWN0YXRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL3dhdGNobGlzdAppbmRleCBjZTlkODFiMTE1MGIxZGExZDU0YWJiY2YzMGJiODk0MjU4 NmVmOTFmLi4xYWIzMDJiODc3ZDU1YmI4MGU3ODE0YjllNzJiZTk0NDQyODc3MTdjIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QKQEAgLTcwLDEx ICs3MCwxNCBAQAogICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvV2ViQ29yZS9wYWdl L2FuaW1hdGlvbi8iLAogICAgICAgICB9LAogICAgICAgICAiR3RrV2ViS2l0MlB1YmxpY0FQSSI6 IHsKLSAgICAgICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2d0ay8iCisgICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvZ2xpYi8iCisgICAgICAgICAgICAgICAgICAgICAgICByInxTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ3RrLyIKICAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9nbGliLyIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvIgogICAgICAgICAgICAgICAgICAgICAgICAgciJ8U291 cmNlL1dlYktpdC9TaGFyZWQvQVBJL2dsaWIvIgogICAgICAgICAgICAgICAgICAgICAgICAgciJ8 U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvIgotICAgICAg ICAgICAgICAgICAgICAgICAgciJ8U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9nbGliLyIsCisgICAgICAgICAgICAgICAgICAgICAgICByInxTb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIvIgorICAgICAgICAgICAgICAgICAg ICAgICAgciJ8U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS93cGUv IiwKICAgICAgICAgfSwKICAgICAgICAgIkNvb3JkaW5hdGVkR3JhcGhpY3MiOiB7CiAgICAgICAg ICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvIgpAQCAtNDM3LDggKzQ0MCw4IEBACiAgICAgICAgICJXZWJSVEMiOiBb ICJlcmljLmNhcmxzb25AYXBwbGUuY29tIiBdLAogICAgIH0sCiAgICAgIk1FU1NBR0VfUlVMRVMi OiB7Ci0gICAgICAgICJHdGtXZWJLaXQyUHVibGljQVBJIjogWyAiVGhhbmtzIGZvciB0aGUgcGF0 Y2guIElmIHRoaXMgcGF0Y2ggY29udGFpbnMgbmV3IHB1YmxpYyBBUEkgIgotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgInBsZWFzZSBtYWtlIHN1cmUgaXQgZm9sbG93cyB0aGUgZ3Vp ZGVsaW5lcyBmb3IgbmV3IFdlYktpdDIgR1RLKyBBUEkuICIKKyAgICAgICAgIkd0a1dlYktpdDJQ dWJsaWNBUEkiOiBbICJUaGFua3MgZm9yIHRoZSBwYXRjaC4gSWYgdGhpcyBwYXRjaCBjb250YWlu cyBuZXcgR1RLIG9yIFdQRSBBUEkgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg InBsZWFzZSBtYWtlIHN1cmUgaXQgZm9sbG93cyB0aGUgZ3VpZGVsaW5lcyBmb3IgbmV3IHB1Ymxp YyBBUEkuICIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJTZWUgaHR0cDovL3Ry YWMud2Via2l0Lm9yZy93aWtpL1dlYktpdEdUSy9BZGRpbmdOZXdXZWJLaXQyQVBJIiwgXSwKICAg ICAgICAgIkFOR0xFIjogWyAiTm90ZSB0aGF0IHRoZXJlIGFyZSBpbXBvcnRhbnQgc3RlcHMgdG8g dGFrZSB3aGVuIHVwZGF0aW5nIEFOR0xFLiAiCiAgICAgICAgICAgICAgICAgICAgIlNlZSBodHRw Oi8vdHJhYy53ZWJraXQub3JnL3dpa2kvVXBkYXRpbmdBTkdMRSIsIF0sCg==