193055 2018-12-29 02:27:20 -0800 .ycm_extra_conf.py should handle XXXInlines.h 2018-12-31 07:32:59 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen cgarcia don.olmstead mcatanzaro webkit-bug-importer oldest_to_newest 1490991 0 ysuzuki 2018-12-29 02:27:20 -0800 .ycm_extra_conf.py should handle XXXInlines.h 1490992 1 358135 ysuzuki 2018-12-29 02:30:00 -0800 Created attachment 358135 Patch 1491065 2 358135 cgarcia 2018-12-31 05:50:05 -0800 Comment on attachment 358135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358135&action=review > Tools/gtk/ycm_extra_conf.py:90 > + else: Does this work? this else: is not correctly indented. It can be removed, though, since previous line is a return. 1491068 3 ysuzuki 2018-12-31 07:30:40 -0800 (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 358135 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358135&action=review > > > Tools/gtk/ycm_extra_conf.py:90 > > + else: > > Does this work? this else: is not correctly indented. It can be removed, > though, since previous line is a return. This is `else` for `for`, but yeah, we can just `return None` here. Fixed. 1491069 4 ysuzuki 2018-12-31 07:31:21 -0800 Committed r239567: <https://trac.webkit.org/changeset/239567> 1491070 5 webkit-bug-importer 2018-12-31 07:32:59 -0800 <rdar://problem/46987867> 358135 2018-12-29 02:30:00 -0800 2018-12-31 05:50:05 -0800 Patch bug-193055-20181229192957.patch text/plain 3100 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjg0MmQ4MDAxODJhZDcxZjZhYTEzMDhlNDVlNDdhNmNi ODI0ODFlMy4uZDgzYmU4ODFmZjdiMjc0MjgyODM1NGNlN2NhNDdhYjY3NzkxMTQ1NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE4LTEyLTI5ICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5v cmc+CisKKyAgICAgICAgLnljbV9leHRyYV9jb25mLnB5IHNob3VsZCBoYW5kbGUgWFhYSW5saW5l cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMw NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21w aWxlX2NvbW1hbmRzLmpzb24gZGF0YWJhc2Ugb25seSByZWNvcmRzIGZsYWdzIGFuZCBvcHRpb25z IGZvciBjcHAgc291cmNlIGZpbGVzLgorICAgICAgICBTbywgd2hlbiB3ZSBvcGVuIGhlYWRlcnMs IHRoaXMgZGF0YWJhc2UgZG9lcyBub3QgaGF2ZSBhbnkgaW5mb3JtYXRpb24gZm9yIHRoYXQuCisg ICAgICAgIE91ciAueWNtX2V4dHJhX2NvbmYucHkgYWxsZXZpYXRlcyB0aGlzIGJ5IHVzaW5nIFhY WC5jcHAncyBjb25maWd1cmF0aW9uIGZvciBYWFguaC4KKyAgICAgICAgQnV0IHRoaXMgbWl0aWdh dGlvbiBkb2VzIG5vdCBoYW5kbGUgWFhYSW5saW5lcy5oIHdlbGwgc2luY2Ugd2UgZG8gbm90IGhh dmUgWFhYSW5saW5lcy5jcHAuCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBY WFhJbmxpbmVzLmggaW4gLnljbV9leHRyYV9jb25mLnB5LiBXaGVuIFhYWElubGluZXMuaCBpcyBx dWVyaWVkLAorICAgICAgICB3ZSBhdHRlbXB0IHRvIGZpbmQgWFhYLmNwcCBhbmQgdXNlIHRoZSBj b25maWd1cmF0aW9uIGlmIGl0IGV4aXN0cy4KKworICAgICAgICAqIGd0ay95Y21fZXh0cmFfY29u Zi5weToKKyAgICAgICAgKGdldEltcGxlbWVudGF0aW9uRmlsZW5hbWUpOgorICAgICAgICAoRmxh Z3NGb3JGaWxlKToKKwogMjAxOC0xMi0yNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlc3VycmVjdCBNYWMgQ01ha2UgYnVpbGQKZGlmZiAt LWdpdCBhL1Rvb2xzL2d0ay95Y21fZXh0cmFfY29uZi5weSBiL1Rvb2xzL2d0ay95Y21fZXh0cmFf Y29uZi5weQppbmRleCBjMTMwOWJjYTM5ZjE3ZDc5Mzc1NzBmZDlmZjdmZmMxZjk1YTBiZDljLi4w YzU0MDEzMGUyOGQzYmM0NTdjOTVkMDFhZmQ1MzgzZGJlNWE2N2JmIDEwMDY0NAotLS0gYS9Ub29s cy9ndGsveWNtX2V4dHJhX2NvbmYucHkKKysrIGIvVG9vbHMvZ3RrL3ljbV9leHRyYV9jb25mLnB5 CkBAIC04MSw2ICs4MSwxNiBAQCBkZWYgZ2V0X2J1aWxkX3BhdGgoKToKICAgICByZXR1cm4gcmVs ZWFzZV9idWlsZF9wYXRoIGlmIHJlbGVhc2VfbXRpbWUgPj0gZGVidWdfbXRpbWUgZWxzZSBkZWJ1 Z19idWlsZF9wYXRoCiAKIAorZGVmIGdldEltcGxlbWVudGF0aW9uRmlsZW5hbWUoZmlsZW5hbWUp OgorICAgIGFsdGVybmF0aXZlX2V4dGVuc2lvbnMgPSBbJy5jcHAnLCAnLmMnXQorICAgIGZvciBh bHRlcm5hdGl2ZV9leHRlbnNpb24gaW4gYWx0ZXJuYXRpdmVfZXh0ZW5zaW9uczoKKyAgICAgICAg YWx0ZXJuYXRpdmVfZmlsZW5hbWUgPSBmaWxlbmFtZVs6LTJdICsgYWx0ZXJuYXRpdmVfZXh0ZW5z aW9uCisgICAgICAgIGlmIG9zLnBhdGguZXhpc3RzKGFsdGVybmF0aXZlX2ZpbGVuYW1lKToKKyAg ICAgICAgICAgIHJldHVybiBhbHRlcm5hdGl2ZV9maWxlbmFtZQorICAgIGVsc2U6CisgICAgICAg IHJldHVybiBOb25lCisKKwogZGVmIEZsYWdzRm9yRmlsZShmaWxlbmFtZSwgKiprd2FyZ3MpOgog ICAgICIiIlRoaXMgaXMgdGhlIG1haW4gZW50cnkgcG9pbnQgZm9yIFlDTS4gSXRzIGludGVyZmFj ZSBpcyBmaXhlZC4KIApAQCAtOTcsMTQgKzEwNywxNiBAQCBkZWYgRmxhZ3NGb3JGaWxlKGZpbGVu YW1lLCAqKmt3YXJncyk6CiAKICAgICAjIEhlYWRlcnMgY2FuJ3QgYmUgYnVpbHQsIHNvIHdlIGdl dCB0aGUgc291cmNlIGZpbGUgZmxhZ3MgaW5zdGVhZC4KICAgICBpZiBmaWxlbmFtZS5lbmRzd2l0 aCgnLmgnKToKLSAgICAgICAgYWx0ZXJuYXRpdmVfZXh0ZW5zaW9ucyA9IFsnLmNwcCcsICcuYydd Ci0gICAgICAgIGZvciBhbHRlcm5hdGl2ZV9leHRlbnNpb24gaW4gYWx0ZXJuYXRpdmVfZXh0ZW5z aW9uczoKLSAgICAgICAgICAgIGFsdGVybmF0aXZlX2ZpbGVuYW1lID0gZmlsZW5hbWVbOi0yXSAr IGFsdGVybmF0aXZlX2V4dGVuc2lvbgotICAgICAgICAgICAgaWYgb3MucGF0aC5leGlzdHMoYWx0 ZXJuYXRpdmVfZmlsZW5hbWUpOgotICAgICAgICAgICAgICAgIGZpbGVuYW1lID0gYWx0ZXJuYXRp dmVfZmlsZW5hbWUKLSAgICAgICAgICAgICAgICBicmVhaworICAgICAgICBpbXBsZW1lbnRhdGlv bkZpbGVuYW1lID0gZ2V0SW1wbGVtZW50YXRpb25GaWxlbmFtZShmaWxlbmFtZSkKKyAgICAgICAg aWYgaW1wbGVtZW50YXRpb25GaWxlbmFtZToKKyAgICAgICAgICAgIGZpbGVuYW1lID0gaW1wbGVt ZW50YXRpb25GaWxlbmFtZQogICAgICAgICBlbHNlOgotICAgICAgICAgICAgcmV0dXJuIHJlc3Vs dAorICAgICAgICAgICAgaWYgbm90IGZpbGVuYW1lLmVuZHN3aXRoKCdJbmxpbmVzLmgnKToKKyAg ICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0CisgICAgICAgICAgICBpbXBsZW1lbnRhdGlvbkZp bGVuYW1lID0gZ2V0SW1wbGVtZW50YXRpb25GaWxlbmFtZShmaWxlbmFtZVs6LWxlbignSW5saW5l cy5oJyldICsgJy5oJykKKyAgICAgICAgICAgIGlmIG5vdCBpbXBsZW1lbnRhdGlvbkZpbGVuYW1l OgorICAgICAgICAgICAgICAgIHJldHVybiByZXN1bHQKKyAgICAgICAgICAgIGZpbGVuYW1lID0g aW1wbGVtZW50YXRpb25GaWxlbmFtZQogICAgICAgICAjIEZvcmNlIGNvbmZpZy5oIGZpbGUgaW5j bHVzaW9uLCBmb3IgR0xpYiBtYWNyb3MuCiAgICAgICAgIHJlc3VsdFsnZmxhZ3MnXS5hcHBlbmQo Ii1pbmNsdWRlY29uZmlnLmgiKQogCg==