193054 2018-12-28 22:58:59 -0800 Should expose other authors from same analysis task to finalize script. 2019-01-09 14:21:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa oldest_to_newest 1490984 0 dewei_zhu 2018-12-28 22:58:59 -0800 Should expose other authors from same analysis task to finalize sript. 1490985 1 358132 dewei_zhu 2018-12-28 23:00:37 -0800 Created attachment 358132 Patch 1490986 2 358133 dewei_zhu 2018-12-28 23:02:41 -0800 Created attachment 358133 Patch 1493084 3 358133 rniwa 2019-01-09 14:21:25 -0800 Comment on attachment 358133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358133&action=review > Websites/perf.webkit.org/tools/js/analysis-results-notifier.js:53 > + const testGroupInfo = {author: testGroup.author(), otherAuthorsFromSameTask: Array.from(otherAuthorsFromSameTask)}; This is a very verbose name... Why not just taskAuthors or authorsInTask? 358132 2018-12-28 23:00:37 -0800 2018-12-28 23:02:40 -0800 Patch bug-193054-20181228230036.patch text/plain 2804 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTU2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAwOTM2OTA5NzYxYTI0ZjE3ZGNmM2FhOWI3YTQyZWUxNGQyNGJlNTA1Li5lMDdiNWUzMTll OWY5YzI5YTdiNWVmNGVmYTI5NTgxMjJhOWVjZGM1IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMi0yOCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgZXhwb3NlIG90aGVyIGF1dGhvcnMgZnJvbSBz YW1lIGFuYWx5c2lzIHRhc2sgdG8gZmluYWxpemUgc3JpcHQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMwNTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCB0byBzZW5kIG5vdGlmaWNh dGlvbiB0byBvdGhlciBhdXRob3JzIGZyb20gc2FtZSBhbmFseXNpcyB0YXNrIGJ5IGV4cG9zaW5n CisgICAgICAgIHRoZWlyIGluZm9ybWF0aW9uIHRvIGZpbmFsaXplIHNjcmlwdC4KKworICAgICAg ICAqIHRvb2xzL2pzL2FuYWx5c2lzLXJlc3VsdHMtbm90aWZpZXIuanM6CisgICAgICAgIChBbmFs eXNpc1Jlc3VsdHNOb3RpZmllci5wcm90b3R5cGUuYXN5bmMuc2VuZE5vdGlmaWNhdGlvbnNGb3JU ZXN0R3JvdXBzKToKKwogMjAxOC0xMi0xNCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1QGFwcGxlLmNv bT4KIAogICAgICAgICBFeHRlbmQgY29tbWl0cyB0YWJsZSB0byBjb250YWluIHRlc3RhYmlsaXR5 IGluZm9ybWF0aW9uLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xz L2pzL2FuYWx5c2lzLXJlc3VsdHMtbm90aWZpZXIuanMgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5v cmcvdG9vbHMvanMvYW5hbHlzaXMtcmVzdWx0cy1ub3RpZmllci5qcwppbmRleCA0OGUyMTI5ZWJl YTQ1ZmVmYjkyZTE5MThiNTVkMGQ0ZmI5ZmMxZDQyLi5lOGUwZWI4NjQzOTk3NzhjN2U0NWJjNTA1 MGI4MjE5MGY3YjlkZjc1IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdG9v bHMvanMvYW5hbHlzaXMtcmVzdWx0cy1ub3RpZmllci5qcworKysgYi9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvdG9vbHMvanMvYW5hbHlzaXMtcmVzdWx0cy1ub3RpZmllci5qcwpAQCAtMzYsMTEg KzM2LDIxIEBAIGNsYXNzIEFuYWx5c2lzUmVzdWx0c05vdGlmaWVyIHsKICAgICB7CiAgICAgICAg IGZvciAoY29uc3QgdGVzdEdyb3VwIG9mIHRlc3RHcm91cHMpIHsKICAgICAgICAgICAgIGF3YWl0 IHRlc3RHcm91cC5mZXRjaFRhc2soKTsKKyAgICAgICAgICAgIGNvbnN0IGFsbFRlc3RHcm91cHNG cm9tU2FtZVRhc2sgPSBhd2FpdCBUZXN0R3JvdXAuZmV0Y2hGb3JUYXNrKHRlc3RHcm91cC50YXNr KCkuaWQoKSk7CisgICAgICAgICAgICBjb25zdCBvdGhlclRlc3RHcm91cHNGcm9tU2FtZVRhc2sg PSBhbGxUZXN0R3JvdXBzRnJvbVNhbWVUYXNrLmZpbHRlcigob3RoZXJUZXN0R3JvdXApID0+IG90 aGVyVGVzdEdyb3VwLmlkKCkgIT0gdGVzdEdyb3VwLmlkKCkpOwogICAgICAgICAgICAgY29uc3Qg dGl0bGUgPSBgIiR7dGVzdEdyb3VwLnRhc2soKS5uYW1lKCl9IiAtICIke3Rlc3RHcm91cC5uYW1l KCl9IiBoYXMgZmluaXNoZWRgOwogICAgICAgICAgICAgY29uc3QgbWVzc2FnZSA9IGF3YWl0IEFu YWx5c2lzUmVzdWx0c05vdGlmaWVyLl9tZXNzYWdlRm9yVGVzdEdyb3VwKHRlc3RHcm91cCwgdGl0 bGUpOwogICAgICAgICAgICAgbGV0IGNvbnRlbnQgPSBBbmFseXNpc1Jlc3VsdHNOb3RpZmllci5f aW5zdGFudGlhdGVOb3RpZmljYXRpb25UZW1wbGF0ZSh0aGlzLl9tZXNzYWdlVGVtcGxhdGUsIHRp dGxlLCBtZXNzYWdlKTsKICAgICAgICAgICAgIGNvbnRlbnQgPSB0aGlzLl9hcHBseVJ1bGVzKHRl c3RHcm91cC5wbGF0Zm9ybSgpLm5hbWUoKSwgdGVzdEdyb3VwLnRlc3QoKS5wYXRoKClbMF0ubmFt ZSgpLCAhIXRlc3RHcm91cC5hdXRob3IoKSwgY29udGVudCk7Ci0gICAgICAgICAgICBjb25zdCB0 ZXN0R3JvdXBJbmZvID0ge2F1dGhvcjogdGVzdEdyb3VwLmF1dGhvcigpfTsKKworICAgICAgICAg ICAgY29uc3Qgb3RoZXJBdXRob3JzRnJvbVNhbWVUYXNrID0gbmV3IFNldDsKKyAgICAgICAgICAg IGZvciAoY29uc3Qgb3RoZXJUZXN0R3JvdXAgb2Ygb3RoZXJUZXN0R3JvdXBzRnJvbVNhbWVUYXNr KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICh0ZXN0R3JvdXAuYXV0aG9yKCkg PT0gb3RoZXJUZXN0R3JvdXAuYXV0aG9yKCkpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl OworICAgICAgICAgICAgICAgIG90aGVyQXV0aG9yc0Zyb21TYW1lVGFzay5hZGQob3RoZXJUZXN0 R3JvdXAuYXV0aG9yKCkpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgY29uc3QgdGVzdEdy b3VwSW5mbyA9IHthdXRob3I6IHRlc3RHcm91cC5hdXRob3IoKSwgb3RoZXJBdXRob3JzRnJvbVNh bWVUYXNrOiBBcnJheS5mcm9tKG90aGVyQXV0aG9yc0Zyb21TYW1lVGFzayl9OwogCiAgICAgICAg ICAgICBjb25zdCB0ZW1wRGlyID0gZnMubWtkdGVtcFN5bmMob3MudG1wZGlyKCkpOwogICAgICAg ICAgICAgY29uc3QgdGVtcEZpbGVQYXRoID0gcGF0aC5qb2luKHRlbXBEaXIsICd0ZW1wLWNvbnRl bnQuanNvbicpOwo= 358133 2018-12-28 23:02:41 -0800 2019-01-09 14:21:25 -0800 Patch bug-193054-20181228230240.patch text/plain 2805 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTU2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAwOTM2OTA5NzYxYTI0ZjE3ZGNmM2FhOWI3YTQyZWUxNGQyNGJlNTA1Li4xNjdmY2I3Nzdk MGY1YTU4MzNhMTEyZWZiMzA2ZGI1NGE3YWUwZWE0IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0xMi0yOCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgZXhwb3NlIG90aGVyIGF1dGhvcnMgZnJvbSBz YW1lIGFuYWx5c2lzIHRhc2sgdG8gZmluYWxpemUgc2NyaXB0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMDU0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgdG8gc2VuZCBub3RpZmlj YXRpb24gdG8gb3RoZXIgYXV0aG9ycyBmcm9tIHNhbWUgYW5hbHlzaXMgdGFzayBieSBleHBvc2lu ZworICAgICAgICB0aGVpciBpbmZvcm1hdGlvbiB0byBmaW5hbGl6ZSBzY3JpcHQuCisKKyAgICAg ICAgKiB0b29scy9qcy9hbmFseXNpcy1yZXN1bHRzLW5vdGlmaWVyLmpzOgorICAgICAgICAoQW5h bHlzaXNSZXN1bHRzTm90aWZpZXIucHJvdG90eXBlLmFzeW5jLnNlbmROb3RpZmljYXRpb25zRm9y VGVzdEdyb3Vwcyk6CisKIDIwMTgtMTItMTQgIERld2VpIFpodSAgPGRld2VpX3podUBhcHBsZS5j b20+CiAKICAgICAgICAgRXh0ZW5kIGNvbW1pdHMgdGFibGUgdG8gY29udGFpbiB0ZXN0YWJpbGl0 eSBpbmZvcm1hdGlvbi4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29s cy9qcy9hbmFseXNpcy1yZXN1bHRzLW5vdGlmaWVyLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3Rvb2xzL2pzL2FuYWx5c2lzLXJlc3VsdHMtbm90aWZpZXIuanMKaW5kZXggNDhlMjEyOWVi ZWE0NWZlZmI5MmUxOTE4YjU1ZDBkNGZiOWZjMWQ0Mi4uZThlMGViODY0Mzk5Nzc4YzdlNDViYzUw NTBiODIxOTBmN2I5ZGY3NSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rv b2xzL2pzL2FuYWx5c2lzLXJlc3VsdHMtbm90aWZpZXIuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53 ZWJraXQub3JnL3Rvb2xzL2pzL2FuYWx5c2lzLXJlc3VsdHMtbm90aWZpZXIuanMKQEAgLTM2LDEx ICszNiwyMSBAQCBjbGFzcyBBbmFseXNpc1Jlc3VsdHNOb3RpZmllciB7CiAgICAgewogICAgICAg ICBmb3IgKGNvbnN0IHRlc3RHcm91cCBvZiB0ZXN0R3JvdXBzKSB7CiAgICAgICAgICAgICBhd2Fp dCB0ZXN0R3JvdXAuZmV0Y2hUYXNrKCk7CisgICAgICAgICAgICBjb25zdCBhbGxUZXN0R3JvdXBz RnJvbVNhbWVUYXNrID0gYXdhaXQgVGVzdEdyb3VwLmZldGNoRm9yVGFzayh0ZXN0R3JvdXAudGFz aygpLmlkKCkpOworICAgICAgICAgICAgY29uc3Qgb3RoZXJUZXN0R3JvdXBzRnJvbVNhbWVUYXNr ID0gYWxsVGVzdEdyb3Vwc0Zyb21TYW1lVGFzay5maWx0ZXIoKG90aGVyVGVzdEdyb3VwKSA9PiBv dGhlclRlc3RHcm91cC5pZCgpICE9IHRlc3RHcm91cC5pZCgpKTsKICAgICAgICAgICAgIGNvbnN0 IHRpdGxlID0gYCIke3Rlc3RHcm91cC50YXNrKCkubmFtZSgpfSIgLSAiJHt0ZXN0R3JvdXAubmFt ZSgpfSIgaGFzIGZpbmlzaGVkYDsKICAgICAgICAgICAgIGNvbnN0IG1lc3NhZ2UgPSBhd2FpdCBB bmFseXNpc1Jlc3VsdHNOb3RpZmllci5fbWVzc2FnZUZvclRlc3RHcm91cCh0ZXN0R3JvdXAsIHRp dGxlKTsKICAgICAgICAgICAgIGxldCBjb250ZW50ID0gQW5hbHlzaXNSZXN1bHRzTm90aWZpZXIu X2luc3RhbnRpYXRlTm90aWZpY2F0aW9uVGVtcGxhdGUodGhpcy5fbWVzc2FnZVRlbXBsYXRlLCB0 aXRsZSwgbWVzc2FnZSk7CiAgICAgICAgICAgICBjb250ZW50ID0gdGhpcy5fYXBwbHlSdWxlcyh0 ZXN0R3JvdXAucGxhdGZvcm0oKS5uYW1lKCksIHRlc3RHcm91cC50ZXN0KCkucGF0aCgpWzBdLm5h bWUoKSwgISF0ZXN0R3JvdXAuYXV0aG9yKCksIGNvbnRlbnQpOwotICAgICAgICAgICAgY29uc3Qg dGVzdEdyb3VwSW5mbyA9IHthdXRob3I6IHRlc3RHcm91cC5hdXRob3IoKX07CisKKyAgICAgICAg ICAgIGNvbnN0IG90aGVyQXV0aG9yc0Zyb21TYW1lVGFzayA9IG5ldyBTZXQ7CisgICAgICAgICAg ICBmb3IgKGNvbnN0IG90aGVyVGVzdEdyb3VwIG9mIG90aGVyVGVzdEdyb3Vwc0Zyb21TYW1lVGFz aykKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBpZiAodGVzdEdyb3VwLmF1dGhvcigp ID09IG90aGVyVGVzdEdyb3VwLmF1dGhvcigpKQorICAgICAgICAgICAgICAgICAgICBjb250aW51 ZTsKKyAgICAgICAgICAgICAgICBvdGhlckF1dGhvcnNGcm9tU2FtZVRhc2suYWRkKG90aGVyVGVz dEdyb3VwLmF1dGhvcigpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGNvbnN0IHRlc3RH cm91cEluZm8gPSB7YXV0aG9yOiB0ZXN0R3JvdXAuYXV0aG9yKCksIG90aGVyQXV0aG9yc0Zyb21T YW1lVGFzazogQXJyYXkuZnJvbShvdGhlckF1dGhvcnNGcm9tU2FtZVRhc2spfTsKIAogICAgICAg ICAgICAgY29uc3QgdGVtcERpciA9IGZzLm1rZHRlbXBTeW5jKG9zLnRtcGRpcigpKTsKICAgICAg ICAgICAgIGNvbnN0IHRlbXBGaWxlUGF0aCA9IHBhdGguam9pbih0ZW1wRGlyLCAndGVtcC1jb250 ZW50Lmpzb24nKTsK