193035 2018-12-25 22:47:44 -0800 [JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] 2018-12-25 23:54:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii don.olmstead ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam webkit-bug-importer ysuzuki oldest_to_newest 1490794 0 fujii 2018-12-25 22:47:44 -0800 [JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] clang-cl reports the following warnings for WinCairo port x64 builds: > ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(390,29): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] > ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(466,29): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] > ..\..\Source\JavaScriptCore\dfg/DFGJITCompiler.cpp(486,33): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] > ..\..\Source\JavaScriptCore\jit/JIT.cpp(732,29): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] > ..\..\Source\JavaScriptCore\jit/JIT.cpp(749,33): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] > ..\..\Source\JavaScriptCore\jit/ThunkGenerators.cpp(93,43): warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion] 1490795 1 358075 fujii 2018-12-25 22:55:12 -0800 Created attachment 358075 Patch 1490797 2 358075 ysuzuki 2018-12-25 23:39:19 -0800 Comment on attachment 358075 Patch r=me 1490798 3 358075 fujii 2018-12-25 23:53:38 -0800 Comment on attachment 358075 Patch Clearing flags on attachment: 358075 Committed r239552: <https://trac.webkit.org/changeset/239552> 1490799 4 fujii 2018-12-25 23:53:41 -0800 All reviewed patches have been landed. Closing bug. 1490800 5 webkit-bug-importer 2018-12-25 23:54:23 -0800 <rdar://problem/46946537> 358075 2018-12-25 22:55:12 -0800 2018-12-25 23:53:38 -0800 Patch bug-193035-20181226155511.patch text/plain 5767 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ZGI2NTQ5NjA1MDQ0MGI3OTk3ZjhmNTYxZjk4MTcxYTU0OGMwMTFmLi5lMWEzYjFhNTZiMWY3OTgx M2U1MmRlYTdhOTE1YjEyNGZjMzk5YzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOC0xMi0yNSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbSlNDXVtXaW5dW0NsYW5nXSB3YXJuaW5nOiBpbXBsaWNpdCBj b252ZXJzaW9uIGZyb20gJ3NpemVfdCcgKGFrYSAndW5zaWduZWQgbG9uZyBsb25nJykgdG8gJ2lu dDMyX3QnIChha2EgJ2ludCcpIGNoYW5nZXMgdmFsdWUgZnJvbSAxODQ0Njc0NDA3MzcwOTU1MTU1 MiB0byAtNjQgWy1XY29uc3RhbnQtY29udmVyc2lvbl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzAzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENsYW5nLWNsIHJlcG9ydHMgYSBjb21waWxhdGlvbiB3 YXJuaW5nIGZvciBpbXBsaWNpdCBjb252ZXJzaW9uCisgICAgICAgIGZyb20gLTY0IHNpemVfdCB0 byBpbnQuIFJlcGxhY2VkICctbWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwnCisgICAgICAg IHdpdGggJy1zdGF0aWNfY2FzdDxpbnQzMl90PihtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2Fs bCknLgorCisgICAgICAgICogZGZnL0RGR0pJVENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpKSVRDb21waWxlcjo6Y29tcGlsZSk6CisgICAgICAgIChKU0M6OkRGRzo6SklUQ29tcGls ZXI6OmNvbXBpbGVGdW5jdGlvbik6CisgICAgICAgICogaml0L0pJVC5jcHA6CisgICAgICAgIChK U0M6OkpJVDo6Y29tcGlsZVdpdGhvdXRMaW5raW5nKToKKyAgICAgICAgKiBqaXQvVGh1bmtHZW5l cmF0b3JzLmNwcDoKKyAgICAgICAgKEpTQzo6c2xvd1BhdGhGb3IpOgorCiAyMDE4LTEyLTEzICBZ dXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0Jp Z0ludF0gU3VwcG9ydCBCaWdJbnQgaW4gSlNPTi5zdHJpbmdpZnkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAKaW5kZXggNDMzNzY0MjE3NTZhOTVlMDBkZmEw NzNkYTg3ZjdjMTU1MTdiNjYzZi4uZmNiZDUzYjgyYjViYmM0MmI1OTFhZjcxZWJmZDk5ZTg1Zjg1 Mzc1YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxl ci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAK QEAgLTM4Nyw3ICszODcsNyBAQCB2b2lkIEpJVENvbXBpbGVyOjpjb21waWxlKCkKICAgICBlbWl0 U3RvcmVDb2RlT3JpZ2luKENvZGVPcmlnaW4oMCkpOwogCiAgICAgaWYgKG1heEZyYW1lRXh0ZW50 Rm9yU2xvd1BhdGhDYWxsKQotICAgICAgICBhZGRQdHIoVHJ1c3RlZEltbTMyKC1tYXhGcmFtZUV4 dGVudEZvclNsb3dQYXRoQ2FsbCksIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKKyAgICAgICAgYWRk UHRyKFRydXN0ZWRJbW0zMigtc3RhdGljX2Nhc3Q8aW50MzJfdD4obWF4RnJhbWVFeHRlbnRGb3JT bG93UGF0aENhbGwpKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOwogCiAgICAgbV9zcGVjdWxhdGl2 ZS0+Y2FsbE9wZXJhdGlvbldpdGhDYWxsRnJhbWVSb2xsYmFja09uRXhjZXB0aW9uKG9wZXJhdGlv blRocm93U3RhY2tPdmVyZmxvd0Vycm9yLCBtX2NvZGVCbG9jayk7CiAKQEAgLTQ2Myw3ICs0NjMs NyBAQCB2b2lkIEpJVENvbXBpbGVyOjpjb21waWxlRnVuY3Rpb24oKQogICAgIGVtaXRTdG9yZUNv ZGVPcmlnaW4oQ29kZU9yaWdpbigwKSk7CiAKICAgICBpZiAobWF4RnJhbWVFeHRlbnRGb3JTbG93 UGF0aENhbGwpCi0gICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIoLW1heEZyYW1lRXh0ZW50Rm9y U2xvd1BhdGhDYWxsKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOworICAgICAgICBhZGRQdHIoVHJ1 c3RlZEltbTMyKC1zdGF0aWNfY2FzdDxpbnQzMl90PihtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRo Q2FsbCkpLCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7CiAKICAgICBtX3NwZWN1bGF0aXZlLT5jYWxs T3BlcmF0aW9uV2l0aENhbGxGcmFtZVJvbGxiYWNrT25FeGNlcHRpb24ob3BlcmF0aW9uVGhyb3dT dGFja092ZXJmbG93RXJyb3IsIG1fY29kZUJsb2NrKTsKICAgICAKQEAgLTQ4Myw3ICs0ODMsNyBA QCB2b2lkIEpJVENvbXBpbGVyOjpjb21waWxlRnVuY3Rpb24oKQogICAgICAgICBicmFuY2gzMihB Ym92ZU9yRXF1YWwsIEdQUkluZm86OnJlZ1QxLCBUcnVzdGVkSW1tMzIobV9jb2RlQmxvY2stPm51 bVBhcmFtZXRlcnMoKSkpLmxpbmtUbyhmcm9tQXJpdHlDaGVjaywgdGhpcyk7CiAgICAgICAgIGVt aXRTdG9yZUNvZGVPcmlnaW4oQ29kZU9yaWdpbigwKSk7CiAgICAgICAgIGlmIChtYXhGcmFtZUV4 dGVudEZvclNsb3dQYXRoQ2FsbCkKLSAgICAgICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIoLW1h eEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOworICAg ICAgICAgICAgYWRkUHRyKFRydXN0ZWRJbW0zMigtc3RhdGljX2Nhc3Q8aW50MzJfdD4obWF4RnJh bWVFeHRlbnRGb3JTbG93UGF0aENhbGwpKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOwogICAgICAg ICBtX3NwZWN1bGF0aXZlLT5jYWxsT3BlcmF0aW9uV2l0aENhbGxGcmFtZVJvbGxiYWNrT25FeGNl cHRpb24obV9jb2RlQmxvY2stPm1faXNDb25zdHJ1Y3RvciA/IG9wZXJhdGlvbkNvbnN0cnVjdEFy aXR5Q2hlY2sgOiBvcGVyYXRpb25DYWxsQXJpdHlDaGVjaywgR1BSSW5mbzo6cmVnVDApOwogICAg ICAgICBpZiAobWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwpCiAgICAgICAgICAgICBhZGRQ dHIoVHJ1c3RlZEltbTMyKG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsKSwgc3RhY2tQb2lu dGVyUmVnaXN0ZXIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCmluZGV4IDkxNWIzM2QzN2U2 YjZhMmQ1OGJhMjU0YmJmYmYzZTk1NzFiYjgwMTkuLjM5YmZkNjRjMDQwNWI1ODliNmNiYzBiYWM4 MTc1N2Y5ZTZhNjU3NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAKQEAgLTcyOSw3ICs3 MjksNyBAQCB2b2lkIEpJVDo6Y29tcGlsZVdpdGhvdXRMaW5raW5nKEpJVENvbXBpbGF0aW9uRWZm b3J0IGVmZm9ydCkKICAgICBzdGFja092ZXJmbG93LmxpbmsodGhpcyk7CiAgICAgbV9ieXRlY29k ZU9mZnNldCA9IDA7CiAgICAgaWYgKG1heEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsKQotICAg ICAgICBhZGRQdHIoVHJ1c3RlZEltbTMyKC1tYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbCks IHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKKyAgICAgICAgYWRkUHRyKFRydXN0ZWRJbW0zMigtc3Rh dGljX2Nhc3Q8aW50MzJfdD4obWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwpKSwgc3RhY2tQ b2ludGVyUmVnaXN0ZXIpOwogICAgIGNhbGxPcGVyYXRpb25XaXRoQ2FsbEZyYW1lUm9sbGJhY2tP bkV4Y2VwdGlvbihvcGVyYXRpb25UaHJvd1N0YWNrT3ZlcmZsb3dFcnJvciwgbV9jb2RlQmxvY2sp OwogCiAgICAgLy8gSWYgdGhlIG51bWJlciBvZiBwYXJhbWV0ZXJzIGlzIDEsIHdlIG5ldmVyIHJl cXVpcmUgYXJpdHkgZml4dXAuCkBAIC03NDYsNyArNzQ2LDcgQEAgdm9pZCBKSVQ6OmNvbXBpbGVX aXRob3V0TGlua2luZyhKSVRDb21waWxhdGlvbkVmZm9ydCBlZmZvcnQpCiAgICAgICAgIG1fYnl0 ZWNvZGVPZmZzZXQgPSAwOwogCiAgICAgICAgIGlmIChtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRo Q2FsbCkKLSAgICAgICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIoLW1heEZyYW1lRXh0ZW50Rm9y U2xvd1BhdGhDYWxsKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOworICAgICAgICAgICAgYWRkUHRy KFRydXN0ZWRJbW0zMigtc3RhdGljX2Nhc3Q8aW50MzJfdD4obWF4RnJhbWVFeHRlbnRGb3JTbG93 UGF0aENhbGwpKSwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOwogICAgICAgICBjYWxsT3BlcmF0aW9u V2l0aENhbGxGcmFtZVJvbGxiYWNrT25FeGNlcHRpb24obV9jb2RlQmxvY2stPm1faXNDb25zdHJ1 Y3RvciA/IG9wZXJhdGlvbkNvbnN0cnVjdEFyaXR5Q2hlY2sgOiBvcGVyYXRpb25DYWxsQXJpdHlD aGVjayk7CiAgICAgICAgIGlmIChtYXhGcmFtZUV4dGVudEZvclNsb3dQYXRoQ2FsbCkKICAgICAg ICAgICAgIGFkZFB0cihUcnVzdGVkSW1tMzIobWF4RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwp LCBzdGFja1BvaW50ZXJSZWdpc3Rlcik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Ro dW5rR2VuZXJhdG9ycy5jcHAKaW5kZXggMDc3Nzc5MTU5OWVjMzdmMmMwOWVjYmQyYzRhNzFhYzAx Yjc4YjIwNC4uODYzMGNkNjYyZWEzMDIzY2E1NGMxNWJmOGZiNTUwZTJhMThiMzcxMiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcApAQCAtOTAsNyAr OTAsNyBAQCBzdGF0aWMgdm9pZCBzbG93UGF0aEZvcihDQ2FsbEhlbHBlcnMmIGppdCwgVk0qIHZt LCBTcHJ0X0pJVE9wZXJhdGlvbl9FQ2xpIHNsb3dQYQogICAgIC8vIE90aGVyIGFyZ3VtZW50IHZh bHVlcyBhcmUgc2hpZnQgYnkgMS4gVXNlIHNwYWNlIG9uIHRoZSBzdGFjayBmb3Igb3VyIHR3byBy ZXR1cm4gdmFsdWVzLgogICAgIC8vIE1vdmluZyB0aGUgc3RhY2sgZG93biBtYXhGcmFtZUV4dGVu dEZvclNsb3dQYXRoQ2FsbCBieXRlcyBnaXZlcyB1cyByb29tIGZvciBvdXIgMyBhcmd1bWVudHMK ICAgICAvLyBhbmQgc3BhY2UgZm9yIHRoZSAxNiBieXRlIHJldHVybiBhcmVhLgotICAgIGppdC5h ZGRQdHIoQ0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1tMzIoLW1heEZyYW1lRXh0ZW50Rm9yU2xvd1Bh dGhDYWxsKSwgQ0NhbGxIZWxwZXJzOjpzdGFja1BvaW50ZXJSZWdpc3Rlcik7CisgICAgaml0LmFk ZFB0cihDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMigtc3RhdGljX2Nhc3Q8aW50MzJfdD4obWF4 RnJhbWVFeHRlbnRGb3JTbG93UGF0aENhbGwpKSwgQ0NhbGxIZWxwZXJzOjpzdGFja1BvaW50ZXJS ZWdpc3Rlcik7CiAgICAgaml0Lm1vdmUoR1BSSW5mbzo6cmVnVDIsIEdQUkluZm86OmFyZ3VtZW50 R1BSMik7CiAgICAgaml0LmFkZFB0cihDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMigzMiksIEND YWxsSGVscGVyczo6c3RhY2tQb2ludGVyUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7 CiAgICAgaml0Lm1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3Vt ZW50R1BSMSk7Cg==