193025 2018-12-24 18:25:35 -0800 REGRESSION (r237269): webkit-patch what-broke is broken 2019-02-04 21:18:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar, Regression P1 Normal --- 190732 1 dbates commit-queue aakash_jain ap commit-queue dean_johnson ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1490744 0 dbates 2018-12-24 18:25:35 -0800 webkit-patch what-broke is broken following <https://trac.webkit.org/changeset/237269/> (bug #190732). $ Tools/Scripts/webkit-patch what-broke Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 84, in <module> main() File "Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/.../Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/.../Tools/Scripts/webkitpy/tool/commands/queries.py", line 212, in execute builder_statuses = tool.buildbot.builder_statuses() AttributeError: 'WebKitPatch' object has no attribute 'buildbot' 1490958 1 webkit-bug-importer 2018-12-28 17:37:29 -0800 <rdar://problem/46974154> 1501342 2 360921 commit-queue 2019-02-01 16:13:23 -0800 Created attachment 360921 Patch 1501354 3 360921 dbates 2019-02-01 16:44:59 -0800 Comment on attachment 360921 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360921&action=review > Tools/ChangeLog:1 > +2019-02-01 Commit Queue <commit-queue@webkit.org> It happened! AI is here! And I thought you were only capable of landing patches. 1501361 4 360925 commit-queue 2019-02-01 17:17:23 -0800 Created attachment 360925 Patch 1501914 5 aakash_jain 2019-02-04 11:09:08 -0800 r+ after fixing the ChangeLog. 1501936 6 360925 commit-queue 2019-02-04 11:49:14 -0800 Comment on attachment 360925 Patch Clearing flags on attachment: 360925 Committed r240936: <https://trac.webkit.org/changeset/240936> 1501937 7 commit-queue 2019-02-04 11:49:16 -0800 All reviewed patches have been landed. Closing bug. 1502247 8 dbates 2019-02-04 21:16:20 -0800 (In reply to WebKit Commit Bot from comment #4) > Created attachment 360925 [details] > Patch You're a bad bot. Now, you're impersonating someone else :/ 1502248 9 dbates 2019-02-04 21:18:46 -0800 (In reply to Daniel Bates from comment #8) > (In reply to WebKit Commit Bot from comment #4) > > Created attachment 360925 [details] > > Patch > > You're a bad bot. Now, you're impersonating someone else :/ Joking aside. Dean, hint, hint, hint. 360921 2019-02-01 16:13:23 -0800 2019-02-01 17:17:22 -0800 Patch bug-193025-20190201161322.patch text/plain 1169 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjExNWYyOThlYzhiNDdlZjgxNjU1M2IyN2NkYTYzYTdl MjU0ZDgwMy4uYjM3NjRmODZlOThlZjhmY2YxZDMwNmZmNWE1Y2U5ZmU1OGM2NjhlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTAxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBSRUdSRVNTSU9OIChyMjM3MjY5KTogd2Via2l0LXBhdGNoIHdoYXQtYnJva2Ug aXMgYnJva2VuIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzMDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5OgorICAgICAgICAoSG9zdC5idWls ZGJvdCk6CisgICAgICAgIChIb3N0LmJ1Z3ppbGxhKTogUmVuYW1lZCB0byAnYnVpbGRib3QnLgor CiAyMDE4LTExLTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBF TkFCTEVfRkFTVF9KSVRfUEVSTUlTU0lPTlMgc2hvdWxkIGJlIGZhbHNlIGZvciBpb3NtYWMuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQppbmRleCAwNzgxMzlkNzAyMmYzYjQxYTY2 NWEzMzVkMmFkNTY2NmRkNjJiNmYzLi42ZjY4Y2YyMmEzZWI3N2FlMzk2YmFhMTdmMTZiY2JhMzA4 MmJlZGQ5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkKQEAgLTYzLDcgKzYz LDcgQEAgY2xhc3MgSG9zdChTeXN0ZW1Ib3N0KToKIAogICAgIEBwcm9wZXJ0eQogICAgIEBtZW1v aXplZAotICAgIGRlZiBidWd6aWxsYShzZWxmKToKKyAgICBkZWYgYnVpbGRib3Qoc2VsZik6CiAg ICAgICAgIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldCBpbXBvcnQgYnVpbGRib3QKICAgICAgICAg cmV0dXJuIGJ1aWxkYm90LkJ1aWxkQm90KCkKIAo= 360925 2019-02-01 17:17:23 -0800 2019-02-04 11:49:14 -0800 Patch bug-193025-20190201171722.patch text/plain 1168 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4NjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjExNWYyOThlYzhiNDdlZjgxNjU1M2IyN2NkYTYzYTdl MjU0ZDgwMy4uZjE1ZjE2ZWVhYWQxZTE4MzQ2OWRiOWIwYzRhODY2NGRiYTI2MzYzZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAyLTAxICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyMzcyNjkpOiB3ZWJraXQtcGF0Y2ggd2hhdC1icm9rZSBp cyBicm9rZW4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTMwMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHk6CisgICAgICAgIChIb3N0LmJ1aWxk Ym90KToKKyAgICAgICAgKEhvc3QuYnVnemlsbGEpOiBSZW5hbWVkIHRvICdidWlsZGJvdCcuCisK IDIwMTgtMTEtMjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEVO QUJMRV9GQVNUX0pJVF9QRVJNSVNTSU9OUyBzaG91bGQgYmUgZmFsc2UgZm9yIGlvc21hYy4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CmluZGV4IDA3ODEzOWQ3MDIyZjNiNDFhNjY1 YTMzNWQyYWQ1NjY2ZGQ2MmI2ZjMuLjZmNjhjZjIyYTNlYjc3YWUzOTZiYWExN2YxNmJjYmEzMDgy YmVkZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQpAQCAtNjMsNyArNjMs NyBAQCBjbGFzcyBIb3N0KFN5c3RlbUhvc3QpOgogCiAgICAgQHByb3BlcnR5CiAgICAgQG1lbW9p emVkCi0gICAgZGVmIGJ1Z3ppbGxhKHNlbGYpOgorICAgIGRlZiBidWlsZGJvdChzZWxmKToKICAg ICAgICAgZnJvbSB3ZWJraXRweS5jb21tb24ubmV0IGltcG9ydCBidWlsZGJvdAogICAgICAgICBy ZXR1cm4gYnVpbGRib3QuQnVpbGRCb3QoKQogCg==