192989 2018-12-21 11:48:55 -0800 Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223 2018-12-21 12:25:31 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin cdumez commit-queue ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1490421 0 krollin 2018-12-21 11:48:55 -0800 willSendRequest is calling maybeLoadFallbackForRedirect, which can delete “this”. After that, some new logging code tries to access “this” and causes the crash. <rdar://problem/46901747> 1490423 1 357963 krollin 2018-12-21 11:56:23 -0800 Created attachment 357963 Patch 1490426 2 357963 cdumez 2018-12-21 12:00:07 -0800 Comment on attachment 357963 Patch r=me 1490435 3 357963 commit-queue 2018-12-21 12:25:29 -0800 Comment on attachment 357963 Patch Clearing flags on attachment: 357963 Committed r239514: <https://trac.webkit.org/changeset/239514> 1490436 4 commit-queue 2018-12-21 12:25:31 -0800 All reviewed patches have been landed. Closing bug. 357963 2018-12-21 11:56:23 -0800 2018-12-21 12:25:29 -0800 Patch bug-192989-20181221115622.patch text/plain 2677 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZmNWM1OTU5NTUwYTAyYjZl MWVjNGM3NDYwNWVhMGQ2ZmY0YjIyZWQuLmRhNmUzNTFiZTIyN2YxNWQzMDVmZDcxNDQwMzQ1Y2Jm MzNmMWYzNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTItMjEgIEtlaXRoIFJv bGxpbiAgPGtyb2xsaW5AYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIGNvbS5hcHBsZS5X ZWJLaXQ6IFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCArIDIyMwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyOTg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2lsbFNlbmRS ZXF1ZXN0IGlzIGNhbGxpbmcgbWF5YmVMb2FkRmFsbGJhY2tGb3JSZWRpcmVjdCwgd2hpY2ggY2Fu CisgICAgICAgIGRlbGV0ZSDigJx0aGlz4oCdLiBBZnRlciB0aGF0LCBzb21lIG5ldyBsb2dnaW5n IGNvZGUgdHJpZXMgdG8gYWNjZXNzCisgICAgICAgIOKAnHRoaXPigJ0gYW5kIGNhdXNlcyB0aGUg Y3Jhc2guIEZpeCB0aGlzIGJ5IGFkanVzdGluZyB0aGUgc2NvcGUgb2YgYQorICAgICAgICAicHJv dGVjdGVkVGhpcyIuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VM b2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRS ZXF1ZXN0KToKKwogMjAxOC0xMi0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFVzZSBPcHRpb25hbDo6dmFsdWVPcigpIGluc3RlYWQgb2YgT3B0aW9uYWw6OnZh bHVlX29yKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl YlJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl YlJlc291cmNlTG9hZGVyLmNwcAppbmRleCA5N2EwYTMzZDljMDc5MDUzMDkyZjc2MzM1ZDY4ZmNk ZjU2NWQ1MDY4Li4xMzA5ZGM3MzcwODhlYzdhZWEwNmEzN2VkYjUyM2YxZTAzNmMxN2YxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VM b2FkZXIuY3BwCkBAIC04NSw2ICs4NSw4IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6OmRldGFj aEZyb21Db3JlTG9hZGVyKCkKIAogdm9pZCBXZWJSZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRSZXF1 ZXN0KFJlc291cmNlUmVxdWVzdCYmIHByb3Bvc2VkUmVxdWVzdCwgUmVzb3VyY2VSZXNwb25zZSYm IHJlZGlyZWN0UmVzcG9uc2UpCiB7CisgICAgUmVmPFdlYlJlc291cmNlTG9hZGVyPiBwcm90ZWN0 ZWRUaGlzKCp0aGlzKTsKKwogICAgIExPRyhOZXR3b3JrLCAiKFdlYlByb2Nlc3MpIFdlYlJlc291 cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QgdG8gJyVzJyIsIHByb3Bvc2VkUmVxdWVzdC51cmwo KS5zdHJpbmcoKS5sYXRpbjEoKS5kYXRhKCkpOwogICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQo IndpbGxTZW5kUmVxdWVzdDogKHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJ dTY0ICIsIHJlc291cmNlSUQgPSAlIiBQUkl1NjQgIikiLCBtX3RyYWNraW5nUGFyYW1ldGVycy5w YWdlSUQsIG1fdHJhY2tpbmdQYXJhbWV0ZXJzLmZyYW1lSUQsIG1fdHJhY2tpbmdQYXJhbWV0ZXJz LnJlc291cmNlSUQpOwogCkBAIC05Myw3ICs5NSw3IEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6 OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmJiBwcm9wb3NlZFJlcXVlc3QsIFJlc291 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2NvcmVMb2FkZXItPndpbGxTZW5kUmVx dWVzdChXVEZNb3ZlKHByb3Bvc2VkUmVxdWVzdCksIHJlZGlyZWN0UmVzcG9uc2UsIFt0aGlzLCBw cm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKFJlc291cmNlUmVxdWVzdCYmIHJlcXVlc3Qp IHsKKyAgICBtX2NvcmVMb2FkZXItPndpbGxTZW5kUmVxdWVzdChXVEZNb3ZlKHByb3Bvc2VkUmVx dWVzdCksIHJlZGlyZWN0UmVzcG9uc2UsIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92ZShw cm90ZWN0ZWRUaGlzKV0oUmVzb3VyY2VSZXF1ZXN0JiYgcmVxdWVzdCkgewogICAgICAgICBpZiAo IW1fY29yZUxvYWRlciB8fCAhbV9jb3JlTG9hZGVyLT5pZGVudGlmaWVyKCkpIHsKICAgICAgICAg ICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoIndpbGxTZW5kUmVxdWVzdDogZXhpdGluZyBlYXJs eSBiZWNhdXNlIG5vIGNvcmVsb2FkZXIgb3IgaWRlbnRpZmllciAocGFnZUlEID0gJSIgUFJJdTY0 ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3VyY2VJRCA9ICUiIFBSSXU2NCAiKSIsIG1f dHJhY2tpbmdQYXJhbWV0ZXJzLnBhZ2VJRCwgbV90cmFja2luZ1BhcmFtZXRlcnMuZnJhbWVJRCwg bV90cmFja2luZ1BhcmFtZXRlcnMucmVzb3VyY2VJRCk7CiAgICAgICAgICAgICByZXR1cm47Cg==