192986 2018-12-21 10:38:36 -0800 [HarfBuzz] Width not correctly reported as 0 for zero font size 2019-01-20 19:09:57 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1490395 0 cgarcia 2018-12-21 10:38:36 -0800 This caused test fast/text/font-size-zero.html (ans likely some others) to fail since we started to use complex text for GTK+ layout tests. 1490396 1 357958 cgarcia 2018-12-21 10:40:35 -0800 Created attachment 357958 Patch 1490413 2 357958 mcatanzaro 2018-12-21 11:30:48 -0800 Comment on attachment 357958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357958&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyps when the font glyphs 1490624 3 cgarcia 2018-12-22 04:34:05 -0800 Committed r239539: <https://trac.webkit.org/changeset/239539> 1490625 4 webkit-bug-importer 2018-12-22 04:35:26 -0800 <rdar://problem/46918699> 1496475 5 mcatanzaro 2019-01-20 19:09:57 -0800 I'm updating this expectation (assuming the change in expectation is correct): --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/text/font-size-below-point-five-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/svg/text/font-size-below-point-five-actual.txt @@ -30,7 +30,6 @@ chunk 1 text run 1 at (35.63,10.00) startOffset 0 endOffset 1 width 4.06: " " RenderSVGTSpan {tspan} at (0,0) size 0x1 RenderSVGInlineText {#text} at (-10,4) size 0x0 - chunk 1 text run 1 at (39.69,10.00) startOffset 0 endOffset 1 width 0.31: "6" RenderSVGInlineText {#text} at (0,0) size 0x0 RenderSVGText {text} at (63,42) size 124x10 contains 1 chunk(s) RenderSVGInlineText {#text} at (0,0) size 124x9 357958 2018-12-21 10:40:35 -0800 2018-12-21 11:30:34 -0800 Patch wk-hb-zero-font-size.diff text/plain 1621 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNjc1YmU3YmZjOC4uOWUzZWRlMTU0ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0xMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0hhcmZCdXp6XSBXaWR0aCBub3QgY29ycmVjdGx5IHJlcG9y dGVkIGFzIDAgZm9yIHplcm8gZm9udCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI5ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlcyB0ZXN0IGZhc3QvdGV4dC9mb250LXNpemUtemVyby5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENv bnRyb2xsZXJIYXJmQnV6ei5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wbGV4VGV4dENvbnRy b2xsZXI6OkNvbXBsZXhUZXh0UnVuOjpDb21wbGV4VGV4dFJ1bik6IFVzZSBlbXB0eSBhZHZhbmNl cyBmb3IgZ2x5cHMgd2hlbiB0aGUgZm9udAorICAgICAgICBzaXplIGlzIHplcm8uCisKIDIwMTgt MTItMjAgIEp1c3RpbiBGYW4gIDxqdXN0aW5fZmFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2Vi R1BVXSBDb252ZXJ0IFdlYkdQVUJpbmRHcm91cHMgaW50byBNVExBcmd1bWVudEVuY29kZXJzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21w bGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAKaW5kZXgg MGUwYWE2Y2FkMTUuLjU1MzJkMTg5OTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovQ29tcGxleFRl eHRDb250cm9sbGVySGFyZkJ1enouY3BwCkBAIC0xNTYsNyArMTU2LDcgQEAgQ29tcGxleFRleHRD b250cm9sbGVyOjpDb21wbGV4VGV4dFJ1bjo6Q29tcGxleFRleHRSdW4oaGJfYnVmZmVyX3QqIGJ1 ZmZlciwgY29uc3QKICAgICAgICAgbV9jb3JlVGV4dEluZGljZXNbaV0gPSBnbHlwaEluZm9zW2ld LmNsdXN0ZXI7CiAKICAgICAgICAgdWludDE2X3QgZ2x5cGggPSBnbHlwaEluZm9zW2ldLmNvZGVw b2ludDsKLSAgICAgICAgaWYgKG1fZm9udC5pc1plcm9XaWR0aFNwYWNlR2x5cGgoZ2x5cGgpKSB7 CisgICAgICAgIGlmIChtX2ZvbnQuaXNaZXJvV2lkdGhTcGFjZUdseXBoKGdseXBoKSB8fCAhbV9m b250LnBsYXRmb3JtRGF0YSgpLnNpemUoKSkgewogICAgICAgICAgICAgbV9nbHlwaHNbaV0gPSBn bHlwaDsKICAgICAgICAgICAgIG1fYmFzZUFkdmFuY2VzW2ldID0geyB9OwogICAgICAgICAgICAg bV9nbHlwaE9yaWdpbnNbaV0gPSB7IH07Cg==