192984 2018-12-21 09:40:50 -0800 Setting the file wrapper and content type of an attachment to a PDF should update its image 2018-12-21 11:40:53 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin cdumez commit-queue esprehn+autocc ews-watchlist gyuyoung.kim mitz thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1490362 0 wenson_hsieh 2018-12-21 09:40:50 -0800 <rdar://problem/46798028> 1490394 1 357957 wenson_hsieh 2018-12-21 10:36:01 -0800 Created attachment 357957 Patch 1490419 2 357957 commit-queue 2018-12-21 11:40:52 -0800 Comment on attachment 357957 Patch Clearing flags on attachment: 357957 Committed r239511: <https://trac.webkit.org/changeset/239511> 1490420 3 commit-queue 2018-12-21 11:40:53 -0800 All reviewed patches have been landed. Closing bug. 357957 2018-12-21 10:36:01 -0800 2018-12-21 11:40:52 -0800 Patch bug-192984-20181221103600.patch text/plain 4647 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM2ZmVkY2Y5NmNiODhm NDgzZGRhYjNhNzU4NTE4ZmYzNTk5NjQxOC4uZTc1ZWMxMjlhYTQ2NTFhYTU4ODQ0MTY2NTk3ZTc3 YzIyYzhiNjI2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEyLTIxICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFNldHRpbmcgdGhl IGZpbGUgd3JhcHBlciBhbmQgY29udGVudCB0eXBlIG9mIGFuIGF0dGFjaG1lbnQgdG8gYSBQREYg c2hvdWxkIHVwZGF0ZSBpdHMgaW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Mjk4NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY3OTgwMjg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cg UERGIGRhdGEgdG8gYmUgdXNlZCB0byB1cGRhdGUgZW5jbG9zaW5nIGltYWdlIGVsZW1lbnRzIHdo ZW4gc2V0dGluZyB0aGUgZmlsZSB3cmFwcGVyIGZvciBhbiBhdHRhY2htZW50LgorICAgICAgICBD b3ZlcmVkIGJ5IGEgbmV3IEFQSSB0ZXN0OiBXS0F0dGFjaG1lbnRUZXN0cy5TZXRGaWxlV3JhcHBl ckZvclBERkltYWdlQXR0YWNobWVudC4KKworICAgICAgICAqIGh0bWwvSFRNTEF0dGFjaG1lbnRF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1pbWVUeXBlSXNTdWl0YWJsZUZvcklubGlu ZUltYWdlQXR0YWNobWVudCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQXR0YWNobWVudEVsZW1l bnQ6OnVwZGF0ZUVuY2xvc2luZ0ltYWdlV2l0aERhdGEpOgorCiAyMDE4LTEyLTIxICBNYW51ZWwg UmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtZ3JpZF0g Rml4IHBlcmNlbnRhZ2VzIGluIHJlbGF0aXZlIG9mZnNldHMgZm9yIGdyaWQgaXRlbXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEF0dGFjaG1lbnRFbGVtZW50LmNwcAppbmRleCA3MTExY2Y2 ZDhkOTM3ODhlNzA1YjhkNjM2YmUxMjVkY2QyZjM2ZmNhLi5jMDQwYzE5OGQ5ZDFiNzBkNzBlYzUw ZWYyYTQ5ODE0ZWJmZDNiMTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxB dHRhY2htZW50RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQXR0YWNo bWVudEVsZW1lbnQuY3BwCkBAIC0yMjYsNiArMjI2LDExIEBAIHZvaWQgSFRNTEF0dGFjaG1lbnRF bGVtZW50Ojp1cGRhdGVBdHRyaWJ1dGVzKE9wdGlvbmFsPHVpbnQ2NF90PiYmIG5ld0ZpbGVTaXpl LCBjCiAgICAgICAgIHJlbmRlcmVyLT5pbnZhbGlkYXRlKCk7CiB9CiAKK3N0YXRpYyBib29sIG1p bWVUeXBlSXNTdWl0YWJsZUZvcklubGluZUltYWdlQXR0YWNobWVudChjb25zdCBTdHJpbmcmIG1p bWVUeXBlKQoreworICAgIHJldHVybiBNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdl TUlNRVR5cGUobWltZVR5cGUpIHx8IE1JTUVUeXBlUmVnaXN0cnk6OmlzUERGTUlNRVR5cGUobWlt ZVR5cGUpOworfQorCiB2b2lkIEhUTUxBdHRhY2htZW50RWxlbWVudDo6dXBkYXRlRW5jbG9zaW5n SW1hZ2VXaXRoRGF0YShjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlLCBSZWY8U2hhcmVkQnVmZmVy PiYmIGRhdGEpCiB7CiAgICAgYXV0byogaG9zdEVsZW1lbnQgPSBzaGFkb3dIb3N0KCk7CkBAIC0y MzgsNyArMjQzLDcgQEAgdm9pZCBIVE1MQXR0YWNobWVudEVsZW1lbnQ6OnVwZGF0ZUVuY2xvc2lu Z0ltYWdlV2l0aERhdGEoY29uc3QgU3RyaW5nJiBjb250ZW50VHkKICAgICAgICAgbWltZVR5cGUg PSBNSU1FVHlwZUZyb21VVEkoY29udGVudFR5cGUpOwogI2VuZGlmCiAKLSAgICBpZiAoIU1JTUVU eXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZShtaW1lVHlwZSkpCisgICAgaWYg KCFtaW1lVHlwZUlzU3VpdGFibGVGb3JJbmxpbmVJbWFnZUF0dGFjaG1lbnQobWltZVR5cGUpKQog ICAgICAgICByZXR1cm47CiAKICAgICBob3N0RWxlbWVudC0+c2V0QXR0cmlidXRlV2l0aG91dFN5 bmNocm9uaXphdGlvbihIVE1MTmFtZXM6OnNyY0F0dHIsIERPTVVSTDo6Y3JlYXRlT2JqZWN0VVJM KGRvY3VtZW50KCksIEJsb2I6OmNyZWF0ZShXVEZNb3ZlKGRhdGEpLCBtaW1lVHlwZSkpKTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYzVjOWEy ODQ0ODg4NTE2YjYyNzgyNzEwOTJjYjYzOGM5MzE0MzFlLi4wNmM3NmUzOWQ5OTIxZTk2YmFkYTg0 YjI1ZTUzOTUxZGRhNmU3NmNmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTItMjEgIFdlbnNvbiBIc2llaCAg PHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgU2V0dGluZyB0aGUgZmlsZSB3cmFw cGVyIGFuZCBjb250ZW50IHR5cGUgb2YgYW4gYXR0YWNobWVudCB0byBhIFBERiBzaG91bGQgdXBk YXRlIGl0cyBpbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkyOTg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80Njc5ODAyOD4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4gQVBJIHRlc3Qg dG8gdmVyaWZ5IHRoYXQgc2V0dGluZyB0aGUgZmlsZSB3cmFwcGVyIGZvciBhIF9XS0F0dGFjaG1l bnQgd2l0aCBhbiBlbmNsb3NpbmcgaW1hZ2UgZWxlbWVudCB3aXRoCisgICAgICAgIFBERiBkYXRh IGNvcnJlY3RseSB1cGRhdGVzIHRoZSBpbWFnZSBlbGVtZW50LgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbToKKwogMjAxOC0x Mi0yMSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzQ2MTk0MzE1PiBtYWNPUzogV2ViS2l0MSBkb2VzIG5vdCBoYW5kbGUg b2NjbHVzaW9uIGNoYW5nZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tCmluZGV4IDgzYjA2NjA1MzZmYWVk ZTFlMmNjMzUzMDMxZTk5NjQ2YzVlOGVjNTIuLjcyMmI2OGNkN2ExOTI2Mzk3Yjc0NTAwMDQyNTM2 Y2U0MzY1OGExMmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQpAQCAtMTUwNSw2ICsxNTA1LDE4IEBA IFRFU1QoV0tBdHRhY2htZW50VGVzdHMsIEF0dGFjaG1lbnRJZGVudGlmaWVyT2ZDbG9uZWRBdHRh Y2htZW50KQogICAgIEVYUEVDVF9XS19TVFJFUShbYXR0YWNobWVudCB1bmlxdWVJZGVudGlmaWVy XSwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LmJvZHku Y2xvbmVOb2RlKHRydWUpLnF1ZXJ5U2VsZWN0b3IoJ2F0dGFjaG1lbnQnKS51bmlxdWVJZGVudGlm aWVyIl0pOwogfQogCitURVNUKFdLQXR0YWNobWVudFRlc3RzLCBTZXRGaWxlV3JhcHBlckZvclBE RkltYWdlQXR0YWNobWVudCkKK3sKKyAgICBhdXRvIHdlYlZpZXcgPSB3ZWJWaWV3Rm9yVGVzdGlu Z0F0dGFjaG1lbnRzKCk7CisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAiZG9jdW1l bnQuYm9keS5hcHBlbmRDaGlsZCgpIiBjb21wbGV0aW9uSGFuZGxlcjpuaWxdOworICAgIE5TU3Ry aW5nICppZGVudGlmaWVyID0gW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpA ImNvbnN0IGkgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpbWcnKTsgZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChpKTsgSFRNTEF0dGFjaG1lbnRFbGVtZW50LmdldEF0dGFjaG1lbnRJZGVudGlm aWVyKGkpIl07CisgICAgX1dLQXR0YWNobWVudCAqYXR0YWNobWVudCA9IFt3ZWJWaWV3IF9hdHRh Y2htZW50Rm9ySWRlbnRpZmllcjppZGVudGlmaWVyXTsKKworICAgIGF1dG8gcGRmRmlsZSA9IGFk b3B0TlMoW1tOU0ZpbGVXcmFwcGVyIGFsbG9jXSBpbml0UmVndWxhckZpbGVXaXRoQ29udGVudHM6 dGVzdFBERkRhdGEoKV0pOworICAgIFthdHRhY2htZW50IHNldEZpbGVXcmFwcGVyOnBkZkZpbGUu Z2V0KCkgY29udGVudFR5cGU6KF9fYnJpZGdlIE5TU3RyaW5nICopa1VUVHlwZVBERiBjb21wbGV0 aW9uOm5pbF07CisgICAgW3dlYlZpZXcgd2FpdEZvckltYWdlRWxlbWVudFNpemVUb0JlY29tZTpD R1NpemVNYWtlKDEzMCwgMjkpXTsKK30KKwogI3ByYWdtYSBtYXJrIC0gUGxhdGZvcm0tc3BlY2lm aWMgdGVzdHMKIAogI2lmIFBMQVRGT1JNKE1BQykK