192981 2018-12-21 06:46:22 -0800 [JSC] Use appendUnbarriered for cached own keys 2018-12-21 22:40:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1490332 0 ysuzuki 2018-12-21 06:46:22 -0800 [JSC] Use appendUnbarriered for cached own keys 1490333 1 357941 ysuzuki 2018-12-21 06:49:00 -0800 Created attachment 357941 Patch 1490382 2 357941 saam 2018-12-21 10:11:51 -0800 Comment on attachment 357941 Patch r=me 1490383 3 357941 saam 2018-12-21 10:12:32 -0800 Comment on attachment 357941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357941&action=review > Source/JavaScriptCore/ChangeLog:8 > + It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after I think unlikely is the wrong wording. We never do this now, but might in the future. 1490384 4 ysuzuki 2018-12-21 10:14:33 -0800 (In reply to Saam Barati from comment #3) > Comment on attachment 357941 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357941&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + It seems unlikely now, but m_cachedOwnKeys would be changed to sentinel after > > I think unlikely is the wrong wording. We never do this now, but might in > the future. Yeah, fixed. Thanks :) 1490617 5 ysuzuki 2018-12-21 22:39:28 -0800 Committed r239536: <https://trac.webkit.org/changeset/239536> 1490618 6 webkit-bug-importer 2018-12-21 22:40:25 -0800 <rdar://problem/46916287> 357941 2018-12-21 06:49:00 -0800 2018-12-21 10:11:51 -0800 Patch bug-192981-20181221234859.patch text/plain 2053 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZjExNjcwMWQwOTE1NTBlNmM1MzQwODFkZjBjNzFhNTM4MmNjNTg0Li5hNDA0N2ZhOTU4NjJlODdh MWQ3Y2FhMDUwZWFjMzA4YzdhMjc2NWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0xMi0yMSAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIFVzZSBhcHBlbmRVbmJhcnJpZXJlZCBmb3IgY2Fj aGVkIG93biBrZXlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTI5ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCBzZWVtcyB1bmxpa2VseSBub3csIGJ1dCBtX2NhY2hlZE93bktleXMgd291bGQgYmUg Y2hhbmdlZCB0byBzZW50aW5lbCBhZnRlcgorICAgICAgICBjaGVja2luZyBgdGhpc09iamVjdC0+ bV9jYWNoZWRPd25LZXlzLnVudmFsaWRhdGVkR2V0KCkgIT0gY2FjaGVkT3duS2V5c1NlbnRpbmVs KClgCisgICAgICAgIGFuZCBiZWZvcmUgZXhlY3V0aW5nIGB2aXNpdG9yLmFwcGVuZCh0aGlzT2Jq ZWN0LT5tX2NhY2hlZE93bktleXMpYC4gVG8gbWFrZQorICAgICAgICB0aGUgY29kZSBzYWZlLCB3 ZSBzaG91bGQgdXNlIGFwcGVuZFVuYmFycmllcmVkIHRvIG1hcmsgbm9uIHNlbnRpbmVsIGNlbGwu CisKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZVJhcmVEYXRhLmNwcDoKKyAgICAgICAgKEpT Qzo6U3RydWN0dXJlUmFyZURhdGE6OnZpc2l0Q2hpbGRyZW4pOgorCiAyMDE4LTEyLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIE9wdGlvbmFsOjpoYXNW YWx1ZSgpIGluc3RlYWQgb2YgT3B0aW9uYWw6Omhhc192YWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVSYXJlRGF0YS5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVSYXJlRGF0YS5jcHAKaW5kZXggZDBmN2Jk ODBjMWMyN2QzZDk2MTEwYTgyNTA0MjFmNjVlMGE4YTk3Mi4uZDU2MDZjZDQxMDVhY2E2MGRlMGY0 YWFkODU1ZDI0ODEzMTQ5ZjBjNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvU3RydWN0dXJlUmFyZURhdGEuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cnVjdHVyZVJhcmVEYXRhLmNwcApAQCAtNzEsOCArNzEsOSBAQCB2b2lkIFN0cnVj dHVyZVJhcmVEYXRhOjp2aXNpdENoaWxkcmVuKEpTQ2VsbCogY2VsbCwgU2xvdFZpc2l0b3ImIHZp c2l0b3IpCiAgICAgdmlzaXRvci5hcHBlbmQodGhpc09iamVjdC0+bV9wcmV2aW91cyk7CiAgICAg dmlzaXRvci5hcHBlbmQodGhpc09iamVjdC0+bV9vYmplY3RUb1N0cmluZ1ZhbHVlKTsKICAgICB2 aXNpdG9yLmFwcGVuZCh0aGlzT2JqZWN0LT5tX2NhY2hlZFByb3BlcnR5TmFtZUVudW1lcmF0b3Ip OwotICAgIGlmICh0aGlzT2JqZWN0LT5tX2NhY2hlZE93bktleXMudW52YWxpZGF0ZWRHZXQoKSAh PSBjYWNoZWRPd25LZXlzU2VudGluZWwoKSkKLSAgICAgICAgdmlzaXRvci5hcHBlbmQodGhpc09i amVjdC0+bV9jYWNoZWRPd25LZXlzKTsKKyAgICBhdXRvKiBjYWNoZWRPd25LZXlzID0gdGhpc09i amVjdC0+bV9jYWNoZWRPd25LZXlzLnVudmFsaWRhdGVkR2V0KCk7CisgICAgaWYgKGNhY2hlZE93 bktleXMgIT0gY2FjaGVkT3duS2V5c1NlbnRpbmVsKCkpCisgICAgICAgIHZpc2l0b3IuYXBwZW5k VW5iYXJyaWVyZWQoY2FjaGVkT3duS2V5cyk7CiB9CiAKIC8vIC0tLS0tLS0tLS0tIE9iamVjdC5w cm90b3R5cGUudG9TdHJpbmcoKSBoZWxwZXIgd2F0Y2hwb2ludCBjbGFzc2VzIC0tLS0tLS0tLS0t Cg==