192957 2018-12-20 14:46:43 -0800 [iOS] Some layout tests are failing after r239441 2018-12-20 17:32:24 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh ap bdakin commit-queue ryanhaddad simon.fraser thorton tsavell webkit-bug-importer wenson_hsieh oldest_to_newest 1490086 0 wenson_hsieh 2018-12-20 14:46:43 -0800 SSIA 1490090 1 wenson_hsieh 2018-12-20 15:00:19 -0800 It looks like these are the relevant tests: • fast/events/ios/click-event-while-editing-node.html • fast/forms/ios/focus-long-textarea.html (this one can just be rebaselined) • fast/forms/ios/zoom-after-input-tap-wide-input.html (this one can just be rebaselined too) • fast/events/ios/key-command-italic-dispatches-keydown.html 1490103 2 wenson_hsieh 2018-12-20 15:40:17 -0800 (In reply to Wenson Hsieh from comment #1) > It looks like these are the relevant tests: > > • fast/events/ios/click-event-while-editing-node.html This test is actually dependent on buggy behavior (scrolling to the touch location rather than the selection), which was fixed in r239441. This just needs to be tweaked slightly. 1490126 3 wenson_hsieh 2018-12-20 16:01:26 -0800 (In reply to Wenson Hsieh from comment #1) > It looks like these are the relevant tests: > … > • fast/events/ios/key-command-italic-dispatches-keydown.html It turns out that this test has the same result before and after my change. 1490137 4 wenson_hsieh 2018-12-20 16:08:10 -0800 <rdar://problem/46781759> 1490148 5 357894 wenson_hsieh 2018-12-20 16:13:49 -0800 Created attachment 357894 Patch 1490216 6 357894 commit-queue 2018-12-20 17:32:23 -0800 Comment on attachment 357894 Patch Clearing flags on attachment: 357894 Committed r239482: <https://trac.webkit.org/changeset/239482> 1490217 7 commit-queue 2018-12-20 17:32:24 -0800 All reviewed patches have been landed. Closing bug. 357894 2018-12-20 16:13:49 -0800 2018-12-20 17:32:23 -0800 Patch bug-192957-20181220161349.patch text/plain 3671 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDU1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDJhMWRkOTUyYzgzNjM4NzhiMjUx NDNhMDI2NmU3YTIwOTdiYmI4MC4uYmU2OTA3NGE5NDJjYjA3ZGJkMjU4ZDlhZDNhY2RhZDNhZjZl ODUzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTEyLTIwICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFNvbWUgbGF5b3V0IHRlc3Rz IGFyZSBmYWlsaW5nIGFmdGVyIHIyMzk0NDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5Mjk1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDY3ODE3 NTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IHNldmVyYWwgZmFpbGluZyBsYXlvdXQgdGVzdHMgYWZ0ZXIgcjIzOTQ0MS4KKworICAgICAgICAq IGZhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRtbDoKKwor ICAgICAgICBUaGlzIHRlc3Qgc3RhcnRlZCBmYWlsaW5nIGFmdGVyIHIyMzk0NDEgYmVjYXVzZSBp dCB0YXBzIHRoZSBib3R0b20gb2YgdGhlIGVkaXRhYmxlIGVsZW1lbnQsIGFuZCB0aGVuIGV4cGVj dHMKKyAgICAgICAgV2ViS2l0IHRvIHNjcm9sbCB0aGUgd2ViIHZpZXcgdXAgdG8gcmV2ZWFsIHRo ZSB0b3VjaGVkIGxvY2F0aW9uLiBUaGlzIHdhcyBleGFjdGx5IHRoZSBidWcgdGhhdCByMjM5NDQx IGZpeGVkLCBzbworICAgICAgICB3ZSBzaG91bGQganVzdCBtYWtlIHRoaXMgdGVzdCBubyBsb25n ZXIgZGVwZW5kIG9uIHRoZSBicm9rZW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1z L2lvcy9mb2N1cy1sb25nLXRleHRhcmVhLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zv cm1zL2lvcy96b29tLWFmdGVyLWlucHV0LXRhcC13aWRlLWlucHV0LWV4cGVjdGVkLnR4dDoKKwor ICAgICAgICBSZWJhc2VsaW5lIGEgY291cGxlIG9mIHRlc3QgZXhwZWN0YXRpb25zIHRvIGFjY291 bnQgZm9yIHRoZSBjaGFuZ2UgaW4gbWFyZ2luIGFyb3VuZCB0aGUgc2VsZWN0aW9uIHJlY3QsIGlu CisgICAgICAgIC1bV0tXZWJWaWV3IF96b29tVG9Gb2N1c1JlY3Q64oCmOl0uCisKIDIwMTgtMTIt MjAgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g TGF5b3V0IFRlc3QgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtl cnMvc2VydmljZS13b3JrZXIvdXBkYXRlLXJlZ2lzdHJhdGlvbi13aXRoLXR5cGUuaHR0cHMuaHRt bCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRtbAppbmRleCA0 ZGUwOWRjMTMwNjU3ZWNhNDJiNGFiZDYzMjcyYjQyY2E5MmFmOGIyLi5mNmIzNGU1ZGJlOTlmZTRh ZmE5Y2RkMjA1MWQ2Yjc0YTBiYWE3MzI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9pb3MvY2xpY2stZXZlbnQtd2hpbGUtZWRpdGluZy1ub2RlLmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LXdoaWxlLWVkaXRpbmctbm9kZS5odG1s CkBAIC0yNCw4ICsyNCw4IEBAIGVkaXRhYmxlLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVu Y3Rpb24oKXsKIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogICAgIHRlc3RSdW5uZXIuZHVtcEFz VGV4dCgpOwogICAgIGpzVGVzdElzQXN5bmMgPSB0cnVlOwotICAgIFVJSGVscGVyLmFjdGl2YXRl QW5kV2FpdEZvcklucHV0U2Vzc2lvbkF0KDUwLCAzMDApLnRoZW4oKCkgPT4gewotICAgICAgICBV SUhlbHBlci50YXBBdCg1MCwgMzAwKS50aGVuKCgpID0+IHsKKyAgICBVSUhlbHBlci5hY3RpdmF0 ZUFuZFdhaXRGb3JJbnB1dFNlc3Npb25BdCg1MCwgMjAwKS50aGVuKCgpID0+IHsKKyAgICAgICAg VUlIZWxwZXIudGFwQXQoNTAsIDIwMCkudGhlbigoKSA9PiB7CiAgICAgICAgICAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjbGlja3MnKS50ZXh0Q29u dGVudCIsIGAke2NsaWNrQ291bnR9YCk7CiAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKICAg ICAgICAgfSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9mb2N1cy1s b25nLXRleHRhcmVhLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2Zv Y3VzLWxvbmctdGV4dGFyZWEtZXhwZWN0ZWQudHh0CmluZGV4IGMyNmU4ZTBlOTJkMGVmNWI0OWUx MzljNTJkMGY1YWFlZWM4MTQ4YWEuLmNiYzBmZjQ0NGYzN2YzNmE5ZWFhNjlmZmVlMjMwODI4ZmMy ZjAyNjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZvY3VzLWxvbmct dGV4dGFyZWEtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2Zv Y3VzLWxvbmctdGV4dGFyZWEtZXhwZWN0ZWQudHh0CkBAIC0zLDQgKzMsNCBAQCBUZXN0cyB6b29t aW5nIGludG8gYSB0YWxsIHRleHRhcmVhIG9uIHRhcC4KIAogdGFwIGxvY2F0aW9uCXsgeDogMzgu MDAwLCB5OiA2NjQuMDAwIH0KIHNjYWxlCTEuNDU1Ci12aXNpYmxlUmVjdAl7IGxlZnQ6IDAuMDAw LCB0b3A6IDUwNi4yOTQsIHdpZHRoOiAyMTkuOTc5LCBoZWlnaHQ6IDM3Ni43MTMgfQordmlzaWJs ZVJlY3QJeyBsZWZ0OiAwLjAwMCwgdG9wOiA0OTguMDQ1LCB3aWR0aDogMjE5Ljk3OSwgaGVpZ2h0 OiAzNzYuNzEzIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL3pvb20t YWZ0ZXItaW5wdXQtdGFwLXdpZGUtaW5wdXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9pb3Mvem9vbS1hZnRlci1pbnB1dC10YXAtd2lkZS1pbnB1dC1leHBlY3RlZC50eHQK aW5kZXggN2U2OTMxMDBkYmIxYzhlMGVhMDYwNmExZWJiZTNlYzEwNjg1MGVmMC4uZDY2YjA2YjNl ZjU5NGY4Y2VjNTY2NGFkYjkxZGJjM2U5MTYzZjJhMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pb3Mvem9vbS1hZnRlci1pbnB1dC10YXAtd2lkZS1pbnB1dC1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3Mvem9vbS1hZnRlci1pbnB1dC10YXAt d2lkZS1pbnB1dC1leHBlY3RlZC50eHQKQEAgLTMsNCArMyw0IEBAIFRlc3RzIHpvb21pbmcgdG8g YW4gb2Zmc2V0IGluIGEgd2lkZSB0ZXh0IGlucHV0IG9uIHRhcC4KIAogdGFwIGxvY2F0aW9uCXsg eDogMzI4LjAwMCwgeTogODYyLjAwMCB9CiBzY2FsZQkxLjQ1NQotdmlzaWJsZVJlY3QJeyBsZWZ0 OiAxMjIuNzA3LCB0b3A6IDc3Ni44MDMsIHdpZHRoOiAyMTkuOTgwLCBoZWlnaHQ6IDM3Ni43MTUg fQordmlzaWJsZVJlY3QJeyBsZWZ0OiAxMTQuNDU4LCB0b3A6IDc3Ni44MDMsIHdpZHRoOiAyMTku OTgwLCBoZWlnaHQ6IDM3Ni43MTUgfQo=