<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>192952</bug_id>
          
          <creation_ts>2018-12-20 13:35:57 -0800</creation_ts>
          <short_desc>Add API test coverage for customUserAgent client setting and service workers</short_desc>
          <delta_ts>2018-12-20 17:26:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Service Workers</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>192951</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>beidson</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1490035</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-12-20 13:35:57 -0800</bug_when>
    <thetext>Add API test coverage for customUserAgent client setting and service workers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490042</commentid>
    <comment_count>1</comment_count>
      <attachid>357861</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-12-20 13:39:26 -0800</bug_when>
    <thetext>Created attachment 357861
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490046</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-12-20 13:43:47 -0800</bug_when>
    <thetext>Attachment 357861 did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545:  Multi-line string (&quot;...&quot;) found.  This lint script doesn&apos;t do well with such strings, and may give bogus warnings.  They&apos;re ugly and unnecessary, and you should use concatenation instead&quot;.  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551:  Multi-line string (&quot;...&quot;) found.  This lint script doesn&apos;t do well with such strings, and may give bogus warnings.  They&apos;re ugly and unnecessary, and you should use concatenation instead&quot;.  [readability/multiline_string] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490142</commentid>
    <comment_count>3</comment_count>
      <attachid>357892</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-12-20 16:10:07 -0800</bug_when>
    <thetext>Created attachment 357892
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490145</commentid>
    <comment_count>4</comment_count>
      <attachid>357892</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-12-20 16:11:38 -0800</bug_when>
    <thetext>Comment on attachment 357892
Patch

Great FIXME</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490147</commentid>
    <comment_count>5</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2018-12-20 16:12:59 -0800</bug_when>
    <thetext>Attachment 357892 did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:545:  Multi-line string (&quot;...&quot;) found.  This lint script doesn&apos;t do well with such strings, and may give bogus warnings.  They&apos;re ugly and unnecessary, and you should use concatenation instead&quot;.  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:551:  Multi-line string (&quot;...&quot;) found.  This lint script doesn&apos;t do well with such strings, and may give bogus warnings.  They&apos;re ugly and unnecessary, and you should use concatenation instead&quot;.  [readability/multiline_string] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490210</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-20 17:24:41 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 357892:

storage/indexeddb/objectstore-basics-workers.html bug 192965 (authors: beidson@apple.com, commit-queue@webkit.org, and mark.lam@apple.com)
http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490211</commentid>
    <comment_count>7</comment_count>
      <attachid>357892</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-20 17:25:24 -0800</bug_when>
    <thetext>Comment on attachment 357892
Patch

Clearing flags on attachment: 357892

Committed r239480: &lt;https://trac.webkit.org/changeset/239480&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490212</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-12-20 17:25:26 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1490213</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-12-20 17:26:29 -0800</bug_when>
    <thetext>&lt;rdar://problem/46888770&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357861</attachid>
            <date>2018-12-20 13:39:26 -0800</date>
            <delta_ts>2018-12-20 16:10:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192952-20181220133926.patch</filename>
            <type>text/plain</type>
            <size>5864</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDcwZTk3NzhiMThmMWM5NWJlZTc2YzRjOGNjMTljZTcz
OWY4NDViMi4uNGYwZjUyODU0NDc3MGVhM2I4ZWMxNWNkMjcxMjJjY2FkZDMzNmU5MCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE4LTEyLTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg
ICAgQWRkIEFQSSB0ZXN0IGNvdmVyYWdlIGZvciBjdXN0b21Vc2VyQWdlbnQgY2xpZW50IHNldHRp
bmcgYW5kIHNlcnZpY2Ugd29ya2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTkyOTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NlcnZpY2VX
b3JrZXJCYXNpYy5tbToKKyAgICAgICAgKC1bU1dNZXNzYWdlSGFuZGxlciB1c2VyQ29udGVudENv
bnRyb2xsZXI6ZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6XSk6CisgICAgICAgICgtW1NXU2NoZW1l
cyB3ZWJWaWV3OnN0YXJ0VVJMU2NoZW1lVGFzazpdKToKKyAgICAgICAgKC1bU1dDdXN0b21Vc2Vy
QWdlbnREZWxlZ2F0ZSBfd2ViVmlldzpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOnVz
ZXJJbmZvOmRlY2lzaW9uSGFuZGxlcjpdKToKKyAgICAgICAgKC1bU1dVc2VyQWdlbnRNZXNzYWdl
SGFuZGxlciB1c2VyQ29udGVudENvbnRyb2xsZXI6ZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6XSk6
CisKIDIwMTgtMTItMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCiAgICAgICAgIFtHVEtdW1dQRV0gQnVtcCB3ZWJraXRndGstdGVzdC1mb250cyB0byAwLjAu
OApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2
aWNlV29ya2VyQmFzaWMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1NlcnZpY2VXb3JrZXJCYXNpYy5tbQppbmRleCA2MWRkYmMzZDYzYTllYTg3YzI2ZWNhMGQxYmZk
NjY3NzY1NzMwOTE2Li4wYWRlMmY4YWU2NmVhZTZlMzYyNjgzOWY5YjI5MTNjNDYwYjc5YTY5IDEw
MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NlcnZpY2VX
b3JrZXJCYXNpYy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1NlcnZpY2VXb3JrZXJCYXNpYy5tbQpAQCAtMzcsNiArMzcsNyBAQAogI2ltcG9ydCA8V2ViS2l0
L1dlYktpdC5oPgogI2ltcG9ydCA8V2ViS2l0L19XS0V4cGVyaW1lbnRhbEZlYXR1cmUuaD4KICNp
bXBvcnQgPFdlYktpdC9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oPgorI2ltcG9y
dCA8V2ViS2l0L19XS1dlYnNpdGVQb2xpY2llcy5oPgogI2ltcG9ydCA8d3RmL0RlcXVlLmg+CiAj
aW1wb3J0IDx3dGYvSGFzaE1hcC5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgpAQCAtNjIs
NyArNjMsNyBAQCBAZW5kCiBAaW1wbGVtZW50YXRpb24gU1dNZXNzYWdlSGFuZGxlcgogLSAodm9p
ZCl1c2VyQ29udGVudENvbnRyb2xsZXI6KFdLVXNlckNvbnRlbnRDb250cm9sbGVyICopdXNlckNv
bnRlbnRDb250cm9sbGVyIGRpZFJlY2VpdmVTY3JpcHRNZXNzYWdlOihXS1NjcmlwdE1lc3NhZ2Ug
KiltZXNzYWdlCiB7Ci0gICAgRVhQRUNUX1RSVUUoW1ttZXNzYWdlIGJvZHldIGlzRXF1YWxUb1N0
cmluZzpAIk1lc3NhZ2UgZnJvbSB3b3JrZXI6IFNlcnZpY2VXb3JrZXIgcmVjZWl2ZWQ6IEhlbGxv
IGZyb20gdGhlIHdlYiBwYWdlIl0pOworICAgIEVYUEVDVF9XS19TVFJFUShAIk1lc3NhZ2UgZnJv
bSB3b3JrZXI6IFNlcnZpY2VXb3JrZXIgcmVjZWl2ZWQ6IEhlbGxvIGZyb20gdGhlIHdlYiBwYWdl
IiwgW21lc3NhZ2UgYm9keV0pOwogICAgIGRvbmUgPSB0cnVlOwogfQogQGVuZApAQCAtMTE3LDYg
KzExOCw3IEBAIEBlbmQKIEBpbnRlcmZhY2UgU1dTY2hlbWVzIDogTlNPYmplY3QgPFdLVVJMU2No
ZW1lSGFuZGxlcj4gewogQHB1YmxpYwogICAgIEhhc2hNYXA8U3RyaW5nLCBSZXNvdXJjZUluZm8+
IHJlc291cmNlczsKKyAgICBOU1N0cmluZyAqZXhwZWN0ZWRVc2VyQWdlbnQ7CiB9CiAKIC0oc2l6
ZV90KWhhbmRsZWRSZXF1ZXN0czsKQEAgLTEzMyw2ICsxMzUsOSBAQCAtKHNpemVfdCloYW5kbGVk
UmVxdWVzdHMKIAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHN0YXJ0VVJM
U2NoZW1lVGFzazooaWQgPFdLVVJMU2NoZW1lVGFzaz4pdGFzawogeworICAgIGlmIChleHBlY3Rl
ZFVzZXJBZ2VudCkKKyAgICAgICAgRVhQRUNUX1dLX1NUUkVRKGV4cGVjdGVkVXNlckFnZW50LCBb
W3Rhc2sucmVxdWVzdCB2YWx1ZUZvckhUVFBIZWFkZXJGaWVsZDpAIlVzZXItQWdlbnQiXSBVVEY4
U3RyaW5nXSk7CisKICAgICBhdXRvIGVudHJ5ID0gcmVzb3VyY2VzLmZpbmQoW3Rhc2sucmVxdWVz
dC5VUkwgYWJzb2x1dGVTdHJpbmddKTsKICAgICBpZiAoZW50cnkgPT0gcmVzb3VyY2VzLmVuZCgp
KSB7CiAgICAgICAgIE5TTG9nKEAiRGlkIG5vdCBmaW5kIHJlc291cmNlIGVudHJ5IGZvciBVUkwg
JUAiLCB0YXNrLnJlcXVlc3QuVVJMKTsKQEAgLTUwOCw2ICs1MTMsNzggQEAgVEVTVChTZXJ2aWNl
V29ya2VycywgQmFzaWMpCiAgICAgZG9uZSA9IGZhbHNlOwogfQogCitAaW50ZXJmYWNlIFNXQ3Vz
dG9tVXNlckFnZW50RGVsZWdhdGUgOiBOU09iamVjdCA8V0tOYXZpZ2F0aW9uRGVsZWdhdGU+IHsK
K30KK0BlbmQKKworQGltcGxlbWVudGF0aW9uIFNXQ3VzdG9tVXNlckFnZW50RGVsZWdhdGUKKwor
LSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkZWNpZGVQb2xpY3lGb3JOYXZp
Z2F0aW9uQWN0aW9uOihXS05hdmlnYXRpb25BY3Rpb24gKiluYXZpZ2F0aW9uQWN0aW9uIHVzZXJJ
bmZvOihpZCA8TlNTZWN1cmVDb2Rpbmc+KXVzZXJJbmZvIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAo
XikoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5LCBfV0tXZWJzaXRlUG9saWNpZXMgKikpZGVjaXNp
b25IYW5kbGVyCit7CisgICAgX1dLV2Vic2l0ZVBvbGljaWVzICp3ZWJzaXRlUG9saWNpZXMgPSBb
W1tfV0tXZWJzaXRlUG9saWNpZXMgYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNlXTsKKyAgICBpZiAo
bmF2aWdhdGlvbkFjdGlvbi50YXJnZXRGcmFtZS5tYWluRnJhbWUpCisgICAgICAgIFt3ZWJzaXRl
UG9saWNpZXMgc2V0Q3VzdG9tVXNlckFnZW50OkAiRm9vIEN1c3RvbSBVc2VyQWdlbnQiXTsKKwor
ICAgIGRlY2lzaW9uSGFuZGxlcihXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lBbGxvdywgd2Vic2l0
ZVBvbGljaWVzKTsKK30KKworQGVuZAorCitAaW50ZXJmYWNlIFNXVXNlckFnZW50TWVzc2FnZUhh
bmRsZXIgOiBOU09iamVjdCA8V0tTY3JpcHRNZXNzYWdlSGFuZGxlcj4KK0BlbmQKKworQGltcGxl
bWVudGF0aW9uIFNXVXNlckFnZW50TWVzc2FnZUhhbmRsZXIKKy0gKHZvaWQpdXNlckNvbnRlbnRD
b250cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxl
ciBkaWRSZWNlaXZlU2NyaXB0TWVzc2FnZTooV0tTY3JpcHRNZXNzYWdlICopbWVzc2FnZQorewor
ICAgIC8vIEZJWE1FOiBuYXZpZ2F0b3IudXNlckFnZW50IGN1cnJlbnRseSBkb2VzIG5vdCByZWZs
ZWN0IHRoZSBjdXN0b20gdXNlciBhZ2VudCBzZXQgYnkgdGhlIGNsaWVudCAoaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjk1MSkuCisgICAgLy8gRVhQRUNUX1dLX1NU
UkVRKEAiTWVzc2FnZSBmcm9tIHdvcmtlcjogRm9vIEN1c3RvbSBVc2VyQWdlbnQiLCBbbWVzc2Fn
ZSBib2R5XSk7CisgICAgZG9uZSA9IHRydWU7Cit9CitAZW5kCisKK3N0YXRpYyBjb25zdCBjaGFy
KiB1c2VyQWdlbnRTV0J5dGVzID0gUiJTV1JFU09VUkNFKAorCitzZWxmLmFkZEV2ZW50TGlzdGVu
ZXIoIm1lc3NhZ2UiLCAoZXZlbnQpID0+IHsKKyAgICBldmVudC5zb3VyY2UucG9zdE1lc3NhZ2Uo
bmF2aWdhdG9yLnVzZXJBZ2VudCk7Cit9KTsKKworKVNXUkVTT1VSQ0UiOworCitURVNUKFNlcnZp
Y2VXb3JrZXJzLCBVc2VyQWdlbnRPdmVycmlkZSkKK3sKKyAgICBbV0tXZWJzaXRlRGF0YVN0b3Jl
IF9hbGxvd1dlYnNpdGVEYXRhUmVjb3Jkc0ZvckFsbE9yaWdpbnNdOworCisgICAgLy8gU3RhcnQg
d2l0aCBhIGNsZWFuIHNsYXRlIGRhdGEgc3RvcmUKKyAgICBbW1dLV2Vic2l0ZURhdGFTdG9yZSBk
ZWZhdWx0RGF0YVN0b3JlXSByZW1vdmVEYXRhT2ZUeXBlczpbV0tXZWJzaXRlRGF0YVN0b3JlIGFs
bFdlYnNpdGVEYXRhVHlwZXNdIG1vZGlmaWVkU2luY2U6W05TRGF0ZSBkaXN0YW50UGFzdF0gY29t
cGxldGlvbkhhbmRsZXI6XigpIHsKKyAgICAgICAgZG9uZSA9IHRydWU7CisgICAgfV07CisgICAg
VGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKyAgICBkb25lID0gZmFsc2U7CisKKyAg
ICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBh
bGxvY10gaW5pdF0pOworCisgICAgYXV0byBtZXNzYWdlSGFuZGxlciA9IGFkb3B0TlMoW1tTV1Vz
ZXJBZ2VudE1lc3NhZ2VIYW5kbGVyIGFsbG9jXSBpbml0XSk7CisgICAgW1tjb25maWd1cmF0aW9u
IHVzZXJDb250ZW50Q29udHJvbGxlcl0gYWRkU2NyaXB0TWVzc2FnZUhhbmRsZXI6bWVzc2FnZUhh
bmRsZXIuZ2V0KCkgbmFtZTpAInN3Il07CisKKyAgICBhdXRvIGhhbmRsZXIgPSBhZG9wdE5TKFtb
U1dTY2hlbWVzIGFsbG9jXSBpbml0XSk7CisgICAgaGFuZGxlci0+cmVzb3VyY2VzLnNldCgic3c6
Ly9ob3N0L21haW4uaHRtbCIsIFJlc291cmNlSW5mbyB7IEAidGV4dC9odG1sIiwgbWFpbkJ5dGVz
IH0pOworICAgIGhhbmRsZXItPnJlc291cmNlcy5zZXQoInN3Oi8vaG9zdC9zdy5qcyIsIFJlc291
cmNlSW5mbyB7IEAiYXBwbGljYXRpb24vamF2YXNjcmlwdCIsIHVzZXJBZ2VudFNXQnl0ZXMgfSk7
CisgICAgaGFuZGxlci0+ZXhwZWN0ZWRVc2VyQWdlbnQgPSBAIkZvbyBDdXN0b20gVXNlckFnZW50
IjsKKyAgICBbY29uZmlndXJhdGlvbiBzZXRVUkxTY2hlbWVIYW5kbGVyOmhhbmRsZXIuZ2V0KCkg
Zm9yVVJMU2NoZW1lOkAiU1ciXTsKKworICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcg
PSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwg
MCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOworICAgIFt3
ZWJWaWV3LmdldCgpLmNvbmZpZ3VyYXRpb24ucHJvY2Vzc1Bvb2wgX3JlZ2lzdGVyVVJMU2NoZW1l
U2VydmljZVdvcmtlcnNDYW5IYW5kbGU6QCJzdyJdOworCisgICAgYXV0byBkZWxlZ2F0ZSA9IGFk
b3B0TlMoW1tTV0N1c3RvbVVzZXJBZ2VudERlbGVnYXRlIGFsbG9jXSBpbml0XSk7CisgICAgW3dl
YlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRlOmRlbGVnYXRlLmdldCgpXTsKKworICAgIE5TVVJM
UmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W05TVVJMIFVS
TFdpdGhTdHJpbmc6QCJzdzovL2hvc3QvbWFpbi5odG1sIl1dOworICAgIFt3ZWJWaWV3IGxvYWRS
ZXF1ZXN0OnJlcXVlc3RdOworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsK
KyAgICBkb25lID0gZmFsc2U7Cit9CisKIFRFU1QoU2VydmljZVdvcmtlcnMsIFJlc3RvcmVGcm9t
RGlzaykKIHsKICAgICBBU1NFUlQobWFpblJlZ2lzdGVyaW5nV29ya2VyQnl0ZXMpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>357892</attachid>
            <date>2018-12-20 16:10:07 -0800</date>
            <delta_ts>2018-12-20 17:25:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-192952-20181220161007.patch</filename>
            <type>text/plain</type>
            <size>5864</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NDcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWExYWIzOTE4ZWY0YzdkYTc0MGEzNGIxMjRjN2RhZjQw
NjE0ZWYzNS4uNzJmNjJiMmIwNWZiMzQ0YTJjMzRmNjFjNjFiN2RiOTlmMzk3NTExOSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE4LTEyLTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg
ICAgQWRkIEFQSSB0ZXN0IGNvdmVyYWdlIGZvciBjdXN0b21Vc2VyQWdlbnQgY2xpZW50IHNldHRp
bmcgYW5kIHNlcnZpY2Ugd29ya2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTkyOTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NlcnZpY2VX
b3JrZXJCYXNpYy5tbToKKyAgICAgICAgKC1bU1dNZXNzYWdlSGFuZGxlciB1c2VyQ29udGVudENv
bnRyb2xsZXI6ZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6XSk6CisgICAgICAgICgtW1NXU2NoZW1l
cyB3ZWJWaWV3OnN0YXJ0VVJMU2NoZW1lVGFzazpdKToKKyAgICAgICAgKC1bU1dDdXN0b21Vc2Vy
QWdlbnREZWxlZ2F0ZSBfd2ViVmlldzpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOnVz
ZXJJbmZvOmRlY2lzaW9uSGFuZGxlcjpdKToKKyAgICAgICAgKC1bU1dVc2VyQWdlbnRNZXNzYWdl
SGFuZGxlciB1c2VyQ29udGVudENvbnRyb2xsZXI6ZGlkUmVjZWl2ZVNjcmlwdE1lc3NhZ2U6XSk6
CisKIDIwMTgtMTItMjAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAg
ICAgICBbV2ViQXV0aE5dIEFkZCBhIHJ1bnRpbWUgZmxhZyBmb3IgbG9jYWwgYXV0aGVudGljYXRv
cgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2
aWNlV29ya2VyQmFzaWMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1NlcnZpY2VXb3JrZXJCYXNpYy5tbQppbmRleCA2MWRkYmMzZDYzYTllYTg3YzI2ZWNhMGQxYmZk
NjY3NzY1NzMwOTE2Li4wYWRlMmY4YWU2NmVhZTZlMzYyNjgzOWY5YjI5MTNjNDYwYjc5YTY5IDEw
MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1NlcnZpY2VX
b3JrZXJCYXNpYy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h
L1NlcnZpY2VXb3JrZXJCYXNpYy5tbQpAQCAtMzcsNiArMzcsNyBAQAogI2ltcG9ydCA8V2ViS2l0
L1dlYktpdC5oPgogI2ltcG9ydCA8V2ViS2l0L19XS0V4cGVyaW1lbnRhbEZlYXR1cmUuaD4KICNp
bXBvcnQgPFdlYktpdC9fV0tXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbi5oPgorI2ltcG9y
dCA8V2ViS2l0L19XS1dlYnNpdGVQb2xpY2llcy5oPgogI2ltcG9ydCA8d3RmL0RlcXVlLmg+CiAj
aW1wb3J0IDx3dGYvSGFzaE1hcC5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgpAQCAtNjIs
NyArNjMsNyBAQCBAZW5kCiBAaW1wbGVtZW50YXRpb24gU1dNZXNzYWdlSGFuZGxlcgogLSAodm9p
ZCl1c2VyQ29udGVudENvbnRyb2xsZXI6KFdLVXNlckNvbnRlbnRDb250cm9sbGVyICopdXNlckNv
bnRlbnRDb250cm9sbGVyIGRpZFJlY2VpdmVTY3JpcHRNZXNzYWdlOihXS1NjcmlwdE1lc3NhZ2Ug
KiltZXNzYWdlCiB7Ci0gICAgRVhQRUNUX1RSVUUoW1ttZXNzYWdlIGJvZHldIGlzRXF1YWxUb1N0
cmluZzpAIk1lc3NhZ2UgZnJvbSB3b3JrZXI6IFNlcnZpY2VXb3JrZXIgcmVjZWl2ZWQ6IEhlbGxv
IGZyb20gdGhlIHdlYiBwYWdlIl0pOworICAgIEVYUEVDVF9XS19TVFJFUShAIk1lc3NhZ2UgZnJv
bSB3b3JrZXI6IFNlcnZpY2VXb3JrZXIgcmVjZWl2ZWQ6IEhlbGxvIGZyb20gdGhlIHdlYiBwYWdl
IiwgW21lc3NhZ2UgYm9keV0pOwogICAgIGRvbmUgPSB0cnVlOwogfQogQGVuZApAQCAtMTE3LDYg
KzExOCw3IEBAIEBlbmQKIEBpbnRlcmZhY2UgU1dTY2hlbWVzIDogTlNPYmplY3QgPFdLVVJMU2No
ZW1lSGFuZGxlcj4gewogQHB1YmxpYwogICAgIEhhc2hNYXA8U3RyaW5nLCBSZXNvdXJjZUluZm8+
IHJlc291cmNlczsKKyAgICBOU1N0cmluZyAqZXhwZWN0ZWRVc2VyQWdlbnQ7CiB9CiAKIC0oc2l6
ZV90KWhhbmRsZWRSZXF1ZXN0czsKQEAgLTEzMyw2ICsxMzUsOSBAQCAtKHNpemVfdCloYW5kbGVk
UmVxdWVzdHMKIAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHN0YXJ0VVJM
U2NoZW1lVGFzazooaWQgPFdLVVJMU2NoZW1lVGFzaz4pdGFzawogeworICAgIGlmIChleHBlY3Rl
ZFVzZXJBZ2VudCkKKyAgICAgICAgRVhQRUNUX1dLX1NUUkVRKGV4cGVjdGVkVXNlckFnZW50LCBb
W3Rhc2sucmVxdWVzdCB2YWx1ZUZvckhUVFBIZWFkZXJGaWVsZDpAIlVzZXItQWdlbnQiXSBVVEY4
U3RyaW5nXSk7CisKICAgICBhdXRvIGVudHJ5ID0gcmVzb3VyY2VzLmZpbmQoW3Rhc2sucmVxdWVz
dC5VUkwgYWJzb2x1dGVTdHJpbmddKTsKICAgICBpZiAoZW50cnkgPT0gcmVzb3VyY2VzLmVuZCgp
KSB7CiAgICAgICAgIE5TTG9nKEAiRGlkIG5vdCBmaW5kIHJlc291cmNlIGVudHJ5IGZvciBVUkwg
JUAiLCB0YXNrLnJlcXVlc3QuVVJMKTsKQEAgLTUwOCw2ICs1MTMsNzggQEAgVEVTVChTZXJ2aWNl
V29ya2VycywgQmFzaWMpCiAgICAgZG9uZSA9IGZhbHNlOwogfQogCitAaW50ZXJmYWNlIFNXQ3Vz
dG9tVXNlckFnZW50RGVsZWdhdGUgOiBOU09iamVjdCA8V0tOYXZpZ2F0aW9uRGVsZWdhdGU+IHsK
K30KK0BlbmQKKworQGltcGxlbWVudGF0aW9uIFNXQ3VzdG9tVXNlckFnZW50RGVsZWdhdGUKKwor
LSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkZWNpZGVQb2xpY3lGb3JOYXZp
Z2F0aW9uQWN0aW9uOihXS05hdmlnYXRpb25BY3Rpb24gKiluYXZpZ2F0aW9uQWN0aW9uIHVzZXJJ
bmZvOihpZCA8TlNTZWN1cmVDb2Rpbmc+KXVzZXJJbmZvIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAo
XikoV0tOYXZpZ2F0aW9uQWN0aW9uUG9saWN5LCBfV0tXZWJzaXRlUG9saWNpZXMgKikpZGVjaXNp
b25IYW5kbGVyCit7CisgICAgX1dLV2Vic2l0ZVBvbGljaWVzICp3ZWJzaXRlUG9saWNpZXMgPSBb
W1tfV0tXZWJzaXRlUG9saWNpZXMgYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNlXTsKKyAgICBpZiAo
bmF2aWdhdGlvbkFjdGlvbi50YXJnZXRGcmFtZS5tYWluRnJhbWUpCisgICAgICAgIFt3ZWJzaXRl
UG9saWNpZXMgc2V0Q3VzdG9tVXNlckFnZW50OkAiRm9vIEN1c3RvbSBVc2VyQWdlbnQiXTsKKwor
ICAgIGRlY2lzaW9uSGFuZGxlcihXS05hdmlnYXRpb25BY3Rpb25Qb2xpY3lBbGxvdywgd2Vic2l0
ZVBvbGljaWVzKTsKK30KKworQGVuZAorCitAaW50ZXJmYWNlIFNXVXNlckFnZW50TWVzc2FnZUhh
bmRsZXIgOiBOU09iamVjdCA8V0tTY3JpcHRNZXNzYWdlSGFuZGxlcj4KK0BlbmQKKworQGltcGxl
bWVudGF0aW9uIFNXVXNlckFnZW50TWVzc2FnZUhhbmRsZXIKKy0gKHZvaWQpdXNlckNvbnRlbnRD
b250cm9sbGVyOihXS1VzZXJDb250ZW50Q29udHJvbGxlciAqKXVzZXJDb250ZW50Q29udHJvbGxl
ciBkaWRSZWNlaXZlU2NyaXB0TWVzc2FnZTooV0tTY3JpcHRNZXNzYWdlICopbWVzc2FnZQorewor
ICAgIC8vIEZJWE1FOiBuYXZpZ2F0b3IudXNlckFnZW50IGN1cnJlbnRseSBkb2VzIG5vdCByZWZs
ZWN0IHRoZSBjdXN0b20gdXNlciBhZ2VudCBzZXQgYnkgdGhlIGNsaWVudCAoaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjk1MSkuCisgICAgLy8gRVhQRUNUX1dLX1NU
UkVRKEAiTWVzc2FnZSBmcm9tIHdvcmtlcjogRm9vIEN1c3RvbSBVc2VyQWdlbnQiLCBbbWVzc2Fn
ZSBib2R5XSk7CisgICAgZG9uZSA9IHRydWU7Cit9CitAZW5kCisKK3N0YXRpYyBjb25zdCBjaGFy
KiB1c2VyQWdlbnRTV0J5dGVzID0gUiJTV1JFU09VUkNFKAorCitzZWxmLmFkZEV2ZW50TGlzdGVu
ZXIoIm1lc3NhZ2UiLCAoZXZlbnQpID0+IHsKKyAgICBldmVudC5zb3VyY2UucG9zdE1lc3NhZ2Uo
bmF2aWdhdG9yLnVzZXJBZ2VudCk7Cit9KTsKKworKVNXUkVTT1VSQ0UiOworCitURVNUKFNlcnZp
Y2VXb3JrZXJzLCBVc2VyQWdlbnRPdmVycmlkZSkKK3sKKyAgICBbV0tXZWJzaXRlRGF0YVN0b3Jl
IF9hbGxvd1dlYnNpdGVEYXRhUmVjb3Jkc0ZvckFsbE9yaWdpbnNdOworCisgICAgLy8gU3RhcnQg
d2l0aCBhIGNsZWFuIHNsYXRlIGRhdGEgc3RvcmUKKyAgICBbW1dLV2Vic2l0ZURhdGFTdG9yZSBk
ZWZhdWx0RGF0YVN0b3JlXSByZW1vdmVEYXRhT2ZUeXBlczpbV0tXZWJzaXRlRGF0YVN0b3JlIGFs
bFdlYnNpdGVEYXRhVHlwZXNdIG1vZGlmaWVkU2luY2U6W05TRGF0ZSBkaXN0YW50UGFzdF0gY29t
cGxldGlvbkhhbmRsZXI6XigpIHsKKyAgICAgICAgZG9uZSA9IHRydWU7CisgICAgfV07CisgICAg
VGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKyAgICBkb25lID0gZmFsc2U7CisKKyAg
ICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBh
bGxvY10gaW5pdF0pOworCisgICAgYXV0byBtZXNzYWdlSGFuZGxlciA9IGFkb3B0TlMoW1tTV1Vz
ZXJBZ2VudE1lc3NhZ2VIYW5kbGVyIGFsbG9jXSBpbml0XSk7CisgICAgW1tjb25maWd1cmF0aW9u
IHVzZXJDb250ZW50Q29udHJvbGxlcl0gYWRkU2NyaXB0TWVzc2FnZUhhbmRsZXI6bWVzc2FnZUhh
bmRsZXIuZ2V0KCkgbmFtZTpAInN3Il07CisKKyAgICBhdXRvIGhhbmRsZXIgPSBhZG9wdE5TKFtb
U1dTY2hlbWVzIGFsbG9jXSBpbml0XSk7CisgICAgaGFuZGxlci0+cmVzb3VyY2VzLnNldCgic3c6
Ly9ob3N0L21haW4uaHRtbCIsIFJlc291cmNlSW5mbyB7IEAidGV4dC9odG1sIiwgbWFpbkJ5dGVz
IH0pOworICAgIGhhbmRsZXItPnJlc291cmNlcy5zZXQoInN3Oi8vaG9zdC9zdy5qcyIsIFJlc291
cmNlSW5mbyB7IEAiYXBwbGljYXRpb24vamF2YXNjcmlwdCIsIHVzZXJBZ2VudFNXQnl0ZXMgfSk7
CisgICAgaGFuZGxlci0+ZXhwZWN0ZWRVc2VyQWdlbnQgPSBAIkZvbyBDdXN0b20gVXNlckFnZW50
IjsKKyAgICBbY29uZmlndXJhdGlvbiBzZXRVUkxTY2hlbWVIYW5kbGVyOmhhbmRsZXIuZ2V0KCkg
Zm9yVVJMU2NoZW1lOkAiU1ciXTsKKworICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcg
PSBhZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwg
MCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOworICAgIFt3
ZWJWaWV3LmdldCgpLmNvbmZpZ3VyYXRpb24ucHJvY2Vzc1Bvb2wgX3JlZ2lzdGVyVVJMU2NoZW1l
U2VydmljZVdvcmtlcnNDYW5IYW5kbGU6QCJzdyJdOworCisgICAgYXV0byBkZWxlZ2F0ZSA9IGFk
b3B0TlMoW1tTV0N1c3RvbVVzZXJBZ2VudERlbGVnYXRlIGFsbG9jXSBpbml0XSk7CisgICAgW3dl
YlZpZXcgc2V0TmF2aWdhdGlvbkRlbGVnYXRlOmRlbGVnYXRlLmdldCgpXTsKKworICAgIE5TVVJM
UmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W05TVVJMIFVS
TFdpdGhTdHJpbmc6QCJzdzovL2hvc3QvbWFpbi5odG1sIl1dOworICAgIFt3ZWJWaWV3IGxvYWRS
ZXF1ZXN0OnJlcXVlc3RdOworCisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsK
KyAgICBkb25lID0gZmFsc2U7Cit9CisKIFRFU1QoU2VydmljZVdvcmtlcnMsIFJlc3RvcmVGcm9t
RGlzaykKIHsKICAgICBBU1NFUlQobWFpblJlZ2lzdGVyaW5nV29ya2VyQnl0ZXMpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>