192939 2018-12-20 10:32:52 -0800 Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck. 2018-12-20 10:52:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1489927 0 mark.lam 2018-12-20 10:32:52 -0800 <rdar://problem/46869516> 1489929 1 357831 mark.lam 2018-12-20 10:40:58 -0800 Created attachment 357831 proposed patch. 1489935 2 357831 keith_miller 2018-12-20 10:48:39 -0800 Comment on attachment 357831 proposed patch. r=me. 1489938 3 mark.lam 2018-12-20 10:52:27 -0800 Thanks for the review. Landed in r239455: <http://trac.webkit.org/r239455>. 357831 2018-12-20 10:40:58 -0800 2018-12-20 10:48:39 -0800 proposed patch. bug-192939.patch text/plain 3835 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzk0NTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTEyLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggYSB0eXBvIGluIHNsb3dfcGF0aF9jb25zdHJ1Y3RfYXJpdHlDaGVj ayBhbmQgb3BlcmF0aW9uQ29uc3RydWN0QXJpdHlDaGVjay4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjkzOQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDY4Njk1MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBzdHJlc3Mvc3RhY2stb3ZlcmZsb3ctZnJhbWUtZm9yLWNvbnN0cnVjdC1hcml0eUNo ZWNrLXNob3VsZC11c2UtY29uc3RydWN0LWNvZGVCbG9jay5qczogQWRkZWQuCisKIDIwMTgtMTIt MjAgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAgICAgV1RGOjpT dHJpbmcgYW5kIFN0cmluZ0ltcGwgb3ZlcmZsb3cgTWF4TGVuZ3RoCkluZGV4OiBKU1Rlc3RzL3N0 cmVzcy9zdGFjay1vdmVyZmxvdy1mcmFtZS1mb3ItY29uc3RydWN0LWFyaXR5Q2hlY2stc2hvdWxk LXVzZS1jb25zdHJ1Y3QtY29kZUJsb2NrLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNz L3N0YWNrLW92ZXJmbG93LWZyYW1lLWZvci1jb25zdHJ1Y3QtYXJpdHlDaGVjay1zaG91bGQtdXNl LWNvbnN0cnVjdC1jb2RlQmxvY2suanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mv c3RhY2stb3ZlcmZsb3ctZnJhbWUtZm9yLWNvbnN0cnVjdC1hcml0eUNoZWNrLXNob3VsZC11c2Ut Y29uc3RydWN0LWNvZGVCbG9jay5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDI3IEBACisv L0AgcmVxdWlyZU9wdGlvbnMoIi0tbWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0xNTcyODY0IikKKwor ZnVuY3Rpb24gZm9vKGEsIGIsIGMpIHsKKyAgICB0cnkgeworICAgICAgICB0aHJvdyBuZXcgRXJy b3IoKTsKKyAgICB9IGNhdGNoIHsKKyAgICAgICAgaGVsbG8oKTsKKyAgICB9Cit9OworCitmdW5j dGlvbiBCYXIoZCwgZSkgeworICAgIGhlbGxvKCk7Cit9CisKK2Z1bmN0aW9uIGhlbGxvKGYpIHsK KyAgICBuZXcgQmFyKDApOworfTsKKwordmFyIGV4Y2VwdGlvbjsKK3RyeSB7CisgICAgZm9vKCk7 Cit9IGNhdGNoKGUpIHsKKyAgICBleGNlcHRpb24gPSBlOworfQorCitpZiAoZXhjZXB0aW9uICE9 ICJSYW5nZUVycm9yOiBNYXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBleGNlZWRlZC4iKQorICAgIHRo cm93ICJGQUlMRUQiOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzk0 NTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTgtMTItMjAgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgorCisgICAgICAgIEZpeCBhIHR5cG8gaW4gc2xvd19wYXRoX2NvbnN0cnVjdF9hcml0eUNoZWNr IGFuZCBvcGVyYXRpb25Db25zdHJ1Y3RBcml0eUNoZWNrLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyOTM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80Njg2OTUxNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBydW50aW1lL0NvbW1vblNs b3dQYXRocy5jcHA6CisKIDIwMTgtMTItMjAgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtCaWdJbnRdIFdlIHNob3VsZCBlbmFibGUgQ1NFIGludG8gYXJpdGht ZXRpYyBvcGVyYXRpb25zIHRoYXQgc3BlY3VsYXRlIEJpZ0ludFVzZQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAyMzk0NDMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMzAsNyArMTMwLDcgQEAgaW50MzJfdCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkNv bnN0cnVjdAogCiAgICAgaW50MzJfdCBtaXNzaW5nQXJnQ291bnQgPSBDb21tb25TbG93UGF0aHM6 OmFyaXR5Q2hlY2tGb3IoZXhlYywgKnZtLCBDb2RlRm9yQ29uc3RydWN0KTsKICAgICBpZiAoVU5M SUtFTFkobWlzc2luZ0FyZ0NvdW50IDwgMCkpIHsKLSAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxv Y2sgPSBDb21tb25TbG93UGF0aHM6OmNvZGVCbG9ja0Zyb21DYWxsRnJhbWVDYWxsZWUoZXhlYywg Q29kZUZvckNhbGwpOworICAgICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IENvbW1vblNsb3dQ YXRoczo6Y29kZUJsb2NrRnJvbUNhbGxGcmFtZUNhbGxlZShleGVjLCBDb2RlRm9yQ29uc3RydWN0 KTsKICAgICAgICAgZXhlYy0+Y29udmVydFRvU3RhY2tPdmVyZmxvd0ZyYW1lKCp2bSwgY29kZUJs b2NrKTsKICAgICAgICAgTmF0aXZlQ2FsbEZyYW1lVHJhY2VyIHRyYWNlcih2bSwgZXhlYyk7CiAg ICAgICAgIHRocm93U3RhY2tPdmVyZmxvd0Vycm9yKHZtLT50b3BDYWxsRnJhbWUsIHNjb3BlKTsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1Bh dGhzLmNwcAkocmV2aXNpb24gMjM5NDQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQ29tbW9uU2xvd1BhdGhzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk0LDcgKzE5NCw3IEBA IFNMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9jb25zdHJ1Y3RfYXJpdHkKICAgICBCRUdJTigpOwog ICAgIGludCBzbG90c1RvQWRkID0gQ29tbW9uU2xvd1BhdGhzOjphcml0eUNoZWNrRm9yKGV4ZWMs IHZtLCBDb2RlRm9yQ29uc3RydWN0KTsKICAgICBpZiAoVU5MSUtFTFkoc2xvdHNUb0FkZCA8IDAp KSB7Ci0gICAgICAgIENvZGVCbG9jayogY29kZUJsb2NrID0gQ29tbW9uU2xvd1BhdGhzOjpjb2Rl QmxvY2tGcm9tQ2FsbEZyYW1lQ2FsbGVlKGV4ZWMsIENvZGVGb3JDYWxsKTsKKyAgICAgICAgQ29k ZUJsb2NrKiBjb2RlQmxvY2sgPSBDb21tb25TbG93UGF0aHM6OmNvZGVCbG9ja0Zyb21DYWxsRnJh bWVDYWxsZWUoZXhlYywgQ29kZUZvckNvbnN0cnVjdCk7CiAgICAgICAgIGV4ZWMtPmNvbnZlcnRU b1N0YWNrT3ZlcmZsb3dGcmFtZSh2bSwgY29kZUJsb2NrKTsKICAgICAgICAgTmF0aXZlQ2FsbEZy YW1lVHJhY2VyIHRyYWNlcigmdm0sIGV4ZWMpOwogICAgICAgICBFcnJvckhhbmRsaW5nU2NvcGUg ZXJyb3JTY29wZSh2bSk7Cg==